Re: [[RESEND]PATCH staging/speakup v3 3/3] use speakup_allocate as per required context

2017-03-24 Thread Pranay Srivastava
On Fri, Mar 24, 2017 at 2:13 PM, Greg KH wrote: > On Fri, Mar 24, 2017 at 02:07:11PM +0530, Pranay Kr. Srivastava wrote: >> speakup_allocate used GFP_ATOMIC for allocations >> even while during initialization due to it's use >> in notifier call. > > Is that a problem? No that's

Re: [[RESEND]PATCH staging/speakup v3 3/3] use speakup_allocate as per required context

2017-03-24 Thread Greg KH
On Fri, Mar 24, 2017 at 02:07:11PM +0530, Pranay Kr. Srivastava wrote: > speakup_allocate used GFP_ATOMIC for allocations > even while during initialization due to it's use > in notifier call. Is that a problem? > Pass GFP_ flags as well to speakup_allocate depending > on the context it is

[[RESEND]PATCH staging/speakup v3 3/3] use speakup_allocate as per required context

2017-03-24 Thread Pranay Kr. Srivastava
speakup_allocate used GFP_ATOMIC for allocations even while during initialization due to it's use in notifier call. Pass GFP_ flags as well to speakup_allocate depending on the context it is called in. Signed-off-by: Pranay Kr. Srivastava --- drivers/staging/speakup/main.c |

Re: [PATCH staging/speakup v3 3/3] use speakup_allocate as per required context

2017-03-23 Thread Greg KH
On Tue, Mar 21, 2017 at 12:40:24PM +0530, Pranay Kr. Srivastava wrote: > speakup_allocate used GFP_ATOMIC for allocations > even while during initialization due to it's use > in notifier call. > > Pass GFP_ flags as well to speakup_allocate depending > on the context it is called in. > >

[PATCH staging/speakup v3 3/3] use speakup_allocate as per required context

2017-03-21 Thread Pranay Kr. Srivastava
speakup_allocate used GFP_ATOMIC for allocations even while during initialization due to it's use in notifier call. Pass GFP_ flags as well to speakup_allocate depending on the context it is called in. Signed-off-by: Pranay Kr. Srivastava --- drivers/staging/speakup/main.c |