Re: [PATCH v1 05/10] staging: atomisp: Remove non-ACPI leftovers

2018-01-02 Thread Julia Lawall
On Tue, 2 Jan 2018, Dan Carpenter wrote: > On Wed, Dec 20, 2017 at 11:30:01AM +0100, Julia Lawall wrote: > > > > > > On Wed, 20 Dec 2017, Dan Carpenter wrote: > > > > > On Tue, Dec 19, 2017 at 10:59:52PM +0200, Andy Shevchenko wrote: > > > > @@ -914,9 +904,7 @@ static int lm3554_probe(struct

Re: [PATCH v1 05/10] staging: atomisp: Remove non-ACPI leftovers

2018-01-02 Thread Dan Carpenter
On Wed, Dec 20, 2017 at 11:30:01AM +0100, Julia Lawall wrote: > > > On Wed, 20 Dec 2017, Dan Carpenter wrote: > > > On Tue, Dec 19, 2017 at 10:59:52PM +0200, Andy Shevchenko wrote: > > > @@ -914,9 +904,7 @@ static int lm3554_probe(struct i2c_client *client) > > > dev_err(>dev, "gpio

Re: [PATCH v1 05/10] staging: atomisp: Remove non-ACPI leftovers

2017-12-21 Thread Sakari Ailus
Hi Andy and Dan, On Wed, Dec 20, 2017 at 12:24:36PM +0200, Andy Shevchenko wrote: > On Wed, Dec 20, 2017 at 6:54 AM, Dan Carpenter > wrote: > > On Tue, Dec 19, 2017 at 10:59:52PM +0200, Andy Shevchenko wrote: > >> @@ -1147,10 +1145,8 @@ static int gc2235_probe(struct

Re: [PATCH v1 05/10] staging: atomisp: Remove non-ACPI leftovers

2017-12-20 Thread Julia Lawall
On Wed, 20 Dec 2017, Dan Carpenter wrote: > On Tue, Dec 19, 2017 at 10:59:52PM +0200, Andy Shevchenko wrote: > > @@ -914,9 +904,7 @@ static int lm3554_probe(struct i2c_client *client) > > dev_err(>dev, "gpio request/direction_output fail"); > > goto fail2; > > } > >

Re: [PATCH v1 05/10] staging: atomisp: Remove non-ACPI leftovers

2017-12-20 Thread Andy Shevchenko
On Wed, Dec 20, 2017 at 6:54 AM, Dan Carpenter wrote: > On Tue, Dec 19, 2017 at 10:59:52PM +0200, Andy Shevchenko wrote: >> @@ -1147,10 +1145,8 @@ static int gc2235_probe(struct i2c_client *client) >> if (ret) >> gc2235_remove(client); > > This error

Re: [PATCH v1 05/10] staging: atomisp: Remove non-ACPI leftovers

2017-12-20 Thread Dan Carpenter
On Tue, Dec 19, 2017 at 10:59:52PM +0200, Andy Shevchenko wrote: > @@ -914,9 +904,7 @@ static int lm3554_probe(struct i2c_client *client) > dev_err(>dev, "gpio request/direction_output fail"); > goto fail2; > } > - if (ACPI_HANDLE(>dev)) > - err =

Re: [PATCH v1 05/10] staging: atomisp: Remove non-ACPI leftovers

2017-12-19 Thread Dan Carpenter
On Tue, Dec 19, 2017 at 10:59:52PM +0200, Andy Shevchenko wrote: > @@ -1147,10 +1145,8 @@ static int gc2235_probe(struct i2c_client *client) > if (ret) > gc2235_remove(client); This error handling is probably wrong... > > - if (ACPI_HANDLE(>dev)) > - ret =

[PATCH v1 05/10] staging: atomisp: Remove non-ACPI leftovers

2017-12-19 Thread Andy Shevchenko
Since all drivers are solely requiring ACPI enumeration, there is no need to additionally check for legacy platform data or ACPI handle. Remove leftovers from the sensors and platform code. Signed-off-by: Andy Shevchenko ---