On Wed, Jun 25, 2014 at 11:44:47AM +0200, Denis Carikli wrote:
On 06/25/2014 06:48 AM, Sascha Hauer wrote:
+#define ENABLE_POL_LOW 0
+#define ENABLE_POL_HIGH1
Adding defines without a proper namespace (IPU_) outside a driver
private header file is not nice. Anyway,
On Wed, Jun 25, 2014 at 06:48:45AM +0200, Sascha Hauer wrote:
On Mon, Jun 16, 2014 at 12:11:18PM +0200, Denis Carikli wrote:
+
/*
* Bitfield of Display Interface signal polarities.
*/
@@ -37,7 +43,7 @@ struct ipu_di_signal_cfg {
unsigned clksel_en:1;
unsigned
On 06/25/2014 06:48 AM, Sascha Hauer wrote:
+#define ENABLE_POL_LOW 0
+#define ENABLE_POL_HIGH1
Adding defines without a proper namespace (IPU_) outside a driver
private header file is not nice. Anyway, instead of adding the
defines ...
Fixed in imx-drm: use defines for
On Wed, Jun 25, 2014 at 09:43:27AM +0100, Russell King - ARM Linux wrote:
On Wed, Jun 25, 2014 at 06:48:45AM +0200, Sascha Hauer wrote:
On Mon, Jun 16, 2014 at 12:11:18PM +0200, Denis Carikli wrote:
+
/*
* Bitfield of Display Interface signal polarities.
*/
@@ -37,7 +43,7 @@
On Mon, Jun 16, 2014 at 12:11:18PM +0200, Denis Carikli wrote:
Signed-off-by: Denis Carikli de...@eukrea.com
It would be nice to have a little more explanation in the commit messages
for these patches. If you'd like to send me better commit messages for
these patches, I'll add them to what I
On 06/24/2014 05:13 PM, Russell King - ARM Linux wrote:
[...]
If you'd like to send me better commit messages for
these patches, I'll add them to what I already have:
imx-drm: use defines for clock polarity settings
The comment of the clk_pol field of the ipu_di_signal_cfg struct was
On Tue, Jun 24, 2014 at 06:25:19PM +0200, Denis Carikli wrote:
On 06/24/2014 05:13 PM, Russell King - ARM Linux wrote:
[...]
If you'd like to send me better commit messages for
these patches, I'll add them to what I already have:
imx-drm: use defines for clock polarity settings
The
Signed-off-by: Denis Carikli de...@eukrea.com
---
ChangeLog v13-v14:
- Rebased
ChangeLog 12-v13:
- No changes
ChangeLog 11-v12:
- Improved the define names to match the hardware:
ENABLE_POL is not a clock signal but instead an enable signal.
ChangeLog v9-v10:
- New patch which was splitted out
