Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get

2019-10-17 Thread Rui Miguel Silva
Hi Chuhong, many thanks for the patch. On Tue 15 Oct 2019 at 14:59, Chuhong Yuan wrote: > devm_regulator_get may return an error but mipi_csis_phy_init misses > a check for it. > This may lead to problems when regulator_set_voltage uses the unchecked > pointer. > This patch adds a check for

Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get

2019-10-17 Thread Rui Miguel Silva
Hi Marco, On Thu 17 Oct 2019 at 09:10, Marco Felsch wrote: > Hi Rui, > > On 19-10-16 14:43, Rui Miguel Silva wrote: >> Hi Marco, >> On Wed 16 Oct 2019 at 10:06, Marco Felsch wrote: >> > Hi Chuhong, >> > >> > On 19-10-15 21:59, Chuhong Yuan wrote: >> >> devm_regulator_get may return an error but

Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get

2019-10-17 Thread Marco Felsch
Hi Rui, On 19-10-16 14:43, Rui Miguel Silva wrote: > Hi Marco, > On Wed 16 Oct 2019 at 10:06, Marco Felsch wrote: > > Hi Chuhong, > > > > On 19-10-15 21:59, Chuhong Yuan wrote: > >> devm_regulator_get may return an error but mipi_csis_phy_init misses > >> a check for it. > >> This may lead to

Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get

2019-10-16 Thread Rui Miguel Silva
Hi Marco, On Wed 16 Oct 2019 at 10:06, Marco Felsch wrote: > Hi Chuhong, > > On 19-10-15 21:59, Chuhong Yuan wrote: >> devm_regulator_get may return an error but mipi_csis_phy_init misses >> a check for it. >> This may lead to problems when regulator_set_voltage uses the unchecked >> pointer. >>

Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get

2019-10-16 Thread Marco Felsch
Hi Chuhong, On 19-10-15 21:59, Chuhong Yuan wrote: > devm_regulator_get may return an error but mipi_csis_phy_init misses > a check for it. > This may lead to problems when regulator_set_voltage uses the unchecked > pointer. > This patch adds a check for devm_regulator_get to avoid potential

[PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get

2019-10-15 Thread Chuhong Yuan
devm_regulator_get may return an error but mipi_csis_phy_init misses a check for it. This may lead to problems when regulator_set_voltage uses the unchecked pointer. This patch adds a check for devm_regulator_get to avoid potential risk. Signed-off-by: Chuhong Yuan --- Changes in v2: - Add a