Re: [PATCH v2] staging: media: sunxi: Add bool cast to value

2019-07-25 Thread Hans Verkuil
On 7/22/19 8:06 AM, Nishka Dasgupta wrote: > Typecast as bool the return value of cedrus_find_format in > cedrus_check_format as the return value of cedrus_check_format is always > treated like a boolean value. > > Signed-off-by: Nishka Dasgupta > --- > Changes in v2: > - Add !! to the returned

Re: [PATCH v2] staging: media: sunxi: Add bool cast to value

2019-07-23 Thread Paul Kocialkowski
Hi, On Mon 22 Jul 19, 18:58, Sakari Ailus wrote: > On Mon, Jul 22, 2019 at 07:14:08PM +0530, Nishka Dasgupta wrote: > > On 22/07/19 5:54 PM, Paul Kocialkowski wrote: > > > Hi, > > > > > > On Mon 22 Jul 19, 12:12, Jeremy Sowden wrote: > > > > On 2019-07-22, at 11:36:51 +0530, Nishka Dasgupta

Re: [PATCH v2] staging: media: sunxi: Add bool cast to value

2019-07-22 Thread Sakari Ailus
On Mon, Jul 22, 2019 at 07:14:08PM +0530, Nishka Dasgupta wrote: > On 22/07/19 5:54 PM, Paul Kocialkowski wrote: > > Hi, > > > > On Mon 22 Jul 19, 12:12, Jeremy Sowden wrote: > > > On 2019-07-22, at 11:36:51 +0530, Nishka Dasgupta wrote: > > > > Typecast as bool the return value of

Re: [PATCH v2] staging: media: sunxi: Add bool cast to value

2019-07-22 Thread Paul Kocialkowski
Hi, On Mon 22 Jul 19, 19:14, Nishka Dasgupta wrote: > On 22/07/19 5:54 PM, Paul Kocialkowski wrote: > > Hi, > > > > On Mon 22 Jul 19, 12:12, Jeremy Sowden wrote: > > > On 2019-07-22, at 11:36:51 +0530, Nishka Dasgupta wrote: > > > > Typecast as bool the return value of cedrus_find_format in > >

Re: [PATCH v2] staging: media: sunxi: Add bool cast to value

2019-07-22 Thread Nishka Dasgupta
On 22/07/19 5:54 PM, Paul Kocialkowski wrote: Hi, On Mon 22 Jul 19, 12:12, Jeremy Sowden wrote: On 2019-07-22, at 11:36:51 +0530, Nishka Dasgupta wrote: Typecast as bool the return value of cedrus_find_format in cedrus_check_format as the return value of cedrus_check_format is always treated

Re: [PATCH v2] staging: media: sunxi: Add bool cast to value

2019-07-22 Thread Jeremy Sowden
On 2019-07-22, at 14:24:38 +0200, Paul Kocialkowski wrote: > On Mon 22 Jul 19, 12:12, Jeremy Sowden wrote: > > On 2019-07-22, at 11:36:51 +0530, Nishka Dasgupta wrote: > > > Typecast as bool the return value of cedrus_find_format in > > > cedrus_check_format as the return value of

Re: [PATCH v2] staging: media: sunxi: Add bool cast to value

2019-07-22 Thread Paul Kocialkowski
Hi, On Mon 22 Jul 19, 12:12, Jeremy Sowden wrote: > On 2019-07-22, at 11:36:51 +0530, Nishka Dasgupta wrote: > > Typecast as bool the return value of cedrus_find_format in > > cedrus_check_format as the return value of cedrus_check_format is > > always treated like a boolean value. > > > >

Re: [PATCH v2] staging: media: sunxi: Add bool cast to value

2019-07-22 Thread Jeremy Sowden
On 2019-07-22, at 11:36:51 +0530, Nishka Dasgupta wrote: > Typecast as bool the return value of cedrus_find_format in > cedrus_check_format as the return value of cedrus_check_format is > always treated like a boolean value. > > Signed-off-by: Nishka Dasgupta > --- > Changes in v2: > - Add !! to

[PATCH v2] staging: media: sunxi: Add bool cast to value

2019-07-22 Thread Nishka Dasgupta
Typecast as bool the return value of cedrus_find_format in cedrus_check_format as the return value of cedrus_check_format is always treated like a boolean value. Signed-off-by: Nishka Dasgupta --- Changes in v2: - Add !! to the returned pointer to ensure that the return value is always either