Hi, I initially submitted a patch to remove all the explicit boolean comparisons in rtl8712. These code changes included two instances where braces needed to be added to clean the output of checkpatch.pl on this patch.
Mike Rapaport correctly pointed out those changes had to go in a separate patch. Not wanting to only fix those two instances, but cover the whole rtl8712, I've added a second patch fixing these. The checkpatch.pl of the second patch included some checks about needing spaces around operands. Including this fix as well for a nicer checkpatch.pl output. Plus also making it cover all rtl8712. In other words, these are a series of recursive cleanup changes. Thanks for the review Mike, Luis Luis de Bethencourt (3): staging: rtl8712: Remove boolean comparisons staging: rtl8712: braces should be used on all arms staging: rtl8712: spaces preferred around operands drivers/staging/rtl8712/hal_init.c | 11 +- drivers/staging/rtl8712/ieee80211.c | 36 ++--- drivers/staging/rtl8712/mlme_linux.c | 2 +- drivers/staging/rtl8712/os_intfs.c | 6 +- drivers/staging/rtl8712/rtl8712_cmd.c | 27 ++-- drivers/staging/rtl8712/rtl8712_efuse.c | 138 ++++++++++--------- drivers/staging/rtl8712/rtl8712_io.c | 6 +- drivers/staging/rtl8712/rtl8712_led.c | 187 +++++++++++++------------- drivers/staging/rtl8712/rtl8712_recv.c | 53 ++++---- drivers/staging/rtl8712/rtl8712_xmit.c | 74 +++++----- drivers/staging/rtl8712/rtl871x_cmd.c | 25 ++-- drivers/staging/rtl8712/rtl871x_eeprom.c | 22 +-- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 153 +++++++++++---------- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 53 +++++--- drivers/staging/rtl8712/rtl871x_ioctl_set.c | 33 ++--- drivers/staging/rtl8712/rtl871x_mlme.c | 144 ++++++++++---------- drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- drivers/staging/rtl8712/rtl871x_mp.c | 23 ++-- drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 38 +++--- drivers/staging/rtl8712/rtl871x_pwrctrl.c | 6 +- drivers/staging/rtl8712/rtl871x_recv.c | 70 +++++----- drivers/staging/rtl8712/rtl871x_security.c | 133 +++++++++--------- drivers/staging/rtl8712/rtl871x_sta_mgt.c | 10 +- drivers/staging/rtl8712/rtl871x_xmit.c | 95 ++++++------- drivers/staging/rtl8712/usb_halinit.c | 13 +- drivers/staging/rtl8712/usb_intf.c | 17 +-- drivers/staging/rtl8712/usb_ops.c | 20 +-- drivers/staging/rtl8712/usb_ops_linux.c | 20 +-- drivers/staging/rtl8712/xmit_linux.c | 4 +- 29 files changed, 753 insertions(+), 668 deletions(-) -- 2.5.3 _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
