Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

2018-04-03 Thread Dan Carpenter
When I look at them now in a more relaxed mood, they're basically all fine except for patch 74 which is buggy. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

2018-04-02 Thread Joe Perches
On Mon, 2018-04-02 at 14:45 +0300, Dan Carpenter wrote: > On Sat, Mar 31, 2018 at 07:12:53AM -0700, Joe Perches wrote: > > On Sat, 2018-03-31 at 11:41 +0300, Dan Carpenter wrote: > > > On Fri, Mar 30, 2018 at 11:36:13PM -0700, Joe Perches wrote: > > > > On Fri, 2018-03-30 at 23:07 -0700, Quytelda

Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

2018-04-02 Thread Dan Carpenter
On Sat, Mar 31, 2018 at 07:12:53AM -0700, Joe Perches wrote: > On Sat, 2018-03-31 at 11:41 +0300, Dan Carpenter wrote: > > On Fri, Mar 30, 2018 at 11:36:13PM -0700, Joe Perches wrote: > > > On Fri, 2018-03-30 at 23:07 -0700, Quytelda Kahja wrote: > > > > This macro, provided in 'linux/kernel.h',

Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

2018-03-31 Thread Joe Perches
On Sat, 2018-03-31 at 11:41 +0300, Dan Carpenter wrote: > On Fri, Mar 30, 2018 at 11:36:13PM -0700, Joe Perches wrote: > > On Fri, 2018-03-30 at 23:07 -0700, Quytelda Kahja wrote: > > > This macro, provided in 'linux/kernel.h', will calculate the size > > > more succinctly than a division

Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

2018-03-31 Thread Dan Carpenter
On Fri, Mar 30, 2018 at 11:36:13PM -0700, Joe Perches wrote: > On Fri, 2018-03-30 at 23:07 -0700, Quytelda Kahja wrote: > > This macro, provided in 'linux/kernel.h', will calculate the size > > more succinctly than a division operation. > > It's nice that you send patches, but please try to send

Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

2018-03-31 Thread Joe Perches
On Fri, 2018-03-30 at 23:07 -0700, Quytelda Kahja wrote: > This macro, provided in 'linux/kernel.h', will calculate the size > more succinctly than a division operation. It's nice that you send patches, but please try to send a cover letter with your patch series. Also, 75 patches is quite a lot

[PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

2018-03-31 Thread Quytelda Kahja
This macro, provided in 'linux/kernel.h', will calculate the size more succinctly than a division operation. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan_net.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git