Re: [PATCH v2 03/18] staging: mt7621-pci: avoid pointer arithmetics in some macros

2018-07-08 Thread Sergio Paracuellos
On Mon, Jul 09, 2018 at 09:13:02AM +1000, NeilBrown wrote: > On Sun, Jul 08 2018, Sergio Paracuellos wrote: > > > RALINK_PCI_MEMBASE, RALINK_PCI_IOBASE, RALINK_PCI_PCICFG_ADDR and > > RALINK_PCI_PCIMSK_ADDR are using very ugly pointer arithmetics to > > read and write along the code. Instead of do

Re: [PATCH v2 03/18] staging: mt7621-pci: avoid pointer arithmetics in some macros

2018-07-08 Thread NeilBrown
On Sun, Jul 08 2018, Sergio Paracuellos wrote: > RALINK_PCI_MEMBASE, RALINK_PCI_IOBASE, RALINK_PCI_PCICFG_ADDR and > RALINK_PCI_PCIMSK_ADDR are using very ugly pointer arithmetics to > read and write along the code. Instead of doing this, use the > mt7621_pci_reg_read and mt7621_pci_reg_write func

[PATCH v2 03/18] staging: mt7621-pci: avoid pointer arithmetics in some macros

2018-07-08 Thread Sergio Paracuellos
RALINK_PCI_MEMBASE, RALINK_PCI_IOBASE, RALINK_PCI_PCICFG_ADDR and RALINK_PCI_PCIMSK_ADDR are using very ugly pointer arithmetics to read and write along the code. Instead of doing this, use the mt7621_pci_reg_read and mt7621_pci_reg_write functions making this a bit cleaner. Signed-off-by: Sergio