Re: [PATCH v2 1/7] staging/wilc1000: Introduce linux_spi_msg_init

2016-01-12 Thread Sudip Mukherjee
On Mon, Jan 11, 2016 at 09:13:31PM +0100, Janosch Frank wrote: > Since all spi read and write functions were basically preparing the > same data, moving the preparation into a function decreased line count > a lot. > > This also resolves the following problems: > Zeroing the message ourselves is

[PATCH v2 1/7] staging/wilc1000: Introduce linux_spi_msg_init

2016-01-11 Thread Janosch Frank
Since all spi read and write functions were basically preparing the same data, moving the preparation into a function decreased line count a lot. This also resolves the following problems: Zeroing the message ourselves is not needed, as spi_message_init() already does that for us. The comment on