RE: [PATCH v4 11/13] staging: typec: tcpci: keep the not connecting cc line open

2018-03-30 Thread Jun Li
; shufan_...@richtek.com; Peter Chen > <peter.c...@nxp.com>; devicet...@vger.kernel.org; > linux-...@vger.kernel.org; dl-linux-imx <linux-...@nxp.com>; > de...@driverdev.osuosl.org > Subject: Re: [PATCH v4 11/13] staging: typec: tcpci: keep the not connecting > cc &g

Re: [PATCH v4 11/13] staging: typec: tcpci: keep the not connecting cc line open

2018-03-30 Thread Guenter Roeck
On 03/28/2018 09:06 AM, Li Jun wrote: While set polarity, we should keep the not connecting cc line to be open. The more I look at this code, the more I am confused by it. The original code doesn't touch the CC lines. This function only sets the polarity. Is it really appropriate to touch

[PATCH v4 11/13] staging: typec: tcpci: keep the not connecting cc line open

2018-03-28 Thread Li Jun
While set polarity, we should keep the not connecting cc line to be open. Signed-off-by: Li Jun --- drivers/staging/typec/tcpci.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c