Hi David, Dan,
On Thu, Nov 30, 2017 at 12:50 AM, David Daney wrote:
> On 11/29/2017 08:07 AM, Souptick Joarder wrote:
>>
>> On Wed, Nov 29, 2017 at 4:00 PM, Souptick Joarder
>> wrote:
>>>
>>> On Wed, Nov 29, 2017 at 6:25 AM, David Daney
>>> wrote:
From: Carlos Munoz
The Ca
On 11/29/2017 02:56 PM, Andrew Lunn wrote:
On Tue, Nov 28, 2017 at 04:55:39PM -0800, David Daney wrote:
+static int bgx_probe(struct platform_device *pdev)
+{
+ struct mac_platform_data platform_data;
+ const __be32 *reg;
+ u32 port;
+ u64 addr;
+ struct device_node
On Tue, Nov 28, 2017 at 04:55:39PM -0800, David Daney wrote:
> +static int bgx_probe(struct platform_device *pdev)
> +{
> + struct mac_platform_data platform_data;
> + const __be32 *reg;
> + u32 port;
> + u64 addr;
> + struct device_node *child;
> + struct platform_device *n
On Wed, Nov 29, 2017 at 10:11:38PM +0300, Dan Carpenter wrote:
> On Wed, Nov 29, 2017 at 09:37:15PM +0530, Souptick Joarder wrote:
> > >> +static int bgx_port_sgmii_set_link_speed(struct bgx_port_priv *priv,
> > >> struct port_status status)
> > >> +{
> > >> + u64 data;
> > >> + u6
On 11/29/2017 08:07 AM, Souptick Joarder wrote:
On Wed, Nov 29, 2017 at 4:00 PM, Souptick Joarder wrote:
On Wed, Nov 29, 2017 at 6:25 AM, David Daney wrote:
From: Carlos Munoz
The Cavium OCTEON cn78xx and cn73xx SoCs have network packet I/O
hardware that is significantly different from prev
On Wed, Nov 29, 2017 at 09:37:15PM +0530, Souptick Joarder wrote:
> >> +static int bgx_port_sgmii_set_link_speed(struct bgx_port_priv *priv,
> >> struct port_status status)
> >> +{
> >> + u64 data;
> >> + u64 prtx;
> >> + u64 miscx;
> >> + int timeout;
> >>
On Wed, Nov 29, 2017 at 4:00 PM, Souptick Joarder wrote:
> On Wed, Nov 29, 2017 at 6:25 AM, David Daney wrote:
>> From: Carlos Munoz
>>
>> The Cavium OCTEON cn78xx and cn73xx SoCs have network packet I/O
>> hardware that is significantly different from previous generations of
>> the family.
>>
On Wed, Nov 29, 2017 at 04:00:01PM +0530, Souptick Joarder wrote:
Hi Souptick
Please trim the code when giving reviews. We don't want to have to
page through 8K lines of code it find a few comments mixed in. Just
keep the beginning of the function you are commented on to make the
context clear. C