Re: [PATCH v5 18/18] staging: mt7621-gpio: avoid use banks in device tree

2018-07-04 Thread Sergio Paracuellos
On Thu, Jul 05, 2018 at 10:51:39AM +1000, NeilBrown wrote: > On Sat, Jun 30 2018, Sergio Paracuellos wrote: > > > On Sat, Jun 30, 2018 at 7:47 AM, NeilBrown wrote: > >> On Mon, Jun 18 2018, Sergio Paracuellos wrote: > >> > >>> Banks shouldn't be defined in DT if number of resources > >>> per

Re: [PATCH v5 18/18] staging: mt7621-gpio: avoid use banks in device tree

2018-07-04 Thread NeilBrown
On Sat, Jun 30 2018, Sergio Paracuellos wrote: > On Sat, Jun 30, 2018 at 7:47 AM, NeilBrown wrote: >> On Mon, Jun 18 2018, Sergio Paracuellos wrote: >> >>> Banks shouldn't be defined in DT if number of resources >>> per bank is not variable. We actually know that this SoC >>> has three banks so

Re: [PATCH v5 18/18] staging: mt7621-gpio: avoid use banks in device tree

2018-06-30 Thread Sergio Paracuellos
On Sat, Jun 30, 2018 at 7:47 AM, NeilBrown wrote: > On Mon, Jun 18 2018, Sergio Paracuellos wrote: > >> Banks shouldn't be defined in DT if number of resources >> per bank is not variable. We actually know that this SoC >> has three banks so take that into account in order to don't >> overspecify

Re: [PATCH v5 18/18] staging: mt7621-gpio: avoid use banks in device tree

2018-06-29 Thread NeilBrown
On Mon, Jun 18 2018, Sergio Paracuellos wrote: > Banks shouldn't be defined in DT if number of resources > per bank is not variable. We actually know that this SoC > has three banks so take that into account in order to don't > overspecify the device tree. Device tree will only have one > node

[PATCH v5 18/18] staging: mt7621-gpio: avoid use banks in device tree

2018-06-18 Thread Sergio Paracuellos
Banks shouldn't be defined in DT if number of resources per bank is not variable. We actually know that this SoC has three banks so take that into account in order to don't overspecify the device tree. Device tree will only have one node making it simple. Update device tree, binding doc and code