Re: [PATCH v5 5/9] media: staging: rkisp1: remove unecessary clocks

2020-10-21 Thread Helen Koike
Hi Rob, On 10/20/20 12:14 PM, Rob Herring wrote: > On Wed, Oct 14, 2020 at 11:46 AM Helen Koike > wrote: >> >> Hi Rob, >> >> Thnaks for your reply. >> >> On 9/22/20 11:24 AM, Rob Herring wrote: >>> On Wed, Jul 22, 2020 at 9:56 AM Helen Koike >>> wrote: aclk_isp_wrap is a child of

Re: [PATCH v5 5/9] media: staging: rkisp1: remove unecessary clocks

2020-10-20 Thread Rob Herring
On Wed, Oct 14, 2020 at 11:46 AM Helen Koike wrote: > > Hi Rob, > > Thnaks for your reply. > > On 9/22/20 11:24 AM, Rob Herring wrote: > > On Wed, Jul 22, 2020 at 9:56 AM Helen Koike > > wrote: > >> > >> aclk_isp_wrap is a child of aclk_isp, and hclk_isp_wrap is a child of > >> hclk_isp, thus

Re: [PATCH v5 5/9] media: staging: rkisp1: remove unecessary clocks

2020-10-14 Thread Helen Koike
Hi Rob, Thnaks for your reply. On 9/22/20 11:24 AM, Rob Herring wrote: > On Wed, Jul 22, 2020 at 9:56 AM Helen Koike wrote: >> >> aclk_isp_wrap is a child of aclk_isp, and hclk_isp_wrap is a child of >> hclk_isp, thus we can remove parents from the list. >> >> Also, for the isp0, we only need

Re: [PATCH v5 5/9] media: staging: rkisp1: remove unecessary clocks

2020-09-22 Thread Rob Herring
On Wed, Jul 22, 2020 at 9:56 AM Helen Koike wrote: > > aclk_isp_wrap is a child of aclk_isp, and hclk_isp_wrap is a child of > hclk_isp, thus we can remove parents from the list. > > Also, for the isp0, we only need the ISP clock, ACLK and HCLK. > In the future we'll need a pixel clock for RK3288

[PATCH v5 5/9] media: staging: rkisp1: remove unecessary clocks

2020-07-22 Thread Helen Koike
aclk_isp_wrap is a child of aclk_isp, and hclk_isp_wrap is a child of hclk_isp, thus we can remove parents from the list. Also, for the isp0, we only need the ISP clock, ACLK and HCLK. In the future we'll need a pixel clock for RK3288 and RK3399, and a JPEG clock for RK3288. So with the goal to