Re: [PATCH v6] rtl8712: Fixed alignment to match open parenthesis

2016-04-26 Thread Luis de Bethencourt
On 26/04/16 15:47, Parth Sane wrote: > Hi, > Yes you are right on that regard. I did do that in my previous patches. > It’s just something that I will have to remember now onwards. Thanks. > Regards, > Parth Sane Sure. It isn't a big issue, just thought it was worth mentioning as a tip. Please ke

Re: [PATCH v6] rtl8712: Fixed alignment to match open parenthesis

2016-04-26 Thread Parth Sane
Hi, Yes you are right on that regard. I did do that in my previous patches. It’s just something that I will have to remember now onwards. Thanks. Regards, Parth Sane > On 26-Apr-2016, at 8:14 PM, Luis de Bethencourt > wrote: > > On 26/04/16 15:33, Parth Sane wrote: >> Hi, >> Thanks for the feedb

Re: [PATCH v6] rtl8712: Fixed alignment to match open parenthesis

2016-04-26 Thread Luis de Bethencourt
On 26/04/16 15:33, Parth Sane wrote: > Hi, > Thanks for the feedback. I did find this issue with the assistance > checkpatch.pl script. > Regards, > Parth Sane Normally people mention the checkpatch warning they are fixing. For example: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux

Re: [PATCH v6] rtl8712: Fixed alignment to match open parenthesis

2016-04-26 Thread Parth Sane
Hi, Thanks for the feedback. I did find this issue with the assistance checkpatch.pl script. Regards, Parth Sane > On 26-Apr-2016, at 8:00 PM, Luis de Bethencourt > wrote: > > On 25/04/16 16:43, Parth Sane wrote: >> Fixed alignment to match open parenthesis. >> >> Signed-off-by: Parth Sane >>

Re: [PATCH v6] rtl8712: Fixed alignment to match open parenthesis

2016-04-26 Thread Luis de Bethencourt
On 25/04/16 16:43, Parth Sane wrote: > Fixed alignment to match open parenthesis. > > Signed-off-by: Parth Sane > > --- > Changes in v6: > -Added line before Signed-off message > This last version looks good to me. Did you find this issue with checkpatch.pl? Thanks, Luis __

[PATCH v6] rtl8712: Fixed alignment to match open parenthesis

2016-04-25 Thread Parth Sane
Fixed alignment to match open parenthesis. Signed-off-by: Parth Sane --- Changes in v6: -Added line before Signed-off message drivers/staging/rtl8712/hal_init.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/st