Re: [PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver

2018-09-07 Thread Paul Kocialkowski
Hi, Le jeudi 06 septembre 2018 à 09:22 +0200, Hans Verkuil a écrit : > On 09/06/2018 09:01 AM, Hans Verkuil wrote: > > On 09/05/2018 06:29 PM, Paul Kocialkowski wrote: > > > Hi and thanks for the review! > > > > > > Le lundi 03 septembre 2018 à 11:11 +0200, Hans Verkuil a écrit : > > > > On

Re: [PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver

2018-09-07 Thread Tomasz Figa
On Thu, Sep 6, 2018 at 4:39 PM Hans Verkuil wrote: > > On 09/06/2018 09:25 AM, Tomasz Figa wrote: > > On Thu, Sep 6, 2018 at 4:01 PM Hans Verkuil wrote: > >> > >> On 09/05/2018 06:29 PM, Paul Kocialkowski wrote: > >>> Hi and thanks for the review! > >>> > >>> Le lundi 03 septembre 2018 à 11:11

Re: [PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver

2018-09-06 Thread Hans Verkuil
On 09/06/2018 09:25 AM, Tomasz Figa wrote: > On Thu, Sep 6, 2018 at 4:01 PM Hans Verkuil wrote: >> >> On 09/05/2018 06:29 PM, Paul Kocialkowski wrote: >>> Hi and thanks for the review! >>> >>> Le lundi 03 septembre 2018 à 11:11 +0200, Hans Verkuil a écrit : On 08/28/2018 09:34 AM, Paul

Re: [PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver

2018-09-06 Thread Tomasz Figa
On Thu, Sep 6, 2018 at 4:01 PM Hans Verkuil wrote: > > On 09/05/2018 06:29 PM, Paul Kocialkowski wrote: > > Hi and thanks for the review! > > > > Le lundi 03 septembre 2018 à 11:11 +0200, Hans Verkuil a écrit : > >> On 08/28/2018 09:34 AM, Paul Kocialkowski wrote: > >>> +static int

Re: [PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver

2018-09-06 Thread Hans Verkuil
On 09/06/2018 09:01 AM, Hans Verkuil wrote: > On 09/05/2018 06:29 PM, Paul Kocialkowski wrote: >> Hi and thanks for the review! >> >> Le lundi 03 septembre 2018 à 11:11 +0200, Hans Verkuil a écrit : >>> On 08/28/2018 09:34 AM, Paul Kocialkowski wrote: +static int cedrus_queue_setup(struct

Re: [PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver

2018-09-06 Thread Hans Verkuil
On 09/05/2018 06:29 PM, Paul Kocialkowski wrote: > Hi and thanks for the review! > > Le lundi 03 septembre 2018 à 11:11 +0200, Hans Verkuil a écrit : >> On 08/28/2018 09:34 AM, Paul Kocialkowski wrote: >>> +static int cedrus_request_validate(struct media_request *req) >>> +{ >>> + struct

Re: [PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver

2018-09-05 Thread Paul Kocialkowski
Hi and thanks for the review! Le lundi 03 septembre 2018 à 11:11 +0200, Hans Verkuil a écrit : > On 08/28/2018 09:34 AM, Paul Kocialkowski wrote: > > +static int cedrus_request_validate(struct media_request *req) > > +{ > > + struct media_request_object *obj, *obj_safe; > > + struct

Re: [PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver

2018-09-05 Thread Paul Kocialkowski
Hi, Le mardi 28 août 2018 à 22:08 -0300, Ezequiel Garcia a écrit : > On Tue, 2018-08-28 at 09:34 +0200, Paul Kocialkowski wrote: > > +static const struct v4l2_m2m_ops cedrus_m2m_ops = { > > + .device_run = cedrus_device_run, > > + .job_abort = cedrus_job_abort, > > +}; > > + > > I

Re: [PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver

2018-09-03 Thread Hans Verkuil
On 08/28/2018 09:34 AM, Paul Kocialkowski wrote: > This introduces the Cedrus VPU driver that supports the VPU found in > Allwinner SoCs, also known as Video Engine. It is implemented through > a v4l2 m2m decoder device and a media device (used for media requests). > So far, it only supports MPEG2

Re: [PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver

2018-08-28 Thread Ezequiel Garcia
On Tue, 2018-08-28 at 09:34 +0200, Paul Kocialkowski wrote: > This introduces the Cedrus VPU driver that supports the VPU found in > Allwinner SoCs, also known as Video Engine. It is implemented through > a v4l2 m2m decoder device and a media device (used for media requests). > So far, it only

Re: [PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver

2018-08-28 Thread Maxime Ripard
On Tue, Aug 28, 2018 at 09:34:20AM +0200, Paul Kocialkowski wrote: > This introduces the Cedrus VPU driver that supports the VPU found in > Allwinner SoCs, also known as Video Engine. It is implemented through > a v4l2 m2m decoder device and a media device (used for media requests). > So far, it

[PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver

2018-08-28 Thread Paul Kocialkowski
This introduces the Cedrus VPU driver that supports the VPU found in Allwinner SoCs, also known as Video Engine. It is implemented through a v4l2 m2m decoder device and a media device (used for media requests). So far, it only supports MPEG2 decoding. Since this VPU is stateless, synchronization