On Wed, Jun 10, 2015 at 10:11:37AM +0300, Dan Carpenter wrote:
Also this driver has active maintainers but somehow we have CC'd the
ATMEL people who maintain a different staging driver...
The original patch had put the maintainers of WILC1000 WIFI DRIVER in the
cc list. Now ccing the actual
On Wed, Jun 10, 2015 at 04:54:47AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Hari Prasath Gujulan Elango hguju...@visteon.com
snip
@@ -7159,8 +7144,9 @@ err_stop:
*/
static void dgap_cleanup_module(void)
{
- if (dgap_numboards)
-
I mean, yes, it doesn't seem to make much sense to continue polling
after all the hardware has been removed. The problem is that we pass a
pci_dev pointer to dgap_remove_one() and it ignores it and removes
everything.
Otherwise, I would probably suggest that it start polling when the first
On Wed, Jun 10, 2015 at 10:11:37AM +0300, Dan Carpenter wrote:
I mean, yes, it doesn't seem to make much sense to continue polling
after all the hardware has been removed. The problem is that we pass a
pci_dev pointer to dgap_remove_one() and it ignores it and removes
everything.
From: Hari Prasath Gujulan Elango hguju...@visteon.com
The driver remove function is not the right place to cleanup resources
allocated in the driver module init.The cleanup is moved from remove
method to module exit as appropriate.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com