[PATCH 22/31] staging: wfx: fix structs alignments

From: Jérôme Pouiller Some structs members were not properly aligned. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/bus_sdio.c | 12 ++--- drivers/staging/wfx/bus_spi.c | 12 ++--- drivers/staging/wfx/debug.c| 2 +- drivers/staging/wfx/fwio.c | 6 +--

[PATCH 20/31] staging: wfx: reformat code on 100 columns

d to write code on 100 columns. This patch just unify the code to use 100 columns. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/bh.c | 12 ++--- drivers/staging/wfx/bus.h| 6 +-- drivers/staging/wfx/bus_sdio.c | 12 ++--- drivers/staging/wfx/bus_spi.c| 24 +++-

[PATCH 21/31] staging: wfx: reformat comments on 100 columns

d to write code on 100 columns. This patch just unify the code to use 100 columns in every comments. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/bh.c | 26 ++- drivers/staging/wfx/bus_spi.c | 14 ++--- drivers/staging/wfx/data_rx.c | 4 ++-

[PATCH 18/31] staging: wfx: prefix structs hif_* with wfx_

From: Jérôme Pouiller All the types related to a driver should use the same prefix. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/bh.c | 12 +-- drivers/staging/wfx/data_rx.c | 2 +- drivers/staging/wfx/data_rx.h | 4 +- drivers/staging/wfx/data_tx.c

[PATCH 19/31] staging: wfx: prefix structs tx_policy and hwbus_ops with wfx_

From: Jérôme Pouiller All the types related to a driver should use the same prefix. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/bus.h | 2 +- drivers/staging/wfx/bus_sdio.c | 2 +- drivers/staging/wfx/bus_spi.c | 2 +- drivers/staging/wfx/data_tx.c | 38

[PATCH 17/31] staging: wfx: prefix tx_policy_is_equal() with wfx_

From: Jérôme Pouiller tx_policy_is_equal() was the only function from data_tx.c without the prefix wfx_. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/data_tx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wfx/data_tx.c

[PATCH 15/31] staging: wfx: prefix functions from hwio.h with wfx_

From: Jérôme Pouiller All the functions related to a driver should use the same prefix. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/bh.c | 8 +-- drivers/staging/wfx/fwio.c | 78 ++-- drivers/staging/wfx/hif_tx.c | 2 +- drivers/staging/wfx/hwio.c | 135

[PATCH 16/31] staging: wfx: prefix functions from debug.h with wfx_

From: Jérôme Pouiller All the functions related to a driver should use the same prefix. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/debug.c | 6 +++--- drivers/staging/wfx/debug.h | 6 +++--- drivers/staging/wfx/hif_tx.c | 8 3 files changed, 10 insertions(+), 10

[PATCH 14/31] staging: wfx: prefix functions from hif_*.h with wfx_

From: Jérôme Pouiller All the functions related to a driver should use the same prefix. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/data_tx.c| 2 +- drivers/staging/wfx/debug.c | 2 +- drivers/staging/wfx/hif_rx.c | 103 +-

[PATCH 12/31] staging: wfx: fix ambiguous function name

From: Jérôme Pouiller The prefix 'ieee80211' is reserved for mac80211. It should not been used. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/scan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wfx/scan.c b/drivers/staging/wfx/scan.c index

[PATCH 13/31] staging: wfx: fix ambiguous function name

From: Jérôme Pouiller The prefix 'ieee80211' is reserved for mac80211. It should not been used. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/data_tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wfx/data_tx.c

[PATCH 11/31] staging: wfx: preserve endianness of struct hif_ind_startup

From: Jérôme Pouiller The hardware fills struct hif_ind_startup with little endian values. So, declare it with little endian fields. It is now a bit more verbose to access to fields of struct hif_ind_startup, but it is less confusing. Signed-off-by: Jérôme Pouiller ---

[PATCH 10/31] stagigg: wfx: replace magic number by HIF_ID_IS_INDICATION

From: Jérôme Pouiller Magic values are not recommended. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wfx/hif_rx.c b/drivers/staging/wfx/hif_rx.c index 6963b54d5593..5e675d2c3e82 100644 ---

[PATCH 09/31] staging: wfx: replace magic value by WFX_HIF_BUFFER_SIZE

From: Jérôme Pouiller Magic values are not recommended. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hwio.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wfx/hwio.c b/drivers/staging/wfx/hwio.c index a2a37efc51a6..977b9325f496 100644 ---

[PATCH 08/31] staging: wfx: use IS_ALIGNED()

From: Jérôme Pouiller It "IS_ALIGNED(ptr, 4)" is more explicit than "ptr & 3". Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/bus_sdio.c | 9 + drivers/staging/wfx/hwio.c | 5 +++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git

[PATCH 07/31] staging: wfx: remove useless #ifdef

From: Jérôme Pouiller In the old days, this file was shared with other projects. Obviously, this "#ifdef __KERNEL__" have no reasons to be in the kernel. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_api_general.h | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH 06/31] staging: wfx: remove unnecessary braces

From: Jérôme Pouiller Braces are not necessary for single statement blocks Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c index

[PATCH 05/31] staging: wfx: explain uncommon Makefile statement

From: Jérôme Pouiller I have got questions about this line from several reviewers. A comment is definitively welcome. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/wfx/Makefile b/drivers/staging/wfx/Makefile

[PATCH 04/31] staging: wfx: fix comment correctness

From: Jérôme Pouiller Using DMA with stack allocated buffers is not supported, whatever the value of CONFIG_VMAP_STACK. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hwio.c | 12 drivers/staging/wfx/hwio.h | 4 2 files changed, 4 insertions(+), 12 deletions(-)

[PATCH 03/31] staging: wfx: fix missing headers

From: Jérôme Pouiller Each headers files should include every types it needs to compile (ie. "gcc $CFLAGS -xc file.h" should compile) Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/bh.h | 1 + drivers/staging/wfx/hif_tx.h | 4 drivers/staging/wfx/hif_tx_mib.h | 7

[PATCH 02/31] staging: wfx: fix HIF API license

From: Jérôme Pouiller Apache-2.0 is not allowed in the kernel. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_api_cmd.h | 2 +- drivers/staging/wfx/hif_api_general.h | 2 +- drivers/staging/wfx/hif_api_mib.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 00/31] staging/wfx: apply suggestions from the linux-wireless review

From: Jérôme Pouiller Most of the patches of this series are the result of the review process on linux-wireless[1]. The patches 1 to 25 are cosmetics. The last 3 patches are not fully backward compatible. I believe it is not a problem in the staging area. [1]:

[PATCH 01/31] staging: wfx: fix Makefile and Kconfig licenses

From: Jérôme Pouiller License was missing in Kconfig. Makefile license was GPL-2.0 while rest of the driver use GPL-2.0-only. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/Kconfig | 1 + drivers/staging/wfx/Makefile | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff

Re: [PATCH v9 08/24] wfx: add bus_sdio.c

On Wednesday 12 January 2022 18:48:48 CET Pali Rohár wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > On Wednesday 12 January 2022 17:45:45 Jérôme Pouiller

Re: [PATCH v9 08/24] wfx: add bus_sdio.c

On Wednesday 12 January 2022 17:45:45 Jérôme Pouiller wrote: > On Wednesday 12 January 2022 12:43:32 CET Pali Rohár wrote: > > > > On Wednesday 12 January 2022 12:18:58 Jérôme Pouiller wrote: > > > On Wednesday 12 January 2022 11:58:59 CET Pali Rohár wrote: > > > > On Tuesday 11 January 2022

Re: [PATCH v9 08/24] wfx: add bus_sdio.c

On Wednesday 12 January 2022 12:43:32 CET Pali Rohár wrote: > > On Wednesday 12 January 2022 12:18:58 Jérôme Pouiller wrote: > > On Wednesday 12 January 2022 11:58:59 CET Pali Rohár wrote: > > > On Tuesday 11 January 2022 18:14:08 Jerome Pouiller wrote: > > > > +static const struct sdio_device_id

Re: [PATCH v9 08/24] wfx: add bus_sdio.c

On Wed, 12 Jan 2022 at 12:43, Pali Rohár wrote: > > On Wednesday 12 January 2022 12:18:58 Jérôme Pouiller wrote: > > On Wednesday 12 January 2022 11:58:59 CET Pali Rohár wrote: > > > On Tuesday 11 January 2022 18:14:08 Jerome Pouiller wrote: > > > > +static const struct sdio_device_id

Re: [PATCH v9 23/24] wfx: remove from the staging area

Jérôme Pouiller writes: > On Wednesday 12 January 2022 08:49:54 CET Kalle Valo wrote: >> Jerome Pouiller writes: >> >> > From: Jérôme Pouiller >> > >> > Signed-off-by: Jérôme Pouiller >> > --- >> > .../bindings/net/wireless/silabs,wfx.yaml | 125 --- >> > drivers/staging/wfx/Kconfig

Re: [PATCH v9 01/24] mmc: sdio: add SDIO IDs for Silabs WF200 chip

red in >> the DT. >> >> So, to apply the quirks necessary for the Silabs WF200, we rely on the >> DT rather than on the SDIO VID/PID. >> >> Signed-off-by: Jérôme Pouiller > > I guess the series is getting close to getting queued up? > > As an option to mak

Re: [PATCH v9 08/24] wfx: add bus_sdio.c

On Wednesday 12 January 2022 13:06:17 Greg Kroah-Hartman wrote: > On Wed, Jan 12, 2022 at 12:43:32PM +0100, Pali Rohár wrote: > > Btw, is there any project which maintains SDIO ids, like there is > > pci-ids.ucw.cz for PCI or www.linux-usb.org/usb-ids.html for USB? > > Both of those projects have

Re: [PATCH v9 08/24] wfx: add bus_sdio.c

On Wed, Jan 12, 2022 at 12:43:32PM +0100, Pali Rohár wrote: > Btw, is there any project which maintains SDIO ids, like there is > pci-ids.ucw.cz for PCI or www.linux-usb.org/usb-ids.html for USB? Both of those projects have nothing to do with the kernel drivers or values at all, they are only for

Re: [PATCH v9 08/24] wfx: add bus_sdio.c

On Wednesday 12 January 2022 12:18:58 Jérôme Pouiller wrote: > On Wednesday 12 January 2022 11:58:59 CET Pali Rohár wrote: > > On Tuesday 11 January 2022 18:14:08 Jerome Pouiller wrote: > > > +static const struct sdio_device_id wfx_sdio_ids[] = { > > > + { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS,

Re: [PATCH v9 08/24] wfx: add bus_sdio.c

On Wednesday 12 January 2022 11:58:59 CET Pali Rohár wrote: > On Tuesday 11 January 2022 18:14:08 Jerome Pouiller wrote: > > +static const struct sdio_device_id wfx_sdio_ids[] = { > > + { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF200) }, > > + { }, > > +}; > > Hello! Is

Re: [PATCH v9 01/24] mmc: sdio: add SDIO IDs for Silabs WF200 chip

necessary for the Silabs WF200, we rely on the > DT rather than on the SDIO VID/PID. > > Signed-off-by: Jérôme Pouiller I guess the series is getting close to getting queued up? As an option to make sure $subject patch doesn't cause a problem for that, I can queue it up and send it fo

Re: [PATCH v9 08/24] wfx: add bus_sdio.c

On Tuesday 11 January 2022 18:14:08 Jerome Pouiller wrote: > +static const struct sdio_device_id wfx_sdio_ids[] = { > + { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF200) }, > + { }, > +}; Hello! Is this table still required? > +MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids); > +

Re: [PATCH v9 08/24] wfx: add bus_sdio.c

[...] > +static const struct of_device_id wfx_sdio_of_match[] = { > + { .compatible = "silabs,wf200",.data = _wf200 }, > + { .compatible = "silabs,brd4001a", .data = _brd4001a }, > + { .compatible = "silabs,brd8022a", .data = _brd8022a }, > + { .compatible =

Re: [PATCH v9 02/24] dt-bindings: introduce silabs,wfx.yaml

On Tuesday 11 January 2022 23:19:56 CET Rob Herring wrote: > On Tue, Jan 11, 2022 at 06:14:02PM +0100, Jerome Pouiller wrote: > > From: Jérôme Pouiller > > > > Prepare the inclusion of the wfx driver in the kernel. > > > > Signed-off-by: Jérôme Pouiller > > --- > >

Re: [PATCH v9 23/24] wfx: remove from the staging area

On Wednesday 12 January 2022 08:49:54 CET Kalle Valo wrote: > Jerome Pouiller writes: > > > From: Jérôme Pouiller > > > > Signed-off-by: Jérôme Pouiller > > --- > > .../bindings/net/wireless/silabs,wfx.yaml | 125 --- > > drivers/staging/wfx/Kconfig | 8 - > >

Re: [PATCH v9 23/24] wfx: remove from the staging area

Jerome Pouiller writes: > From: Jérôme Pouiller > > Signed-off-by: Jérôme Pouiller > --- > .../bindings/net/wireless/silabs,wfx.yaml | 125 --- > drivers/staging/wfx/Kconfig | 8 - > drivers/staging/wfx/Makefile | 25 - > drivers/staging/wfx/bh.c

Re: [PATCH v9 02/24] dt-bindings: introduce silabs,wfx.yaml

On Tue, Jan 11, 2022 at 06:14:02PM +0100, Jerome Pouiller wrote: > From: Jérôme Pouiller > > Prepare the inclusion of the wfx driver in the kernel. > > Signed-off-by: Jérôme Pouiller > --- > .../bindings/net/wireless/silabs,wfx.yaml | 138 ++ > 1 file changed, 138

Re: [PATCH v9 02/24] dt-bindings: introduce silabs,wfx.yaml

changed, 138 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings

[PATCH v9 24/24] wfx: get out from the staging area

From: Jérôme Pouiller The wfx driver is now mature enough to leave the staging area. Signed-off-by: Jérôme Pouiller --- MAINTAINERS | 3 ++- drivers/net/wireless/Kconfig | 1 + drivers/net/wireless/Makefile| 1 + drivers/net/wireless/silabs/Kconfig

[PATCH v9 22/24] wfx: add traces.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/traces.h | 496 +++ 1 file changed, 496 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/traces.h diff --git a/drivers/net/wireless/silabs/wfx/traces.h

[PATCH v9 21/24] wfx: add debug.c/debug.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/debug.c | 331 drivers/net/wireless/silabs/wfx/debug.h | 19 ++ 2 files changed, 350 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/debug.c create mode 100644

[PATCH v9 20/24] wfx: add scan.c/scan.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/scan.c | 144 + drivers/net/wireless/silabs/wfx/scan.h | 22 2 files changed, 166 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/scan.c create mode 100644

[PATCH v9 19/24] wfx: add sta.c/sta.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/sta.c | 798 ++ drivers/net/wireless/silabs/wfx/sta.h | 67 +++ 2 files changed, 865 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/sta.c create mode 100644

[PATCH v9 18/24] wfx: add data_tx.c/data_tx.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/data_tx.c | 572 ++ drivers/net/wireless/silabs/wfx/data_tx.h | 66 +++ 2 files changed, 638 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/data_tx.c create mode

[PATCH v9 17/24] wfx: add queue.c/queue.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/queue.c | 298 drivers/net/wireless/silabs/wfx/queue.h | 44 2 files changed, 342 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/queue.c create mode

[PATCH v9 16/24] wfx: add data_rx.c/data_rx.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/data_rx.c | 92 +++ drivers/net/wireless/silabs/wfx/data_rx.h | 17 + 2 files changed, 109 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/data_rx.c create mode

[PATCH v9 15/24] wfx: add hif_rx.c/hif_rx.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/hif_rx.c | 392 +++ drivers/net/wireless/silabs/wfx/hif_rx.h | 17 + 2 files changed, 409 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/hif_rx.c create mode 100644

[PATCH v9 14/24] wfx: add key.c/key.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/key.c | 227 ++ drivers/net/wireless/silabs/wfx/key.h | 19 +++ 2 files changed, 246 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/key.c create mode 100644

[PATCH v9 13/24] wfx: add hif_tx*.c/hif_tx*.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/hif_tx.c | 492 +++ drivers/net/wireless/silabs/wfx/hif_tx.h | 61 +++ drivers/net/wireless/silabs/wfx/hif_tx_mib.c | 308 drivers/net/wireless/silabs/wfx/hif_tx_mib.h

[PATCH v9 12/24] wfx: add hif_api_*.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/hif_api_cmd.h | 554 ++ .../net/wireless/silabs/wfx/hif_api_general.h | 252 drivers/net/wireless/silabs/wfx/hif_api_mib.h | 346 +++ 3 files changed, 1152 insertions(+)

[PATCH v9 11/24] wfx: add bh.c/bh.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/bh.c | 323 +++ drivers/net/wireless/silabs/wfx/bh.h | 34 +++ 2 files changed, 357 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/bh.c create mode 100644

[PATCH v9 10/24] wfx: add fwio.c/fwio.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/fwio.c | 390 + drivers/net/wireless/silabs/wfx/fwio.h | 15 + 2 files changed, 405 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/fwio.c create mode 100644

[PATCH v9 09/24] wfx: add hwio.c/hwio.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/hwio.c | 335 + drivers/net/wireless/silabs/wfx/hwio.h | 78 ++ 2 files changed, 413 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/hwio.c create mode

[PATCH v9 08/24] wfx: add bus_sdio.c

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/bus_sdio.c | 283 + 1 file changed, 283 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/bus_sdio.c diff --git a/drivers/net/wireless/silabs/wfx/bus_sdio.c

[PATCH v9 07/24] wfx: add bus_spi.c

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/bus_spi.c | 297 ++ 1 file changed, 297 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/bus_spi.c diff --git a/drivers/net/wireless/silabs/wfx/bus_spi.c

[PATCH v9 06/24] wfx: add bus.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/bus.h | 36 +++ 1 file changed, 36 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/bus.h diff --git a/drivers/net/wireless/silabs/wfx/bus.h

[PATCH v9 05/24] wfx: add main.c/main.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/main.c | 485 + drivers/net/wireless/silabs/wfx/main.h | 42 +++ 2 files changed, 527 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/main.c create mode 100644

[PATCH v9 04/24] wfx: add wfx.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/wfx.h | 166 ++ 1 file changed, 166 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/wfx.h diff --git a/drivers/net/wireless/silabs/wfx/wfx.h

[PATCH v9 03/24] wfx: add Makefile/Kconfig

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/Kconfig | 13 drivers/net/wireless/silabs/wfx/Makefile | 26 2 files changed, 39 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/Kconfig create

[PATCH v9 02/24] dt-bindings: introduce silabs,wfx.yaml

From: Jérôme Pouiller Prepare the inclusion of the wfx driver in the kernel. Signed-off-by: Jérôme Pouiller --- .../bindings/net/wireless/silabs,wfx.yaml | 138 ++ 1 file changed, 138 insertions(+) create mode 100644

[PATCH v9 00/24] wfx: get out from the staging area

as soon as Kalle will have validated the new format. [1]: https://lore.kernel.org/linux-firmware/2833354.gXvVfaC4I7@pc-42/ As requested by Kalle[2], I send one file per patch. At the end, all the patches (or at least the patches 3 to 24) will be squashed (therefore, I didn't bother to write real

[PATCH v9 01/24] mmc: sdio: add SDIO IDs for Silabs WF200 chip

From: Jérôme Pouiller Note that the values used by Silabs are uncommon. A driver cannot fully rely on the SDIO PnP. It should also check if the device is declared in the DT. So, to apply the quirks necessary for the Silabs WF200, we rely on the DT rather than on the SDIO VID/PID.

[PATCH v3 1/1] drm/bridge: anx7625: send DPCD command to downstream

Send DPCD command to downstream before anx7625 power down, let downstream monitor enter into standby mode. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 42 +++ 1 file changed, 35 insertions(+), 7 deletions(-) diff --git

[PATCH v2 1/1] drm/bridge: anx7625: send DPCD command to downstream

Send DPCD command to downstream before anx7625 power down, let downstream monitor enter into standby mode. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 40 --- 1 file changed, 35 insertions(+), 5 deletions(-) diff --git

Re: [PATCH] staging: rtl8188eu: replace camelcase field CustomerID

On Mon, Jan 03, 2022 at 12:11:32PM +0100, Alberto Merciai wrote: > Replace camelcase field CustomerID to customer_id, compliant > with linux kernel coding style. Apologize, don't consider it, wrong branch was used. Regards, Alberto Merciai ___ devel

[PATCH] staging: rtl8188eu: replace camelcase field CustomerID

Replace camelcase field CustomerID to customer_id, compliant with linux kernel coding style. Signed-off-by: Alberto Merciai --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2 +- drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +- drivers/staging/rtl8188eu/include/rtl8188e_hal.h | 2

Re: [PATCH] Staging: rtl871: rtl871x_mlme: fixed coding style issues

EID_HT_CAPABILITY, >sizeof(struct ieee80211_ht_cap), >(unsigned char *)_capie, pout_len); > phtpriv->ht_option = 1; > @@ -1699,13 +1672,13 @@ static void update_ht_cap(struct _adapter *padapter, > u8 *pie,

[PATCH] Staging: rtl871: rtl871x_mlme: fixed coding style issues

Fixed multiple line dereferences Signed-off-by: Agam Kohli --- drivers/staging/rtl8712/rtl871x_mlme.c | 125 ++--- 1 file changed, 49 insertions(+), 76 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c index

Re: [PATCH] binder: fix async_free_space accounting for empty parcels

On Mon, Dec 20, 2021 at 11:01:50AM -0800, Todd Kjos wrote: > In 4.13, commit 74310e06be4d ("android: binder: Move buffer out of area > shared with user space") > fixed a kernel structure visibility issue. As part of that patch, > sizeof(void *) was used as the buffer

Re: [PATCH] binder: fix async_free_space accounting for empty parcels

On Mon, Dec 20, 2021 at 11:06:09AM -0800, Todd Kjos wrote: > On Mon, Dec 20, 2021 at 11:02 AM Todd Kjos wrote: > > > > In 4.13, commit 74310e06be4d ("android: binder: Move buffer out of area > > shared with user space") > > fixed a kernel structure vi

[PATCH 4.9 01/62] staging: ion: Prevent incorrect reference counting behavour

From: Lee Jones Supply additional checks in order to prevent unexpected results. Fixes: b892bf75b2034 ("ion: Switch ion to use dma-buf") Suggested-by: Dan Carpenter Signed-off-by: Lee Jones Signed-off-by: Greg Kroah-Hartman --- drivers/staging/android/ion/ion.c |6 ++ 1 file

[PATCH 4.4 01/52] staging: ion: Prevent incorrect reference counting behavour

From: Lee Jones Supply additional checks in order to prevent unexpected results. Fixes: b892bf75b2034 ("ion: Switch ion to use dma-buf") Suggested-by: Dan Carpenter Signed-off-by: Lee Jones Signed-off-by: Greg Kroah-Hartman --- drivers/staging/android/ion/ion.c |6 ++ 1 file

Re: [PATCH v2 3/4] binder: read pre-translated fds from sender buffer

On Tue, Nov 30, 2021 at 10:51:51AM -0800, Todd Kjos wrote: > This patch is to prepare for an up coming patch where we read > pre-translated fds from the sender buffer and translate them before > copying them to the target. It does not change run time. > > The patch adds two

Re: [PATCH v2 1/4] binder: fix handling of error during copy

On Tue, Nov 30, 2021 at 10:51:49AM -0800, Todd Kjos wrote: > If a memory copy function fails to copy the whole buffer, > a positive integar with the remaining bytes is returned. > In binder_translate_fd_array() this can result in an fd being > skipped due to the failed copy, but the loop continues

Re: [PATCH v2 2/4] binder: avoid potential data leakage when copying txn

On Tue, Nov 30, 2021 at 10:51:50AM -0800, Todd Kjos wrote: > Transactions are copied from the sender to the target > first and objects like BINDER_TYPE_PTR and BINDER_TYPE_FDA > are then fixed up. This means there is a short period where > the sender's version of these objects are visible to the >

Re: [PATCH v2 0/4] binder: Prevent untranslated sender data from being copied to target

On Tue, Nov 30, 2021 at 10:51:48AM -0800, Todd Kjos wrote: > v2: > - add "binder: fix handling of error during copy" to fix > bug noticed by Dan Carpenter > - address Dan Carpenter's comments Thanks! regards, dan carpenter ___ devel mailing list

Re: [PATCH v9 02/13] dt-bindings: media: nxp, imx8mq-vpu: Update the bindings for G2 support

Le 29/11/2021 à 21:13, Adam Ford a écrit : On Wed, Apr 7, 2021 at 2:37 AM Benjamin Gaignard wrote: Introducing the G2 hevc video decoder requires modifications of the bindings to allow one node per VPU. VPUs share one hardware control block which is provided as a phandle on a syscon. Each

Re: [PATCH v9 02/13] dt-bindings: media: nxp, imx8mq-vpu: Update the bindings for G2 support

On Wed, Apr 7, 2021 at 2:37 AM Benjamin Gaignard wrote: > > Introducing the G2 hevc video decoder requires modifications of the bindings > to allow > one node per VPU. > > VPUs share one hardware control block which is provided as a phandle on > a syscon. > Each node has now one reg and one

Patch "staging: ion: Prevent incorrect reference counting behavour" has been added to the 4.9-stable tree

This is a note to let you know that I've just added the patch titled staging: ion: Prevent incorrect reference counting behavour to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch

Re: [PATCH v3 1/1] staging: ion: Prevent incorrect reference counting behavour

On Fri, Nov 26, 2021 at 10:33:35AM +, Lee Jones wrote: > Supply additional checks in order to prevent unexpected results. > > Fixes: b892bf75b2034 ("ion: Switch ion to use dma-buf") > Suggested-by: Dan Carpenter > Signed-off-by: Lee Jones > --- > Destined for v4.4.y and v4.9.y > >

Patch "staging: ion: Prevent incorrect reference counting behavour" has been added to the 4.4-stable tree

This is a note to let you know that I've just added the patch titled staging: ion: Prevent incorrect reference counting behavour to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch

Re: [PATCH v3 1/1] staging: ion: Prevent incorrect reference counting behavour

On Fri, Nov 26, 2021 at 10:33:35AM +, Lee Jones wrote: > Supply additional checks in order to prevent unexpected results. > > Fixes: b892bf75b2034 ("ion: Switch ion to use dma-buf") > Suggested-by: Dan Carpenter > Signed-off-by: Lee Jones > --- > Destined for v4.4.y and v4.9.y Thanks!

[PATCH v3 1/1] staging: ion: Prevent incorrect reference counting behavour

Supply additional checks in order to prevent unexpected results. Fixes: b892bf75b2034 ("ion: Switch ion to use dma-buf") Suggested-by: Dan Carpenter Signed-off-by: Lee Jones --- Destined for v4.4.y and v4.9.y drivers/staging/android/ion/ion.c | 6 ++ 1 file changed, 6 insertions(+) diff

Re: [PATCH 1/1] staging: ion: Prevent incorrect reference counting behavour

+ if (handle->kmap_cnt == INT_MAX) > > > + return ERR_PTR(-EOVERFLOW); > > > handle->kmap_cnt++; > > > return buffer->vaddr; > > > } > > > > Which is all well and good until somebody changes

Re: [PATCH 1/1] staging: ion: Prevent incorrect reference counting behavour

On Fri, Nov 26, 2021 at 08:56:27AM +, Lee Jones wrote: > On Fri, 26 Nov 2021, Dan Carpenter wrote: > > > On Thu, Nov 25, 2021 at 06:18:22PM +0300, Dan Carpenter wrote: > > > I had thought that ->kmap_cnt was a regular int and not an unsigned > > > int, but I would have to pull a stable tree

Re: [PATCH 1/1] staging: ion: Prevent incorrect reference counting behavour

On Fri, Nov 26, 2021 at 08:56:27AM +, Lee Jones wrote: > On Fri, 26 Nov 2021, Dan Carpenter wrote: > > > On Thu, Nov 25, 2021 at 06:18:22PM +0300, Dan Carpenter wrote: > > > I had thought that ->kmap_cnt was a regular int and not an unsigned > > > int, but I would have to pull a stable tree

Re: [PATCH 1/1] staging: ion: Prevent incorrect reference counting behavour

On Fri, 26 Nov 2021, Dan Carpenter wrote: > On Thu, Nov 25, 2021 at 06:18:22PM +0300, Dan Carpenter wrote: > > I had thought that ->kmap_cnt was a regular int and not an unsigned > > int, but I would have to pull a stable tree to see where I misread the > > code. > > I was looking at (struct

Re: [PATCH 1/1] staging: ion: Prevent incorrect reference counting behavour

On Thu, Nov 25, 2021 at 06:18:22PM +0300, Dan Carpenter wrote: > I had thought that ->kmap_cnt was a regular int and not an unsigned > int, but I would have to pull a stable tree to see where I misread the > code. I was looking at (struct ion_buffer)->kmap_cnt but this is (struct

Re: [PATCH 1/1] staging: ion: Prevent incorrect reference counting behavour

all. It's a double increment on the > > > success path and it leave handle->kmap_cnt overflowed on failure path. > > > > I read the helper to take copies of the original variables. > > > > #define __unsigned_add_overflow(a, b, d) ({ \ > > typeof(a) __

Re: [PATCH 1/1] staging: ion: Prevent incorrect reference counting behavour

\ > typeof(b) __b = (b);\ > typeof(d) __d = (d);\ > (void) (&__a == &__b); \ > (void) (&__a == __d); \ > *__d = __a + __b; \ ^^

Re: [PATCH 1/1] staging: ion: Prevent incorrect reference counting behavour

b);\ > typeof(d) __d = (d);\ > (void) (&__a == &__b); \ > (void) (&__a == __d); \ > *__d = __a + __b; \ > *__d < __a;

Re: [PATCH 1/1] staging: ion: Prevent incorrect reference counting behavour

\ typeof(b) __b = (b);\ typeof(d) __d = (d);\ (void) (&__a == &__b); \ (void) (&__a == __d); \ *__d = __a + __b; \ *__d < __a;

Re: [PATCH 1/1] staging: ion: Prevent incorrect reference counting behavour

On Thu, Nov 25, 2021 at 02:20:04PM +, Lee Jones wrote: > Supply additional checks in order to prevent unexpected results. > > Fixes: b892bf75b2034 ("ion: Switch ion to use dma-buf") > Signed-off-by: Lee Jones > --- > Should be back-ported from v4.9 and earlier. > >

[PATCH 1/1] staging: ion: Prevent incorrect reference counting behavour

Supply additional checks in order to prevent unexpected results. Fixes: b892bf75b2034 ("ion: Switch ion to use dma-buf") Signed-off-by: Lee Jones --- Should be back-ported from v4.9 and earlier. drivers/staging/android/ion/ion.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [PATCH 1/1] staging: ion: Prevent incorrect reference counting behavour

t; > > > > > > Looks like they're not widely used. > > > > > > > > I'll try them out and see how they go. > > > > > > > > > > + return ERR_PTR(-EOVERFLOW); > > > > > > + > > > > &g

Re: [PATCH 1/1] staging: ion: Prevent incorrect reference counting behavour

return ERR_PTR(-EOVERFLOW); > > > > > + > > > > > handle->kmap_cnt++; > > > > > return buffer->vaddr; > > > > > } > > > > > > > > What stable kernel branch(e

Re: [PATCH 1/1] staging: ion: Prevent incorrect reference counting behavour

l try them out and see how they go. > > > > > > + return ERR_PTR(-EOVERFLOW); > > > > + > > > > handle->kmap_cnt++; > > > > return buffer->vaddr; > > > > } > > &g

<    1   2   3   4   5   6   7   8   9   10   >