Re: [PATCH] comedi: Humusoft MF634 and MF624 DAQ cards driver

2014-01-10 Thread Ian Abbott
On 2014-01-09 22:46, Rostislav Lisovy wrote: This patch adds Comedi driver for Humusoft MF634 (PCIe) and MF624 (PCI) data acquisition cards. The legacy card Humusoft MF614 is not supported. More info about the cards may be found at http://humusoft.cz/produkty/datacq/ The driver was tested with

Re: [PATCH] comedi: Humusoft MF634 and MF624 DAQ cards driver

2014-01-09 Thread Rostislav Lisovy
On Wed, 2014-01-08 at 10:47 +0300, Dan Carpenter wrote: On Tue, Jan 07, 2014 at 11:24:57PM +0100, Rostislav Lisovy wrote: This patch adds Comedi driver for Humusoft MF634 (PCIe) and MF624 (PCI) data acquisition cards. The legacy card Humusoft MF614 is not supported. More info about the

Re: [PATCH] comedi: Humusoft MF634 and MF624 DAQ cards driver

2014-01-08 Thread Rostislav Lisovy
Hello Dan; On Wed, 2014-01-08 at 10:47 +0300, Dan Carpenter wrote: On Tue, Jan 07, 2014 at 11:24:57PM +0100, Rostislav Lisovy wrote: This patch adds Comedi driver for Humusoft MF634 (PCIe) and MF624 (PCI) data acquisition cards. The legacy card Humusoft MF614 is not supported. More info

Re: [PATCH] comedi: Humusoft MF634 and MF624 DAQ cards driver

2014-01-07 Thread Dan Carpenter
On Tue, Jan 07, 2014 at 11:24:57PM +0100, Rostislav Lisovy wrote: This patch adds Comedi driver for Humusoft MF634 (PCIe) and MF624 (PCI) data acquisition cards. The legacy card Humusoft MF614 is not supported. More info about the cards may be found at http://humusoft.cz/produkty/datacq/ The

RE: [PATCH] comedi: Humusoft MF634 and MF624 DAQ cards driver

2014-01-02 Thread Hartley Sweeten
On Monday, December 30, 2013 6:37 PM, Rostislav Lisovy wrote: create mode 100644 drivers/staging/comedi/drivers/mf6x4.c Hello Rostislav, As pointed out by Dan Carpenter, you need to add a change log and Signed-off-by lines to this patch. Overall this looks pretty good. Comments below. diff

Re: [PATCH] comedi: Humusoft MF634 and MF624 DAQ cards driver

2013-12-30 Thread Dan Carpenter
These days comedi drivers are looking really nice. :) You will need to resend because it's missing a change log and a Signed-off-by line. Wait for Ian or Hartley to comment before resending. I had a few minor style nits mentioned inline below. Run the patch through `scripts/checkpatch.pl