Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-06-09 Thread Lars-Peter Clausen
On 06/09/2014 01:18 AM, Ben Dooks wrote: On Fri, May 30, 2014 at 08:16:59PM +0200, Lars-Peter Clausen wrote: On 05/30/2014 07:33 PM, David Daney wrote: On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote: On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe berthe...@gmail.com wrote: ---

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-06-09 Thread Andrzej Hajda
On 06/09/2014 01:29 PM, Lars-Peter Clausen wrote: On 06/09/2014 01:18 AM, Ben Dooks wrote: On Fri, May 30, 2014 at 08:16:59PM +0200, Lars-Peter Clausen wrote: On 05/30/2014 07:33 PM, David Daney wrote: On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote: On Fri, May 30, 2014 at 1:30 PM,

RE: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-06-09 Thread David Laight
From: Of Andrzej Hajda ... You can't error out on module unload, although that's not really relevant here. gpiochip_remove() is typically called when the device that registered the GPIO chip is unbound. And despite some remove() callbacks having a return type of int you can not abort the

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-06-08 Thread Ben Dooks
On Fri, May 30, 2014 at 08:16:59PM +0200, Lars-Peter Clausen wrote: On 05/30/2014 07:33 PM, David Daney wrote: On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote: On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe berthe...@gmail.com wrote: --- a/drivers/gpio/gpiolib.c +++

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-05-31 Thread Lars-Peter Clausen
On 05/31/2014 01:29 AM, Greg KH wrote: On Fri, May 30, 2014 at 08:16:59PM +0200, Lars-Peter Clausen wrote: On 05/30/2014 07:33 PM, David Daney wrote: On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote: On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe berthe...@gmail.com wrote: ---

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-05-31 Thread Dan Carpenter
On Sat, May 31, 2014 at 09:35:39AM +0200, Lars-Peter Clausen wrote: On 05/31/2014 01:29 AM, Greg KH wrote: On Fri, May 30, 2014 at 08:16:59PM +0200, Lars-Peter Clausen wrote: On 05/30/2014 07:33 PM, David Daney wrote: On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote: On Fri, May 30, 2014 at

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-05-30 Thread David Daney
On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote: On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe berthe...@gmail.com wrote: --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1263,10 +1263,9 @@ static void gpiochip_irqchip_remove(struct gpio_chip *gpiochip); * * A gpio_chip

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-05-30 Thread Lars-Peter Clausen
On 05/30/2014 07:33 PM, David Daney wrote: On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote: On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe berthe...@gmail.com wrote: --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1263,10 +1263,9 @@ static void gpiochip_irqchip_remove(struct

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-05-30 Thread Greg KH
On Fri, May 30, 2014 at 08:16:59PM +0200, Lars-Peter Clausen wrote: On 05/30/2014 07:33 PM, David Daney wrote: On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote: On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe berthe...@gmail.com wrote: --- a/drivers/gpio/gpiolib.c +++