Re: [PATCH] staging: lustre: lustre: Off by two in lmv_fid2path()

2017-08-18 Thread Dilger, Andreas
> On Aug 17, 2017, at 09:47, Greg Kroah-Hartman > wrote: > > On Mon, Aug 14, 2017 at 04:01:17PM +0100, James Simmons wrote: >> >>> We want to concatonate join string one, a '/' character, string two and >>> then a NUL terminator. The destination buffer holds

Re: [PATCH] staging: lustre: lustre: Off by two in lmv_fid2path()

2017-08-17 Thread Greg Kroah-Hartman
On Mon, Aug 14, 2017 at 04:01:17PM +0100, James Simmons wrote: > > > We want to concatonate join string one, a '/' character, string two and > > then a NUL terminator. The destination buffer holds ori_gf->gf_pathlen > > characters. The strlen() function returns the number of characters not > >

Re: [PATCH] staging: lustre: lustre: Off by two in lmv_fid2path()

2017-08-14 Thread James Simmons
> We want to concatonate join string one, a '/' character, string two and > then a NUL terminator. The destination buffer holds ori_gf->gf_pathlen > characters. The strlen() function returns the number of characters not > counting the NUL terminator. So we should be adding two extra spaces, >