Re: [PATCH] staging: pi433: Cleanup codestyle, indent statements after case labels

2018-01-09 Thread Dan Carpenter
On Tue, Jan 09, 2018 at 09:04:50PM +0100, Valentin Vidic wrote: > On Sun, Dec 24, 2017 at 02:42:57PM +0100, Marcus Wolf wrote: > > > int rf69_set_dagc(struct spi_device *spi, enum dagc dagc) > > > { > > > switch (dagc) { > > > - case normalMode: return rf69_write_reg(spi, > >

Re: [PATCH] staging: pi433: Cleanup codestyle, indent statements after case labels

2018-01-09 Thread Marcus Wolf
Am 09.01.2018 um 21:04 schrieb Valentin Vidic: > On Sun, Dec 24, 2017 at 02:42:57PM +0100, Marcus Wolf wrote: >>> int rf69_set_dagc(struct spi_device *spi, enum dagc dagc) >>> { >>> switch (dagc) { >>> - case normalMode: return rf69_write_reg(spi, >>> REG_TESTDAGC,

Re: [PATCH] staging: pi433: Cleanup codestyle, indent statements after case labels

2018-01-09 Thread Valentin Vidic
On Sun, Dec 24, 2017 at 02:42:57PM +0100, Marcus Wolf wrote: > > int rf69_set_dagc(struct spi_device *spi, enum dagc dagc) > > { > > switch (dagc) { > > - case normalMode: return rf69_write_reg(spi, > > REG_TESTDAGC, DAGC_NORMAL); > > - case improve:

Re: [PATCH] staging: pi433: Cleanup codestyle, indent statements after case labels

2018-01-08 Thread Greg KH
On Sun, Dec 24, 2017 at 04:38:02AM +0100, Michael Panzlaff wrote: > This patch changes the indentation of the statements after case labels. > The linux coding guidelines do not explicitly mentiond this but pretty > much all existing code doesn't put any statements into the same line of > their

Re: [PATCH] staging: pi433: Cleanup codestyle, indent statements after case labels

2018-01-08 Thread Greg KH
On Sun, Dec 24, 2017 at 04:38:02AM +0100, Michael Panzlaff wrote: > To be applied on: > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > Branch: > staging-next That's not needed to be in the changelog text. I'll hand-edit it for now, but please don't include it in future

Re: [PATCH] staging: pi433: Cleanup codestyle, indent statements after case labels

2017-12-24 Thread Marcus Wolf
Am 24.12.2017 um 04:38 schrieb Michael Panzlaff: > To be applied on: > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > Branch: > staging-next > > This patch changes the indentation of the statements after case labels. > The linux coding guidelines do not explicitly mentiond