Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-18 Thread Samuel Thibault
Justin Skists, le lun. 18 juin 2018 09:55:32 +0100, a ecrit: > When I was going through the driver code, to become familiar with it, there > were a few places that I thought needed a closer look. Yes, cleanup work is probably needed in various places. Samuel

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-18 Thread Justin Skists
> On 18 June 2018 at 09:46 Samuel Thibault wrote: > > > Justin Skists, le lun. 18 juin 2018 09:41:44 +0100, a ecrit: > > > On 18 June 2018 at 06:34 Gregory Nowak wrote: > > > With /sys/accessibility/speakup/synth set to bns, I am getting output > > > alternately from the bns and from soft.

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-18 Thread Samuel Thibault
Justin Skists, le lun. 18 juin 2018 09:41:44 +0100, a ecrit: > > On 18 June 2018 at 06:34 Gregory Nowak wrote: > > With /sys/accessibility/speakup/synth set to bns, I am getting output > > alternately from the bns and from soft. It's as if speakup can't make > > up its mind which synthesizer is

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-18 Thread Justin Skists
> On 18 June 2018 at 06:34 Gregory Nowak wrote: > > > On Tue, Jun 12, 2018 at 08:31:06AM +0200, Samuel Thibault wrote: > > The load/unload is about the module itself, i.e. modprobe speakup_bns ; > > modprobe speakup_soft, switch between them, then rmmod speakup_bns ; > > speakup_soft or the

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-18 Thread Samuel Thibault
Thanks for the tests! Samuel ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-17 Thread Gregory Nowak
On Tue, Jun 12, 2018 at 08:31:06AM +0200, Samuel Thibault wrote: > The load/unload is about the module itself, i.e. modprobe speakup_bns ; > modprobe speakup_soft, switch between them, then rmmod speakup_bns ; > speakup_soft or the converse (to exercise both orders). # uname -a Linux p41box

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-12 Thread Samuel Thibault
Gregory Nowak, le lun. 11 juin 2018 16:51:22 -0700, a ecrit: > On Tue, Jun 12, 2018 at 12:57:03AM +0200, Samuel Thibault wrote: > > Anybody up for testing please? > > > > If people want to see speakup get mainlined instead of staging, please > > help. > > If I understand right, this patch

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-11 Thread John Covici
Maybe I can do it, I have a kernel with speakup, using 4.9.43. Will the patch fit there? On Mon, 11 Jun 2018 18:57:03 -0400, Samuel Thibault wrote: > > [1 ] > Hello, > > Samuel Thibault, le mer. 06 juin 2018 15:26:28 +0200, a ecrit: > > I'd also rather see it tested in the real wild before

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-11 Thread Gregory Nowak
On Tue, Jun 12, 2018 at 12:57:03AM +0200, Samuel Thibault wrote: > Anybody up for testing please? > > If people want to see speakup get mainlined instead of staging, please > help. If I understand right, this patch changes how synthesizers are loaded and unloaded through

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-11 Thread Samuel Thibault
Hello, Samuel Thibault, le mer. 06 juin 2018 15:26:28 +0200, a ecrit: > I'd also rather see it tested in the real wild before committing. Could > somebody on the speakup mailing list test the patch? (which I have > re-attached as a file for conveniency). Anybody up for testing please? If people

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-06 Thread Justin Skists
On Wed, Jun 06, 2018 at 03:26:28PM +0200, Samuel Thibault wrote: > Hello, > > Justin Skists, le lun. 04 juin 2018 10:52:12 +0100, a ecrit: > > The synths[] array is a collection of synths acting like a list. > > There is no need for synths to be an array, so refactor synths[] to use > > standard

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-06 Thread Samuel Thibault
Hello, Justin Skists, le lun. 04 juin 2018 10:52:12 +0100, a ecrit: > The synths[] array is a collection of synths acting like a list. > There is no need for synths to be an array, so refactor synths[] to use > standard kernel list_head API, instead, and modify the usages to suit. > As a

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-04 Thread Samuel Thibault
Hello, Justin Skists, le lun. 04 juin 2018 10:52:12 +0100, a ecrit: > The synths[] array is a collection of synths acting like a list. > There is no need for synths to be an array, so refactor synths[] to use > standard kernel list_head API, instead, and modify the usages to suit. > As a