Re: [PATCH v2 2/2] staging: erofs: fix i_blocks calculation

2019-05-28 Thread Chao Yu
On 2019/5/28 14:57, Dan Carpenter wrote: > On Tue, May 28, 2019 at 11:02:12AM +0800, Chao Yu wrote: >> On 2019/5/28 10:36, Gao Xiang wrote: >>> For compressed files, i_blocks should not be calculated >>> by using i_size. i_u.compressed_blocks is used instead. >>> >>> In addition, i_blocks was

Re: [PATCH v2 2/2] staging: erofs: fix i_blocks calculation

2019-05-28 Thread Gao Xiang
Hi Dan, On 2019/5/28 14:57, Dan Carpenter wrote: > On Tue, May 28, 2019 at 11:02:12AM +0800, Chao Yu wrote: >> On 2019/5/28 10:36, Gao Xiang wrote: >>> For compressed files, i_blocks should not be calculated >>> by using i_size. i_u.compressed_blocks is used instead. >>> >>> In addition, i_blocks

Re: [PATCH v2 2/2] staging: erofs: fix i_blocks calculation

2019-05-28 Thread Dan Carpenter
On Tue, May 28, 2019 at 11:02:12AM +0800, Chao Yu wrote: > On 2019/5/28 10:36, Gao Xiang wrote: > > For compressed files, i_blocks should not be calculated > > by using i_size. i_u.compressed_blocks is used instead. > > > > In addition, i_blocks was miscalculated for non-compressed > > files

Re: [PATCH v2 2/2] staging: erofs: fix i_blocks calculation

2019-05-27 Thread Gao Xiang
On 2019/5/28 11:02, Chao Yu wrote: > On 2019/5/28 10:36, Gao Xiang wrote: >> For compressed files, i_blocks should not be calculated >> by using i_size. i_u.compressed_blocks is used instead. >> >> In addition, i_blocks was miscalculated for non-compressed >> files previously, fix it as well.

Re: [PATCH v2 2/2] staging: erofs: fix i_blocks calculation

2019-05-27 Thread Chao Yu
On 2019/5/28 10:36, Gao Xiang wrote: > For compressed files, i_blocks should not be calculated > by using i_size. i_u.compressed_blocks is used instead. > > In addition, i_blocks was miscalculated for non-compressed > files previously, fix it as well. > > Signed-off-by: Gao Xiang > --- > change