Re: staging: Add rtl8723bs sdio wifi driver

2019-05-21 Thread Hans de Goede
Hi, On 5/21/19 3:49 PM, Colin Ian King wrote: Hi, static analysis with Coverity has detected an issues in the rtl8723bs wifi driver: File: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c in function rtw_dbg_port(): CID 18480: Operands don't affect result (CONSTANT_EXPRESSION_RESULT)

staging: Add rtl8723bs sdio wifi driver

2019-05-21 Thread Colin Ian King
Hi, static analysis with Coverity has detected an issues in the rtl8723bs wifi driver: File: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c in function rtw_dbg_port(): CID 18480: Operands don't affect result (CONSTANT_EXPRESSION_RESULT) dead_error_condition: The condition (extra_arg & 7U) > 7U

[bug report] staging: Add rtl8723bs sdio wifi driver

2018-01-31 Thread Dan Carpenter
Hello Hans de Goede, The patch 554c0a3abf21: "staging: Add rtl8723bs sdio wifi driver" from Mar 29, 2017, leads to the following static checker warning: drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c:1374 _PHY_PathADDAOn8723B() warn: both sides of ternary the same: