Re: [PATCH v1 1/9] staging: android: binder: Move some of the logic into subfunction

2013-12-05 Thread Dan Carpenter
On Wed, Dec 04, 2013 at 06:09:33PM +, Serban Constantinescu wrote: +static void bc_increfs_done(struct binder_proc *proc, + struct binder_thread *thread, uint32_t cmd, + void __user *node_ptr, void __user *cookie) +{ + struct binder_node *node; + + node =

Re: [PATCH v1 2/9] staging: android: binder: Add binder_copy_to_user()

2013-12-05 Thread Dan Carpenter
On Wed, Dec 04, 2013 at 06:09:34PM +, Serban Constantinescu wrote: This patch adds binder_copy_to_user() to be used for copying binder commands to user address space. This way we can abstract away the copy_to_user() calls and add separate handling for the compat layer. Signed-off-by:

Re: [PATCH v1 3/9] staging: android: binder: Add cmd == CMD_NAME handling

2013-12-05 Thread Dan Carpenter
On Wed, Dec 04, 2013 at 06:09:35PM +, Serban Constantinescu wrote: This patch modifies the functions that need to be passed the explicit command to use a boolean flag. This way we can reuse the code for 64bit compat commands. I don't understand this at all. cmd seems like it should be

Re: [PATCH v1 4/9] staging: android: binder: Add align_helper() macro

2013-12-05 Thread Dan Carpenter
On Wed, Dec 04, 2013 at 06:09:36PM +, Serban Constantinescu wrote: This patch adds align_helper() macro that will be used for enforcing the desired alignment on 64bit systems where the alignment will differ depending on the userspace used (32bit /64bit). This patch is a temporary patch

Re: [PATCH 34/39] vme: remove DEFINE_PCI_DEVICE_TABLE macro

2013-12-05 Thread ZHAO Gang
On Tue, Dec 3, 2013 at 7:29 AM, Jingoo Han jg1@samsung.com wrote: Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by: Jingoo Han jg1@samsung.com --- Greg, this patch should be reverted. It do the opposite things.

Re: [PATCH 28/39] staging: remove DEFINE_PCI_DEVICE_TABLE macro

2013-12-05 Thread ZHAO Gang
On Tue, Dec 3, 2013 at 7:26 AM, Jingoo Han jg1@samsung.com wrote: Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by: Jingoo Han jg1@samsung.com I think you misunderstood the checkpatch.pl warning, it tells you what to do, not what not to do.

Re: [PATCH 04/11] staging: et131x: drop packet when error occurs in et131x_tx

2013-12-05 Thread Mark Einon
On Wed, Dec 04, 2013 at 03:23:29PM -0800, Greg Kroah-Hartman wrote: On Wed, Dec 04, 2013 at 03:24:14PM +0800, ZHAO Gang wrote: As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY when tx failed. Really? That's ok to do? Seems like you are changing the logic of the

Re: [PATCH v1 1/9] staging: android: binder: Move some of the logic into subfunction

2013-12-05 Thread Greg KH
On Thu, Dec 05, 2013 at 11:18:22AM +0300, Dan Carpenter wrote: On Wed, Dec 04, 2013 at 06:09:33PM +, Serban Constantinescu wrote: +static void bc_increfs_done(struct binder_proc *proc, + struct binder_thread *thread, uint32_t cmd, + void __user *node_ptr, void __user

Re: [PATCH 34/39] vme: remove DEFINE_PCI_DEVICE_TABLE macro

2013-12-05 Thread Greg Kroah-Hartman
On Thu, Dec 05, 2013 at 05:14:37PM +0800, ZHAO Gang wrote: On Tue, Dec 3, 2013 at 7:29 AM, Jingoo Han jg1@samsung.com wrote: Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by: Jingoo Han jg1@samsung.com --- Greg, this patch should be

Re: [PATCH 28/39] staging: remove DEFINE_PCI_DEVICE_TABLE macro

2013-12-05 Thread Greg Kroah-Hartman
On Thu, Dec 05, 2013 at 05:06:33PM +0800, ZHAO Gang wrote: On Tue, Dec 3, 2013 at 7:26 AM, Jingoo Han jg1@samsung.com wrote: Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by: Jingoo Han jg1@samsung.com I think you misunderstood the

RE: [PATCH 00/51] staging: comedi: cleanup irq requests

2013-12-05 Thread Hartley Sweeten
On Wednesday, December 04, 2013 4:47 AM, Ian Abbott wrote: On 2013-12-03 19:07, H Hartley Sweeten wrote: The comedi subsystem only requires the drivers to support interrupts if one or more of the subdevices support async commands. Since this is optional: 1) don't fail the attach if the irq is

[PATCHv5][ 2/8] staging: imx-drm: Add RGB666 support for parallel display.

2013-12-05 Thread Denis Carikli
Cc: Rob Herring rob.herr...@calxeda.com Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Stephen Warren swar...@wwwdotorg.org Cc: Ian Campbell ijc+devicet...@hellion.org.uk Cc: devicet...@vger.kernel.org Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc:

[PATCHv5][ 3/8] staging: imx-drm: Correct BGR666 and the board's dts that use them.

2013-12-05 Thread Denis Carikli
Cc: Rob Herring rob.herr...@calxeda.com Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Stephen Warren swar...@wwwdotorg.org Cc: Ian Campbell ijc+devicet...@hellion.org.uk Cc: devicet...@vger.kernel.org Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc:

[PATCHv5][ 1/8] [media] v4l2: add new V4L2_PIX_FMT_RGB666 pixel format.

2013-12-05 Thread Denis Carikli
That new macro is needed by the imx_drm staging driver for supporting the QVGA display of the eukrea-cpuimx51 board. Cc: Rob Herring rob.herr...@calxeda.com Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Stephen Warren swar...@wwwdotorg.org Cc: Ian Campbell

[PATCHv5][ 4/8] staging: imx-drm: Use de-active and pixelclk-active display-timings.

2013-12-05 Thread Denis Carikli
If de-active and/or pixelclk-active properties were set in the display-timings DT node, they were not used. Instead the data-enable and the pixel data clock polarity were hardcoded. This change is needed for making the eukrea-cpuimx51 QVGA display work. Greg Kroah-Hartman

[PATCHv5][ 6/8] ARM: dts: mbimx51sd: Add display support.

2013-12-05 Thread Denis Carikli
The CMO-QVGA, DVI-SVGA and DVI-VGA are added. Cc: Shawn Guo shawn@linaro.org Cc: Sascha Hauer ker...@pengutronix.de Cc: linux-arm-ker...@lists.infradead.org Cc: Eric Bénard e...@eukrea.com Signed-off-by: Denis Carikli de...@eukrea.com --- ChangeLog v3-v5: - Updated to new GPIO defines. -

[PATCHv5][ 5/8] staging: imx-drm: parallel display: add regulator support.

2013-12-05 Thread Denis Carikli
Cc: Dan Carpenter dan.carpen...@oracle.com Cc: Rob Herring rob.herr...@calxeda.com Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Stephen Warren swar...@wwwdotorg.org Cc: Ian Campbell ijc+devicet...@hellion.org.uk Cc: devicet...@vger.kernel.org Cc: Greg Kroah-Hartman

[PATCHv5][ 8/8] ARM: imx_v6_v7_defconfig: Enable backlight gpio support.

2013-12-05 Thread Denis Carikli
The eukrea mbimxsd51 has a gpio backlight for its LCD display, so we turn that driver on. Cc: Sascha Hauer ker...@pengutronix.de Cc: linux-arm-ker...@lists.infradead.org Cc: Fabio Estevam fabio.este...@freescale.com Cc: Shawn Guo shawn@linaro.org Cc: Eric Bénard e...@eukrea.com

[PATCHv5][ 7/8] ARM: dts: mbimx51sd: Add CMO-QVGA backlight support.

2013-12-05 Thread Denis Carikli
Cc: Shawn Guo shawn@linaro.org Cc: Sascha Hauer ker...@pengutronix.de Cc: linux-arm-ker...@lists.infradead.org Cc: Eric Bénard e...@eukrea.com Signed-off-by: Denis Carikli de...@eukrea.com --- ChangeLog v3-v5: - Updated to the new GPIO defines. ChangeLog v2-v3: - Splitted out from the patch

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-05 Thread Serban Constantinescu
Hi all, Thanks for your feedback! Sadly enough, being in a different time-zone, is not useful. Sorry for the confusion related to why is this patch needed or not. I should highlight a bit more what is the patch enabling and what would be the different alternatives, at least from my

Re: [PATCH v1 1/9] staging: android: binder: Move some of the logic into subfunction

2013-12-05 Thread Serban Constantinescu
On 05/12/13 08:18, Dan Carpenter wrote: On Wed, Dec 04, 2013 at 06:09:33PM +, Serban Constantinescu wrote: +static void bc_increfs_done(struct binder_proc *proc, + struct binder_thread *thread, uint32_t cmd, + void __user *node_ptr, void __user *cookie) +{ +

Re: [PATCH v1 2/9] staging: android: binder: Add binder_copy_to_user()

2013-12-05 Thread Serban Constantinescu
On 04/12/13 23:17, Greg KH wrote: On Wed, Dec 04, 2013 at 06:09:34PM +, Serban Constantinescu wrote: This patch adds binder_copy_to_user() to be used for copying binder commands to user address space. This way we can abstract away the copy_to_user() calls and add separate handling for the

Re: [PATCH v1 3/9] staging: android: binder: Add cmd == CMD_NAME handling

2013-12-05 Thread Serban Constantinescu
On 05/12/13 08:40, Dan Carpenter wrote: On Wed, Dec 04, 2013 at 06:09:35PM +, Serban Constantinescu wrote: This patch modifies the functions that need to be passed the explicit command to use a boolean flag. This way we can reuse the code for 64bit compat commands. I don't understand

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-05 Thread Greg KH
On Thu, Dec 05, 2013 at 06:31:25PM +, Serban Constantinescu wrote: Hi all, Thanks for your feedback! Sadly enough, being in a different time-zone, is not useful. Sorry for the confusion related to why is this patch needed or not. I should highlight a bit more what is the patch

[PATCH v2 13/31] staging: comedi: amplc_pci230: tidy up irq request

2013-12-05 Thread H Hartley Sweeten
Clean up the irq request in the attach of this driver and remove the dev_{level} noise. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/amplc_pci230.c | 27

[PATCH v2 02/31] staging: comedi: me4000: use dev-read_subdev

2013-12-05 Thread H Hartley Sweeten
Use the dev-read_subdev that was setup in the device attach instead of accessing the dev-subdevices array directly. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 08/31] staging: comedi: adl_pci9111: fix incorrect irq passed to request_irq()

2013-12-05 Thread H Hartley Sweeten
The dev-irq passed to request_irq() will always be 0 when the auto_attach function is called. The pcidev-irq should be used instead to get the correct irq number. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman

[PATCH v2 01/31] staging: comedi: ni_at_2150: tidy up irq/dma request

2013-12-05 Thread H Hartley Sweeten
This driver needs both an irq and dma in order to support async commands. If the irq and dma are not available the driver will still function for single analog input reads. Tidy up the code that does the irq and dma requests so that the driver will still attach if they are not avaliable. The

[PATCH v2 22/31] staging: comedi: adl_pci9118: use dev-read_subdev

2013-12-05 Thread H Hartley Sweeten
Use the dev-read_subdev that was setup in the device attach instead of accessing the dev-subdevices array directly. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 24/31] staging: comedi: amplc_pci224: use dev-write_subdev

2013-12-05 Thread H Hartley Sweeten
Use the dev-write_subdev that was setup in the device attach instead of accessing the dev-subdevices array directly. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 25/31] staging: comedi: ni_65xx: use dev-read_subdev

2013-12-05 Thread H Hartley Sweeten
Use the dev-read_subdev that was setup in the device attach instead of accessing the dev-subdevices array directly. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 09/31] staging: comedi: adl_pci9111: the irq is only needed for async command support

2013-12-05 Thread H Hartley Sweeten
An irq is only needed for async command support, modify the attach of the subdevices so that the command support is only hooked up if the irq request was successful. Remove the then unnecessary sanity check in pci9111_ai_do_cmd(). Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc:

[PATCH v2 21/31] staging: comedi: hwrdv_apci3200: use dev-read_subdev

2013-12-05 Thread H Hartley Sweeten
Use the dev-read_subdev that was setup in the device attach instead of accessing the dev-subdevices array directly. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 26/31] staging: comedi: ni_atmio16d: use dev-read_subdev

2013-12-05 Thread H Hartley Sweeten
Use the dev-read_subdev that was setup in the device attach instead of accessing the dev-subdevices array directly. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 10/31] staging: comedi: dt2814: use dev-read_subdev

2013-12-05 Thread H Hartley Sweeten
Use the dev-read_subdev that was setup in the device attach instead of accessing the dev-subdevices array directly. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 07/31] staging: comedi: das16m1: remove unnecessary 'dev-irq' test

2013-12-05 Thread H Hartley Sweeten
This function can only be called if the irq was sucessfully requested. The dev-irq will always be valid. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/das16m1.c |

[PATCH v2 05/31] staging: comedi: das1800: tidy up irq request

2013-12-05 Thread H Hartley Sweeten
This driver only needs an irq in order to support async commands. If the irq is not available the driver will still function for single analog input reads. Tidy up the code that does the irq requests so that the driver will still attach if it is not avaliable. Remove the noise about the irq

[PATCH v2 18/31] staging: comedi: dt3000: use dev-read_subdev

2013-12-05 Thread H Hartley Sweeten
Use the dev-read_subdev that was setup in the device attach instead of accessing the dev-subdevices array directly. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 27/31] staging: comedi: rtd520: use dev-read_subdev

2013-12-05 Thread H Hartley Sweeten
Use the dev-read_subdev that was setup in the device attach instead of accessing the dev-subdevices array directly. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 12/31] staging: comedi: dt282x: use dev-write_subdev

2013-12-05 Thread H Hartley Sweeten
Use the dev-write_subdev that was setup in the device attach instead of accessing the dev-subdevices array directly. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 11/31] staging: comedi: dt282x: use dev-read_subdev

2013-12-05 Thread H Hartley Sweeten
Use the dev-read_subdev that was setup in the device attach instead of accessing the dev-subdevices array directly. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 19/31] staging: comedi: s626: use dev-read_subdev

2013-12-05 Thread H Hartley Sweeten
Use the dev-read_subdev that was setup in the device attach instead of accessing the dev-subdevices array directly. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

Re: [PATCHv5][ 3/8] staging: imx-drm: Correct BGR666 and the board's dts that use them.

2013-12-05 Thread Marek Vasut
On Thursday, December 05, 2013 at 07:28:07 PM, Denis Carikli wrote: [...] Can you please explain the correction here ? Why is it needed ? What was the problem ? Thanks! Best regards, Marek Vasut ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCHv5][ 4/8] staging: imx-drm: Use de-active and pixelclk-active display-timings.

2013-12-05 Thread Marek Vasut
On Thursday, December 05, 2013 at 07:28:08 PM, Denis Carikli wrote: If de-active and/or pixelclk-active properties were set in the display-timings DT node, they were not used. Instead the data-enable and the pixel data clock polarity were hardcoded. This change is needed for making the

Re: [PATCHv5][ 5/8] staging: imx-drm: parallel display: add regulator support.

2013-12-05 Thread Marek Vasut
On Thursday, December 05, 2013 at 07:28:09 PM, Denis Carikli wrote: Cc: Dan Carpenter dan.carpen...@oracle.com Cc: Rob Herring rob.herr...@calxeda.com Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Stephen Warren swar...@wwwdotorg.org Cc: Ian Campbell

Re: [PATCHv5][ 6/8] ARM: dts: mbimx51sd: Add display support.

2013-12-05 Thread Marek Vasut
On Thursday, December 05, 2013 at 07:28:10 PM, Denis Carikli wrote: The CMO-QVGA, DVI-SVGA and DVI-VGA are added. Cc: Shawn Guo shawn@linaro.org Cc: Sascha Hauer ker...@pengutronix.de Cc: linux-arm-ker...@lists.infradead.org Cc: Eric Bénard e...@eukrea.com Signed-off-by: Denis Carikli

[PATCH 2/7] staging: et131x: Remove unnecessary phydev checks

2013-12-05 Thread Mark Einon
Several checks for a valid adapter-phydev pointer are made where the pointer has already been checked previously in the code path. Remove these redundant checks. Signed-off-by: Mark Einon mark.ei...@gmail.com --- drivers/staging/et131x/et131x.c | 13 + 1 file changed, 5

[PATCH 1/7] staging: et131x: improve indenting in et131x_adjust_link()

2013-12-05 Thread Mark Einon
Negate some 'if' checks to return early, allowing a large block of code to be un-indented. Signed-off-by: Mark Einon mark.ei...@gmail.com --- drivers/staging/et131x/et131x.c | 160 --- 1 file changed, 81 insertions(+), 79 deletions(-) diff --git

[PATCH 6/7] staging: et131x: remove unhelpful comments

2013-12-05 Thread Mark Einon
Get rid of some of the more unhelpful comments. Signed-off-by: Mark Einon mark.ei...@gmail.com --- drivers/staging/et131x/et131x.c | 204 ++- 1 file changed, 28 insertions(+), 176 deletions(-) diff --git a/drivers/staging/et131x/et131x.c

[PATCH v2 06/31] staging: comedi: das1800: use dev-read_subdev

2013-12-05 Thread H Hartley Sweeten
Use the dev-read_subdev that was setup in the device attach instead of accessing the dev-subdevices array directly. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 31/31] staging: comedi: multiq3: pass subdevice to encoder_reset()

2013-12-05 Thread H Hartley Sweeten
Pass the subdevice pointer to encoder_reset() from the attach instead of accessing the dev-subdevices array directly to get the pointer. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 00/31] staging: comedi: cleanup irq requests

2013-12-05 Thread H Hartley Sweeten
The comedi subsystem only requires the drivers to support interrupts if one or more of the subdevices support async commands. Since this is optional: 1) don't fail the attach if the irq is not available 2) only hookup the async command support if the irq is available 3) remove any async command

[PATCH v2 29/31] staging: comedi: ni_pcidio: use dev-read_subdev

2013-12-05 Thread H Hartley Sweeten
Use the dev-read_subdev that was setup in the device attach instead of accessing the dev-subdevices array directly. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 03/31] staging: comedi: me4000: refactor request_irq() during attach

2013-12-05 Thread H Hartley Sweeten
Do the request_irq() before setting up the subdevices. This removes an indent level and makes the code a bit cleaner. Also, remove the dev_warn() noise about the irq. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman

[PATCH v2 14/31] staging: comedi: adl_pci9118: tidy up irq request

2013-12-05 Thread H Hartley Sweeten
Clean up the irq request in the attach of this driver and remove the dev_{level} noise. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/adl_pci9118.c | 43

[PATCH v2] staging: et131x: replace magic number bitmask with defined values

2013-12-05 Thread Mark Einon
Signed-off-by: Mark Einon mark.ei...@gmail.com --- I noticed the obvious typo just after sending. Now fixed. drivers/staging/et131x/et131x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index

Re: [PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c

2013-12-05 Thread Joe Perches
On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote: On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange wrote: Fixes warnings regarding redundant parantheses thrown by the checkpatch tool in bpctl_mod.c [] if (ret 0) return BP_NOT_CAP; if (ret == 0)

Re: [PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c

2013-12-05 Thread Dan Carpenter
On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote: On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote: On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange wrote: Fixes warnings regarding redundant parantheses thrown by the checkpatch tool in bpctl_mod.c [] if (ret

[PATCH 08/13] staging: comedi: pcmuio: add inline helpers to get the 'iobase', 'asic', and 'port'

2013-12-05 Thread H Hartley Sweeten
To reduce the potential for bugs, and better document the code, introduce some inline helper functions to consolidate the calculations needed to get the 'iobase' for a given asic and the 'asic' and 'port' associated with a given subdevice. Signed-off-by: H Hartley Sweeten

[PATCH 12/13] staging: comedi: pcmuio: tidy up pcmuio_attach()

2013-12-05 Thread H Hartley Sweeten
Clean up the local variables, 'sdev_no' and 'asic' are both used in simple for () loops. Use the local variable 'i' for both cases. The 'n_subdevs' variable is only used in one place, just remove it. For aesthetics, add some whitespace to the subdevice init and reorder it to follow the more

[PATCH 06/13] staging: comedi: pcmuio: fix pcmuio_dio_insn_bits()

2013-12-05 Thread H Hartley Sweeten
This dio subdevice (*insn_bits) function does not follow the norm for comedi drivers. It also _appears_ to return the incorrect state of the channels. Use the comedi_dio_update_state() helper to handle the boilerplate for updating the output channel state. Due to the hardware we then need to

[PATCH 05/13] staging: comedi: pcmuio: remove subdevice private data

2013-12-05 Thread H Hartley Sweeten
The subdevice private data is only needed for each 'asic' not for each subdevice. Since the 'asic' can be calculated easily from the subdevice we can merge the subdevice private data members directly into the private data. This removes the need to kcalloc/free the subdevice private data and saves

[PATCH 02/13] staging: comedi: pcmuio: spinlock protect pcmuio_{write, read}()

2013-12-05 Thread H Hartley Sweeten
Currently only the pcmuio_handle_asic_interrupt() function uses the spinlock in the private data to protect the read of the paged interrupt id registers. All accesses to the paged registers should be protected to ensure that the page is not changed until the access is complete. Move the

[PATCH 10/13] staging: comedi: pcmuio: fix types of some private data variables

2013-12-05 Thread H Hartley Sweeten
The 'enabled_mask' is a bit mask of the channels that are enabled for interrupt detection and should be an unsigned int. The 'stop_count' is a = 0 value that is set by the unsigned int cmd-stop_arg. Make it an unsigned int. The 'active' and 'continuous' members are flags. Make them unsigned int

[PATCH 00/13] staging: comedi: pcmuio: cleanup driver

2013-12-05 Thread H Hartley Sweeten
I orignally posted this series on 07/24/2013. At that time Ian Abbott had some comments on it. I finally got around to addressing them. This series cleans up the interrupt support and private data usage. It also does a bit of cleanup to clarify the driver. H Hartley Sweeten (13): staging:

[PATCH 13/13] staging: comedi: pcmuio: tidy up pcmuio_start_intr()

2013-12-05 Thread H Hartley Sweeten
Refactor this function a bit to remove the need for an extra indent level and cleanup some of the odd line breaks. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 03/13] staging: comedi: pcmuio: tidy up pcmuio_handle_asic_interrupt()

2013-12-05 Thread H Hartley Sweeten
Unfortunatly, since there could be two asics, we can't use dev-read_subdev to get the subdevice. But, the comedi_subdevice associated with the 'asic' can easily be calculated. This allows removing the for () loop that searched for the correct subdevice. Tidy up the function. ---

[PATCH 04/13] staging: comedi: pcmuio: remove 'asic' member from subdevice private data

2013-12-05 Thread H Hartley Sweeten
The 'asic' associated with a subdevice can be easily calculated. The functions that use this member in the subdevice private data can only be called by the subdevices that support interrupts. Just calculate the 'asic' when needed and remove the member variable and sanity checks. Signed-off-by: H

[PATCH 01/13] staging: comedi: pcmuio: fix interrupt requests

2013-12-05 Thread H Hartley Sweeten
Legacy (ISA) interrupts are not sharable so this driver should not be passing the IRQF_SHARED flag when requesting the interrupts. This driver supports two board types: PCM-UIO48 with one asic (one interrupt source) PCM-UIO96 with two asics (two interrupt sources) The PCM-UIO96 has a jumper

[PATCH 10/13] staging: comedi: pcmuio: fix types of some private data variables

2013-12-05 Thread H Hartley Sweeten
The 'enabled_mask' is a bit mask of the channels that are enabled for interrupt detection and should be an unsigned int. The 'stop_count' is a = 0 value that is set by the unsigned int cmd-stop_arg. Make it an unsigned int. The 'active' and 'continuous' members are flags. Make them unsigned int

[PATCH 09/13] staging: comedi: pcmuio: document the spinlock_t variables

2013-12-05 Thread H Hartley Sweeten
Add some comments about the two spinlock_t variables in the private data. Also, add come comments for the functions that do not need to lock/unlock the spinlock. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman

RE: [PATCH 10/13] staging: comedi: pcmuio: fix types of some private data variables

2013-12-05 Thread Hartley Sweeten
On Thursday, December 05, 2013 4:54 PM, H Hartley Sweeten wrote: Subject: [PATCH 10/13] staging: comedi: pcmuio: fix types of some private data variables Oops.. This one got posted twice. Sorry about that. Hartley ___ devel mailing list

Re: [PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c

2013-12-05 Thread Joe Perches
On Fri, 2013-12-06 at 02:21 +0300, Dan Carpenter wrote: On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote: On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote: On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange wrote: Fixes warnings regarding redundant parantheses thrown

Re: [PATCH 28/39] staging: remove DEFINE_PCI_DEVICE_TABLE macro

2013-12-05 Thread ZHAO Gang
On Thu, Dec 5, 2013 at 11:43 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Dec 05, 2013 at 05:06:33PM +0800, ZHAO Gang wrote: On Tue, Dec 3, 2013 at 7:26 AM, Jingoo Han jg1@samsung.com wrote: Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.

[PATCH 11/13] staging: comedi: pcmuio: remove unneeded include

2013-12-05 Thread H Hartley Sweeten
The linux/slab.h header is no longer needed by this driver. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcmuio.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH 07/13] staging: comedi: pcmuio: remove unnecessary mask of triggered channels

2013-12-05 Thread H Hartley Sweeten
The 'triggered' value is read directly from the three trigger id registers and does not have any extra data that needs masked off. Remove the 'mytrig' local variable and just use 'triggered' directly. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk

[PATCH -next] staging: slicoss: Remove last reference to compare_ether_addr

2013-12-05 Thread Joe Perches
And use the normal is_foo_ether_addr functions and ETH_ALEN too. Signed-off-by: Joe Perches j...@perches.com --- drivers/staging/slicoss/README| 1 - drivers/staging/slicoss/slicoss.c | 21 - 2 files changed, 8 insertions(+), 14 deletions(-) diff --git

Re: [PATCH] Staging: TIDSPBRIDGE: Remove UUID helper

2013-12-05 Thread Ivajlo Dimitrov
Hi Greg, On 01.12.2013 19:07, Ivaylo DImitrov wrote: From: Ivaylo Dimitrov freemangor...@abv.bg Custom uuid helper function is needed only in rmgr/dbdcd.c and doesn't need to be exported. It can also be made way simpler by using sscanf. Signed-off-by: Ivaylo Dimitrov freemangor...@abv.bg ---

Re: [PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c

2013-12-05 Thread Dan Carpenter
On Thu, Dec 05, 2013 at 03:29:22PM -0800, Joe Perches wrote: On Fri, 2013-12-06 at 02:21 +0300, Dan Carpenter wrote: On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote: On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote: On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange

Re: [PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c

2013-12-05 Thread Joe Perches
On Fri, 2013-12-06 at 10:11 +0300, Dan Carpenter wrote: On Thu, Dec 05, 2013 at 03:29:22PM -0800, Joe Perches wrote: On Fri, 2013-12-06 at 02:21 +0300, Dan Carpenter wrote: On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote: On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter

Re: [PATCH] Staging: TIDSPBRIDGE: Remove UUID helper

2013-12-05 Thread Dan Carpenter
On Fri, Dec 06, 2013 at 08:05:38AM +0200, Ivajlo Dimitrov wrote: Hi Greg, On 01.12.2013 19:07, Ivaylo DImitrov wrote: From: Ivaylo Dimitrov freemangor...@abv.bg Custom uuid helper function is needed only in rmgr/dbdcd.c and doesn't need to be exported. It can also be made way simpler by

Re: [PATCH] Staging: TIDSPBRIDGE: Remove UUID helper

2013-12-05 Thread Ivajlo Dimitrov
My other patch (the one that fixes the security issue) was already applied, albeit it was sent after this one, see https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/commit/?h=staging-linusid=559c71fe5dc3bf2ecc55afb336145db7f0abf810 , that is why I think there is some problem with