On Fri, Dec 20, 2013 at 11:48:31PM +, Bernd Porr wrote:
From 5971245d01f25890826fc05f7bab0d2b8d6bfd63 Mon Sep 17 00:00:00 2001
From: Bernd Porr m...@berndporr.me.uk
Date: Fri, 20 Dec 2013 23:32:08 +
Subject: [PATCH 1/1] Moving un-registering of the subdevices and the main
comedi
A couple of these are real endian bugs, it's not just warnings.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sun, Dec 22, 2013 at 05:37:02PM -0600, Larry Finger wrote:
Smatch shows the following:
CHECK drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1401 OnAssocReq() error: buffer
overflow 'pstapriv-sta_aid' 32 = 32
This is a false positive in
On Sun, Dec 22, 2013 at 05:36:55PM -0600, Larry Finger wrote:
--- a/drivers/staging/rtl8188eu/include/odm_interface.h
+++ b/drivers/staging/rtl8188eu/include/odm_interface.h
@@ -51,7 +51,7 @@ ODM_REG(DIG,_pDM_Odm)
#define _cat(_name, _ic_type, _func) \
On Mon, Dec 23, 2013 at 05:52:05PM +0800, rogera...@realtek.com wrote:
+static int rtsx_usb_seq_write_register(struct rtsx_ucr *ucr,
+ u16 addr, u16 len, u8 *data)
+{
+ u16 cmd_len = len + 12;
+
+ if (data == NULL)
+ return -EINVAL;
+
+ cmd_len =
-Werror=unused-parameter is stupid. Better to turn it off instead of
ugly work arounds.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi Dan,
see my re-submission of these patches. I did that properly with the git
email this time. Hope that's now all properly formatted. Thanks also for
the link.
Best,
/Bernd
Dan Carpenter wrote:
On Fri, Dec 20, 2013 at 11:48:31PM +, Bernd Porr wrote:
From
The functions sleep_on, sleep_on_timeout, interruptible_sleep_on
and interruptible_sleep_on_timeout have been deprecated for as
long as I can remember, and a number of people have contributed
patches in the past to remove them from various drivers.
This has recently popped up again and I decided
sleep_on and related functions are going away and should not be used
in this driver any more.
This removes the call to interruptible_sleep_on for a wait queue that
is never woken up, and replaces an interruptible_sleep_on_timeout
call with the equivalent wait_event_interruptible_timeout() to
interruptible_sleep_on is racy and going away. This replaces the
use in the gdm72xx driver with the appropriate
wait_event_interruptible_lock_irq.
Signed-off-by: Arnd Bergmann a...@arndb.de
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Cc: de...@driverdev.osuosl.org
---
interruptible_sleep_on is racy and going away. This replaces the one
caller in the panel driver with the appropriate wait_event_interruptible
variant.
Signed-off-by: Arnd Bergmann a...@arndb.de
Cc: de...@driverdev.osuosl.org
Cc: Willy Tarreau wi...@meta-x.org
Cc: Greg Kroah-Hartman
On Sat, Dec 28, 2013 at 03:13:52AM -0600, Chase Southwood wrote:
From: Chase Southwood chase.southw...@yahoo.com
We get this from your email. It's not needed unless you are forwarding
a patch from someone else.
This is a patch for pcmmio.c that changes several printk() calls to dev_dbg()
This driver won't link without USB support.
Reported-by: Jim Davis jim.ep...@gmail.com
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/staging/media/sn9c102/Kconfig
b/drivers/staging/media/sn9c102/Kconfig
index d8ae2354b626..3ab9c81173da 100644
---
Minor nits. Nothing major.
On Wed, Dec 25, 2013 at 07:29:52PM +0200, Ivaylo DImitrov wrote:
From: Ivaylo Dimitrov freemangor...@abv.bg
Use upstream hashtable implementation instead of generic code
Signed-off-by: Ivaylo Dimitrov freemangor...@abv.bg
Send from the same email you are using
On Thu, Dec 26, 2013 at 07:55:39PM +0100, Sebastian Rachuj wrote:
- if (pbyDesireSSID != NULL) {
- if (((PWLAN_IE_SSID) pbyDesireSSID)-len != 0)
- pSSID = (PWLAN_IE_SSID) pbyDesireSSID;
- }
+ if ((pbyDesireSSID != NULL)
+ (((PWLAN_IE_SSID)
On Mon, Dec 30, 2013 at 03:52:37PM +0100, Michael Gunselmann wrote:
wmgr.h: Fixed checkpatch errors.
Four typedef warnings remain.
line 85: This typedef increases understandability
so this warning is not touched.
line 196, 203 and 214:
+ u32 val_size;
+ DECLARE_HASHTABLE(hash_table, GH_HASH_ORDER);
+ u32 (*hash)(void *);
+ bool (*match)(void *, void *);
+ void (*delete)(void *);
I forgot to say, put the parameter name in the declaration.
+ u32 (*hash)(void *key);
+ bool (*match)(void *key,
On Tue, Dec 31, 2013 at 10:52:37PM +0100, Pavel Machek wrote:
__u32 is only useful for kernel-user interface, u32 should be enough
for kernel. Formatting was very confusing around __get_free_pages().
The subject should say:
[PATCH] hv: Trivial cleanups for drivers/hv/connection.c
regards,
Fixed indentation coding style issues on rtw_io.c
Signed-off-by: Tim Jester-Pfadt t...@gmx.de
---
drivers/staging/rtl8188eu/core/rtw_io.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c
b/drivers/staging/rtl8188eu/core/rtw_io.c
Fixed foo * bar should be foo *bar.
Fixed by Joe Borg r...@josephb.org
---
drivers/staging/comedi/drivers/das1800.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/das1800.c
b/drivers/staging/comedi/drivers/das1800.c
index 1880038..8fb87df
Fixing foo * bar should be foo *bar.
Fixed by Joe Borg r...@josephb.org
---
drivers/staging/comedi/drivers/das6402.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/das6402.c
b/drivers/staging/comedi/drivers/das6402.c
index fb25cb8..37ae356
On 01/02/2014 11:03 AM, Tim Jester-Pfadt wrote:
Fixed indentation coding style issues on rtw_io.c
Signed-off-by: Tim Jester-Pfadt t...@gmx.de
---
drivers/staging/rtl8188eu/core/rtw_io.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On Wednesday, January 01, 2014 6:55 PM, Chase Southwood wrote:
This is a patch for pcmmio.c that changes several printk() calls to dev_dbg()
or dev_err() to fix checkpatch.pl warnings. Patched from 3.13-rc6.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
On Monday, December 30, 2013 6:37 PM, Rostislav Lisovy wrote:
create mode 100644 drivers/staging/comedi/drivers/mf6x4.c
Hello Rostislav,
As pointed out by Dan Carpenter, you need to add a change log and
Signed-off-by lines to this patch.
Overall this looks pretty good. Comments below.
diff
Fixed indentation coding style issues on rtw_io.c
Signed-off-by: Tim Jester-Pfadt t...@gmx.de
---
drivers/staging/rtl8188eu/core/rtw_io.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c
There are a couple of ways to get at the drm_device for the vblank
operations. One of them is via the private imxdrm structure, the
other is via the DRM crtc structure, which also stores a pointer.
Use the DRM method instead of our own method.
Signed-off-by: Russell King
Here is my large patch series which cleans up imx-drm, and gets it ready
to move out of drivers/staging. This is a preview only.
One of these patches introduces a generic helper in drivers/base which
can be used by any subsystem to assemble a sub-devices together and
complete the probe of a
The component helper provides us the drm_device which is being
registered. Rather than having to reference a global in imx-drm-core,
use this to get the imxdrm device, and also use it to register the CRTC
against.
This means we never have CRTCs/encoders/connectors without the drivers
private
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
arch/arm/boot/dts/imx6dl.dtsi |3 ++-
arch/arm/boot/dts/imx6q.dtsi |1 +
arch/arm/boot/dts/imx6qdl.dtsi |1 -
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6dl.dtsi
Enabling the debug for PLL lock shows that this times out almost every
time. Having such an event at debug level is probably a bug in itself
because it hides this fact.
Waiting 5ms seems to allow it to lock. Also, adjust the loop so that
we check for success before checking whether we've timed
Extracted from another patch by Fabio Estevam, this adds the DT
configuration for HDMI output on the IMX6 SoCs
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
arch/arm/boot/dts/imx6dl.dtsi |4
arch/arm/boot/dts/imx6q.dtsi |4
arch/arm/boot/dts/imx6qdl.dtsi | 10
Provide two helper functions to assist with cleaning up imx-drm
connectors and encoders.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-drm-core.c | 13 +
drivers/staging/imx-drm/imx-drm.h |2 ++
2 files changed, 15 insertions(+), 0
imx-fb.c doesn't need to be separate from imx-drm-core.c - all it is
doing is setting up the minimum and maximum sizes of the scanout
buffers, and setting up the mode_config function pointers. Move the
contents into imx-drm-core.c and kill this file.
Signed-off-by: Russell King
We have the drm_device available, so rather than storing it and then
using the stored version, us the one we already have available to us.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-drm-core.c | 16
1 files changed, 8 insertions(+),
Now that we know when the components of the imx-drm subsystem will be
initialised, we can move the fbdev helper initialisation and teardown
into imx-drm-core. This gives us the required ordering that DRM wants
in both driver load and unload methods.
We can also stop exporting the
There's no reason for this to be a separate function; merge the
two together.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-drm-core.c | 33 ---
1 files changed, 9 insertions(+), 24 deletions(-)
diff --git
The DI clock selection was very rudimentary: it would statically use
either the IPU internal clock or the DI external clock depending on
which encoder was being used. In the case of HDMI, it would always
use the IPU clock.
Moreover, using the IPU clock resulted in fractional divisors, which
are
There's no point in using the clk API for this; we end up having to
violate the layering this provides.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/ipu-v3/ipu-di.c | 328 ++-
1 files changed, 105 insertions(+), 223 deletions(-)
Now that our bind function is only ever called during the main DRM
driver -load callback, we don't need to have the imx_drm_connector or
imx_drm_encoder abstractions anymore. So let's get rid of it, and move
the DRM connector and encoder setup into the connector support files.
Signed-off-by:
The vsync active edge delay is in lines, not pixel clocks.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-hdmi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/imx-drm/imx-hdmi.c
It is now no longer necessary to keep this structure around; we can
allocate it upon DRM driver load and destroy it thereafter without
affecting the other components now.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-drm-core.c | 47
Many of the variables for the audio clock regenerator (CTS/N) were not
initialised in any way. The pixel rate which was being used also
wasn't being adjusted at all when the display mode is modified.
Get rid of the seaprate 'pixel_clk_rate', and use the stored pixel
clock rate instead. Pass
Rather than having large if() and switch() statements, provide a table
to look up the register settings for various clock rates.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-hdmi.c | 250 ++--
1 files changed, 95
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-hdmi.c | 56 +--
1 files changed, 15 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/imx-drm/imx-hdmi.c
b/drivers/staging/imx-drm/imx-hdmi.c
index
fb_reg provides no real benefit to the driver: imx_hdmi_fb_registered()
will never be called multiple times. Let's get rid of this.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-hdmi.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
This mutex doesn't protect anything anymore; get rid of it.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-drm-core.c | 26 +++---
1 files changed, 3 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/imx-drm/imx-drm-core.c
Various cleanups are possible after the previous round of changes; these
have no real functional bearing other than tidying up the code.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-drm-core.c | 47 +++
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-hdmi.c | 49 ---
1 files changed, 22 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/imx-drm/imx-hdmi.c
b/drivers/staging/imx-drm/imx-hdmi.c
index
Add hotplug support. We have to make the interrupt handler threaded so
we can call drm_helper_hpd_irq_event(). Keeping in mind that we will
want to share the interrupt with other HDMI interface drivers (eg, audio
and CEC) put the groundwork in now for that, rather than just using
IRQF_ONESHOT.
Delay publishing sysfs connector entries until all components have
initialised. This reduces the probability of generating false hotplug
events when we're uncertain whether the driver can fully initialise.
This also pulls that code out of the individual imx-drm connector
drivers.
Signed-off-by:
Rather than manually writing each register sequentially, we can use a
loop to reduce the amount of code.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-hdmi.c | 40 ---
1 files changed, 14 insertions(+), 26 deletions(-)
There are a load of read-modify-write patterns to change bitfields in
various registers in this driver; provide a helper to perform this
manipulation.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-hdmi.c | 188 +---
1
Address the following issues:
- imx_drm_encoder_get_mux_id() searches the CRTC list for the matching
CRTC, and returns the position within this list as the MUX programming
value for encoders. This is sub-optimal for two reasons:
1. It relies upon the CRTC list not changing during the
Use the componentised device support for imx-drm. This requires all
the sub-components and the master device to register with the component
device support.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
arch/arm/boot/dts/imx51-babbage.dts| 10 ++-
Subsystems such as ALSA, DRM and others require a single card-level
device structure to represent a subsystem. However, firmware tends to
describe the individual devices and the connections between them.
Therefore, we need a way to gather up the individual component devices
together, and
Since we're now operating like a conventional DRM driver, doing all
the initialisation within the driver's -load callback, we don't
need to mess around with the mode groups - we can rely on the one
in the DRM platform code.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
The clock manipulations do nothing for us: the clock is already enabled
by the only caller (imx_hdmi_platform_probe()). Get rid of these and
simplify the code.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-hdmi.c |8
1 files changed, 0
Parse the ELD (EDID like data) stored from the HDMI driver to restrict
the sample rates and channels which are available to ALSA. This causes
the ALSA device to reflect the capabilities of the overall audio path,
not just what is supported at the HDMI source interface level.
Signed-off-by:
On 01/02/2014 02:46 PM, Tim Jester-Pfadt wrote:
Fixed indentation coding style issues on rtw_io.c
Signed-off-by: Tim Jester-Pfadt t...@gmx.de
---
drivers/staging/rtl8188eu/core/rtw_io.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
Instead of manually checking the bounds of VMALLOC_START and
VMALLOC_END, just use is_vmalloc_addr. That's what the function
was designed for.
Signed-off-by: Laura Abbott lau...@codeaurora.org
---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c |3 +--
1 files changed, 1 insertions(+), 2
--
Although you might be nervous about my e-mail as we have not met before.
My name is Mrs Teresa Au,HSBC Hong Kong, head of corporate sustainability
Asia pacific region. A sum of(USD$23,200,000.00) (Twenty three million,
two Hundred Thousand dollars) Million , It is absolutely risk free,was
On 01/02/2014 02:44 AM, Dan Carpenter wrote:
On Sun, Dec 22, 2013 at 05:37:02PM -0600, Larry Finger wrote:
Smatch shows the following:
CHECK drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1401 OnAssocReq() error: buffer
overflow
Fixed indentation coding style issues on rtw_io.c
Signed-off-by: Tim Jester-Pfadt t...@gmx.de
---
drivers/staging/rtl8188eu/core/rtw_io.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c
Fixed all space before tab warnings and space before close parenthesis
errors on rtl8188e_spec.h
Signed-off-by: Tim Jester-Pfadt t...@gmx.de
---
drivers/staging/rtl8188eu/include/rtl8188e_spec.h | 70 +++
1 file changed, 35 insertions(+), 35 deletions(-)
diff --git
On Fri, Jan 03, 2014 at 12:22:59AM +0100, Tim Jester-Pfadt wrote:
Fixed indentation coding style issues on rtw_io.c
Signed-off-by: Tim Jester-Pfadt t...@gmx.de
---
Next time, if you do a v2 patch please put a note here under the ---
line what changed between the previous one and this one.
2:
65 matches
Mail list logo
