[PATCH] Staging : comedi : comedidev.h Fixed warning space coding style issue

2014-01-20 Thread Surendra Patil
Fixed a coding style issue,removed space after the function pointer name Signed-off-by: Surendra Patil surendra@gmail.com --- drivers/staging/comedi/comedidev.h | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git

Re: [PATCH] staging: lustre: fix GFP_ATOMIC macro usage

2014-01-20 Thread Marek Szyprowski
Hello, On 2014-01-17 15:33, Greg Kroah-Hartman wrote: On Fri, Jan 17, 2014 at 09:46:56AM +0100, Marek Szyprowski wrote: GFP_ATOMIC is not a single gfp flag, but a macro which expands to the other flags and LACK of __GFP_WAIT flag. To check if caller wanted to perform an atomic allocation,

Re: [PATCH 1/3] mfd: Add realtek USB card reader driver

2014-01-20 Thread Roger
On 01/16/2014 05:35 PM, Lee Jones wrote: +static int rtsx_usb_bulk_transfer_sglist(struct rtsx_ucr *ucr, + unsigned int pipe, struct scatterlist *sg, int num_sg, + unsigned int length, unsigned int *act_len, int timeout) +{ + int ret; + +

Re: [PATCH] Staging : comedi : comedidev.h Fixed warning space coding style issue

2014-01-20 Thread Dan Carpenter
On Mon, Jan 20, 2014 at 12:19:09AM -0800, Surendra Patil wrote: Fixed a coding style issue,removed space after the function pointer name Signed-off-by: Surendra Patil surendra@gmail.com --- drivers/staging/comedi/comedidev.h | 32 1 file changed, 16

[patch] staging: android: ion: dummy: fix an error code

2014-01-20 Thread Dan Carpenter
We should be returning -ENOMEM here instead of zero. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/staging/android/ion/ion_dummy_driver.c b/drivers/staging/android/ion/ion_dummy_driver.c index 55b2002753f2..f0d786c539ea 100644 ---

Re: [PATCH] drivers: staging: lustre: lustre: include: add __attribute__((packed)) for the related union

2014-01-20 Thread James Hogan
Hi Chen, On 19/01/14 10:07, Chen Gang wrote: BTW: this patch is related with another patch which is discussing (so I have cc that patch to you and Greg too): if we could sure that it is a compiler's feature issue, we will skip this patch. If you're referring to the #pragma pack portability

Re: [PATCH] drivers: staging: lustre: lustre: include: add __attribute__((packed)) for the related union

2014-01-20 Thread Dan Carpenter
Ah. From so metag is a new arch and not a compiler like the changelog says. On Mon, Jan 20, 2014 at 11:56:47AM +, James Hogan wrote: struct a { struct b { unsigned int x; unsigned short y; } x; unsigned short y; } __packed; This is not

Re: [PATCH] drivers: staging: lustre: lustre: include: add __attribute__((packed)) for the related union

2014-01-20 Thread James Hogan
On 20/01/14 12:30, Dan Carpenter wrote: Ah. From so metag is a new arch and not a compiler like the changelog says. On Mon, Jan 20, 2014 at 11:56:47AM +, James Hogan wrote: struct a { struct b { unsigned int x; unsigned short y; } x;

Re: [PATCH] drivers: staging: lustre: lustre: include: add __attribute__((packed)) for the related union

2014-01-20 Thread Dan Carpenter
On Mon, Jan 20, 2014 at 12:37:57PM +, James Hogan wrote: On 20/01/14 12:30, Dan Carpenter wrote: Ah. From so metag is a new arch and not a compiler like the changelog says. On Mon, Jan 20, 2014 at 11:56:47AM +, James Hogan wrote: struct a { struct b {

Re: [PATCH] drivers: staging: lustre: lustre: include: add __attribute__((packed)) for the related union

2014-01-20 Thread Dan Carpenter
Are you sure it's padding the unions, and not just treating the unions as structs? What is the size of this union? union a { int x; short y; }; regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-20 Thread Insop Song
On Thu, Jan 16, 2014 at 1:41 PM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Jan 16, 2014 at 11:47:41AM -0800, Insop Song wrote: There is no way to detect FPGA until it is programmed. This is a reason and the only reason of this driver to download the program to the FPGA so that it

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-20 Thread Greg KH
On Mon, Jan 20, 2014 at 09:16:08AM -0800, Insop Song wrote: On Thu, Jan 16, 2014 at 1:41 PM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Jan 16, 2014 at 11:47:41AM -0800, Insop Song wrote: There is no way to detect FPGA until it is programmed. This is a reason and the only reason of

RE: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-20 Thread Hartley Sweeten
On Monday, January 20, 2014 11:06 AM, Greg KH wrote: On Mon, Jan 20, 2014 at 09:16:08AM -0800, Insop Song wrote: On Thu, Jan 16, 2014 at 1:41 PM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Jan 16, 2014 at 11:47:41AM -0800, Insop Song wrote: There is no way to detect FPGA until it is

Re: [PATCH] drivers: staging: lustre: lustre: include: add __attribute__((packed)) for the related union

2014-01-20 Thread Dan Carpenter
I made a quick and dirty sparse patch to check for this. I don't think I will bother trying to send it to sparse upstream, but you can if you want to. It found 289 unions which might need a __packed added. The lustre unions were not in my allmodconfig so they're not listed. Perhaps there could

Re: [PATCH 1/3] mfd: Add realtek USB card reader driver

2014-01-20 Thread Greg Kroah-Hartman
On Mon, Jan 20, 2014 at 04:55:52PM +0800, Roger wrote: On 01/16/2014 05:35 PM, Lee Jones wrote: +static int rtsx_usb_bulk_transfer_sglist(struct rtsx_ucr *ucr, + unsigned int pipe, struct scatterlist *sg, int num_sg, + unsigned int length, unsigned int *act_len, int

RE: [PATCH net-next] hyperv: Add support for physically discontinuous receive buffer

2014-01-20 Thread KY Srinivasan
-Original Message- From: Haiyang Zhang Sent: Monday, January 20, 2014 2:06 PM To: David Miller Cc: net...@vger.kernel.org; KY Srinivasan; o...@aepfle.de; jasow...@redhat.com; linux-ker...@vger.kernel.org; driverdev- de...@linuxdriverproject.org Subject: RE: [PATCH net-next]

RE: [PATCH V2 1/1] Drivers: hv: Implement the file copy service

2014-01-20 Thread KY Srinivasan
Olaf, I am cleaning up the code based on your feedback. By the time I am done with my cleanup, I doubt if this patch would apply. Do you mind if I were to include your changes here as part of my cleanup? Thank you, K. Y -Original Message- From: Olaf Hering [mailto:o...@aepfle.de]

Re: [PATCH V2 1/1] Drivers: hv: Implement the file copy service

2014-01-20 Thread Olaf Hering
On Mon, Jan 20, KY Srinivasan wrote: I am cleaning up the code based on your feedback. By the time I am done with my cleanup, I doubt if this patch would apply. Do you mind if I were to include your changes here as part of my cleanup? Yes, thats fine. Olaf

RE: [PATCH V2 1/1] Drivers: hv: Implement the file copy service

2014-01-20 Thread KY Srinivasan
-Original Message- From: Olaf Hering [mailto:o...@aepfle.de] Sent: Monday, January 20, 2014 2:16 PM To: KY Srinivasan Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; a...@canonical.com; jasow...@redhat.com Subject: Re: [PATCH V2 1/1]

RE: [PATCH net-next] hyperv: Add support for physically discontinuous receive buffer

2014-01-20 Thread Haiyang Zhang
-Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Tuesday, January 14, 2014 5:32 PM To: Haiyang Zhang Cc: net...@vger.kernel.org; KY Srinivasan; o...@aepfle.de; jasow...@redhat.com; linux-ker...@vger.kernel.org; driverdev- de...@linuxdriverproject.org

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-20 Thread Insop Song
On Mon, Jan 20, 2014 at 10:51 AM, Hartley Sweeten hartl...@visionengravers.com wrote: I have not looked at this driver but... Couldn't this be done from user space using urjtag? http://urjtag.org/ Thank you for letting me know urjtag. This can be useful to replace existing jtag dongles.

[PATCH v5 0/1] staging: fpgaboot: Xilinx FPGA firmware download drive

2014-01-20 Thread Insop Song
Xilinx FPGA firmware download driver v5 - update based on Greg's feedback - updated README to reflect the use case of the driver Insop Song (1): staging: fpgaboot: Xilinx FPGA firmware download driver drivers/staging/Kconfig |2 + drivers/staging/Makefile

[PATCH v5 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-20 Thread Insop Song
This driver downloads Xilinx FPGA firmware using gpio pins. It loads Xilinx FPGA bitstream format firmware image and program the Xilinx FPGA using SelectMAP (parallel) mode. Signed-off-by: Insop Song insop.s...@gainspeed.com --- drivers/staging/Kconfig |2 +