Re: [PATCH v14 04/10] imx-drm: use defines for clock polarity settings

2014-06-25 Thread Russell King - ARM Linux
On Wed, Jun 25, 2014 at 06:48:45AM +0200, Sascha Hauer wrote: On Mon, Jun 16, 2014 at 12:11:18PM +0200, Denis Carikli wrote: + /* * Bitfield of Display Interface signal polarities. */ @@ -37,7 +43,7 @@ struct ipu_di_signal_cfg { unsigned clksel_en:1; unsigned

Re: [PATCH v14 07/10] imx-drm: Use drm_display_mode timings flags.

2014-06-25 Thread Russell King - ARM Linux
On Mon, Jun 16, 2014 at 12:11:21PM +0200, Denis Carikli wrote: The previous hardware behaviour was kept if the flags are not set. I'd like to throw in a patch that I've been carrying for a bit now. It conflicts with your patches, but I'm happy to fix that conflict locally (and have been doing

Re: [PATCH v14 08/10] drm/panel: Add Eukrea mbimxsd51 displays.

2014-06-25 Thread Denis Carikli
On 06/24/2014 05:06 PM, Russell King - ARM Linux wrote: It would be better if you separate the binding documentation updates from the other functional changes too. Fixed. Denis. ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH v14 04/10] imx-drm: use defines for clock polarity settings

2014-06-25 Thread Denis Carikli
On 06/25/2014 06:48 AM, Sascha Hauer wrote: +#define ENABLE_POL_LOW 0 +#define ENABLE_POL_HIGH1 Adding defines without a proper namespace (IPU_) outside a driver private header file is not nice. Anyway, instead of adding the defines ... Fixed in imx-drm: use defines for

Re: [PATCH v14 04/10] imx-drm: use defines for clock polarity settings

2014-06-25 Thread Sascha Hauer
On Wed, Jun 25, 2014 at 09:43:27AM +0100, Russell King - ARM Linux wrote: On Wed, Jun 25, 2014 at 06:48:45AM +0200, Sascha Hauer wrote: On Mon, Jun 16, 2014 at 12:11:18PM +0200, Denis Carikli wrote: + /* * Bitfield of Display Interface signal polarities. */ @@ -37,7 +43,7 @@

[PATCH] staging: rtl8192u: r8192U_core.c: Cleaning up variable is set more than once

2014-06-25 Thread Rickard Strandqvist
A struct member variable is set to the same value more than once This was found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/staging/rtl8192u/r8192U_core.c |1 - 1 file changed, 1 deletion(-)

Re: [PATCH 6/6] Staging: bcm: Lines shortened in download_ddr_settings()

2014-06-25 Thread Matthias Beyer
On 23-06-2014 13:44:22, j...@joshtriplett.org wrote: On Mon, Jun 23, 2014 at 11:42:33AM +0200, Matthias Beyer wrote: Signed-off-by: Matthias Beyer m...@beyermatthias.de As with the previous line-wrapping patch, this doesn't seem like a net improvement; the lines seem far more readable

[PATCH 2/2] staging: wlan-ng/hfa384x_usb.c: add blank line after declarations

2014-06-25 Thread Cheng-Wei Lee
This patch fixes the following checkpatch.pl issues in hfa384x_usb.c: WARNING: Missing a blank line after declarations Signed-off-by: Quentin Lee lee.rhaps...@gmail.com --- drivers/staging/wlan-ng/hfa384x_usb.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [PATCH 1/2] staging: wlan-ng/hfa384x_usb.c: remove return statements for void function

2014-06-25 Thread Cheng-Wei Lee
Dear all, Thanks Joe's reminder. I've resent patch. Sincerely, Quentin 2014-06-25 23:28 GMT+08:00, Joe Perches j...@perches.com: On Wed, 2014-06-25 at 23:24 +0800, Cheng-Wei Lee wrote: This patch fixes the following checkpatch.pl issues in hfa384x_usb.c: WARNING: void function return

[PATCH 0/4] Staging: unisys: Remove references to __DATE__ and __TIME__

2014-06-25 Thread Ken Cox
This series removes all references to __DATE__ and __TIME__ from the unisys drivers and also removes BROKEN from the Kconfig so the drivers can be built. PATCH 1: Gets rid of references to __DATE__ and __TIME__ PATCH 2: Removes buildDate and buildTime arguments from BusDeviceInfo_Init() PATCH 3:

[PATCH 2/4] Staging: unisys: remove buildDate and buildTime arguments from BusDeviceInfo_Init

2014-06-25 Thread Ken Cox
The unisys drivers no longer need to record the build date and time since the same info is already in the kernel elsewhere. Signed-off-by: Ken Cox j...@redhat.com --- drivers/staging/unisys/include/vbushelper.h | 8 +++- drivers/staging/unisys/uislib/uisutils.c| 7

[PATCH 3/4] Staging: unisys: Remove build_date and build_time from virtpci_driver structure

2014-06-25 Thread Ken Cox
The drivers do not need to keep track of these fields since the same information is present elsewhere in the kernel. Signed-off-by: Ken Cox j...@redhat.com --- drivers/staging/unisys/virthba/virthba.c | 2 -- drivers/staging/unisys/virtpci/virtpci.h | 2 -- 2 files changed, 4 deletions(-) diff

[PATCH 4/4] Staging: unisys Remove BROKEN from Kconfig to allow compilation

2014-06-25 Thread Ken Cox
The unisys drivers now properly check to make sure they are running on the s-Par platform before they will initialize. This was fixed in commit fcd0157ece so it is safe to allow the unisys drivers to be built. This has been tested in the same qemu environment that originally produced the panic

Re: [PATCH 1/2] staging: wlan-ng/hfa384x_usb.c: remove return statements for void function

2014-06-25 Thread Joe Perches
On Wed, 2014-06-25 at 23:24 +0800, Cheng-Wei Lee wrote: This patch fixes the following checkpatch.pl issues in hfa384x_usb.c: WARNING: void function return statements are not generally useful subject/code mismatch. Signed-off-by: Quentin Lee lee.rhaps...@gmail.com ---

Re: [Patch v3 2/4] Staging: unisys: Fix sparse warnings in uislib

2014-06-25 Thread Ken Cox
On 06/17/2014 06:01 PM, Greg KH wrote: On Thu, Jun 05, 2014 at 01:56:16PM -0500, Ken Cox wrote: Added I/O version for the function ultra_vbus_init_channel() to get rid of noderef sparse warnings when accessing I/O space. Signed-off-by: Ken Cox j...@redhat.com ---

Re: [PATCH 00/22] Add and use pci_zalloc_consistent

2014-06-25 Thread John W. Linville
On Mon, Jun 23, 2014 at 06:41:28AM -0700, Joe Perches wrote: Adding the helper reduces object code size as well as overall source size line count. It's also consistent with all the various zalloc mechanisms in the kernel. Done with a simple cocci script and some typing. Joe Perches

Re: [PATCH 2/2] staging: wlan-ng/hfa384x_usb.c: remove return statements for void function

2014-06-25 Thread Joe Perches
On Wed, 2014-06-25 at 23:35 +0800, Cheng-Wei Lee wrote: This patch fixes the following checkpatch.pl issues in hfa384x_usb.c: WARNING: Missing a blank line after declarations Still has a mismatch between subject and code diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c [] @@ -3533,7

[PATCH] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-06-25 Thread Dexuan Cui
Currently the VSC has no chance to notify the VSP of the dirty rectangle on VM panic because the notification work is done in a workqueue, and in panic() the kernel typically ends up in an infinite loop, and a typical kernel config has CONFIG_PREEMPT_VOLUNTARY=y and CONFIG_PREEMPT is not set, so a

Re: [PATCH 2/2] staging: wlan-ng/hfa384x_usb.c: remove return statements for void function

2014-06-25 Thread Cheng-Wei Lee
Hi Joe, Thanks for your kindly reply. I'll submit patch again. Many thanks, Quentin 2014-06-26 8:09 GMT+08:00, Joe Perches j...@perches.com: On Wed, 2014-06-25 at 23:35 +0800, Cheng-Wei Lee wrote: This patch fixes the following checkpatch.pl issues in hfa384x_usb.c: WARNING: Missing a blank

[PATCH] staging: wlan-ng/hfa384x_usb.c: add blank line after declarations

2014-06-25 Thread Cheng-Wei Lee
This patch fixes the following checkpatch.pl issues in hfa384x_usb.c: WARNING: Missing a blank line after declarations Signed-off-by: Quentin Lee lee.rhaps...@gmail.com --- drivers/staging/wlan-ng/hfa384x_usb.c |1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH] staging: wlan-ng/hfa384x_usb.c: add blank line after declarations

2014-06-25 Thread Joe Perches
On Thu, 2014-06-26 at 09:55 +0800, Cheng-Wei Lee wrote: This patch fixes the following checkpatch.pl issues in hfa384x_usb.c: WARNING: Missing a blank line after declarations This time you've got the right subject, and right type of content, but unfortunately, the content is wrapped and can't

Re: [PATCH] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-06-25 Thread Greg KH
On Tue, Jun 24, 2014 at 09:44:14PM +, Dexuan Cui wrote: On Tue, Jun 24, 2014 at 08:29:17AM +0800, Dexuan Cui wrote: Currently the VSC has no chance to notify the VSP of the dirty rectangle on VM panic because the notification work is done in a workqueue, and in panic() the kernel

Re: [Patch v3 2/4] Staging: unisys: Fix sparse warnings in uislib

2014-06-25 Thread Greg KH
On Wed, Jun 25, 2014 at 02:01:03PM -0500, Ken Cox wrote: On 06/17/2014 06:01 PM, Greg KH wrote: On Thu, Jun 05, 2014 at 01:56:16PM -0500, Ken Cox wrote: Added I/O version for the function ultra_vbus_init_channel() to get rid of noderef sparse warnings when accessing I/O space.

Re: [PATCH 1/4] Staging: unisys: remove references to __DATE__ and __TIME__

2014-06-25 Thread Greg KH
On Wed, Jun 25, 2014 at 11:48:23AM -0500, Ken Cox wrote: The use of __DATE__ and __TIME__ is no longer allowed in the kernel so this commit removes those. They were once useful when the drivers were being built externally, but now that the drivers are in the kernel the use of the macros is

Re: [PATCH 3/4] Staging: unisys: Remove build_date and build_time from virtpci_driver structure

2014-06-25 Thread Greg KH
On Wed, Jun 25, 2014 at 11:48:25AM -0500, Ken Cox wrote: The drivers do not need to keep track of these fields since the same information is present elsewhere in the kernel. Signed-off-by: Ken Cox j...@redhat.com Again, just do this, not the first one at all. greg k-h