Re: [PATCH v2 4/4] Staging: rts5208: Fix a format specifier for dev_err

2014-07-08 Thread Fabio Falzoi
Hi Micky, in the latest linux-tree sources, lun field in struct scsi_device from include/scsi/scsi_device.h is a u64: unsigned int id, channel; u64 lun; unsigned int manufacturer; so we get a compiler warning if we keep the %u specifier. Regards, Fabio On Tue, Jul 8,

Re: [PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-08 Thread Fabio Falzoi
Hi, here exist some checkpatch errors. Best Regards. micky. Yes, you'are right, I'm gonna fix it, thanks. On Tue, Jul 8, 2014 at 4:12 AM, micky micky_ch...@realsil.com.cn wrote: On 07/07/2014 03:10 PM, Fabio Falzoi wrote: Use print_hex_dump_bytes to have memory properly dumped only when

[PATCH] staging: wlan-ng: Use net_device_stats from struct net_device

2014-07-08 Thread Tobias Klauser
Instead of using an own copy of struct net_device_stats in struct wlandevice, use stats from struct net_device. Also remove the thus unnecessary .ndo_get_stats function, as it would now just return netdev-stats, which is the default in dev_get_stats(). Furthermore, convert prefix increment of

[PATCH] staging: gdm72xx: Use net_device_stats from struct net_device

2014-07-08 Thread Tobias Klauser
Instead of using an own copy of struct net_device_stats in struct nic, use stats from struct net_device. Also remove the thus unnecessary .ndo_get_stats function, as it would now just return netdev-stats, which is the default in dev_get_stats(). Signed-off-by: Tobias Klauser tklau...@distanz.ch

[PATCH] staging: et131x: Use net_device_stats from struct net_device

2014-07-08 Thread Tobias Klauser
Instead of using an own copy of struct net_device_stats in struct et131x_adapter, use stats from struct net_device. Signed-off-by: Tobias Klauser tklau...@distanz.ch --- drivers/staging/et131x/et131x.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git

Re: [PATCH] staging: rtl8192u: fix checkpatch error/warning in r819xU_phy.c

2014-07-08 Thread Dan Carpenter
On Tue, Jul 08, 2014 at 11:34:18AM +0530, sanjeev sharma wrote: From: sanjeevs1 sanjeev_sha...@mentor.com ^ No. This is a patch to the r819xU_phy.c file that fixes up all the Error/Warning found by the checkpatch.pl tool Split it into one thing per patch. Signed-off-by:

[PATCH] staging: gdm72xx: Remove unnecessary memset of netdev private data

2014-07-08 Thread Tobias Klauser
The memory for struct net_device private data is allocated using kzalloc/vzalloc in alloc_netdev_mqs, thus there is no need to zero it again in the driver. Signed-off-by: Tobias Klauser tklau...@distanz.ch --- drivers/staging/gdm72xx/gdm_wimax.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [PATCH v2 2/5] staging:iio:hmc5843: Split hmc5843.c to multiple files

2014-07-08 Thread Dan Carpenter
When you compare the old and new versions of hmc5843_read_raw() then it appears there is a bug fix or something which hasn't been documentented in the changelog. -static int hmc5843_read_raw(struct iio_dev *indio_dev, - struct iio_chan_spec const *chan, -

Re: [PATCH v2 04/10] lib/vsprintf: add %*pE[achnops] format specifier

2014-07-08 Thread Andy Shevchenko
On Mon, 2014-07-07 at 09:50 -0700, Joe Perches wrote: On Mon, 2014-07-07 at 18:21 +0300, Andy Shevchenko wrote: diff --git a/lib/vsprintf.c b/lib/vsprintf.c [] static noinline_for_stack +char *escaped_string(char *buf, char *end, u8 *addr, struct printf_spec spec, +

Re: [PATCH 5/5] staging:nvec: Add missing blank line after declarations.

2014-07-08 Thread Dan Carpenter
Looks ok. If you wanted it probably would have been better to fold patches 3, 4, and 5 together but this is ok too. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-08 Thread Dan Carpenter
On Tue, Jul 08, 2014 at 08:23:02AM +0200, Fabio Falzoi wrote: Hi, here exist some checkpatch errors. Best Regards. micky. Yes, you'are right, I'm gonna fix it, thanks. And leave out the semi-colon as well. regards, dan carpenter ___

Re: [PATCH v2 04/10] lib/vsprintf: add %*pE[achnops] format specifier

2014-07-08 Thread Andy Shevchenko
On Mon, 2014-07-07 at 09:25 -0700, Joe Perches wrote: [trivial notes] Thanks! Fixed locally, though am waiting for few more days if any other comment comes. On Mon, 2014-07-07 at 18:21 +0300, Andy Shevchenko wrote: This allows user to print a given buffer as esaped string. The rules

Re: [PATCH 02/13] staging: rtl8188eu: Remove function rtw_alloc_etherdev()

2014-07-08 Thread Dan Carpenter
On Tue, Jul 08, 2014 at 12:10:02AM +0530, navin patidar wrote: rtw_alloc_etherdev() is used in rtw_init_netdev() but never gets called because old_padapter is never NULL. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/osdep_service.h |1 -

RE: [PATCH v2] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-07-08 Thread Dexuan Cui
-Original Message- From: driverdev-devel-boun...@linuxdriverproject.org [mailto:driverdev- devel-boun...@linuxdriverproject.org] On Behalf Of Dexuan Cui Sent: Friday, June 27, 2014 5:35 AM To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev-

Re: [PATCH v2] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-07-08 Thread Dan Carpenter
Don't use likely/unlikely unless you have benchmark numbers to show that it makes a speed up. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] hyperv: Add netpoll support

2014-07-08 Thread Richard Weinberger
In order to have at least a netconsole to debug kernel issues on Windows Azure this patch implements netpoll support. Sending packets is easy, netvsc_start_xmit() does already everything needed. To receive we need to trigger the channel callback which is usally called via tasklet_schedule().

Re: [PATCH] staging: rtl8192u: fix checkpatch error/warning in r819xU_phy.c

2014-07-08 Thread Dan Carpenter
On Tue, Jul 08, 2014 at 03:18:40PM +0530, sanjeev sharma wrote: Hi Dan, On Tue, Jul 8, 2014 at 1:13 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Tue, Jul 08, 2014 at 11:34:18AM +0530, sanjeev sharma wrote: From: sanjeevs1 sanjeev_sha...@mentor.com ^ No.

Re: Status of RMI4 drivers?

2014-07-08 Thread Kristina Martšenko
On 06/07/14 21:12, Dmitry Torokhov wrote: On Sat, Jul 5, 2014 at 8:39 PM, Greg KH gre...@linuxfoundation.org wrote: On Sat, Jul 05, 2014 at 04:37:37PM +0100, Alan Cox wrote: On Fri, 2014-07-04 at 21:48 +0300, Kristina Martšenko wrote: Hi, I'm going over some older drivers in the staging tree

Re: [PATCH] staging:nvec: Fix several coding style warnings

2014-07-08 Thread Marc Dietrich
Hi Guillaume, On Tue, 8 Jul 2014 00:31:32 +0200 Guillaume Clement gclem...@baobob.org wrote: This fixes several warnings in the nvec staging driver. Pawel Lebioda already sent a patch series to fix these issues a few days ago. From a first look, your patch series looks identical. Thanks

Re: [PATCH 8/8] staging: rtl8712: remove inapplicable comment

2014-07-08 Thread Dan Carpenter
On Tue, Jun 24, 2014 at 10:52:41PM -0400, James A Shackleford wrote: Signed-off-by: James A Shackleford sh...@linux.com --- drivers/staging/rtl8712/osdep_service.h |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8712/osdep_service.h

Re: [PATCH 2/2] staging: wlan-ng/hfa384x_usb.c: add blank line after declarations

2014-07-08 Thread Dan Carpenter
On Wed, Jun 25, 2014 at 11:25:33PM +0800, Cheng-Wei Lee wrote: This patch fixes the following checkpatch.pl issues in hfa384x_usb.c: WARNING: Missing a blank line after declarations Signed-off-by: Quentin Lee lee.rhaps...@gmail.com --- drivers/staging/wlan-ng/hfa384x_usb.c |4 +--- 1

Re: Question about patches for bcm

2014-07-08 Thread Dan Carpenter
On Thu, Jun 26, 2014 at 04:42:11PM +0200, Matthias Beyer wrote: Hi, I have a question related to some patches I send in. (I send them to de...@driverdev.osuosl.org, but they show up in the archives of this list... so I'm asking here) I send 6 patch sets since the beginning of the month.

[patch] staging: rtl8188eu: use GFP_ATOMIC under spinlock

2014-07-08 Thread Dan Carpenter
We're holding a spinlock here so we can't do sleeping allocations. The call tree is: rtw_sta_flush() -- takes spin_lock_bh(pstapriv-asoc_list_lock); -- ap_free_sta() -- rtw_clearstakey_cmd() Originally these calls were rtw_zmalloc() and then we switched them to kzalloc() in fadbe0cd5292

Re: [PATCH 4/4] staging: xillybus: Remove sparse error on IS_ERR()

2014-07-08 Thread Dan Carpenter
On Sat, Jul 05, 2014 at 12:45:10PM +0300, Eli Billauer wrote: IS_ERR() expects a non-__iomem pointer. This should be fixed in the latest versions of Sparse. Don't make the code worse to work around bugs in the tools. regards, dan carpenter ___ devel

Re: [PATCH 4/4] staging: xillybus: Remove sparse error on IS_ERR()

2014-07-08 Thread Eli Billauer
Hi, Indeed -- I upgraded to sparse 0.5.0, and there's no need for this fix anymore. I'll start keeping track of sparse's git repo from now on. Dan -- Thanks for pointing this out. Greg -- Please don't apply this patch. Eli On 08/07/14 14:36, Dan Carpenter wrote: On Sat, Jul 05, 2014 at

Re: Status of RMI4 drivers?

2014-07-08 Thread Linus Walleij
On Tue, Jul 8, 2014 at 12:12 PM, Kristina Martšenko kristina.martse...@gmail.com wrote: On 06/07/14 21:12, Dmitry Torokhov wrote: I was supposed to uprev the driver to the latest kernel and start merging it, unfortunately last month and a half was quite a mess. Hopefully now I should have

Re: Anybody working on tidspbridge?

2014-07-08 Thread Kristina Martšenko
On 29/06/14 19:42, Greg KH wrote: On Fri, Jun 20, 2014 at 07:05:17PM +0300, Kristina Martšenko wrote: On 20/06/14 18:43, Kristina Martšenko wrote: Hi Omar, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving tidspbridge out of

Re: Anybody working on tidspbridge?

2014-07-08 Thread Peter Meerwald
Hello, Given the total lack of response here, I suggest just deleting the driver. No one has ever done the real work that is going to be required to get this code out of staging. It has had build errors causing it to not even be usable for some kernel versions with no one noticing, so

Re: [PATCH v2 2/5] staging:iio:hmc5843: Split hmc5843.c to multiple files

2014-07-08 Thread Josef Gajdusek
On Tue, Jul 08, 2014 at 11:23:51AM +0300, Dan Carpenter wrote: When you compare the old and new versions of hmc5843_read_raw() then it appears there is a bug fix or something which hasn't been documentented in the changelog. -static int hmc5843_read_raw(struct iio_dev *indio_dev, -

[PATCH v3 2/5] staging:iio:hmc5843: Split hmc5843.c to multiple files

2014-07-08 Thread Josef Gajdusek
This patch splits hmc5843.c to multiple files - the interface-agnostic hmc5843_core.c, i2c specific hmc5843_i2c.c and header file hmc5843.h. This is another step to add support of SPI-enabled hmc5983. Signed-off-by: Josef Gajdusek a...@atx.name --- drivers/staging/iio/magnetometer/Kconfig

[PATCH v3 3/5] staging:iio:hmc5843: register - value arrays now can have different lengths

2014-07-08 Thread Josef Gajdusek
Changed structure of struct hmc5843_chip_info to include length of translation arrays. Code previously using #defined constant has been changed accordingly. This allows to integrate devices which do have different amounts of available rates/scales. Signed-off-by: Josef Gajdusek a...@atx.name ---

[PATCH v3 4/5] staging:iio:hmc5843: Add support for i2c hmc5983

2014-07-08 Thread Josef Gajdusek
This patch adds support for the hmc5983 i2c interface. This chip is almost identical to the hmc5883. The difference being added temperature compensation, additional available sample rate (220Hz) and an SPI interface. Signed-off-by: Josef Gajdusek a...@atx.name ---

[PATCH v3 5/5] staging:iio:hmc5843: Add support for spi hmc5983

2014-07-08 Thread Josef Gajdusek
This patch adds support for the hmc5983 spi interface. This chip is almost identical to the hmc5883. The difference being added temperature compensation, additional available sample rate (220Hz) and an SPI interface. Signed-off-by: Josef Gajdusek a...@atx.name ---

[PATCH] staging: rtl8192ee: Correct bitmask in comparsion

2014-07-08 Thread Andrey Utkin
The issue is discovered by static checker. The proposed change (0x000c0 - 0x000c) is likely correct because: 1. 16-bit `map` holds value coming from struct ieee80211_vht_mcs_info.tx_mcs_map, which is described so: TX MCS map 2 bits for each stream, total 8 streams. The changed code refers to case

[PATCH] staging: ft1000-usb: check for errors in card_send_command

2014-07-08 Thread Andrey Utkin
kmalloc() result check was lacking. Fixing that required also changing card_send_command() return type from void to int, and checking its return code everywhere. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=78561 Reported-by: Maksymilian Arciemowicz m...@cert.cx Signed-off-by: Andrey

[PATCH] [media] davinci-vpfe: Fix retcode check

2014-07-08 Thread Andrey Utkin
Use signed type to check correctly for negative error code. The issue was reported with static analyser: [linux-3.13/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c:270]: (style) A pointer can not be negative so it is either pointless or an error to check if it is. Bugzilla:

Re: [PATCH] [media] davinci-vpfe: Fix retcode check

2014-07-08 Thread Levente Kurusa
2014-07-08 16:08 GMT+02:00 Andrey Utkin andrey.krieger.ut...@gmail.com: Use signed type to check correctly for negative error code. The issue was reported with static analyser: [linux-3.13/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c:270]: (style) A pointer can not be negative so it is

[PATCH 1/2] solo6x10: expose encoder quantization setting as V4L2 control

2014-07-08 Thread Andrey Utkin
solo6*10 boards have configurable quantization parameter which takes values from 0 to 31, inclusively. This change enables setting it with ioctl VIDIOC_S_CTRL with id V4L2_CID_MPEG_VIDEO_H264_MIN_QP. --- drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c | 5 + 1 file changed, 5

[PATCH 2/2] solo6x10: update GOP size, QP immediately

2014-07-08 Thread Andrey Utkin
Previously, it was needed to reopen device to update GOP size and quantization parameter. Now we update device registers with new values immediately. --- drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH] [media] davinci-vpfe: Fix retcode check

2014-07-08 Thread Andrey Utkin
2014-07-08 17:32 GMT+03:00 Levente Kurusa lkur...@redhat.com: Hmm, while it is true that get_ipipe_mode returns an int, but the consequent call to regw_ip takes an u32 as its second argument. Did it cause a build warning for you? (Can't really check since I don't have ARM cross compilers

Re: [PATCH] staging: rtl8192ee: Correct bitmask in comparsion

2014-07-08 Thread Dan Carpenter
On Tue, Jul 08, 2014 at 04:54:59PM +0300, Andrey Utkin wrote: The issue is discovered by static checker. The proposed change (0x000c0 - 0x000c) is likely correct because: 1. 16-bit `map` holds value coming from struct ieee80211_vht_mcs_info.tx_mcs_map, which is described so: TX MCS map 2 bits

Re: [PATCH] [media] davinci-vpfe: Fix retcode check

2014-07-08 Thread Dan Carpenter
On Tue, Jul 08, 2014 at 04:32:57PM +0200, Levente Kurusa wrote: 2014-07-08 16:08 GMT+02:00 Andrey Utkin andrey.krieger.ut...@gmail.com: Use signed type to check correctly for negative error code. The issue was reported with static analyser:

Re: [PATCH 1/2] solo6x10: expose encoder quantization setting as V4L2 control

2014-07-08 Thread Dan Carpenter
On Tue, Jul 08, 2014 at 05:30:33PM +0300, Andrey Utkin wrote: solo6*10 boards have configurable quantization parameter which takes values from 0 to 31, inclusively. This change enables setting it with ioctl VIDIOC_S_CTRL with id V4L2_CID_MPEG_VIDEO_H264_MIN_QP. Both of these two need

[PATCH 1/2] solo6x10: expose encoder quantization setting as V4L2 control

2014-07-08 Thread Andrey Utkin
solo6*10 boards have configurable quantization parameter which takes values from 0 to 31, inclusively. This change enables setting it with ioctl VIDIOC_S_CTRL with id V4L2_CID_MPEG_VIDEO_H264_MIN_QP. Signed-off-by: Andrey Utkin andrey.ut...@corp.bluecherry.net ---

[PATCH 2/2] solo6x10: update GOP size, QP immediately

2014-07-08 Thread Andrey Utkin
Previously, it was needed to reopen device to update GOP size and quantization parameter. Now we update device registers with new values immediately. Signed-off-by: Andrey Utkin andrey.ut...@corp.bluecherry.net --- drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c | 4 1 file changed, 4

Re: [PATCH] [media] davinci-vpfe: Fix retcode check

2014-07-08 Thread Prabhakar Lad
Hi Andrey, Thanks for the patch! On Tue, Jul 8, 2014 at 3:58 PM, Andrey Utkin andrey.krieger.ut...@gmail.com wrote: 2014-07-08 17:32 GMT+03:00 Levente Kurusa lkur...@redhat.com: Hmm, while it is true that get_ipipe_mode returns an int, but the consequent call to regw_ip takes an u32 as its

Re: [PATCH v2 04/10] lib/vsprintf: add %*pE[achnops] format specifier

2014-07-08 Thread Joe Perches
On Tue, 2014-07-08 at 11:24 +0300, Andy Shevchenko wrote: On Mon, 2014-07-07 at 09:50 -0700, Joe Perches wrote: Perhaps better if -1 was accepted by string_escape_mem as a strlen request or just ignored as a 0 length is above. Would it be any benefit here? Dunno, it was just a thought

Re: [PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-08 Thread Joe Perches
On Tue, 2014-07-08 at 11:45 +0300, Dan Carpenter wrote: On Tue, Jul 08, 2014 at 08:23:02AM +0200, Fabio Falzoi wrote: I'm gonna fix it, thanks. And leave out the semi-colon as well. another way to do this is: static void rtsx_hex_dump(void *buf, size_t len) { #if DEBUG

[PATCH 1/2] staging: unisys: remove all proc entries from virtpci

2014-07-08 Thread Erik Arfvidson
This patch removes all proc entries from virtpci Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/virtpci/virtpci.c | 309 +-- 1 file changed, 1 insertion(+), 308 deletions(-)

Re: [PATCH 2/2] staging: unisys: added virtpci info entry

2014-07-08 Thread Greg KH
On Tue, Jul 08, 2014 at 01:21:31PM -0400, Erik Arfvidson wrote: - + /*debug_fs file and direcroty removal*/ + debugfs_remove(info_debugfs_entry); + debugfs_remove(virtpci_debugfs_dir); Odd indentation, comment style, and spelling typos :( Also, you can just remove

RE: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Haiyang Zhang
-Original Message- From: Richard Weinberger [mailto:rich...@nod.at] Sent: Tuesday, July 8, 2014 5:32 AM To: KY Srinivasan; Haiyang Zhang Cc: de...@linuxdriverproject.org; net...@vger.kernel.org; linux- ker...@vger.kernel.org; Richard Weinberger Subject: [PATCH] hyperv: Add netpoll

Re: [PATCH 2/2] staging: unisys: added virtpci info entry

2014-07-08 Thread Dan Carpenter
On Tue, Jul 08, 2014 at 01:21:31PM -0400, Erik Arfvidson wrote: This patch adds the virtpci debugfs directory and the info entry inside of it. Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com ---

RE: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread KY Srinivasan
-Original Message- From: Richard Weinberger [mailto:rich...@nod.at] Sent: Tuesday, July 8, 2014 2:32 AM To: KY Srinivasan; Haiyang Zhang Cc: de...@linuxdriverproject.org; net...@vger.kernel.org; linux- ker...@vger.kernel.org; Richard Weinberger Subject: [PATCH] hyperv: Add netpoll

[PATCH 2/2] staging: unisys: added virtpci info entry

2014-07-08 Thread Erik Arfvidson
This patch adds the virtpci debugfs directory and the info entry inside of it. Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/virtpci/virtpci.c | 122 ++- 1 file changed, 118

Re: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Richard Weinberger
Am 08.07.2014 20:01, schrieb KY Srinivasan: -Original Message- From: Richard Weinberger [mailto:rich...@nod.at] Sent: Tuesday, July 8, 2014 2:32 AM To: KY Srinivasan; Haiyang Zhang Cc: de...@linuxdriverproject.org; net...@vger.kernel.org; linux- ker...@vger.kernel.org; Richard

Re: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Richard Weinberger
Am 08.07.2014 19:55, schrieb Haiyang Zhang: -Original Message- From: Richard Weinberger [mailto:rich...@nod.at] Sent: Tuesday, July 8, 2014 5:32 AM To: KY Srinivasan; Haiyang Zhang Cc: de...@linuxdriverproject.org; net...@vger.kernel.org; linux- ker...@vger.kernel.org; Richard

Re: Anybody working on tidspbridge?

2014-07-08 Thread Suman Anna
Hi Peter, On 07/08/2014 09:36 AM, Greg KH wrote: On Tue, Jul 08, 2014 at 03:03:58PM +0200, Peter Meerwald wrote: Hello, Given the total lack of response here, I suggest just deleting the driver. No one has ever done the real work that is going to be required to get this code out of

RE: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Haiyang Zhang
-Original Message- From: Richard Weinberger [mailto:rich...@nod.at] Sent: Tuesday, July 8, 2014 2:40 PM To: Haiyang Zhang; KY Srinivasan Cc: de...@linuxdriverproject.org; net...@vger.kernel.org; linux- ker...@vger.kernel.org Subject: Re: [PATCH] hyperv: Add netpoll support Am

Re: [PATCH 2/2] staging: unisys: added virtpci info entry

2014-07-08 Thread Erik Arfvidson
Hi, Thanks for the comments and suggestions, I'll get them fixed and send it in the new patch. Cheers, Erik ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Richard Weinberger
Am 08.07.2014 22:03, schrieb KY Srinivasan: The VCPU the channel is bound to is available in the channel state. You could use the following code Fragment to ensure that the call is made on the right cpu: smp_call_function_single(dev-channel-target_cpu,

[PATCH v3 0/4] Staging: rts5208: Use standard debug features

2014-07-08 Thread Fabio Falzoi
Use standard debug features instead of relying on the custom configuration option CONFIG_RTS5208_DEBUG and a series of home grown macros. Changes in v3: * defined rtsx_hex_dump as a static inline function to avoid checkpatch errors Changes in v2: * defined rtsx_hex_dump macro to produce output

[PATCH v3 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-08 Thread Fabio Falzoi
Use print_hex_dump_bytes to have memory properly dumped only when DEBUG is defined. Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com --- drivers/staging/rts5208/ms.c| 4 ++-- drivers/staging/rts5208/rtsx_chip.c | 4 ++-- drivers/staging/rts5208/rtsx_scsi.c | 9 -

[PATCH v3 3/4] Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option

2014-07-08 Thread Fabio Falzoi
CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options instead. Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com --- drivers/staging/rts5208/Kconfig | 7 --- drivers/staging/rts5208/sd.c| 5 + 2 files changed, 1 insertion(+), 11 deletions(-) diff --git

[PATCH v3 4/4] Staging: rts5208: Fix a format specifier for dev_err

2014-07-08 Thread Fabio Falzoi
Fix an incorrect use of the %d format specifier in dev_err that caused a warning. Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com --- drivers/staging/rts5208/rtsx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c

Re: [PATCH v2] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-07-08 Thread gre...@linuxfoundation.org
On Tue, Jul 08, 2014 at 10:17:48PM +, Dexuan Cui wrote: -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Tuesday, July 8, 2014 17:27 PM To: Dexuan Cui Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev-

Re: [PATCH] staging: binder: add vm_fault handler

2014-07-08 Thread Greg KH
On Mon, Jun 02, 2014 at 06:17:59PM +0530, Vinayak Menon wrote: An issue was observed when a userspace task exits. The page which hits error here is the zero page. In binder mmap, the whole of vma is not mapped. On a task crash, when debuggerd reads the binder regions, the unmapped areas fall

Re: [PATCH v2 00/10] staging: rtl8723au: Fix USB macro functions

2014-07-08 Thread Greg KH
On Tue, Jul 01, 2014 at 12:06:59PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Greg, Here is v2 of patch 08/10 Sanitize USB read/write functions it should fix the 'do not do DMA on the stack' issue with the original version. With this patch 09/10 is

Re: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Richard Weinberger
Am 09.07.2014 00:47, schrieb Francois Romieu: Richard Weinberger rich...@nod.at : [...] This won't work as netpoll runs with IRQs disabled. -ndo_poll_controller() has to make sure that SKBs can be received and transmitted while IRQs are off. I thought calling the channel callback by hand

Re: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Francois Romieu
Richard Weinberger rich...@nod.at : [...] This won't work as netpoll runs with IRQs disabled. -ndo_poll_controller() has to make sure that SKBs can be received and transmitted while IRQs are off. I thought calling the channel callback by hand would be enough to receive SKBs. What are you

Re: [PATCH 054/115] staging: ced1401: remove typedef for TRANSAREA

2014-07-08 Thread Greg KH
On Mon, Jun 30, 2014 at 12:00:46PM +0200, Luca Ellero wrote: Signed-off-by: Luca Ellero luca.ell...@brickedbrain.com --- drivers/staging/ced1401/ced_ioc.c | 21 - drivers/staging/ced1401/usb1401.c |9 ++--- drivers/staging/ced1401/usb1401.h |6 +++--- 3

Re: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Richard Weinberger
Am 09.07.2014 00:47, schrieb Francois Romieu: Richard Weinberger rich...@nod.at : [...] This won't work as netpoll runs with IRQs disabled. -ndo_poll_controller() has to make sure that SKBs can be received and transmitted while IRQs are off. I thought calling the channel callback by hand

Re: [PATCH] staging: bcm: add missing blank lines after declarations

2014-07-08 Thread Greg Kroah-Hartman
On Fri, Jul 04, 2014 at 10:30:27PM +0200, Pawel Lebioda wrote: This patch fixes almost all 'missing blank line after declaration' warnings reported by checkpatch.pl for drivers/staging/bcm. Signed-off-by: Pawel Lebioda pawel.lebiod...@gmail.com Reviewed-by: Matthias Beyer

Re: [PATCH v2 01/18] staging: comedi: ni_65xx: filter interval register is 32-bit

2014-07-08 Thread Greg KH
On Thu, Jun 26, 2014 at 12:05:07PM -0700, H Hartley Sweeten wrote: According to the register programming manual, the filter interval register is 32-bit. Fix the writes to this register. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk

Re: [PATCH 1/3 V2] staging: cxt1e1: Remove useless OS_phystov() and OS_vtophys()

2014-07-08 Thread Greg KH
On Mon, Jun 30, 2014 at 03:56:11PM +0900, Daeseok Youn wrote: OS_phystov()/OS_vtophys() are replaced with phys_to_virt()/virt_to_phys(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- V2: use virt_to_phys()/phys_to_virt() instead of __pa()/__va(). drivers/staging/cxt1e1/musycc.c

Re: [PATCH 1/1] staging: cxt1e1: remove null test before kfree

2014-07-08 Thread Greg Kroah-Hartman
On Fri, Jul 04, 2014 at 09:58:15PM +0200, Fabian Frederick wrote: Fix checkpatch warning: WARNING: kfree(NULL) is safe this check is probably not required Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Daeseok Youn daeseok.y...@gmail.com Cc: de...@driverdev.osuosl.org Signed-off-by:

Re: [PATCH v3 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-08 Thread Greg KH
On Tue, Jul 08, 2014 at 11:38:30PM +0200, Fabio Falzoi wrote: Use print_hex_dump_bytes to have memory properly dumped only when DEBUG is defined. Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com --- drivers/staging/rts5208/ms.c| 4 ++-- drivers/staging/rts5208/rtsx_chip.c |

Re: [PATCH v3 1/4] Staging: rts5208: Replace custom macro with pr_debug

2014-07-08 Thread Greg KH
On Tue, Jul 08, 2014 at 11:38:29PM +0200, Fabio Falzoi wrote: Use pr_debug macro to control tracing verbosity through dynamic debug facility. For almost all of these, you should use dev_dbg() instead, as you have access to a struct device (well, you should have, you might have to dig for

Re: [PATCH v2 1/1] staging: lustre: libcfs: nidstrings.c - use ARRAY_SIZE macro

2014-07-08 Thread Greg KH
On Wed, Jul 02, 2014 at 04:23:55PM +0530, Anil Belur wrote: From: Anil Belur ask...@gmail.com - this patch replaces sizeof(a)/sizeof(a[0]) with the ARRAY_SIZE macro to get the number of nidstrings (and netstrfns) - v2: also for netstrfns Signed-off-by: Anil Belur ask...@gmail.com

Re: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Francois Romieu
Richard Weinberger rich...@nod.at : Am 09.07.2014 00:47, schrieb Francois Romieu: [...] What are you taking about ? netconsole does not need to receive. Isn't netconsole is only one user of netpoll ? Out of tree users are irrelevant. See netpoll related comments in

[PATCH 0/8] Drivers: scsi: storvsc: Bug fixes and improvements

2014-07-08 Thread K. Y. Srinivasan
In this patch set I have fixed a few bugs and implemented some enhancements. K. Y. Srinivasan (8): Drivers: scsi: storvsc: Change the limits to reflect the values on the host Drivers: scsi: storvsc: Filter commands based on the storage protocol version Drivers: scsi: storvsc: Fix a

[PATCH 2/8] Drivers: scsi: storvsc: Filter commands based on the storage protocol version

2014-07-08 Thread K. Y. Srinivasan
Going forward it is possible that some of the commands that are not currently implemented will be implemented on future Windows hosts. Make command filtering depend on the host version. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Cc: sta...@vger.kernel.org --- drivers/scsi/storvsc_drv.c |

[PATCH 5/8] Drivers: scsi: storvsc: Fix a bug in the handling of SRB status flags

2014-07-08 Thread K. Y. Srinivasan
SRB status can have additional information. Mask these out before processing SRB status. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Cc: sta...@vger.kernel.org --- drivers/scsi/storvsc_drv.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git

[PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

2014-07-08 Thread K. Y. Srinivasan
Host does not handle WRITE_SAME_16; filter this command out. This patch is required to handle large devices (greater than 2 TB disks). Signed-off-by: K. Y. Srinivasan k...@microsoft.com Cc: sta...@vger.kernel.org --- drivers/scsi/storvsc_drv.c |1 + 1 files changed, 1 insertions(+), 0

[PATCH 3/8] Drivers: scsi: storvsc: Fix a bug in handling VMBUS protocol version

2014-07-08 Thread K. Y. Srinivasan
Based on the negotiated VMBUS protocol version, we adjust the size of the storage protocol messages. The two sizes we currently handle or pre-win8 and post-win8. Win WS2012 R2, we are negotiating higher VMBUS protocol version than the win8 version. Make adjustments to correctly handle this.

[PATCH 1/8] Drivers: scsi: storvsc: Change the limits to reflect the values on the host

2014-07-08 Thread K. Y. Srinivasan
Hyper-V hosts can support multiple targets and multiple channels and larger number of LUNs per target. Update the code to reflect this. With this patch we can correctly enumerate all the paths in a multi-path storage environment. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Cc:

Re: [PATCH 1/1] staging: speakup: main.c - use time_after()

2014-07-08 Thread Greg KH
On Tue, Jul 01, 2014 at 12:30:22PM +0530, Anil Belur wrote: From: Anil Belur ask...@gmail.com - this patch fixes jiffies comparision with a safer function to prevent any overflows Signed-off-by: Anil Belur ask...@gmail.com --- drivers/staging/speakup/main.c | 2 +- 1 file changed, 1

[PATCH 8/8] drivers: scsi: storvsc: Correctly handle TEST_UNIT_READY failure

2014-07-08 Thread K. Y. Srinivasan
On some Windows hosts on FC SANs, TEST_UNIT_READY can return SRB_STATUS_ERROR. Correctly handle this. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Cc: sta...@vger.kernel.org --- drivers/scsi/storvsc_drv.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git

[PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-08 Thread K. Y. Srinivasan
Implement a simple abort handler. The host does not support Abort; just ensure that all inflight I/Os have been accounted for. Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- drivers/scsi/storvsc_drv.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff

[PATCH 7/8] drivers: scsi: storvsc: Set srb_flags in all cases

2014-07-08 Thread K. Y. Srinivasan
Correctly set SRB flags for all valid I/O directions. Some IHV drivers on the Windows host require this. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Cc: sta...@vger.kernel.org --- drivers/scsi/storvsc_drv.c | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git

Re: Asus TX201LA Driver for rtl8821ae

2014-07-08 Thread Greg KH
On Wed, Jul 09, 2014 at 02:34:12AM +0200, Mario wrote: linux-next.git-v3.14-drivers-staging rtl8821ae in conjunction with their linux-firmware-4c7327a35767c2133600376380c867dff3cbaa1c-rtlwifi It went wonderfully with uname-r (3.14.3-200.fc20.x86_64). Today, however, came update

Re: [PATCH 1/1] staging: android: logger: fixes not useful else warnings This patch fixes WARNING: else is not generally useful after a break or return

2014-07-08 Thread 黄钦佳
OK, I will have another try. However I have a question. As I'm from China, should I use the name in my identity card or I can use my own English name which getting used to? Says, Qinjia Huang(ID card) or Kinka Huang? Thanks 2014-07-08 8:51 GMT+08:00 Greg Kroah-Hartman g...@kroah.com: Your

RE: [PATCH v2] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-07-08 Thread Dexuan Cui
-Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Tuesday, July 8, 2014 17:27 PM To: Dexuan Cui Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev- de...@linuxdriverproject.org; plagn...@jcrosoft.com;

[PATCH v3] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-07-08 Thread Dexuan Cui
Currently the VSC has no chance to notify the VSP of the dirty rectangle on VM panic because the notification work is done in a workqueue, and in panic() the kernel typically ends up in an infinite loop, and a typical kernel config has CONFIG_PREEMPT_VOLUNTARY=y and CONFIG_PREEMPT is not set, so a

Re: [PATCH 1/1] staging: android: logger: fixes not useful else warnings This patch fixes WARNING: else is not generally useful after a break or return

2014-07-08 Thread Greg Kroah-Hartman
On Wed, Jul 09, 2014 at 09:41:42AM +0800, 黄钦佳 wrote: OK, I will have another try. However I have a question. As I'm from China, should I use the name in my identity card or I can use my own English name which getting used to? Says, Qinjia Huang(ID card) or Kinka Huang? Your real name please,

Re: [PATCH] Staging: comedi: check the return value of kobject_set_name

2014-07-08 Thread Anton Protopopov
2014-06-09 14:01 GMT+04:00 Ian Abbott abbo...@mev.co.uk: On 2014-06-07 14:56, Anton Protopopov wrote: Added a check of the return value of the kobject_set_name function. Signed-off-by: Anton Protopopov a.s.protopo...@gmail.com --- drivers/staging/comedi/comedi_fops.c | 9 - 1

Re: [PATCH v2 1/1] staging: lustre: libcfs: nidstrings.c - use ARRAY_SIZE macro

2014-07-08 Thread Anil Shashikumar Belur
On Wednesday 09 July 2014 05:18 AM, Greg KH wrote: Someone sent this same patch just before you did, sorry :( Ah - no worries - sorry for the noise. ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 1/1] staging: speakup: main.c - use time_after()

2014-07-08 Thread Anil Shashikumar Belur
On Wednesday 09 July 2014 05:21 AM, Greg KH wrote: This change is already in my tree, what branch are you working against? greg k-h Hi Greg, I am using staging.git. I try to make sure and rebase any changes in my branch with staging-next before sending out the patches. Not sure, if I am

Re: [PATCH] Staging: comedi: check the return value of kobject_set_name

2014-07-08 Thread gregkh
On Wed, Jul 09, 2014 at 08:24:06AM +0400, Anton Protopopov wrote: 2014-06-09 14:01 GMT+04:00 Ian Abbott abbo...@mev.co.uk: On 2014-06-07 14:56, Anton Protopopov wrote: Added a check of the return value of the kobject_set_name function. Signed-off-by: Anton Protopopov

Re: [PATCH 1/1] staging: speakup: main.c - use time_after()

2014-07-08 Thread Greg KH
On Wed, Jul 09, 2014 at 09:57:06AM +0530, Anil Shashikumar Belur wrote: On Wednesday 09 July 2014 05:21 AM, Greg KH wrote: This change is already in my tree, what branch are you working against? greg k-h Hi Greg, I am using staging.git. I try to make sure and rebase any changes in my

Re: [PATCH] Staging: comedi: check the return value of kobject_set_name

2014-07-08 Thread Anton Protopopov
09.07.2014 08:28, gregkh пишет: On Wed, Jul 09, 2014 at 08:24:06AM +0400, Anton Protopopov wrote: 2014-06-09 14:01 GMT+04:00 Ian Abbott abbo...@mev.co.uk: On 2014-06-07 14:56, Anton Protopopov wrote: Added a check of the return value of the kobject_set_name function. Signed-off-by: Anton

  1   2   >