this patch fixes some errors and warnings reported by checkpatch.pl
Signed-off-by: Zahari Doychev zahari.doyc...@linux.com
---
drivers/staging/bcm/PHSModule.h | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/bcm/PHSModule.h
Signed-off-by: Rahul Garg rahul.lnm...@gmail.com
---
drivers/staging/vt6655/tcrc.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6655/tcrc.c b/drivers/staging/vt6655/tcrc.c
index ed6868a..bf8d4c3 100644
--- a/drivers/staging/vt6655/tcrc.c
+++
On Sun, Jul 27, 2014 at 04:51:43PM +0530, Rahul Garg wrote:
Signed-off-by: Rahul Garg rahul.lnm...@gmail.com
---
drivers/staging/vt6655/tcrc.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
I know this is a tiny patch, but you are doing two different things
here, and
On 21/07/14 09:24, Himangi Saraogi wrote:
Hi,
I was looking at the possibility of using a managed interface for
iio_device_register in sca3000_probe. But this will lead to the
iio_device_unregister function being called after
sca3000_unconfigure_ring in the remove function. I have a few
This patch fixes the following errors and warnings:
ft1000_proc.c:26: WARNING: Use #include linux/io.h instead of asm/io.h
ft1000_proc.c:27: WARNING: Use #include linux/uaccess.h instead of
asm/uaccess.h
ft1000_proc.c:33: ERROR: Macros with multiple statements should be enclosed in
a do - while
On Sun, Jul 27, 2014 at 10:23:53AM -0700, Joe Perches wrote:
On Sun, 2014-07-27 at 19:08 +0200, Nicolas Thery wrote:
This patch fixes the following errors and warnings:
[]
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c
b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c
Fixed a coding style issue.
Signed-off-by: Sylvain Calador sylvain.cala...@gmail.com
---
drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.h
On Sun, Jul 27, 2014 at 10:35:38AM -0700, Greg KH wrote:
On Sun, Jul 27, 2014 at 10:23:53AM -0700, Joe Perches wrote:
On Sun, 2014-07-27 at 19:08 +0200, Nicolas Thery wrote:
This patch fixes the following errors and warnings:
[]
diff --git
On Sun, 2014-07-27 at 10:35 -0700, Greg KH wrote:
How about removing the proc files entirely, as I doubt they are really
needed :)
unnecessary proc entry removals are always good too.
___
devel mailing list
de...@linuxdriverproject.org
This patch add entries for ISL29018 and ISL29028 into trivial-devices.txt.
This patch fix following error.
./isl29018.c:643: WARNING: DT compatible string isl,isl29018
appears un-documented -- check Documentation/devicetree/bindings/
./isl29028.c:540: WARNING: DT compatible string isil,isl29028
On Sat, Jul 26, 2014 at 11:44:57AM +0100, Malcolm Priestley wrote:
On 26/07/14 10:18, Guillaume CLÉMENT wrote:
On Sat, Jul 26, 2014 at 10:24:30AM +0200, Guillaume CLÉMENT wrote:
Hi Malcolm,
On Sat, Jul 26, 2014 at 12:09:49AM +0100, Malcolm Priestley wrote:
Hi Guillaume
On 25/07/14 13:47,
On Thu, Jul 24, 2014 at 10:55:09PM -0400, Benjamin Romer wrote:
Move the /proc/visorchipset/parahotplug interface to sysfs under
/sys/devices/platform/visorchipset/parahotplug/deviceenabled and
/sys/devices/platform/visorchipset/parahotplug/devicedisabled.
The parahotplug interface is used
This patch started as a fix to some checkpatch complaints in ft1000
procfs code but Greg suggested to remove the procfs entries altogether:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2014-July/055594.html
Signed-off-by: Nicolas Thery nth...@gmail.com
---
On Fri, Jul 25, 2014 at 07:18:37PM +0300, Igor Bezukh wrote:
Removed redundant comments from device.h header file.
Signed-off-by: Igor Bezukh igb...@gmail.com
---
drivers/staging/vt6655/device.h | 82
++-
1 file changed, 21 insertions(+), 61
This patch fixes the warning generated by sparse: Using plain integer as NULL
pointer by replacing the offending 0s with NULL.
drivers/staging/lustre/lustre/lov/lov_obd.c:902:48: warning: Using plain
integer as NULL pointer
drivers/staging/lustre/lustre/lov/lov_obd.c:946:54: warning: Using
On Fri, Jul 25, 2014 at 07:37:45PM +0300, Igor Bezukh wrote:
Removed redundant comments from key.h header file.
Signed-off-by: Igor Bezukh igb...@gmail.com
---
drivers/staging/vt6655/key.h | 26 +++---
1 file changed, 7 insertions(+), 19 deletions(-)
Also doesn't
On Fri, Jul 25, 2014 at 07:35:12PM +0300, Igor Bezukh wrote:
Removed redundant comments from iwctl.h header file.
Signed-off-by: Igor Bezukh igb...@gmail.com
---
drivers/staging/vt6655/iwctl.h | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
Also doesn't apply :(
On Fri, Jul 25, 2014 at 07:45:53PM +0300, Igor Bezukh wrote:
Removed redundant comments from mac.h header file.
Signed-off-by: Igor Bezukh igb...@gmail.com
---
drivers/staging/vt6655/mac.h | 388
--
1 file changed, 188 insertions(+), 200
On Sun, 2014-07-27 at 19:08 +0200, Nicolas Thery wrote:
This patch fixes the following errors and warnings:
[]
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c
b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c
[]
@@ -23,34 +23,38 @@
[]
-#define seq_putx(m, message, size,
On 27/07/14 19:21, Greg Kroah-Hartman wrote:
On Sat, Jul 26, 2014 at 11:44:57AM +0100, Malcolm Priestley wrote:
On 26/07/14 10:18, Guillaume CLÉMENT wrote:
On Sat, Jul 26, 2014 at 10:24:30AM +0200, Guillaume CLÉMENT wrote:
Hi Malcolm,
On Sat, Jul 26, 2014 at 12:09:49AM +0100, Malcolm
On Sun, Jul 27, 2014 at 01:10:25AM +0200, Rickard Strandqvist wrote:
Replacing strncpy with strlcpy to avoid strings that lacks null terminate.
And replacing strncat with strlcat because of incorrect use.
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
On Fri, Jul 25, 2014 at 06:23:10PM +, Hartley Sweeten wrote:
On Friday, July 25, 2014 10:07 AM, Ian Abbott wrote:
`dio200_detach()` in amplc_dio200.c calls
`amplc_dio200_common_detach()` in amplc_dio200_common.c, followed by
`comedi_legacy_detach()` in ../drivers.c. Both of those
Fixed some coding style issues.
Signed-off-by: Jessica Yu j...@cowsay.org
---
drivers/staging/lustre/lustre/libcfs/linux/linux-module.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-module.c
Hello Kernel Developers!
I've attached a small patch to fix a coding style problem and make checkpatch
happy, as part of challenge 10 of Eudyptula.
Thank you
--- drivers/staging/lustre/lustre/ldlm/ldlm_extent.c.orig 2014-07-27
20:26:53.714161698 +0100
+++
On Sun, Jul 27, 2014 at 08:53:50PM -0700, Jessica Yu wrote:
Fixed some coding style issues.
What coding style issues? Be specific, and explicit.
Care to try it again?
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
On Sun, Jul 27, 2014 at 08:56:38PM +0100, Liviu I. wrote:
Hello Kernel Developers!
I've attached a small patch to fix a coding style problem and make checkpatch
happy, as part of challenge 10 of Eudyptula.
Thank you
--- drivers/staging/lustre/lustre/ldlm/ldlm_extent.c.orig
Fixed some coding style issues.
Signed-off-by: Jessica Yu j...@cowsay.org
---
drivers/staging/lustre/lustre/libcfs/linux/linux-module.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-module.c
Fixed some coding style issues:
- Removed spaces after open parenthesis and before close parenthesis
- Removed parentheses in some return statements, since return is not a
function
- Fixed a warning regarding the file_operations struct; it is
normally const
- Fixed pointer style issues (foo *
From: Santiago Torres torresari...@gmail.com
Added three newlines after variable declarations to pass checkpatch.pl.
Signed-off by: Santiago Torres-Arias torresari...@gmail.com
---
drivers/staging/rtl8712/mlme_linux.c |3 +++
1 file changed, 3 insertions(+)
diff --git
fixes all sparse warnings Using plain integer as NULL pointer
in drivers/staging/lustre
drivers/staging/lustre/lnet/lnet/api-ni.c:1665:32: warning: Using plain integer
as NULL pointer
drivers/staging/lustre/lnet/lnet/api-ni.c:1773:35: warning: Using plain integer
as NULL pointer
2014-07-27 20:44 GMT+02:00 Greg Kroah-Hartman gre...@linuxfoundation.org:
On Sun, Jul 27, 2014 at 01:10:25AM +0200, Rickard Strandqvist wrote:
Replacing strncpy with strlcpy to avoid strings that lacks null terminate.
And replacing strncat with strlcat because of incorrect use.
Signed-off-by:
Your email has won you ( £500,000.00 Pounds ) in the Heritage give away promo,
to confirm you are not a robot answer the below question who is the current
president of United States Of America (A)Hillary Clinton, (B)Barack Obama,
(C)Bill Gate,send the correct answer to wu.transfe...@qq.com,
fix coding style: use C89 comments, not C99
Signed-off-by: Rahul Garg rahul.lnm...@gmail.com
---
drivers/staging/vt6655/tcrc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/tcrc.c b/drivers/staging/vt6655/tcrc.c
index ed6868a..ddc5efd 100644
---
From: Anil Belur ask...@gmail.com
- Some of the functions internally call copy_{to,from}_user() but does
not use '__user'. this patch fixes missing __user annotations.
- this patch fixes the following sparse errors:
drivers/staging/cxt1e1/linux.c:488:33: warning: incorrect type in argument 2
On Mon, Jul 28, 2014 at 08:38:29AM +0530, Anil Belur wrote:
From: Anil Belur ask...@gmail.com
- Some of the functions internally call copy_{to,from}_user() but does
not use '__user'. this patch fixes missing __user annotations.
- this patch fixes the following sparse errors:
On Monday 28 July 2014 08:43 AM, Greg KH wrote:
On Mon, Jul 28, 2014 at 08:38:29AM +0530, Anil Belur wrote:
Signed-off-by: Anil Belur ask...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
This file is no
Hello Greg,
I didn't received automated email.
Regards
Sanjeev Sharma
-Original Message-
From: Greg KH [mailto:gre...@linuxfoundation.org]
Sent: Wednesday, July 23, 2014 8:55 PM
To: Sharma, Sanjeev
Cc: de...@driverdev.osuosl.org; swetl...@google.com; way...@gmail.com;
Remove extraneous space after open paren and before close paren.
Signed-off-by: Jessica Yu j...@cowsay.org
---
drivers/staging/lustre/lustre/libcfs/linux/linux-module.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Remove unnecessary parens from return statements, return is not a function
Signed-off-by: Jessica Yu j...@cowsay.org
---
drivers/staging/lustre/lustre/libcfs/linux/linux-module.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Fix pointer code style (foo * bar - foo *bar)
Signed-off-by: Jessica Yu j...@cowsay.org
---
drivers/staging/lustre/lustre/libcfs/linux/linux-module.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-module.c
I revisited my original patch and realized that it should be split into
separate parts.
Jessica Yu (4):
Staging: lustre: linux-module: fix pointer style issue
Staging: lustre: linux-module: remove unnecessary spaces
Staging: lustre: linux-module: remove extraneous parens
Staging: lustre:
41 matches
Mail list logo