Hello Kernel Developers!
I've attached a small patch to fix a coding style problem and make checkpatch
happy, as part of challenge 10 of Eudyptula.
Signed-off-by: Liviu Itoafa liviu.i.2...@gmail.com
Thank you
--- drivers/staging/lustre/lustre/ldlm/ldlm_extent.c.orig 2014-07-27
Fix your From header and read paragraph 1 of
Documentation/email-clients.txt
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
From: Anil Belur ask...@gmail.com
- private_ioctl() the internally calls copy_{to,from}_user() and does
not use '__user' while refrencing user space pointers.
- this patch passes __user annotation as a cast, when the pointer is
being refernced.
- this patch fixes the following sparse errors:
On 2014-07-27 19:45, Greg Kroah-Hartman wrote:
On Fri, Jul 25, 2014 at 06:23:10PM +, Hartley Sweeten wrote:
On Friday, July 25, 2014 10:07 AM, Ian Abbott wrote:
`dio200_detach()` in amplc_dio200.c calls
`amplc_dio200_common_detach()` in amplc_dio200_common.c, followed by
经济动作的三不原则mP.xls
Description: Binary data
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Remove redundant return statements at the end of void functions. This
addresses the checkpatch.pl warnings:
WARNING: void function return statements are not generally useful
#533: FILE: stub_rx.c:533:
+ return;
+}
#1125: FILE: vhci_hcd.c:1125:
+ return;
+}
#116: FILE: vhci_rx.c:116:
+
The `bustype` member of `struct pc236_board` variables is initialized,
but never used. Remove it along with the enumerated constants
associated with it.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pc236.c | 1 -
Add an optional callback function pointer to the board data to be called
when checking if an interrupt has occurred and to clear it if it has.
Since the callback returns `bool`, change a few other `int` values to
`bool` to match.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
The amplc_pc236 module is a low-level comedi driver that handles both
ISA boards (Amplicon PC36AT) and PCI boards (Amplicon PCI236). Since
support for each is controlled by two separate kernel configuration
options, the module needs a small number of CPP conditionals to handle
the three different
Move the static board data in `pc236_isa_boards[]` and `pc236_pci_board`
closer to where they are used.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pc236.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git
If an asynchronous command was running when the device is being
detached, the comedi core would have called the subdevice `cancel`
handler (`pc236_intr_cancel()`) before calling the `detach` handler
(`pc236_detach()`). Since the cancel handler disables hardware
interrupts (at least for the PCI236
Add an optional callback function pointer to the board data to be called
when interrupts are logically enabled or disabled to update the hardware
registers.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pc236.c | 18 ++
1 file changed, 14
`pc236_intr_enable()` and `pc236_intr_disable()` are very similar.
Combine them into a single function `pc236_intr_update()` with a
parameter to indicate whether interrupts are being enabled or disabled.
Change type type of the `enable_irq` member of the private data to
`bool` to match the
The amplc_pc236 driver currently handles both ISA and PCI devices and
uses a small amount of conditional compilation depending which are
enabled.
Move most of the functionality into a new module, amplc_pc236_common,
and split off support for PCI devices into a new module, amplc_pci236.
Retain
Can you folks please stop this challenge Bullshit? More checkpatch
fixes is not something we'll need at all.
Thanks you!
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Move the /proc/visorchipset/parahotplug interface to sysfs under
/sys/devices/platform/visorchipset/parahotplug/deviceenabled and
/sys/devices/platform/visorchipset/parahotplug/devicedisabled.
The parahotplug interface is used to deal with SR-IOV recovery situations on
s-Par guest partitions. The
Hi Christoph,
What kind of things that you think a newbie can fix ?
Thanks
--
Lucas Tanure
+55 (19) 988176559
On Mon, Jul 28, 2014 at 9:53 AM, Christoph Hellwig h...@infradead.org wrote:
Can you folks please stop this challenge Bullshit? More checkpatch
fixes is not something we'll need at
On 25 July 2014 at 00:02 Greg Kroah-Hartman gre...@linuxfoundation.org
wrote:
On Wed, Jul 23, 2014 at 09:04:38PM +0200, Fabian Frederick wrote:
Fix following sh-allmodconfig errors reported on kisskb
drivers/built-in.o: In function `ion_vm_fault':
ion.c:(.text+0x1f2d8f8): undefined
On 7/28/14, Lucas Tanure tan...@linux.com wrote:
Hi Christoph,
What kind of things that you think a newbie can fix ?
You can start working on fixing the pci_map_* and dma_map_* return
value checks with CONFIG_DMA_API_DEBUG enabled. A lot of drivers still
missing that...
Thanks
--
Lucas
On Mon, Jul 28, 2014 at 05:53:19AM -0700, Christoph Hellwig wrote:
Can you folks please stop this challenge Bullshit? More checkpatch
fixes is not something we'll need at all.
Greg and Dan have previously said that the staging tree is a good place
for newcomers to submit checkpatch cleanup
Some functions defined in r8192U_core.c and only used locally are marked as
static.
This fixes some warnings issued by sparse.
Signed-off-by: Antoine Schweitzer-Chaput anto...@schweitzer-chaput.fr
---
drivers/staging/rtl8192u/r8192U_core.c |8 +---
1 file changed, 5 insertions(+), 3
On Sunday, July 27, 2014 11:45 AM, Greg Kroah-Hartman wrote:
On Fri, Jul 25, 2014 at 06:23:10PM +, Hartley Sweeten wrote:
On Friday, July 25, 2014 10:07 AM, Ian Abbott wrote:
`dio200_detach()` in amplc_dio200.c calls
`amplc_dio200_common_detach()` in amplc_dio200_common.c, followed by
Hi,
these are my patches for the
drivers/staging/bcm/IPv6Protocol.c
file.
Please note: I'm not able to test these patches as I do not have the appropriate
hardware, I compiled them at least.
Kind regards,
Matthias Beyer
Matthias Beyer (6):
Staging: bcm: IPv6Protocol.c: Reindented
This patch removes the unneccessary blocks inside the case statements
and fixes the indentation of their content.
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/IPv6Protocol.c | 88 +-
1 file changed, 40 insertions(+), 48
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/IPv6Protocol.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/bcm/IPv6Protocol.c
b/drivers/staging/bcm/IPv6Protocol.c
index 5bcdaf9..c5bbb14 100644
---
This patch simplifies
if (a) {
x = false;
} else {
if (b) {
x = false;
}
}
to
if (a || b) {
x = false;
}
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/IPv6Protocol.c | 7 ++-
1 file changed, 2
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/IPv6Protocol.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/bcm/IPv6Protocol.c
b/drivers/staging/bcm/IPv6Protocol.c
index c5bbb14..c1b0367 100644
---
Removes whitespace before semicolons and add blank line after
declaration.
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/IPv6Protocol.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/bcm/IPv6Protocol.c
Convert this inline CamelCase function into a define.
For aesthetics, move the new define so it is associated with the
register define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The 'enable' and 'read_not_write' parameters are true/false flags. For
aesthetics, change their types to bool.
Rename the local variable 'input_select_bits' to simply 'bits' and reuse
it when enabling the dma on the m series and 660x counter variants.
Add a local variable for the 'mask' that is
Convert this enum into defines and rename the CamelCase symbols.
For aesthetics, move the new defines so they are associated with
the register define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Remove the BUG_ON(counter == NULL). If this can never happen and it
if did the driver should have died long before this function is called.
For aesthetics, rename the local variable 'retval' to simply 'ret'.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
The external callers of ni_tio_acknowledge_and_confirm() only call
this function to ack any pending errors or interrupts before starting
a new async command. Only the internal code in ni_tiocmd uses the
data that is optionally returned by this function.
Remove the export from
Convert this enum into defines and rename the CamelCase symbols.
For aesthetics, move the new defines so they are associated with
the register define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Convert this enum into defines and rename the CamelCase symbols.
For aesthetics, move the new defines so they are associated with
the register define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Convert this enum into defines and rename the CamelCase symbols.
For aesthetics, move the new defines so they are associated with
the register define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Convert this enum into defines and rename the CamelCase symbols.
For aesthetics, move the new defines so they are associated with
the register define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Convert this enum into defines and rename the CamelCase symbols.
For aesthetics, move the new defines so they are associated with
the register define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Convert this enum into defines and rename the CamelCase symbols.
For aesthetics, move the new defines so they are associated with
the register define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Convert this enum into defines and rename the CamelCase symbols.
For aesthetics, move the new defines so they are associated with
the register define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Fix the CamelCase issues by replacing the enums used for the register
bits with simple defines/macros and renaming the symbols.
Remove some unnecessary BUG() checks and tidy up some of the functions
in ni_tiocmd.
H Hartley Sweeten (19):
staging: comedi: ni_tio: tidy up
Remove the need for some of the local variables.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_tio.c | 17 ++---
1 file changed, 6 insertions(+),
Convert this enum and the others related to it into defines and
rename the CamelCase symbols.
For aesthetics, move the new defines so they are associated with
the register define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Convert this enum into defines and rename the CamelCase symbols.
For aesthetics, move the new defines so they are associated with
the register define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Convert this enum into defines and rename all the CamelCase symbols.
For aesthetics, move the new defines so they are associated with the
register define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |1 -
drivers/staging/rtl8188eu/include/rtl8188e_hal.h |1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/core/rtw_mlme.c |3 ++-
drivers/staging/rtl8188eu/include/rtw_mlme.h |3 +--
drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 10 +-
3 files changed, 4 insertions(+), 12 deletions(-)
diff
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/include/recv_osdep.h |2 --
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 12
2 files changed, 14 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/recv_osdep.h
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c|3 ++-
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h |2 +-
drivers/staging/rtl8188eu/os_dep/mlme_linux.c|9 +
3 files changed, 4 insertions(+), 10 deletions(-)
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/core/rtw_mlme.c |3 ++-
drivers/staging/rtl8188eu/include/rtw_mlme.h |3 +--
drivers/staging/rtl8188eu/os_dep/mlme_linux.c |9 +
3 files changed, 4 insertions(+), 11 deletions(-)
diff
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c|3 ++-
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h |2 +-
drivers/staging/rtl8188eu/os_dep/mlme_linux.c|8 +---
3 files changed, 4 insertions(+), 9 deletions(-)
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 13 -
drivers/staging/rtl8188eu/include/rtw_mlme.h |2 +-
drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 12 +---
3 files changed, 10 insertions(+), 17
-Original Message-
From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
Sent: Saturday, July 26, 2014 12:25 PM
To: KY Srinivasan
Cc: Martin K. Petersen; Sitsofe Wheeler; Christoph Hellwig;
gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
KY == KY Srinivasan k...@microsoft.com writes:
KY,
KY At the time thin-provisioning was defined, the discovery
KY information was first proposed in READ CAPACITY 16 command. And then
KY moved into the new dedicated VPD page - B2h. You can see the
KY information reported in this VPD page is
On Mon, 2014-07-28 at 19:05 +, KY Srinivasan wrote:
-Original Message-
From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
Sent: Monday, July 28, 2014 12:03 PM
To: KY Srinivasan
Cc: Martin K. Petersen; Sitsofe Wheeler; Christoph Hellwig;
From: Adrian Remonda adrianremo...@gmail.com
Signed-off-by: Adrian Remonda adrianremo...@gmail.com
---
drivers/staging/android/sw_sync.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/android/sw_sync.c
b/drivers/staging/android/sw_sync.c
index
Fix coding style issue.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
drivers/staging/android/sw_sync.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/android/sw_sync.c
b/drivers/staging/android/sw_sync.c
index a76db3f..863d4b1 100644
---
Fix coding style issue.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
drivers/staging/android/sync.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
index e7b2e02..69c16cb 100644
---
This patch makes checkpatch.pl script happy by fixing the following
warning:
WARNING: else is not generally useful after a break or return
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
drivers/staging/android/timed_gpio.c |5 +++--
1 file changed, 3 insertions(+), 2
This patch makes checkpatch.pl happy by fixing the following warning:
WARNING: Prefer kstrtotype to single variable sscanf
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
drivers/staging/android/timed_output.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff
This patch makes checkpatch.pl script happier by fixing all warnings
related to else statement after break or return.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
drivers/staging/bcm/Bcmchar.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
On Mon, 2014-07-28 at 21:09 -0300, Murilo Opsfelder Araujo wrote:
This patch makes checkpatch.pl script happier by fixing all warnings
related to else statement after break or return.
[]
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
[]
@@ -561,10 +561,10 @@ static
63 matches
Mail list logo
