From: Anil Belur ask...@gmail.com
v2:
- private_ioctl() internally calls copy_{to,from}_user() and does
not use '__user' which gives out several sparse warnings
- this patch adds __user annotation to the data member of struct
tagSCmdRequest as suggested by tklau...@distanz.ch
- sparse
On 2014-07-30 at 12:41:59 +0200, Anil Belur ask...@gmail.com wrote:
From: Anil Belur ask...@gmail.com
This line is only necessary if you're sending the patch on behalf of
someone else. Also there is no need to have the 1/1 in the Subject line
as you're only sending one patch, not an entire
On 2014-07-29 at 19:44:24 +0200, fernando.apesteg...@gmail.com
fernando.apesteg...@gmail.com wrote:
From: Fernando Apesteguia fernando.apesteg...@gmail.com
Add static to the definition of the pci device table.
Signed-off-by: Fernando Apesteguia fernando.apesteg...@gmail.com
This change is
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
v2: Be less aggressive in brace removal. Keep them for outer nested
'if's. Keep them in outer control statements where the inner control
statement uses braces.
---
drivers/staging/comedi/drivers/amplc_pci230.c | 120 ++
1
Remove some pairs of parentheses that don't really improve readability.
Also, reduce the amount of leading whitespace in a few places.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
v2: fixed conflict with v2 on an earlier patch in the series.
---
drivers/staging/comedi/drivers/amplc_pci230.c |
On 2014-07-30 01:54, Hartley Sweeten wrote:
On Tuesday, July 29, 2014 4:58 AM, Ian Abbott wrote:
Tidy up the amplc_pci230 driver a bit. There are more changes to come
after this. The only one of these that should alter the object code is
patch 06, which replaces a udelay() call with
- private_ioctl() internally calls copy_{to,from}_user() and does
not use '__user' which gives out several sparse warnings
- these sparse warnings were fixed by adding __user annotation to
the data member of struct tagSCmdRequest:
drivers/staging/vt6655/ioctl.c:78:51: warning: incorrect type
On Tue, Jul 29, 2014 at 03:09:43PM -0400, Benjamin Romer wrote:
-#define CHANNEL_u32_MISMATCH(chType, chName, field, expected, actual, fil, \
+#define CHANNEL_U32_MISMATCH(chType, chName, field, expected, actual, fil, \
lin, logCtx) \
On 2014-07-29 23:01, H Hartley Sweeten wrote:
Some of the comedi drivers use memory mapped I/O. Currently all of these
drivers save the ioremap'ed base address in their private data.
Add a new member, 'mmio' to the comedi_device struct so the drivers don't
need to carry it in the private data.
On Wed, Jul 30, 2014 at 06:29:57PM +0530, Anil Belur wrote:
- private_ioctl() internally calls copy_{to,from}_user() and does
not use '__user' which gives out several sparse warnings
- these sparse warnings were fixed by adding __user annotation to
the data member of struct tagSCmdRequest:
On Wed, Jul 30, 2014 at 12:53:47PM +0100, Ian Abbott wrote:
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
v2: Be less aggressive in brace removal. Keep them for outer nested
'if's. Keep them in outer control statements where the inner control
statement uses braces.
Really every
On 2014-07-30 14:41, Dan Carpenter wrote:
On Wed, Jul 30, 2014 at 12:53:47PM +0100, Ian Abbott wrote:
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
v2: Be less aggressive in brace removal. Keep them for outer nested
'if's. Keep them in outer control statements where the inner control
On Wed, Jul 30, 2014 at 03:04:03PM +0100, Ian Abbott wrote:
On 2014-07-30 14:41, Dan Carpenter wrote:
On Wed, Jul 30, 2014 at 12:53:47PM +0100, Ian Abbott wrote:
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
v2: Be less aggressive in brace removal. Keep them for outer nested
'if's. Keep
On Wed, Jul 30, 2014 at 1:43 PM, Tobias Klauser tklau...@distanz.ch wrote:
On 2014-07-29 at 19:44:24 +0200, fernando.apesteg...@gmail.com
fernando.apesteg...@gmail.com wrote:
From: Fernando Apesteguia fernando.apesteg...@gmail.com
Add static to the definition of the pci device table.
On 09/07/14 06:04, Dexuan Cui wrote:
Currently the VSC has no chance to notify the VSP of the dirty rectangle on VM
panic because the notification work is done in a workqueue, and in panic() the
kernel typically ends up in an infinite loop, and a typical kernel config has
On 2014-07-30 15:09, Dan Carpenter wrote:
On Wed, Jul 30, 2014 at 03:04:03PM +0100, Ian Abbott wrote:
On 2014-07-30 14:41, Dan Carpenter wrote:
On Wed, Jul 30, 2014 at 12:53:47PM +0100, Ian Abbott wrote:
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
v2: Be less aggressive in brace removal.
On Wednesday, July 30, 2014 7:28 AM, Ian Abbott wrote:
On 2014-07-30 15:09, Dan Carpenter wrote:
On Wed, Jul 30, 2014 at 03:04:03PM +0100, Ian Abbott wrote:
On 2014-07-30 14:41, Dan Carpenter wrote:
On Wed, Jul 30, 2014 at 12:53:47PM +0100, Ian Abbott wrote:
Signed-off-by: Ian Abbott
From: Fernando Apesteguia fernando.apesteg...@gmail.com
Add static to variable.
Signed-off-by: Fernando Apesteguia fernando.apesteg...@gmail.com
---
drivers/staging/vt6655/ioctl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/ioctl.c
Hello,
Add static to variable.
Signed-off-by: Fernando Apesteguia fernando.apesteg...@gmail.com
---
drivers/staging/vt6655/ioctl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/ioctl.c
b/drivers/staging/vt6655/ioctl.c
index 65e5933..cc6e47b
On Wed, Jul 30, 2014 at 9:16 PM, Guillaume Clement gclem...@baobob.org wrote:
Hello,
Add static to variable.
Signed-off-by: Fernando Apesteguia fernando.apesteg...@gmail.com
---
drivers/staging/vt6655/ioctl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Fernando Apesteguia fernando.apesteg...@gmail.com
Add static to debug method.
Signed-off-by: Fernando Apesteguia fernando.apesteg...@gmail.com
---
drivers/staging/rtl8192u/r8192U_core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Mon, Jul 28, 2014 at 11:07:40PM +0200, adrianremo...@gmail.com wrote:
From: Adrian Remonda adrianremo...@gmail.com
Your changelog text is up there in the subject, not down here in the
body of the email :(
___
devel mailing list
Thanks for reviewing my first patch, Joe. How about this new one,
guys?
-- 8 --
Consequently, made checkpatch.pl happy.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
drivers/staging/android/timed_gpio.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
On Wed, Jul 30, 2014 at 04:15:23PM +, Hartley Sweeten wrote:
On Wednesday, July 30, 2014 7:28 AM, Ian Abbott wrote:
On 2014-07-30 15:09, Dan Carpenter wrote:
On Wed, Jul 30, 2014 at 03:04:03PM +0100, Ian Abbott wrote:
On 2014-07-30 14:41, Dan Carpenter wrote:
On Wed, Jul 30, 2014 at
On Wed, Jul 30, 2014 at 11:33:41PM +0200, fernando.apesteg...@gmail.com wrote:
From: Fernando Apesteguia fernando.apesteg...@gmail.com
Add static to debug method.
Signed-off-by: Fernando Apesteguia fernando.apesteg...@gmail.com
---
drivers/staging/rtl8192u/r8192U_core.c |2 +-
1
On Wed, Jul 30, 2014 at 06:29:57PM +0530, Anil Belur wrote:
- private_ioctl() internally calls copy_{to,from}_user() and does
not use '__user' which gives out several sparse warnings
- these sparse warnings were fixed by adding __user annotation to
the data member of struct tagSCmdRequest:
On Tue, Jul 29, 2014 at 03:09:41PM -0400, Benjamin Romer wrote:
This patch switches all use of the U16 typedef to use the kernel's u16 type
instead.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
.../include/channels/controlframework.h| 18
On Mon, Jul 28, 2014 at 07:38:23PM -0300, Murilo Opsfelder Araujo wrote:
Fix coding style issue.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
drivers/staging/android/sw_sync.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/android/sw_sync.c
For forwarding scenarios, it will be useful to allocate larger
sendbuf. Make the necessary adjustments to permit this.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
---
drivers/net/hyperv/hyperv_net.h |2 +-
drivers/net/hyperv/netvsc.c |7 ++-
2 files changed, 3
On Mon, Jul 28, 2014 at 08:03:46PM -0300, Murilo Opsfelder Araujo wrote:
Fix coding style issue.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
drivers/staging/android/sync.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Tue, Jul 29, 2014 at 04:41:53PM +0530, Sanjeev Sharma wrote:
This is a patch to the r8190_rtl8256.c file that fixes
checkpatch reported space coding style issues.
Signed-off-by: Sanjeev Sharmasanjeev_sha...@mentor.com
Please use a ' ' character...
Please resend all of your patches, they
From: K. Y. Srinivasan k...@microsoft.com
Date: Wed, 30 Jul 2014 18:20:16 -0700
For forwarding scenarios, it will be useful to allocate larger
sendbuf. Make the necessary adjustments to permit this.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Please submit this with a proper Subject
For forwarding scenarios, it will be useful to allocate larger
sendbuf. Make the necessary adjustments to permit this.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
---
drivers/net/hyperv/hyperv_net.h |2 +-
drivers/net/hyperv/netvsc.c |7 ++-
2 files changed, 3
On Thursday 31 July 2014 05:38 AM, Greg KH wrote:
This patch doesn't apply against my tree at all, what did you make it
against?
Always work against linux-next, or the staging-next branch of my
staging.git tree on git.kernel.org.
thanks,
greg k-h
Hi,
I am working on staging.git. After
When a configration file is parsed with dgap_parsefile(),
makes nodes for saving configrations for board.
Making a node will allocate node memory and strings for saving
configrations with kstrdup().
So these are freed when dgap is unloaded or failed to initialize.
Signed-off-by: Daeseok Youn
AddedSigned-off-by: line that was missing.
Sanjeev Sharma (3):
staging:r8180: coding style: Fixed commenting style
staging:r8180: coding style: Fixed too long lines
staging:r8190: coding style: Fixed checkpatch reported Error
drivers/staging/rtl8192u/r8180_93cx6.c | 15 +--
This is a patch to the r8180_93cx6.h file that fixes
long lines along with some additional warning.
Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com
---
Changes in v2:
- Added signed-off field.
drivers/staging/rtl8192u/r8180_93cx6.h | 11 +++
1 file changed, 7 insertions(+), 4
This is a patch to the r8180_93cx6.c file that fixes
commenting style warning
Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com
---
Changes in v2:
- Added signed-off field.
drivers/staging/rtl8192u/r8180_93cx6.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff
This is a patch to the r8190_rtl8256.c file that fixes
checkpatch reported space coding style issues.
Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com
---
Changes in v2:
- Added space character in the signed-off-by field.
drivers/staging/rtl8192u/r8190_rtl8256.c | 169
Hi Greg,
I have resent all the patches in order. Please review.
Regards
Sanjeev Sharma
-Original Message-
From: Greg KH [mailto:gre...@linuxfoundation.org]
Sent: Thursday, July 31, 2014 5:51 AM
To: Sharma, Sanjeev
Cc: de...@driverdev.osuosl.org; oor...@gmail.com;
40 matches
Mail list logo
