Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support

On Mon, May 04, 2015 at 10:09:08PM +, Jose Rivera wrote: > > > + WARN_ON((int16_t)irq_count < 0); > > > > This code is doing "WARN_ON(test_bit(15, (unsigned long *)&irq_count));". > > That seems like nonsense. Anyway, just delete the WARN_ON(). > > > I disagree. This WARN_ON is check

Re: [PATCH 4/7] staging: fsl-mc: Upgraded MC bus driver to match MC fw 7.0.0

On Mon, May 04, 2015 at 11:58:13PM +, Jose Rivera wrote: > > > > On Tue, Apr 28, 2015 at 12:39:07PM -0500, J. German Rivera wrote: > > > - Migrated MC bus driver to use DPRC flib 0.6. > > > > What does this mean? What is a flib? > > > The DPRC flib is the API to manipulate DPRC objects. >

Re: [PATCHv2] staging: rtl8192e: fix wrong assignment

On Mon, May 04, 2015 at 10:17:09PM +0200, Mateusz Kulikowski wrote: > As far as I know (radio) noise is rarely above 0 dBm - if it is, you're doing > something wrong. > This means we can just change rtllib_rx_stats::noise to s8. I think it's hard to do that because these definitions are part of t

Re: [PATCHv2] staging: rtl8192e: fix wrong assignment

On Tue, May 05, 2015 at 12:19:57PM +0300, Dan Carpenter wrote: > On Mon, May 04, 2015 at 10:17:09PM +0200, Mateusz Kulikowski wrote: > > As far as I know (radio) noise is rarely above 0 dBm - if it is, you're > > doing something wrong. > > This means we can just change rtllib_rx_stats::noise to s8

Re: [PATCH v2] staging: comedi: daqboard2000: Use preferred comment style

On 03/05/15 21:49, Arno Tiemersma wrote: Use the preferred block comment style for the copyright and driver description header comments. Signed-off-by: Arno Tiemersma --- drivers/staging/comedi/drivers/daqboard2000.c | 196 +- 1 file changed, 98 insertions(+), 98 dele

Re: [PATCH 000/107] staging: comedi: tidy up ni_stc.h

On 01/05/15 22:58, H Hartley Sweeten wrote: The ni_stc.h header contains the DAQ-STC and board specific register information used by ni_mio_common.c to provide the "guts" for the National Instruments MIO drivers ni_atmio, ni_mio_cs, and ni_pcimio. Those drivers all currently include the ni_mio_co

RE: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support

> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Tuesday, May 05, 2015 3:49 AM > To: Rivera Jose-B46482 > Cc: de...@driverdev.osuosl.org; ag...@suse.de; a...@arndb.de; Sharma > Bhupesh-B45370; gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; >

RE: [PATCH 6/7] staging: fsl-mc: Add locking to serialize mc_send_command() calls

> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Thursday, April 30, 2015 7:59 AM > To: Rivera Jose-B46482 > Cc: gre...@linuxfoundation.org; a...@arndb.de; > de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; Yoder Stuart- > B08248; Sharma Bhupes

Re: Anybody working on rtl8712?

On 06/20/2014 10:52 PM, Christian Lamparter wrote: > rtl8192su development is chugging along. It just doesn't take place on > driverdev list. The driver reached "feature parity" with rtl8192cu for > some time ago. But as with rtl8192cu, I would recommend adding just > a friendly "printk". Yup, Rea

[PATCH 19/27] staging: fbtft: Allow compile test of GPIO consumers if !GPIOLIB

The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer functionality only, can still be compiled if GPIOLIB is not enabled. Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where appropriate. Sign

[PATCH 20/27] Staging: iio: Allow compile test of GPIO consumers if !GPIOLIB

The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer functionality only, can still be compiled if GPIOLIB is not enabled. Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where appropriate. Sign

[PATCH 18/27] staging: android: Allow compile test of GPIO consumers if !GPIOLIB

The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer functionality only, can still be compiled if GPIOLIB is not enabled. Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where appropriate. Sign

Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support

On Tue, May 05, 2015 at 04:08:49PM +, Jose Rivera wrote: > > Subject: Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support > > > > On Mon, May 04, 2015 at 10:09:08PM +, Jose Rivera wrote: > > > > > + WARN_ON((int16_t)irq_count < 0); > > > > > > > > This code is doing "WARN_ON(te

Re: Anybody working on rtl8712?

Xose Vazquez Perez writes: > On 06/20/2014 10:52 PM, Christian Lamparter wrote: > >> rtl8192su development is chugging along. It just doesn't take place on >> driverdev list. The driver reached "feature parity" with rtl8192cu for >> some time ago. But as with rtl8192cu, I would recommend adding ju

[PATCH 0/6] staging: comedi: gsc_hpdi: some clean-ups

Simplify (eliminate) the board type matching code, since only a single board type is supported. Reformat the comments. Fix the checkpatch issues. Use a better module description string. 1) staging: comedi: gsc_hpdi: tidy up comments 2) staging: comedi: gsc_hpdi: remove multiple board type suppo

[PATCH 3/6] staging: comedi: gsc_hpdi: usleep_range is preferred over udelay

Fix checkpatch issue: "CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt". `udelay()` is only called once from a place where sleeping is allowed. Replace it with a call to `usleep_range()` with a reasonable upper limit. Signed-off-by: Ian Abbott --- driver

[PATCH 6/6] staging: comedi: gsc_hpdi: use a better MODULE_DESCRIPTION()

Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/gsc_hpdi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/gsc_hpdi.c b/drivers/staging/comedi/drivers/gsc_hpdi.c index 51ab801..e929618 100644 --- a/drivers/staging/comedi/drivers/gsc

[PATCH 5/6] staging: comedi: gsc_hpdi: use PCI_DEVICE_SUB()

Use the `PCI_DEVICE_SUB()` macro in the initializer of the PCI module device table `gsc_hpdi_pci_table[]`. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/gsc_hpdi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/gsc_hpdi.c b/

[PATCH 4/6] staging: comedi: gsc_hpdi: prefer using the BIT() macro

Fix all the checkpatch issues "CHECK: Prefer using the BIT macro". Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/gsc_hpdi.c | 82 +++ 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/drivers/staging/comedi/drivers/gsc_hpdi.c b/drivers/st

[PATCH 1/6] staging: comedi: gsc_hpdi: tidy up comments

Use the usual style for block comments. Squash double spaces after comment opening sequence. Move some comments after opening braces to following line. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/gsc_hpdi.c | 59 ++- 1 file changed, 34 insertions(+)

[PATCH 2/6] staging: comedi: gsc_hpdi: remove multiple board type support

The code for determining which board type matches the PCI device ID is over-the-top since only a single board type is supported. Also, the method it uses match the PCI device ID to a board type is a little antiquated. Most comedi drivers for PCI devices use `driver_data` from the probed PCI devic

Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support

On Tue, 2015-05-05 at 11:08 -0500, Rivera Jose-B46482 wrote: > > > > to read what "goto error;" does. The error handling here calls > > > > devm_kfree() which is not needed... devm_ functions automatically > > > > clean up after themselves. This seems a pattern throughout. Do a > > > > search f

Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support

On Tue, 2015-05-05 at 19:40 +0300, Dan Carpenter wrote: > On Tue, May 05, 2015 at 04:08:49PM +, Jose Rivera wrote: > > > Subject: Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support > > > > > > On Mon, May 04, 2015 at 10:09:08PM +, Jose Rivera wrote: > > > > > > + WARN_ON((int16_

RE: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support

> -Original Message- > From: Wood Scott-B07421 > Sent: Tuesday, May 05, 2015 2:57 PM > To: Dan Carpenter > Cc: Rivera Jose-B46482; de...@driverdev.osuosl.org; Yoder Stuart-B08248; > Hamciuc Bogdan-BHAMCIU1; a...@arndb.de; Sharma Bhupesh-B45370; > gre...@linuxfoundation.org; linux-ker...@v

RE: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support

> -Original Message- > From: Wood Scott-B07421 > Sent: Tuesday, May 05, 2015 2:42 PM > To: Rivera Jose-B46482 > Cc: Dan Carpenter; de...@driverdev.osuosl.org; ag...@suse.de; > a...@arndb.de; Sharma Bhupesh-B45370; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; Yoder Stuart-B

Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support

On Tue, 2015-05-05 at 15:22 -0500, Rivera Jose-B46482 wrote: > > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Tuesday, May 05, 2015 2:57 PM > > To: Dan Carpenter > > Cc: Rivera Jose-B46482; de...@driverdev.osuosl.org; Yoder Stuart-B08248; > > Hamciuc Bogdan-BHAMCIU1; a...@

Re: [PATCH] hv_netvsc: remove unused variable in netvsc_send()

From: Jerry Snitselaar Date: Mon, 4 May 2015 10:57:16 -0700 > With commit b56fc3c53654 ("hv_netvsc: Fix a bug in netvsc_start_xmit()"), > skb variable is no longer used in netvsc_send. Remove variable and dead > code that depended on it. > > Cc: Haiyang Zhang > Cc: K. Y. Srinivasan > Signed-o

Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree

On Mon, May 04, 2015 at 02:07:13PM +, Simmons, James A. wrote: > >> > When is "soon"? How about, if I don't see some real work happening from > >> > you all in the next 2 months (i.e. before 4.1-final), I drop lustre from > >> > the tree in 4.2-rc1. Given that you all have had over 2 years to

[PATCH 018/141] staging: unisys: delbusdevices() doesn't need to be inline

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/visorchipset.h | 12 drivers/staging/unisys/visorchipset/visorchipset_main.c | 16 ++-- 2 files changed, 14 insertions(+), 14 deletions(-) diff --

[PATCH 007/141] staging: unisys: Don't zero struct elements which will be memset away

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys/visorchipset/visor

[PATCH 000/141] staging: unisys: s-Par driver rebuild series

This series of patches contains a complete overhaul of the s-Par driver tree, introducing a new (and significantly improved) driver called visorbus. This new module consolidates the support code from the many other modules that existed in our tree, allowing us to remove those, and makes much better

[PATCH 058/141] staging: unisys: remove typedef GUEST_PHYSICAL_ADDRESS to u64

From: Erik Arfvidson This patch removes typedef GUEST_PHYSICAL_ADDRESS to u64 Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- .../include/channels/controlvmchannel.h| 38 ++ drivers/staging/unisys/visorbus/visorchipset.c | 2 +- 2 files cha

[PATCH 009/141] staging: unisys: Get rid of uint usage

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys/vis

[PATCH 001/141] staging: unisys: Move module parameters around and mark static

From: Jes Sorensen Move the module parameters and make sure they are static. Signed-off-by: Jes Sorensen Tested-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/globals.h | 10 --- .../unisys/visorchipset/visorchipset_main.c| 31 +++--- 2 files chang

[PATCH 043/141] staging: unisys: visorchannel: visorchannel_create_overlap() is never used

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/visorbus.h | 9 + drivers/staging/unisys/visorbus/visorchannel.c | 20 2 files changed, 1 insertion(+), 28 deletions(-) diff --git a/drivers/stagi

[PATCH 005/141] staging: unisys: Remove some unnecessary parenthesis

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/visorchipset_umode.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visorchipset_umode.h b/drivers/staging/unisys/v

[PATCH 039/141] staging: unisys: cleanup visorbus_private.h

From: Prarit Bhargava visorbus_private.h contains code that is called from visorbus into the visorchipset code. Now that the visorchipset code has been brought into the visorbus directory, many of the declarations are not necessary and can be cleaned up. TODO: PARSER_WHICH_STRING enum only has

[PATCH 004/141] staging: unisys: Fix up a few cases of bad formatting

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/file.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/file.c b/drivers/staging/unisys/visorchipset/file.c in

[PATCH 047/141] staging: unisys: memregion: Eliminate unnecessary 'requested' flag

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorutil/memregion_direct.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/staging/unisys/visorutil/memregion_direct.c b/drivers/staging/unisys

[PATCH 013/141] staging: unisys: buffer_list_pool isn't used for anything

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- .../staging/unisys/visorchipset/visorchipset_main.c | 20 1 file changed, 20 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys/visor

[PATCH 006/141] staging: unisys: Remove unncessary parenthesis

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys/vis

[PATCH 032/141] staging: unisys: remove globals.h

From: Prarit Bhargava globals.h is only included in visorchannel.c and only contains 2 includes. These can be included directly in visorchannel.c. Signed-off-by: Prarit Bhargava Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/globals.h | 27 -- d

[PATCH 010/141] staging: unisys: Remove unused cache object counter

From: Jes Sorensen kmem_cache statistics are available through SLAB anyway Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visorchip

[PATCH 061/141] staging: unisys: remove unused #define MAX_SERIAL_NUM

From: Erik Arfvidson This patch simply removes #define MAX_SERIAL_NUM from iochannel.h Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/common-spar/include/channels/iochannel.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/unisys/

[PATCH 021/141] staging: unisys: Remove write-only variable g_diag_msg_hdr

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys/visorchipset/visor

[PATCH 049/141] staging: unisys: visorchipset: Use ioremap direction rather than heavy visor_memregion

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchipset.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/

[PATCH 079/141] staging: unisys: visorchannel_write(): Handle partial channel_header writes

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchannel.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchannel.c b/drivers/staging/unisys/visorbus/visorch

[PATCH 040/141] staging: unisys: visorchannel cleanup visorchannel_create_guts()

From: Prarit Bhargava The error handling in this function was broken and while looking at that I noticed that the whole function was in need of cleanup. This patch fixes the error handling, specifically if (!p) { visorchannel_destroy(p);

[PATCH 011/141] staging: unisys: Don't include timskmod.h

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/parser.h | 1 - drivers/staging/unisys/visorchipset/visorchipset.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/parser.h b/dri

[PATCH 008/141] staging: unisys: Do not initialize variables unnecessarily

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- .../unisys/visorchipset/visorchipset_main.c| 36 +++--- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/st

[PATCH 015/141] staging: unisys: findbus() doesn't need to be inline

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/visorchipset.h | 12 - .../unisys/visorchipset/visorchipset_main.c| 31 +++--- 2 files changed, 22 insertions(+), 21 deletions(-) diff --git a/d

[PATCH 003/141] staging: unisys: Eliminate globals.h

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/file.c | 6 +++-- drivers/staging/unisys/visorchipset/file.h | 2 -- drivers/staging/unisys/visorchipset/globals.h | 29 -- .../unisys

[PATCH 012/141] staging: unisys: Remove a couple of unnecessary blank lines

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/visorchipset.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visorchipset.h b/drivers/staging/unisys/visorchipset/visorchipset.h inde

[PATCH 099/141] staging: unisys: uislib.h: Remove unused cache allocation prototypes

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/uisutils.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/unisys/include/uisutils.h b/drivers/staging/unisys/include/uisutils.h index c7d0ba8..4514772 10064

[PATCH 057/141] staging: unisys: Eliminate unused visorchannel_dump_section()

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/visorbus.h | 2 -- drivers/staging/unisys/visorbus/visorchannel.c | 37 -- 2 files changed, 39 deletions(-) diff --git a/drivers/staging/unisys/include

[PATCH 029/141] staging: unisys: unify channel attributes into visorbus_main.c

From: Prarit Bhargava The code in channel_attr.[ch] only creates sysfs files and is called only in visorbus_main.c. This code should be unified into visorbus_main.c. There are some functions that have been made static. Signed-off-by: Prarit Bhargava Signed-off-by: Benjamin Romer --- driver

[PATCH 089/141] staging: unisys: remove timskmod.h and procobjecttree.h

From: Erik Arfvidson This patch move the needed linux include files from timskmod.h to the files that calls those include. Also procobjecttree.h is removed since it is dead code. Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/periodic_work.h

[PATCH 138/141] staging: unisys: Update diag serverity enum

From: David Kershner Give the enum the correct values instead of based on other values. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/diagchannel.h | 34 1 file changed, 10 insertions(+), 24 deletions(-) diff --git

[PATCH 109/141] staging: unisys: Move diagchannel to include

From: David Kershner Diagchannel needs to go to standard include. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- .../common-spar/include/channels/diagchannel.h | 427 - drivers/staging/unisys/include/diagchannel.h | 427 + 2 f

[PATCH 078/141] staging: unisys: visorchannel_read(): Use memcpy_fromio() directly

From: Jes Sorensen Note, this changes the behavior of visorchannel_read(). The old code would return the channel header, if the offset argument was 0, and the caller tried to read beyond the size of the visorchannel. Note this only worked for offset == 0, but not for (offset > 0) && (offset < hea

[PATCH 080/141] staging: unisys: visorchannel_create_guts(): Use visorchannel_read()

From: Jes Sorensen There is no benefit to calling visor_memregion_read() at this point. Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchannel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/v

[PATCH 091/141] staging: unisys: fix visorbus Kconfig

Removing visorutil made it impossible to build visorbus. Remove the config setting from the Kconfig so the module can be enabled in the build. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/sta

[PATCH 136/141] staging: unisys: Removed unused entries from struct visor_channeltype_descriptor

From: Jes Sorensen min_size/max_size aren't used anywhere, and they were just causing headaches in the drivers being ported over to the new interfaces. Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/visorbus.h | 2 -- 1 file changed, 2 deletions(-

[PATCH 016/141] staging: unisys: Remove unused typedef SPARREPORTEVENT_COMPLETE_FUNC

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/visorchipset.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visorchipset.h b/drivers/staging/unisys/visorchipset/visorchipset.h ind

[PATCH 134/141] staging: unisys: Hide vbus_hdr_info from public visor_device

From: Don Zickus The vbus_hdr_info is a private struct that is used to communicate bus info over the channel. Currently it is public in visorbus.h and causes compile problems (missing header). Fix this by allocating memory and turn the public element into a pointer. Signed-off-by: Don Zickus

[PATCH 041/141] staging: unisys: visorchannel some general function cleanups

From: Prarit Bhargava Just some cleanups for visorchannel.c, and removal of safe_sig_queue_validate() which is dead code. Signed-off-by: Prarit Bhargava Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchannel.c | 110 + 1 file changed, 41 inserti

[PATCH 118/141] staging: unisys: Properly move version file into bus attr

From: Don Zickus Simplify things by moving the version file handling into the core. Signed-off-by: Don Zickus Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorbus_main.c | 66 +++-- 1 file changed, 30 insertions(+), 36 deletions(-) diff --git a/drive

[PATCH 085/141] staging: unisys: add acpi pnp driver

From: Prarit Bhargava According to Unisys, another OS detects the PNP0A07 as the auto load device. We can also do this in the linux kernel by simply converting the driver over to the ACPI driver model. Notes: This changes the usage of __init and it had to be removed from some functions to avoid

[PATCH 042/141] staging: unisys: fix sig_read_data and sig_read_data functions

From: Prarit Bhargava The sig_read_data() and sig_write_data() functions are involved in 2 steps of calls. They really don't need to be and this makes for much simpler code. Signed-off-by: Prarit Bhargava Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchannel.c | 46 +

[PATCH 059/141] staging: unisys: remove unused enum from controlvmchannel.h

From: Erik Arfvidson This patch removes this enum since it is unused Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- .../staging/unisys/common-spar/include/channels/controlvmchannel.h| 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/unisys/common-spar

[PATCH 106/141] staging: unisys: Move controlframework into controlvmchannel.h

From: David Kershner Controlframework was only needed by controlvmchannel, move the structures into that header file. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- .../include/channels/controlframework.h| 62 -- .../include/channels/controlvmc

[PATCH 097/141] staging: unisys: Remove wrapper around parser_init_guts()

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchipset.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/vi

[PATCH 023/141] staging: unisys: add visorbus driver

From: Erik Arfvidson This base driver provides bus functionality to visorhid, visorhba, and visornic which will be later added to our driver base. Visorbus supports sPar bus model and manages bus specific functionality. It maintains the sysfs subtree /sys/devices/visorbus*/.It is responsible for

[PATCH 020/141] staging: unisys: No point in checking != 0

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- .../unisys/visorchipset/visorchipset_main.c| 26 +++--- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/st

[PATCH 028/141] staging: unisys: unify businst attributes into visorbus_main.c

From: Prarit Bhargava The code in businst_attr.[ch] only creates sysfs files and is called only in visorbus_main.c. This code should be unified into visorbus_main.c. There are some functions that have been made static. Signed-off-by: Prarit Bhargava Signed-off-by: Benjamin Romer --- drivers

[PATCH 139/141] staging: unisys: Remove unneeded fields in diagchannel.h

From: David Kershner Diagchannel.h is used primarily for the diagnostics channel. The diagnostics channel is not being used by linux guests currently, so the majority of the file is not needed. What is left is what is needed to perform postcode vmcalls. Those postcodes will eventually end up in t

[PATCH 122/141] staging: unisys: Add visor device find routine

From: Don Zickus If we are going to remove the bus_info structs than we need a way to find the devices when the *_create/destroy cmds are sent over the vmchannel. This function crudely impements what pci has. It takes a bus_no and dev_no and finds the matching 'struct visor_device'. This funct

[PATCH 083/141] staging: unisys: Finally remove the last remnants of memregion

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/visorbus.h | 1 - drivers/staging/unisys/visorbus/visorchannel.c | 53 ++ drivers/staging/unisys/visorchannel/globals.h | 1 - drivers/staging

[PATCH 053/141] staging: unisys: decouple visor_memregion_{read, write}()

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- .../staging/unisys/visorutil/memregion_direct.c| 26 -- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/drivers/staging/unisys/visorutil/memregion_direct.c b/drivers/staging

[PATCH 113/141] staging: unisys: remove remaining utility headers

From: David Kershner remove uisqueue.h, uisthread.h, and uisutils.h replace HOSTADDRESS with u64 remove "uisutils.h" from header list in visorchipset.c Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/uisqueue.h | 396

[PATCH 102/141] staging: unisys: visorchipset_init(): Simplify initial checks

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchipset.c | 40 +++--- 1 file changed, 17 insertions(+), 23 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/uni

[PATCH 036/141] staging: unisys: remove file.c and pass functionality to visorchipset

From: Erik Arfvidson This patch trasitions the include files and functions from file.c and places them into visorchipset_main.c Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/Makefile | 2 +- drivers/staging/unisys/visorchipset/file

[PATCH 019/141] staging: unisys: Avoid some == 0 checks

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/file.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/file.c b/drivers/staging/unisys/visorchipset/file.c

[PATCH 037/141] staging: unisys: move parser.[ch] functionality into visorchipset

From: Erik Arfvidson This patch moves includes files and functions from parser.[ch] into visorchipset. Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorbus_main.c| 2 +- drivers/staging/unisys/visorchipset/Makefile | 2 +- driv

[PATCH 130/141] staging: unisys: Convert the device attributes to visor_device

From: Don Zickus Convert the device attribute files to properly use visor_device. This removes a whole bunch of checks and assumptions and simplifies the code. Everything is straightforward. No testing down as I can't mimic channel info correctl. Signed-off-by: Don Zickus Signed-off-by: Benja

[PATCH 075/141] staging: unisys: memregion: Eliminate visor_memregion_get_*() functions

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchannel.c | 7 +++ drivers/staging/unisys/visorutil/memregion.h| 3 --- drivers/staging/unisys/visorutil/memregion_direct.c | 21 - 3 fil

[PATCH 124/141] staging: unisys: Add checks for creation

From: Don Zickus There was a bunch of channel creation checks before the visorchannel_create function was called, moving some of those checks inside. This keeps the outside code cleaner and handles the situation where a caller forgets to make these checks. Signed-off-by: Don Zickus Signed-off-

[PATCH 121/141] staging: unisys: Prep for removing 'info' structs

From: Don Zickus The visorbus driver has three _info structs lying around (device, bus, channel) that store subsets of info from the bigger structs. Having these structs around make resource handling very difficult and more complicated than it needs to be. Use the device infrastructure and inst

[PATCH 111/141] staging: unisys: Get rid of references to common-spar

From: David Kershner Makefiles still had common-spar listed in ccflags. This gets rid of them. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/Makefile | 2 -- drivers/staging/unisys/visorchannel/Makefile | 2 -- 2 files changed, 4 deletion

[PATCH 104/141] staging: unisys: Remove appos_subsystems.h

From: David Kershner Get rid of common-spar/include/diagnostics/appos_subsystems.h. No one is using it. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- .../include/diagnostics/appos_subsystems.h | 310 - drivers/staging/unisys/include/uisutils.h

[PATCH 081/141] staging: unisys: Eliminate visor_memregion_read()

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchannel.c | 11 +-- drivers/staging/unisys/visorutil/memregion.h| 2 -- drivers/staging/unisys/visorutil/memregion_direct.c | 12 3 files cha

[PATCH 065/141] staging: unisys: controlvmchannel.h comment aligment and cleanup

From: Erik Arfvidson This patch is a comment aligment and cleanup for controlvmchannel.h. Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- .../include/channels/controlvmchannel.h| 231 ++--- 1 file changed, 107 insertions(+), 124 deletions(-) diff -

[PATCH 098/141] staging: unisys: visorchipset: Remove unused cache allocator

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchipset.c | 39 -- 1 file changed, 39 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visor

[PATCH 046/141] staging: unisys: memregion: Use proper errno for mapit()

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- .../staging/unisys/visorutil/memregion_direct.c| 28 +- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/drivers/staging/unisys/visorutil/memregion_direct.c b/drivers/stagin

[PATCH 050/141] staging: unisys: visorchipset.c: No need to include memregion.h anymore

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchipset.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c index 9390ed6..e0f

[PATCH 082/141] staging: unisys: Eliminate visor_memregion_write()

From: Jes Sorensen visorchannel's signal code should call visorchannel_write() directly. This is more consistent and cleaner, and allows us to remove the last memregion call. Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchannel.c | 34

[PATCH 100/141] staging: unisys: visorchipset_file_{init, cleanup}(): mark static

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchipset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset

[PATCH 092/141] staging: unisys: remove visorutil from top level Makefile

The visorutil directory is still mentioned in the top level makefile for the Unisys drivers, so remove it. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/unisys/Makefile b/drivers/staging/unisys/Makefile index

[PATCH 014/141] staging: unisys: Remove write-only visorchipset_bus_info.dev_no

From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/visorchipset.h | 1 - drivers/staging/unisys/visorchipset/visorchipset_main.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visor

[PATCH 034/141] staging: unisys: remove visorchipset_umode.h

From: Erik Arfvidson removes visorchipset_umode.h and pass functionality to visorchipset.h Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/file.c | 1 - drivers/staging/unisys/visorchipset/visorchipset.h | 1 + .../unisys/visorchip

  1   2   >