Remove alloc failed messages where not needed to make checkpatch.pl happy.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git
This function never supported checking of MAC block.
Instead of printing several warnings - print it once and exit.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
Use pr_debug() instead.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtllib.h| 1 -
drivers/staging/rtl8192e/rtllib_module.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h
Assert macro printed warning message (and was used once).
Remove it, and add netdev_warn() in place where it was called.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 5 +++--
drivers/staging/rtl8192e/rtllib_debug.h | 8
Use print_hex_dump_bytes() if VERBOSE_DEBUG is enabled.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtl819x_BAProc.c | 20
drivers/staging/rtl8192e/rtl819x_HTProc.c | 7 +--
drivers/staging/rtl8192e/rtllib.h | 11
Fix most of remaining PREFER_PR_LEVEL warnings in rtllib.
Replace printk() with netdev_* if possible, pr_* in other cases.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +-
drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 67
Improve readability and make checkpatch happy.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtllib_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c
b/drivers/staging/rtl8192e/rtllib_rx.c
This header is not used - remove it to make driver code smaller.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtl8192e/rtl_crypto.h | 382 -
1 file changed, 382 deletions(-)
delete mode 100644
This messages are not needed, as failure is reported earlier in code.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 1 -
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 1 -
2 files changed, 2 deletions(-)
diff
Replace :? with min_t for readability. Remove check that is always false.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtllib_softmac_wx.c | 8 +---
drivers/staging/rtl8192e/rtllib_wx.c | 3 +--
2 files changed, 2 insertions(+), 9
Reindent lines to make checkpatch happy.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 83 +++---
drivers/staging/rtl8192e/rtllib_rx.c | 24 +
2 files changed, 67 insertions(+), 40
WOL capability was reported in an awkward way - print it nicely.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtl8192e/rtl_pm.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_pm.c
Use netdev_dbg() instead.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtllib.h| 6
drivers/staging/rtl8192e/rtllib_rx.c | 58
drivers/staging/rtl8192e/rtllib_tx.c | 5 ++--
3 files changed, 35
On May 21, 2015, at 11:12 AM, Dan Carpenter wrote:
Oh, sorry, I didn't read your patch very carefully. It won't cause a
deadlock. But I'm going to assume it's still not right until lustre
expert Acks it.
I just took a closer look and it appears original code is buggy and the patch
just
Use pr_* where needed (rtllib init code).
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtllib.h| 2 --
drivers/staging/rtl8192e/rtllib_module.c | 8 +++-
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git
Replace all RTLLIB_DEBUG(RTLLIB_DL_ERR, *) calls with netdev_err()
for errors that really should be reported to user.
Use netdev_warn() for the rest.
Rephrase some of the messages to make them more readable/compact.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
Use dedicated macro to compare ethernet addresses in probe_rq_parse().
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtllib_softmac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c
Move MFIE_TYPE_GENERIC handler to rtllib_parse_mife_generic() function.
Code was not altered significantly, therefore in some places it generates
LONG_LINE checkpatch.pl warnings.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtllib_rx.c | 397
Use netdev_dbg() instead of RTLLIB_DEBUG_WX().
Rewrite some messages to be more readable.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtllib.h| 1 -
drivers/staging/rtl8192e/rtllib_wx.c | 33 -
2 files changed,
Add __aligned(2) into ethernet addresses allocated on stack or in non-packed
structures. Use ETH_ALEN as array length in places where it was hardcoded to 6.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 +++-
Replace memcpy() with ether_addr_copy() where possible to make
checkpatch.pl happy.
Change was target tested (download 1Mb file over WPA2 network)
with BUG trap for unaligned addresses in ether_addr_copy()
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
It is neither compiled nor used in rtl8192e.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtllib_crypt.c | 254
drivers/staging/rtl8192e/rtllib_crypt.h | 34 -
2 files changed, 288 deletions(-)
delete mode
- Extract frame_ctl once and use it as variable.
- Drop endian conversion in is_beacon() function
(used in simplified function only)
- Simplify debug messages
- Invert STYPE checks in debug messages - it is valid
as only BEACON and PROBE_RESP are allowed
Signed-off-by: Mateusz Kulikowski
Use netdev_dbg() instead, remove duplicated logs.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtllib.h| 1 -
drivers/staging/rtl8192e/rtllib_rx.c | 101 ---
drivers/staging/rtl8192e/rtllib_wx.c | 12 +++--
3
- Pass extra argument (rtllib_device) to rtllib_parse_qos_info_param_IE()
and update_network()
- Replace RTLLIB_DEBUG_QOS() with netdev_dbg()
- Remove RTLLIB_DEBUG_QOS()
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtllib.h| 1 -
Loaded Hyper-V module will use these functions to disable CPU hotplug
under certain circumstances. Convert cpu_hotplug_disabled to a counter
(protected by cpu_add_remove_lock) to support e.g. disable - disable -
enable call sequences.
Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com
---
Changes since v1:
- Make cpu_hotplug_disabled a counter [Radim Krčmář]
Export cpu_hotplug_enable/cpu_hotplug_disable functions from cpu.c and use
them instead of altering smp_ops.cpu_disable in Hyper-V vmbus module.
Vitaly Kuznetsov (2):
cpu-hotplug: export
Commit e513229b4c38 (Drivers: hv: vmbus: prevent cpu offlining on newer
hypervisors) was altering smp_ops.cpu_disable to prevent CPU offlining.
We can bo better by using cpu_hotplug_enable/disable functions instead of
such hard-coding.
Reported-by: Radim Krčmář rkrc...@redhat.com
Signed-off-by:
On Thursday, May 21, 2015 12:57:40 PM Xose Vazquez Perez wrote:
On 05/07/2015 12:37 AM, Jes Sorensen wrote:
Christian Lamparter chunk...@googlemail.com writes:
But as I mentioned before: I would recommend adding just a _friendly_
printk
I'm happy adding a printk - what would you
101 - 129 of 129 matches
Mail list logo
