Re: [PATCH] Staging: sm750fb: ddk750_dvi.h: Fix brace coding style issue

2015-07-10 Thread Dan Carpenter
On Fri, Jul 10, 2015 at 08:56:05AM +0200, Anders Fridlund wrote: > Sorry, for that. Do I need to re-submit the patch(es), or should I > only change it for future patches? For future patches. regards, dan carpenter ___ devel mailing list de...@linuxdriv

Re: [PATCH 1/3] staging: wilc1000: wilc_wlan_cfg_commit(): replace integer with pointer

2015-07-10 Thread Johnny Kim
On 2015년 07월 10일 15:20, Julian Calaby wrote: Hi Johnny, On Fri, Jul 10, 2015 at 3:55 PM, Johnny Kim wrote: A argument of wilc_wlan_cfg_commit() is address of structure. But because the size is restricted to 32bit, it is not correct for 64bit machine. So, this changes the interger value to ob

Re: [PATCH 2/3] staging: wilc1000: wilc_wlan_cfg_get(): replace integer with void pointer

2015-07-10 Thread Johnny Kim
On 2015년 07월 10일 15:25, Julian Calaby wrote: Hi Johnny, On Fri, Jul 10, 2015 at 3:55 PM, Johnny Kim wrote: Last argument of wilc_wlan_cfg_get function is actually structure's address. This should be changed to be compatible with 64bit machine. Because wilc_wlan_cfg_get function is mapped by f

Re: [PATCH 1/3] staging: wilc1000: wilc_wlan_cfg_commit(): replace integer with pointer

2015-07-10 Thread Julian Calaby
Hi Johnny, On Fri, Jul 10, 2015 at 5:58 PM, Johnny Kim wrote: > > On 2015년 07월 10일 15:20, Julian Calaby wrote: >> >> Hi Johnny, >> >> On Fri, Jul 10, 2015 at 3:55 PM, Johnny Kim wrote: >>> >>> A argument of wilc_wlan_cfg_commit() is address of structure. >>> But because the size is restricted to

Re: [PATCH 2/3] staging: wilc1000: wilc_wlan_cfg_get(): replace integer with void pointer

2015-07-10 Thread Julian Calaby
Hi Johnny, On Fri, Jul 10, 2015 at 6:11 PM, Johnny Kim wrote: > > On 2015년 07월 10일 15:25, Julian Calaby wrote: >> >> Hi Johnny, >> >> On Fri, Jul 10, 2015 at 3:55 PM, Johnny Kim wrote: >>> >>> Last argument of wilc_wlan_cfg_get function is actually structure's >>> address. >>> This should be cha

[PATCH 4/5] staging: rtl8188eu: remove ROMVer from struct HAL_VERSION

2015-07-10 Thread Jakub Sitnicki
ROM version on RTL8188EU is always 0. Signed-off-by: Jakub Sitnicki --- drivers/staging/rtl8188eu/hal/hal_com.c | 2 +- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 2 -- drivers/staging/rtl8188eu/include/HalVerDef.h | 2 -- 3 files changed, 1 insertion(+), 5 deletions(-) d

[PATCH 2/5] staging: rtl8188eu: remove ICtype from struct HAL_VERSION

2015-07-10 Thread Jakub Sitnicki
IC type on RTL8188EU is always 8188E. Remove it and all the macros that check it. Signed-off-by: Jakub Sitnicki --- drivers/staging/rtl8188eu/hal/hal_com.c | 13 + drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 1 - drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +-

[PATCH 0/5] staging: rtl8188eu: Clean up rtl8188e_read_chip_version()

2015-07-10 Thread Jakub Sitnicki
This series of clean-up patches is a result of a review of rtl8188e_read_chip_version(). The motivation for getting it in shape is that this function could serve as read_chip_version function callback in struct rtl_hal_ops, if this driver gets converted to use rtl_usb (rtlwifi). Jakub Sitnicki (5

[PATCH 1/5] staging: rtl8188eu: remove RegulatorMode from struct hal_data_8188e

2015-07-10 Thread Jakub Sitnicki
This field is not used anywhere. Also, kill the rt_regulator_mode enum which exists just for this field. Signed-off-by: Jakub Sitnicki --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 3 --- drivers/staging/rtl8188eu/include/rtl8188e_hal.h | 7 --- 2 files changed, 10 deletions(-)

[PATCH 3/5] staging: rtl8188eu: remove RFtype from struct HAL_VERSION

2015-07-10 Thread Jakub Sitnicki
RFtype in struct HAL_VERSION duplicates rf_type in struct hal_data_8188e, and does not change. Remove it and the macros that test it. Signed-off-by: Jakub Sitnicki --- drivers/staging/rtl8188eu/hal/hal_com.c | 12 +--- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 15 ++-

[PATCH 5/5] staging: rtl8188eu: fold rtl8188e_read_chip_version() into rtl8188e_SetHalODMVar()

2015-07-10 Thread Jakub Sitnicki
Both rtl8188e_read_chip_version() and ReadChipVersion8188E() are used only in one place. Make ReadChipVersion8188E() a void function and eliminate its wrapper - rtl8188e_read_chip_version(). Signed-off-by: Jakub Sitnicki --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 11 ++- 1

[PATCH] Staging: lustre: fixed a blank line after declarations coding style issue

2015-07-10 Thread Ronit Halder
Fixed a blank line after declarations coding style issue Signed-off-by: Ronit Halder --- drivers/staging/lustre/lustre/lov/lov_merge.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/lustre/lustre/lov/lov_merge.c b/drivers/staging/lustre/lustre/lov/lov_merge.c index b7e7bfa.

Re: [PATCH] Alternate rtl8192cu driver.

2015-07-10 Thread P. Varet
Hi Dan, hi all, On 08/07/15 12:36, Dan Carpenter wrote: The bug report says that it connects fine. Then in 10 minutes the connection dies and reconnects. Is connecting an issue for you? Oh, I was under the impression that the person who connects fine then loses the connection sporadically

Acknowledge

2015-07-10 Thread Mr Wong Peter
Acknowledge FROM: Mr. Peter Wong Tung Shun (Managing Director) Hang Seng Bank Limited 83 Des Voeux Road, Central Hong Kong SAR. Email. wongpeter...@yahoo.com.hk Attention: It is understandable that you may have a bit uneasy, because I do not know you, but I have a lucrative business propo

Re: [PATCH 13/13] staging: unisys: Allow visorbus to autoload

2015-07-10 Thread Dan Carpenter
On Thu, Jul 09, 2015 at 01:27:53PM -0400, Benjamin Romer wrote: > From: David Kershner > > We inadvertently remove the MODULE_DEVICE_TABLE line for visorbus, > this patch adds it back in. > > Signed-off-by: David Kershner > Signed-off-by: Benjamin Romer Fixes: d5b3f1dccee4 ('staging: unisys:

Re: [PATCH] Alternate rtl8192cu driver.

2015-07-10 Thread Greg KH
On Fri, Jul 10, 2015 at 07:54:30PM +0200, P. Varet wrote: > Here's what I see on my side. I'll try to be as thorough as I can. Please send this to the maintainer of the driver, and the linux-wireless mailing list. The people there can help you out much more so than the people on this driverdev-