Re: [PATCH V4 00/24] staging: wilc1000: Resend V4

2016-02-22 Thread Greg KH
On Mon, Feb 22, 2016 at 07:14:07PM +0900, Leo Kim wrote: > Dear Greg > > This is the 4th fix patch about the mistake merging. > Mistake merging is revert the below commit when rebase V3 patches. > (already applied commit) - 6c2ab2398b88 ("staging: wilc1000: remove spaces > around '->'") > (V3

[patch 6/6] Staging: gdm72xx: remove duplicate condition

2016-02-22 Thread Dan Carpenter
We know "len" is not zero because we tested for that at the beginning of the function so this test can be removed. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c index 6d647d6..09bf64e 100644 ---

Re: [PATCH 1/1] staging: ion: debugfs sparse warning, proper mask

2016-02-22 Thread Laura Abbott
On 02/20/2016 07:15 PM, Derek Yerger wrote: From drivers/staging/android TODO file - sparse errors. The current code attempts assignment of -1 to unsigned type gfp_t. Assignment should be an enumerated type of GFP_KERNEL, GFP_ATOMIC, GFP_HIGHMEM, or __GFP_HIGH. The original 2014 patch by Gioh

[patch 1/6] staging: gdm72xx: underflow in netlink_rcv_cb()

2016-02-22 Thread Dan Carpenter
If nlh->nlmsg_len is less than ND_IFINDEX_LEN we end up trying to memcpy a negative size. I also re-ordered slighty the condition to make it more uniform. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/gdm72xx/netlink_k.c

[patch 3/6] Staging: gdm72xx: make "len" unsigned

2016-02-22 Thread Dan Carpenter
We had an underflow bug here and I think I fixed it but we may as well be proactive and make "len" unsigned to be double sure. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/gdm72xx/gdm_wimax.h b/drivers/staging/gdm72xx/gdm_wimax.h index 3330cd79..ed12813

[patch 2/6] Staging: gdm72xx: silence underflow warning in netlink_send()

2016-02-22 Thread Dan Carpenter
The value of "group" comes from "idx" in __gdm_wimax_event_send(): if (sscanf(e->dev->name, "wm%d", ) == 1) Smatch marks sscanf values as user controlled. It's supposed to be a number in 0-30 range. We cap the upper bound but allow negatives. Fix this by making it type u16 instead.

[patch 4/6] staging: gdm72xx: zero out padding

2016-02-22 Thread Dan Carpenter
We pad the start of this buffer with 256 bytes of padding. It's not clear to me exactly what's going on or how it's used but let's zero it out. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/gdm72xx/usb_boot.c b/drivers/staging/gdm72xx/usb_boot.c index

[patch 5/6] Staging: gdm72xx: underflow bug in gdm_wimax_ioctl_get_data()

2016-02-22 Thread Dan Carpenter
"size" here should be unsigned, otherwise we might end up trying to copy negative bytes in gdm_wimax_ioctl_get_data() resulting in an information leak. Reported-by: Alan Cox Signed-off-by: Dan Carpenter diff --git

[RFC] staging: iio: isl29018: use regmap to retrieve struct device

2016-02-22 Thread Alison Schofield
Remove struct device from drivers global data and use regmap API to retrieve device info instead. This replacement can be done for drivers that include regmap in their global data. Signed-off-by: Alison Schofield --- drivers/staging/iio/light/isl29018.c | 28

Re: [PATCH] staging: rtl8188eu: Remove RF_PATH_C & RF_PATH_D

2016-02-22 Thread Larry Finger
On 02/17/2016 09:14 PM, Andrew Bradford wrote: RTL8188EE has a maximum of 2 RF paths (chains) so paths C and D are not needed to support this part. Signed-off-by: Andrew Bradford --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 26 --

Re: [PATCH 1/1] staging: ion: debugfs sparse warning, proper mask

2016-02-22 Thread Derek Yerger
I'm sorry, it seems I am mistaken. This was in reference to patches which weren't committed. Please see: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2014-October/060203.html for the patch with this specific mask used. The reason __GFP_HIGHMEM may have been chosen is

Re: [patch 3/6] Staging: gdm72xx: make "len" unsigned

2016-02-22 Thread kbuild test robot
Hi Dan, [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.5-rc5 next-20160222] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Dan-Carpenter/staging-gdm72xx

[PATCH V4 05/24] staging: wilc1000: removes potential null dereference

2016-02-22 Thread Leo Kim
This patch removes the error reported by smatch. - wilc_wfi_cfgoperations.c:674 scan() error: potential null dereference 'strHiddenNetwork.net_info'. (kmalloc returns null) Signed-off-by: Leo Kim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 ++ 1 file

[PATCH V4 01/24] staging: wilc1000: wilc_wlan.c: removes PRINT_ER

2016-02-22 Thread Leo Kim
This patches removes PRINT_ER that is unnecessary debug logs. Signed-off-by: Leo Kim --- drivers/staging/wilc1000/wilc_wlan.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c index

[PATCH V4 03/24] staging: wilc1000: linux_mon.c: replaces PRINT_ER with netdev_err

2016-02-22 Thread Leo Kim
This patches replaces PRINT_ER with netdev_err. Signed-off-by: Leo Kim --- drivers/staging/wilc1000/linux_mon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c index

[PATCH V4 00/24] staging: wilc1000: Resend V4

2016-02-22 Thread Leo Kim
Dear Greg This is the 4th fix patch about the mistake merging. Mistake merging is revert the below commit when rebase V3 patches. (already applied commit) - 6c2ab2398b88 ("staging: wilc1000: remove spaces around '->'") (V3 mistake patch) - [PATCH V3 09/24] staging: wilc1000:

[PATCH V4 07/24] staging: wilc1000: linux_mon.c: removes unnecessary log message

2016-02-22 Thread Leo Kim
From: Chris Park This patch removes unnecessary log message and relate variables. Signed-off-by: Chris Park Signed-off-by: Leo Kim --- drivers/staging/wilc1000/linux_mon.c | 42 1 file

[PATCH V4 06/24] staging: wilc1000: host_interface.c: removes unnecessary log message

2016-02-22 Thread Leo Kim
From: Chris Park This patch removes unnecessary log message and relate variables. Signed-off-by: Chris Park Signed-off-by: Leo Kim --- drivers/staging/wilc1000/host_interface.c | 5 - 1 file changed, 5 deletions(-) diff

[PATCH V4 04/24] staging: wilc1000: linux_mon.c: add to check routine

2016-02-22 Thread Leo Kim
This patch adds the return value which needs the check and prints the error message when it fails. Signed-off-by: Leo Kim --- drivers/staging/wilc1000/linux_mon.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/linux_mon.c

[PATCH V4 11/24] staging: wilc1000: host_interface.c: removes unnecessary log messages

2016-02-22 Thread Leo Kim
From: Chris Park This patch removes unnecessary log message and relate variables. Signed-off-by: Chris Park Signed-off-by: Leo Kim --- drivers/staging/wilc1000/host_interface.c | 31 --- 1 file

[PATCH V4 10/24] staging: wilc1000: removes unused HOSTAPD_DBG tag

2016-02-22 Thread Leo Kim
From: Chris Park This patch removes unused HOSTAPD_DBG tag. Signed-off-by: Chris Park Signed-off-by: Leo Kim --- drivers/staging/wilc1000/linux_wlan_common.h | 4 +--- drivers/staging/wilc1000/wilc_debugfs.c | 5 ++--- 2

[PATCH V4 09/24] staging: wilc1000: wilc_wfi_cfgoperations.c: removes unnecessary log messages

2016-02-22 Thread Leo Kim
From: Chris Park This patch removes the unnecessary log messages which is used with the HOSTAPD_DBG tag. Signed-off-by: Chris Park Signed-off-by: Leo Kim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 88

RE: [PATCH RESEND 04/10] staging: wilc1000: removes unnecessary wilc_debug print log

2016-02-22 Thread Kim, Leo
Dear Dan, This patch is subject "removes unnecessary wilc_debug print log". Your advice are correct but in this patch is not applied. I'll be applied to next patch about the your good advice. Would be okay? Always appreciate your positive advice & great information.  Thanks, BR  Leo

Re: [PATCH RESEND 04/10] staging: wilc1000: removes unnecessary wilc_debug print log

2016-02-22 Thread Dan Carpenter
On Mon, Feb 22, 2016 at 01:41:13PM +0900, Leo Kim wrote: > This patch removes unnecessary wilc_debug print log. > The print log was written when if condition fail. > The condition is chip-id check function. > Also, replaces this condition with normal function. > > Signed-off-by: Leo Kim

[PATCH V4 08/24] staging: wilc1000: linux_mon.c: removes comments

2016-02-22 Thread Leo Kim
From: Chris Park This patch removes unnecessary comments. Signed-off-by: Chris Park Signed-off-by: Leo Kim --- drivers/staging/wilc1000/linux_mon.c | 4 1 file changed, 4 deletions(-) diff --git

[PATCH V4 13/24] staging: wilc1000: wilc_wfi_cfgoperations.c: removes unnecessary log messages

2016-02-22 Thread Leo Kim
From: Chris Park This patch removes unnecessary log messages. And, it adds a 'break' statement in accordance with the switch-case rule. Signed-off-by: Chris Park Signed-off-by: Leo Kim ---

[PATCH V4 02/24] staging: wilc1000: linux_mon.c: removes debug logs

2016-02-22 Thread Leo Kim
This patches removes unnecessary debug logs. Signed-off-by: Leo Kim --- drivers/staging/wilc1000/linux_mon.c | 24 ++-- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/drivers/staging/wilc1000/linux_mon.c

[PATCH V4 17/24] staging: wilc1000: host_interface.c: replace PRINT_ER with netdev_err

2016-02-22 Thread Leo Kim
From: Chris Park This patch replaces PRINT_ER with netdev_err. Signed-off-by: Chris Park Signed-off-by: Leo Kim --- drivers/staging/wilc1000/host_interface.c | 284 +++--- 1 file changed, 142

[PATCH V4 19/24] staging: wilc1000: wilc_wfi_cfgoperations.c: removes unnecessary log messages

2016-02-22 Thread Leo Kim
From: Chris Park This patch removes unnecessary log messages. Signed-off-by: Chris Park Signed-off-by: Leo Kim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 14 +++--- 1 file changed, 3 insertions(+), 11

[PATCH V4 21/24] staging: wilc1000: removes unused region feature

2016-02-22 Thread Leo Kim
From: Chris Park This patch removes unused region feature on debug message. Also, removes the functions of related in this feature. Signed-off-by: Chris Park Signed-off-by: Leo Kim --- drivers/staging/wilc1000/linux_wlan_common.h

[PATCH V4 20/24] staging: wilc1000: wilc_wlan.c: removes unnecessary log messages

2016-02-22 Thread Leo Kim
From: Chris Park This patch removes unnecessary log messages. Signed-off-by: Chris Park Signed-off-by: Leo Kim --- drivers/staging/wilc1000/wilc_wlan.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH V4 12/24] staging: wilc1000: wilc_wfi_cfgoperations.c: removes unnecessary log messages

2016-02-22 Thread Leo Kim
From: Chris Park This patch removes unnecessary log messages and relate variables. Signed-off-by: Chris Park Signed-off-by: Leo Kim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 233 +- 1 file

[PATCH V4 14/24] staging: wilc1000: removes unused CFG80211_DBG tag

2016-02-22 Thread Leo Kim
From: Chris Park This patch removes unused CFG80211_DBG tag. Signed-off-by: Chris Park Signed-off-by: Leo Kim --- drivers/staging/wilc1000/linux_wlan_common.h | 4 +--- drivers/staging/wilc1000/wilc_debugfs.c | 6 +++--- 2

[PATCH V4 22/24] staging: wilc1000: removes usused PRINT_XX(region...)

2016-02-22 Thread Leo Kim
From: Chris Park This patch removes unused PRINT_XX(region...) because already removed in used to region feature of whole wilc source. Also, removes unnecessary related region extern variable. Signed-off-by: Chris Park Signed-off-by: Leo Kim

[PATCH V4 24/24] staging: wilc1000: moves LINUX_RX_SIZE, LINUX_TX_SIZE

2016-02-22 Thread Leo Kim
From: Chris Park This patch moves LINUX_RX_SIZE and LINUX_TX_SIZE to wilc_wlan.h file because there are only used to wilc_wlan.c file. Signed-off-by: Chris Park Signed-off-by: Leo Kim ---

[PATCH V4 23/24] staging: wilc1000: moves to define values

2016-02-22 Thread Leo Kim
From: Chris Park This patch moves DEBUG, INFO, WRN and ERR values to wilc_debugfs.c file because this is only used to wilc_debugfs.c file. And, removes unnecessary WILC_DEBUGFS and else-case variables. Signed-off-by: Chris Park Signed-off-by: Leo Kim

[PATCH V4 15/24] staging: wilc1000: coreconfigurator.c: removes unnecessary log messages

2016-02-22 Thread Leo Kim
From: Chris Park This patch removes unnecessary log messages. Signed-off-by: Chris Park Signed-off-by: Leo Kim --- drivers/staging/wilc1000/coreconfigurator.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH V4 18/24] staging: wilc1000: linux_wlan.c: removes unnecessary log messages

2016-02-22 Thread Leo Kim
From: Chris Park This patch removes unnecessary log messages. Signed-off-by: Chris Park Signed-off-by: Leo Kim --- drivers/staging/wilc1000/linux_wlan.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH V4 16/24] staging: wilc1000: host_interface.c: removes unnecessary log messages

2016-02-22 Thread Leo Kim
From: Chris Park This patch removes unnecessary log messages. Signed-off-by: Chris Park Signed-off-by: Leo Kim --- drivers/staging/wilc1000/host_interface.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-)

Re: [PATCH] staging: xgifb: Fix comment style

2016-02-22 Thread Bo YU
Oh, I am miss ccing list in previous email. On Sun, Feb 21, 2016 at 8:57 PM, Roger H Newell wrote: > Hello: > > I think you need to make sure your staging-testing tree is current > before creating a patch. > > git checkout staging-testing && git fetch origin > git

Re: [PATCH RESEND 04/10] staging: wilc1000: removes unnecessary wilc_debug print log

2016-02-22 Thread Dan Carpenter
On Mon, Feb 22, 2016 at 11:42:42AM +, Kim, Leo wrote: > Dear Dan, > > This patch is subject "removes unnecessary wilc_debug print log". I'm fine with you fixing it up in a later patch, but you should not be defending this patch as valid way to do things. The rule is "do one thing at a

[PATCH 00/24] Second batch of LNet updates

2016-02-22 Thread James Simmons
This patch set fixes many of the LNet issues encounter run in production environments. One of the long standing issues was not being able to reconfigure LNet after initialization. Doing so left it in a broken state. Several other issues are also addressed in this patch set. Merged back into this

[PATCH 01/24] staging: lustre: Dynamic LNet Configuration (DLC) IOCTL changes

2016-02-22 Thread James Simmons
From: Amir Shehata This is the fourth patch of a set of patches that enables DLC. This patch changes the IOCTL infrastructure in preparation of adding extra IOCTL communication between user and kernel space. The changes include: - adding a common header to be passed to

[PATCH 06/24] staging: lustre: remove LUSTRE_{,SRV_}LNET_PID

2016-02-22 Thread James Simmons
From: John L. Hammond Remove LUSTRE_LNET_PID (12354) and LUSTRE_SRV_LNET_PID (12345) from the libcfs headers and replace their uses with a new macro LNET_PID_LUSTRE (also 12345) in lnet/types.h. Signed-off-by: John L. Hammond Intel-bug-id:

[PATCH 08/24] staging: lustre: return appropriate errno when adding route

2016-02-22 Thread James Simmons
From: Amir Shehata When adding route it ignored specific scenarios, namely: 1. route already exists 2. route is on a local net 3. route is unreacheable This patch returns the appropriate return codes from the lower level function lnet_add_route(), and then ignores the

[PATCH 03/24] staging: lustre: fix crash due to NULL networks string

2016-02-22 Thread James Simmons
From: Amir Shehata If there is an invalid networks or ip2nets lnet_parse_networks() gets called with a NULL 'network' string parameter lnet_parse_networks() needs to sanitize its input string now that it's being called from multiple places. Instead, check for a NULL

[PATCH 02/24] staging: lustre: Dynamic LNet Configuration (DLC) show command

2016-02-22 Thread James Simmons
From: Amir Shehata This is the fifth patch of a set of patches that enables DLC. This patch adds the new structures which will be used in the IOCTL communication. It also added a set of show operations to show buffers, networks, statistics and peer information.

Re: [RFC] Staging: goldfish_audio.c: Modify goldfish audio driver to use ALSA framework

2016-02-22 Thread Greg KH
On Mon, Feb 22, 2016 at 09:20:24PM +0530, PrasannaKumar Muralidharan wrote: > From: PrasannaKumar Muralidharan > > Modified goldfish audio driver to use ALSA framework. Only playback support > is implemented. After fixing review comments capture support will be >

[RFC] Staging: goldfish_audio.c: Modify goldfish audio driver to use ALSA framework

2016-02-22 Thread PrasannaKumar Muralidharan
From: PrasannaKumar Muralidharan Modified goldfish audio driver to use ALSA framework. Only playback support is implemented. After fixing review comments capture support will be implemented. Only able to compile test so sending as RFC. Signed-off-by: PrasannaKumar

[PATCH] Staging: comedi: mite: added spaces around | and *

2016-02-22 Thread Philippe Loctaux
Added spaces around | and *, fixing 2 checkpatch checks. Signed-off-by: Philippe Loctaux --- drivers/staging/comedi/drivers/mite.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/mite.c

Re: [PATCH 4/4] staging: rtl8192u: r8192U_core: use kmalloc_array instead of kmalloc

2016-02-22 Thread Geliang Tang
On Sun, Feb 07, 2016 at 07:55:09PM -0800, Greg Kroah-Hartman wrote: > On Sun, Nov 08, 2015 at 10:17:54PM +0800, Geliang Tang wrote: > > Use kmalloc_array instead of kmalloc to allocate memory for an array. > > > > Signed-off-by: Geliang Tang > > --- > >

Administrador do sistema

2016-02-22 Thread ADMIN
Sua caixa de correio excedeu o limite de armazenamento, que é de 20 GB como conjunto pelo administrador, você está atualmente em execução no 20,9 GB, você pode não ser capaz de Enviar ou receber novas mensagens até que você re-validar sua caixa de correio. Para Revalide sua caixa de

Re: [PATCH 4/4] staging: rtl8192u: r8192U_core: use kmalloc_array instead of kmalloc

2016-02-22 Thread Greg Kroah-Hartman
On Tue, Feb 23, 2016 at 08:55:04AM +0800, Geliang Tang wrote: > On Sun, Feb 07, 2016 at 07:55:09PM -0800, Greg Kroah-Hartman wrote: > > On Sun, Nov 08, 2015 at 10:17:54PM +0800, Geliang Tang wrote: > > > Use kmalloc_array instead of kmalloc to allocate memory for an array. > > > > > >

[PATCH] staging: rtl8723au: use list_first_entry*

2016-02-22 Thread Geliang Tang
Use list_first_entry*() instead of container_of() to simplify the code. Signed-off-by: Geliang Tang --- drivers/staging/rtl8723au/core/rtw_recv.c | 49 +-- drivers/staging/rtl8723au/core/rtw_xmit.c | 26 +--- 2 files changed, 22

[PATCH 16/24] staging: lustre: assume a kernel build

2016-02-22 Thread James Simmons
From: John L. Hammond In lnet/lnet/ and lnet/selftest/ assume a kernel build (assume that __KERNEL__ is defined). Remove some common code only needed for user space LNet. Only part of the work of this patch got merged. This is the final bits. Signed-off-by: John L.

[PATCH 19/24] staging: lustre: remove unnecessary EXPORT_SYMBOL from lnet layer

2016-02-22 Thread James Simmons
From: Frank Zago A lot of symbols don't need to be exported at all because they are only used in the module they belong to. Signed-off-by: Frank Zago Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5829 Reviewed-on: http://review.whamcloud.com/13320

[PATCH 24/24] staging: lustre: Remove LASSERTS from router checker

2016-02-22 Thread James Simmons
From: Doug Oucharek In lnet_router_checker(), there are two LASSERTS. Neither protects us from anything and one of them triggered for a customer crashing the system unecessarily. This patch removes them. Signed-off-by: Doug Oucharek

Re: [PATCH 10/56] staging/lustre: Remove ldlm type/mode typedefs

2016-02-22 Thread kbuild test robot
Hi Oleg, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.5-rc5 next-20160222] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/green-linuxhacker-ru/More-Lustre

re: staging: rtl8723au: use list_for_each_entry*()

2016-02-22 Thread Dan Carpenter
Hello Geliang Tang, The patch e280d71bea18: "staging: rtl8723au: use list_for_each_entry*()" from Feb 18, 2016, leads to the following static checker warning: drivers/staging/rtl8723au/core/rtw_sta_mgt.c:365 rtw_get_stainfo23a() error: potential NULL dereference 'psta'.

Re: [PATCH] Staging: comedi: mite: added spaces around | and *

2016-02-22 Thread Joe Perches
On Tue, 2016-02-23 at 00:38 +0100, Philippe Loctaux wrote: > Added spaces around | and *, fixing 2 checkpatch checks. [] > diff --git a/drivers/staging/comedi/drivers/mite.c > b/drivers/staging/comedi/drivers/mite.c [] > @@ -51,7 +51,7 @@ >   >  #include "mite.h" >   > -#define TOP_OF_PAGE(x)

Re: [PATCH] staging/lustre: proper support of NFS anonymous dentries

2016-02-22 Thread Oleg Drokin
On Feb 14, 2016, at 7:58 PM, Greg Kroah-Hartman wrote: > On Sun, Feb 14, 2016 at 07:13:52PM -0500, gr...@linuxhacker.ru wrote: >> From: Dmitry Eremin >> >> NFS can ask to encode dentries that are not connected to the root. >> The fix check for parent is NULL and encode

[PATCH] Staging: comedi: contec_pci_dio: fixed comment blocks coding style issues

2016-02-22 Thread Philippe Loctaux
Makes the comment blocks start with /* on separate lines, and end with */ on separate lines as well, starting with * for each comment lines. Signed-off-by: Philippe Loctaux --- drivers/staging/comedi/drivers/contec_pci_dio.c | 47 + 1 file

Re: [PATCH] staging: rtl8723au: use list_first_entry*

2016-02-22 Thread Jes Sorensen
Geliang Tang writes: > Use list_first_entry*() instead of container_of() to simplify the code. > > Signed-off-by: Geliang Tang > --- > drivers/staging/rtl8723au/core/rtw_recv.c | 49 > +-- >

Re: [RFC] Staging: goldfish_audio.c: Modify goldfish audio driver to use ALSA framework

2016-02-22 Thread PrasannaKumar Muralidharan
Tried testing this with Android user space. But it did not work as the user space HAL layer does not use ALSA by default. Need to modify the Android tree to use tinyalsa to test this change. I did not try out any Linux distribution with Android emulator. I will try any of the above way and report

Re: [RFC] Staging: goldfish_audio.c: Modify goldfish audio driver to use ALSA framework

2016-02-22 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Mon, Feb 22, 2016 at 10:50:09PM +0530, PrasannaKumar Muralidharan wrote: > Tried testing this with Android user space. But it did not work as the > user space HAL layer does not use ALSA by default.

[PATCH 4/7] staging: wilc1000: handle_cfg_param: rename wid_cnt

2016-02-22 Thread Chaehyun Lim
wid_cnt variable is used as indicating array index of struct wid_list. This patch renames wid_cnt to i that makes more readability. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 184 +++--- 1 file changed, 92

[PATCH 1/7] staging: wilc1000: handle_set_mac_address: fix missing blank line after declaration

2016-02-22 Thread Chaehyun Lim
commit 31cc9885e7c7 ("staging: wilc1000: handle_set_mac_address: use kmemdup") introduces a new checkpatch warning, so this patch fixes it. WARNING: Missing a blank line after declarations FILE: drivers/staging/wilc1000/host_interface.c:430: Signed-off-by: Chaehyun Lim

[PATCH 5/7] staging: wilc1000: handle_cfg_param: fix logical continuations

2016-02-22 Thread Chaehyun Lim
This patch fixes logical continuations found by checkpatch CHECK: Logical continuations should be on the previous line Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 3/7] staging: wilc1000: handle_cfg_param: change data type of wid_cnt

2016-02-22 Thread Chaehyun Lim
This patch changes data type of wid_cnt from u8 to int. This variable uses array index of struct wid_list so that it is better to use int type. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 7/7] staging: wilc1000: handle_cfg_param: remove unnecessary whitespace

2016-02-22 Thread Chaehyun Lim
This patch removes unnecessary whitespace before a quoted newline found by checkpatch WARNING: unnecessary whitespace before a quoted newline Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 6/7] staging: wilc1000: handle_cfg_param: fix line over 80 characters

2016-02-22 Thread Chaehyun Lim
This patch fixes line over 80 characters found by checkpatch WARNING: line over 80 characters Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

RE: [PATCH RESEND 04/10] staging: wilc1000: removes unnecessary wilc_debug print log

2016-02-22 Thread Kim, Leo
Dear Dan, Thank you your great comments. I will be not forget your advice. Please understand that if you have a misunderstanding. Thank you & Best Regards. Leo -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Monday, February 22, 2016 11:44 PM To: Kim,

Re: [RFC] Staging: goldfish_audio.c: Modify goldfish audio driver to use ALSA framework

2016-02-22 Thread PrasannaKumar Muralidharan
According to Android porting guide tinyalsa will work for ALSA drivers, it is included in the Android open source project tree. Change in their build configuration should be enough to use this patch. I think it is better to get your question answered before proceeding further. I don't have a clue

[PATCH 19/56] staging/lustre: Get rid of ldlm_error_t typedef

2016-02-22 Thread green
From: Oleg Drokin Replace it with enum ldlm_error Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 8 drivers/staging/lustre/lustre/ldlm/ldlm_flock.c| 4 ++--

[PATCH 47/56] staging/lustre/llite: Adjust comments to better conform to coding style

2016-02-22 Thread green
From: Oleg Drokin This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/dcache.c | 18 ++- drivers/staging/lustre/lustre/llite/dir.c

[PATCH 27/56] staging/lustre: Remove FSF mailing address from GPL notices

2016-02-22 Thread green
From: Oleg Drokin This patch removes remaining several places that still had that extra paragraph included in Lustre code. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/include/linux/libcfs/libcfs_cpu.h | 5 -

[PATCH 16/56] staging/lustre: Get rid of object update code

2016-02-22 Thread green
From: Oleg Drokin Object update was originally planned to be used for cross-server updates, so nothing to do with the client. The idea was later significantly reworked anyway so even wire structs should not be retained. This gets rid of update_cmd_t, UPDATE and

[PATCH 26/56] staging/lustre: Remove server-side changelog defines

2016-02-22 Thread green
From: Oleg Drokin CHANGELOG_MAGIC, CHANGELOG_MINMASK, CHANGELOG_ALLMASK, CHANGELOG_DEFMASK and CHANGELOG_USER_PREFIX are all unused on the client. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre/lustre_idl.h | 11

[PATCH 25/56] staging/lustre: Get rid of C99 comments in lustre_idl.h

2016-02-22 Thread green
From: Oleg Drokin lustre_idl.h contains various protocol data. In order to avoid reusal of values that might have meant something else in the past, the old no longer used values are commented out, convert the comments into regular comments from C99 where appropriate.

[PATCH 37/56] staging/lustre: Remove last_rcvd-file related data

2016-02-22 Thread green
From: Oleg Drokin last_rcvd (last received) is a special server-side file on the Lustre FS that stores information about server filesystem and also list of connected clients and their state. There's no point in having any of tha ton the client, though. Signed-off-by: Oleg

[PATCH 49/56] staging/lustre/lov: Adjust comments to better conform to coding style

2016-02-22 Thread green
From: Oleg Drokin This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/lov/lov_ea.c | 3 +-

[PATCH 10/56] staging/lustre: Remove ldlm type/mode typedefs

2016-02-22 Thread green
From: Oleg Drokin Replace ldlm_mode_t with enum ldlm_mode, ldlm_type_t with enum ldlm_type Signed-off-by: Oleg Drokin --- .../lustre/lustre/include/lustre/lustre_idl.h | 14 drivers/staging/lustre/lustre/include/lustre_dlm.h | 39

[PATCH 21/56] staging/lustre: Get rid of ldlm_ns_type_t typedef

2016-02-22 Thread green
From: Oleg Drokin Replace it with enum ldlm_ns_type Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 6 +++--- drivers/staging/lustre/lustre/ldlm/ldlm_lib.c | 2 +-

[PATCH 12/56] staging/lustre: Get rid of obd_cmd_t typedef

2016-02-22 Thread green
From: Oleg Drokin Replace with enum obd_cmd Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre/lustre_idl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 11/56] staging/lustre: Get rid of mgs_cmd_t typedef

2016-02-22 Thread green
From: Oleg Drokin Replace it with enum mgs_cmd Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre/lustre_idl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 09/56] staging/lustre: Get rid of ldlm_cmd_t typedef

2016-02-22 Thread green
From: Oleg Drokin Replace it with enum ldlm_cmd Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre/lustre_idl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 15/56] staging/lustre/ldlm: Remove unused lr_most_restr from struct ldlm_resource

2016-02-22 Thread green
From: Oleg Drokin This member comes from the dawn of time and is no longer needed Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 3 --- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 3 ---

[PATCH 30/56] staging/lustre: Remove duplicated quota defines

2016-02-22 Thread green
From: Oleg Drokin QUOTABLOCK_BITS, QUOTABLOCK_SIZE and toqb are only used on the server and are copied from kernel code anyway. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre/lustre_idl.h | 12

[PATCH 45/56] staging/lustre/lclient: Adjust comments to better conform to coding style

2016-02-22 Thread green
From: Oleg Drokin This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/lclient/glimpse.c| 3 ++-

[PATCH 29/56] staging/lustre: Remove *_CONNECT_SUPPORTED defines

2016-02-22 Thread green
From: Oleg Drokin These defines are only used on the servers to determine what connect flags corresponding servers support: MDT_CONNECT_SUPPORTED OST_CONNECT_SUPPORTED MGS_CONNECT_SUPPORTED ECHO_CONNECT_SUPPORTED Signed-off-by: Oleg Drokin ---

[PATCH 14/56] staging/lustre: Get rid of sec_cmd_t typedef

2016-02-22 Thread green
From: Oleg Drokin Replace with enum sec_cmd Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre/lustre_idl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 17/56] staging/lustre: Get rid of lustre_fid typedef

2016-02-22 Thread green
From: Oleg Drokin Replace it with struct lu_fid Signed-off-by: Oleg Drokin --- .../lustre/lustre/include/lustre/lustre_idl.h | 2 +- .../lustre/lustre/include/lustre/lustre_user.h | 24 +++--- 2 files changed, 13

[PATCH 46/56] staging/lustre/ldlm: Adjust comments to better conform to coding style

2016-02-22 Thread green
From: Oleg Drokin This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ldlm/interval_tree.c | 6 +-

[PATCH 41/56] staging/lustre: Reformat comments and structures in lustre_idl.h

2016-02-22 Thread green
From: Oleg Drokin This file mostly contains various on the wire data and got significantly mangled in transition. This patch rectifies the situation somewhat. Also fixes the comment style for block comments. Signed-off-by: Oleg Drokin ---

[PATCH 44/56] staging/lustre/fid: Adjust comments to better conform to coding style

2016-02-22 Thread green
From: Oleg Drokin This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/fid/fid_request.c | 6 -- 1 file changed, 4 insertions(+), 2

[PATCH 50/56] staging/lustre/mdc: Adjust comments to better conform to coding style

2016-02-22 Thread green
From: Oleg Drokin This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 3 +- drivers/staging/lustre/lustre/mdc/mdc_locks.c

[PATCH 53/56] staging/lustre/obdecho: Adjust comments to better conform to coding style

2016-02-22 Thread green
From: Oleg Drokin This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/obdecho/echo_client.c | 9 ++--- 1 file changed, 6 insertions(+), 3

[PATCH 24/56] staging/lustre: Remove lustre_build_version.h

2016-02-22 Thread green
From: Oleg Drokin of the two macroses is contained the LUSTRE_RELEASE was unused and BUILD_VERSION is too generically named and was replaced with LUSTRE_VERSION_STRING with all the users (provided by lustre_ver.h) With in-kernel client the build version should be combined

[PATCH 38/56] staging/lustre: Remove dead code in ldlm_lock_destroy_internal

2016-02-22 Thread green
From: Oleg Drokin This code has been commented out since end of 2012, so it's clearly not needed here. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 10 -- 1 file changed, 10 deletions(-) diff --git

[PATCH 43/56] staging/lustre/fld: Adjust comments to better conform to coding style

2016-02-22 Thread green
From: Oleg Drokin This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/fld/fld_cache.c| 9 ++---

  1   2   >