Re: [PATCH 1/1] Staging: comedi: dmm32at: fix BIT macro issue.

2016-06-10 Thread Ian Abbott
On 09/06/16 13:04, Ravishankar Karkala Mallikarjunayya wrote: This Replace all occurences of (1<

Re: [PATCH] staging: comedi: dt2811: Fixed commenting coding style issues.

2016-06-10 Thread Ian Abbott
On 10/06/16 03:14, Akshay Shipurkar wrote: Fixed all 4 commenting coding style warnings generated by checkpatch.pl on dt2811.c Signed-off-by: Akshay Shipurkar --- drivers/staging/comedi/drivers/dt2811.c | 248 1 file changed, 124

Re: [PATCH 0/2] PCI: hv: fix a couple of issues in hv_pci_onchannelcallback()

2016-06-10 Thread Vitaly Kuznetsov
Vitaly Kuznetsov writes: > kmemleak helped me to identify a memory leak in hv_pci_onchannelcallback() > and while fixing it I stumbled upon an unrelated issue(s) there. > > Vitaly Kuznetsov (2): > PCI: hv: don't leak buffer in hv_pci_onchannelcallback() > PCI: hv: handle

[PATCH 1/1] Staging: comedi: dmm32at: fix BIT macro issue.

2016-06-10 Thread Ravishankar Karkala Mallikarjunayya
This Replace all occurences of (1< ---

RE: [PATCH 0/4] Drivers: hv: ring_buffer: make in-place consumption always possible

2016-06-10 Thread KY Srinivasan
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Friday, June 10, 2016 2:47 AM > To: de...@linuxdriverproject.org > Cc: linux-ker...@vger.kernel.org; KY Srinivasan ; Haiyang > Zhang > Subject: [PATCH 0/4]

Re: [PATCH v2 0/2] staging: comedi: serial2002: Fix two styling issues

2016-06-10 Thread Ian Abbott
On 09/06/16 20:39, Chris Cesare wrote: checkpatch.pl warns about a bare unsigned and an unnecessary cast. Patchset splits fixes for these into two separate patches. Chris Cesare (2): staging: comedi: serial2002: Fix bare unsigned styling issue staging: comedi: serial2002: Fix unnecessary

Re: [PATCH 1/1] Staging: comedi: dmm32at: fix BIT macro issue.

2016-06-10 Thread Ian Abbott
On 10/06/16 12:15, Ravishankar Karkala Mallikarjunayya wrote: This Replace all occurences of (1<

Re: [PATCH 0/2] PCI: hv: fix a couple of issues in hv_pci_onchannelcallback()

2016-06-10 Thread Bjorn Helgaas
On Fri, Jun 10, 2016 at 02:05:33PM +0200, Vitaly Kuznetsov wrote: > Vitaly Kuznetsov writes: > > > kmemleak helped me to identify a memory leak in hv_pci_onchannelcallback() > > and while fixing it I stumbled upon an unrelated issue(s) there. > > > > Vitaly Kuznetsov (2): >

Re: [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs in own kmem_caches

2016-06-10 Thread Greg Kroah-Hartman
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Fri, Jun 10, 2016 at 03:25:28PM +, Faccini, Bruno wrote: > Hello, > The intent of this patch is not to solve the corruptions for sure, but > only to avoid the concerned MEs/small-MDs LNet

[PATCH 0/4] Drivers: hv: ring_buffer: make in-place consumption always possible

2016-06-10 Thread Vitaly Kuznetsov
K. Y., I'd like to accompany your netvsc performance improvement work by making in-place consumption of VMBus packets always possible. Currently we forbid it when a packet 'wraps around' the ring so we can't provide a single pointer to it. The idea if this series is dead simple: let's make a

[PATCH 2/4] Drivers: hv: ring_buffer: wrap around mappings for ring buffers

2016-06-10 Thread Vitaly Kuznetsov
Make it possible to always use a single memcpy() or to provide a direct link to a packet on the ring buffer by creating virtual mapping for two copies of the ring buffer with vmap(). Utilize currently empty hv_ringbuffer_cleanup() to do the unmap. While on it, replace sizeof(struct

[PATCH 3/4] Drivers: hv: ring_buffer: use wrap around mappings in hv_copy{from, to}_ringbuffer()

2016-06-10 Thread Vitaly Kuznetsov
With wrap around mappings for ring buffers we can always use a single memcpy() to do the job. Signed-off-by: Vitaly Kuznetsov --- drivers/hv/ring_buffer.c | 24 +++- 1 file changed, 3 insertions(+), 21 deletions(-) diff --git a/drivers/hv/ring_buffer.c

[PATCH 1/4] Drivers: hv: cleanup vmbus_open() for wrap around mappings

2016-06-10 Thread Vitaly Kuznetsov
In preparation for doing wrap around mappings for ring buffers cleanup vmbus_open() function: - check that ring sizes are PAGE_SIZE aligned (they are for all in-kernel drivers now); - kfree(open_info) on error only after we kzalloc() it (not an issue as it is valid to call kfree(NULL); -

[PATCH 4/4] Drivers: hv: ring_buffer: count on wrap around mappings in get_next_pkt_raw()

2016-06-10 Thread Vitaly Kuznetsov
With wrap around mappings in place we can always provide drivers with direct links to packets on the ring buffer, even when they wrap around. Do the required updates to get_next_pkt_raw()/put_pkt_raw() Signed-off-by: Vitaly Kuznetsov --- include/linux/hyperv.h | 32

[PATCH net-next, v2] tools: hv: Add a script to help bonding synthetic and VF NICs

2016-06-10 Thread Haiyang Zhang
This script helps to create bonding network devices based on synthetic NIC (the virtual network adapter usually provided by Hyper-V) and the matching VF NIC (SRIOV virtual function). So the synthetic NIC and VF NIC can function as one network device, and fail over to the synthetic NIC if VF is

[PATCH] staging: lustre: o2iblnd: remove typedefs

2016-06-10 Thread James Simmons
Remove all remaining typedefs in o2iblnd driver. Signed-off-by: James Simmons --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 339 +- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h| 299

[NAK] [PATCH v4 00/29] Fixed issues raised by tglx, then move visorbus to drivers/virt

2016-06-10 Thread Kershner, David A
> -Original Message- > From: David Kershner [mailto:david.kersh...@unisys.com] > Sent: Wednesday, June 8, 2016 5:14 PM > To: cor...@lwn.net; t...@linutronix.de; mi...@redhat.com; > h...@zytor.com; Kershner, David A ; > gre...@linuxfoundation.org; Arfvidson, Erik

[PATCH] staging: lustre: socklnd: remove typedefs

2016-06-10 Thread James Simmons
Remove all remaining typedefs in socklnd driver. Signed-off-by: James Simmons --- .../staging/lustre/lnet/klnds/socklnd/socklnd.c| 302 ++-- .../staging/lustre/lnet/klnds/socklnd/socklnd.h| 209 +++---

[PATCH 27/28] staging: unisys: visorinput: ensure proper locking wrt creation & ints

2016-06-10 Thread David Kershner
From: Tim Sell Ensure we properly lock between visorinput_channel_interrupt(), visorinput_open(), and devdata_create(). We now guarantee that: * interrupts will be disabled and remain disabled during device creation, by setting 'paused = true' across device creation

[PATCH 24/28] staging: unisys: visorbus: Rename function to follow existing convention

2016-06-10 Thread David Kershner
From: David Binder Renames visorchipset_device_pause_response to device_pause_response, thereby following the convention that other responder functions follow. Signed-off-by: David Binder Signed-off-by: David Kershner

[PATCH 16/28] staging: unisys: visorbus: remove unused parameter from function

2016-06-10 Thread David Kershner
From: Tim Sell The off parameter to visorchannel_create_guts() was never used, so it was removed. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchannel.c | 7 +++

Re: [PATCH net-next,v2] tools: hv: Add a script to help bonding synthetic and VF NICs

2016-06-10 Thread David Miller
From: Haiyang Zhang Date: Fri, 10 Jun 2016 14:23:12 -0700 > This script helps to create bonding network devices based on synthetic NIC > (the virtual network adapter usually provided by Hyper-V) and the matching > VF NIC (SRIOV virtual function). So the synthetic NIC and

[PATCH 13/28] staging: unisys: visorbus: Remove unnecessary EXPORT_SYMBOL statements

2016-06-10 Thread David Kershner
From: Bryan Thompson The driver that is now visorbus started out as multiple separate drivers, and when they were merged the EXPORT_SYMBOL statements that were required for separate drivers were left in the code. This patch removes those now unnecessary exports.

[PATCH 23/28] staging: unisys: visorbus: Remove notifier-related code from visorbus

2016-06-10 Thread David Kershner
From: David Binder When this functionality was first implemented, visorchipset and visorbus were separate drivers, which necessitated a registration mechanism for them to communicate. More-recently, visorchipset and visorbus were combined into a single driver, and now

[PATCH 14/28] staging: unisys: visorbus: Remove unused functions

2016-06-10 Thread David Kershner
From: Bryan Thompson Remove visorbus_clear_channel, visorchannel_signalqueue_slots_avail, visorchannel_signalqueue_max_slots, visorchannel_clear, and visorchannel_debug which are no longer called by any driver. Signed-off-by: Bryan Thompson

[PATCH 26/28] staging: unisys: Move vbushelper.h to visorbus directory

2016-06-10 Thread David Kershner
Only visorbus needs this header file so move it to visorbus directory. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/{include => visorbus}/vbushelper.h | 0 1 file changed, 0 insertions(+), 0 deletions(-)

[PATCH 21/28] staging: unisys: visorbus: Move visorbus-unique functions to private header

2016-06-10 Thread David Kershner
From: David Binder Moves function prototypes that are unique to visorbus from include/visorbus.h to visorbus/visorbus_private.h. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH 28/28] staging: unisys: visorinput: make lock_visor_dev a mutex

2016-06-10 Thread David Kershner
From: Tim Sell Since lock_visor_dev is a binary semaphore it makes more sense to use a mutex lock. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visorinput/visorinput.c | 34

[PATCH 20/28] staging: unisys: visorbus: Rectify commenting in visorchipset.c

2016-06-10 Thread David Kershner
From: David Binder Adds kerneldoc formatting to appropriate functions. Other multi-line comments now use proper formatting. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH 18/28] staging: unisys: visorbus: fix commenting in visorbus_main.c

2016-06-10 Thread David Kershner
From: David Binder This patch ONLY touches comment lines, i.e., NO executable code is affected. * All functions worthy of documenting now use standard kerneldoc formatting. * Improper uses of kerneldoc formatting were converted to standard multi-line comments. *

[PATCH 22/28] staging: unisys: visorbus: rectify kerneldoc comment for struct

2016-06-10 Thread David Kershner
From: David Binder Fixes the kerneldoc comment for struct visor_device - the struct members were not listed with the appropriate @ prefix. Signed-off-by: David Binder Signed-off-by: David Kershner ---

[PATCH 02/28] staging: unisys: visorbus: check parahotplug_request_complete_result

2016-06-10 Thread David Kershner
From: Erik Arfvidson This patch modifies the caller of parahotplug_request_complete() to check the return value and return appropriate result. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner

[PATCH 03/28] staging: unisys: visorbus: remove unused module parameters

2016-06-10 Thread David Kershner
From: David Binder Removes unused module parameters from visorbus_main.c, in response to findings by SonarQube. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH 00/28] staging: unisys: fix visorbus & visorinput issues raised by tglx

2016-06-10 Thread David Kershner
This patchset comprises the first 26 patches of the previously-submitted patchset (but retracted): [PATCH v4 00/29] Fixed issues raised by tglx, then move visorbus to drivers/virt then adds 2 patches to visorinput that: * fixes a device initialization

[PATCH 09/28] staging: unisys: visorinput: remove unnecessary locking

2016-06-10 Thread David Kershner
From: Tim Sell Locking in the _interrupt() function is NOT necessary so long as we ensure that interrupts have been stopped whenever we need to pause or resume the device, which we now do. While a device is paused, we ensure that interrupts stay disabled, i.e. that the

[PATCH 06/28] staging: unisys: visornic: Correct comment spelling mistake

2016-06-10 Thread David Kershner
From: David Binder Fixes a comment spelling mistake in visornic. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH 11/28] staging: unisys: visorbus: remove periodic_work.h/.c

2016-06-10 Thread David Kershner
From: Tim Sell These files were made no-longer-necessary by recent commits. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/include/periodic_work.h | 40 -

[PATCH 12/28] staging: unisys: visorbus: Make visordriver_callback_lock a mutex

2016-06-10 Thread David Kershner
From: Bryan Thompson visordriver_callback_lock is just a binary semaphore that logically makes more sense as a mutex. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH 01/28] staging: unisys: visorbus: remove return values for write_vbus functions

2016-06-10 Thread David Kershner
From: Erik Arfvidson This patch removes the return values from the write_vbus_* channel functions. Nobody was checking the return values and the value stored into the vbus info is not critical to the functioning of the device. Signed-off-by: Erik Arfvidson

[PATCH 04/28] staging: unisys: visorbus: remove unused struct

2016-06-10 Thread David Kershner
From: David Binder Removes unused struct definition, channel_size_info, in response to findings by SonarQube. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH 10/28] staging: unisys: visorbus: use kernel timer instead of workqueue

2016-06-10 Thread David Kershner
From: Tim Sell A kernel timer is now used as the vehicle to periodically call the channel_interrupt function of registered visor drivers, instead of a workqueue. This simplifies a lot of things by making periodic_work.c and periodic_work.h no longer necessary. This

[PATCH 25/28] staging: unisys: visorbus: fix visorbus_private.h comments

2016-06-10 Thread David Kershner
From: Tim Sell This patch ONLY touches comment lines, i.e., NO executable code is affected. Comments were fixed in visorbus_private.h: * Minor typos were corrected. * Useless comments were removed. Signed-off-by: Tim Sell Signed-off-by: David

[PATCH 19/28] staging: unisys: visorbus: fix visorchannel.c comments

2016-06-10 Thread David Kershner
From: David Binder This patch ONLY touches comment lines, i.e., NO executable code is affected. Comments were fixed in visorchannel.c: * All functions worthy of documenting now use standard kerneldoc formatting. * Multi-line comments were tweaked so as to use

[PATCH 15/28] staging: unisys: Remove reference to unused STANDALONE_CLIENT

2016-06-10 Thread David Kershner
From: Bryan Thompson The STANDALONE_CLIENT define is no longer used by Unisys driver code. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH 08/28] staging: unisys: visorbus: removed unused periodic_test_workqueue

2016-06-10 Thread David Kershner
From: Tim Sell periodic_test_workqueue was an unused relic from the past, and was removed. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorbus_main.c | 15

[PATCH 17/28] staging: unisys: visorbus: fix commenting in vbusdevinfo.h

2016-06-10 Thread David Kershner
From: David Binder This patch ONLY touches comment lines, i.e., NO executable code is affected. * All functions worthy of documenting now use standard kerneldoc formatting. * Multi-line comments were tweaked so as to use appropriate conventions. * Minor typos were

[PATCH 05/28] staging: unisys: visorbus: modify format string to match argument

2016-06-10 Thread David Kershner
From: David Binder Modifies the format string of snprintf to expect an unsigned int instead of a signed one, per the supplied argument. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH 07/28] staging: unisys: include: Remove thread-related enum members

2016-06-10 Thread David Kershner
From: David Binder Code relating to ktheads was previously removed from s-Par driver code. This patch cleans up lingering remnants of kthreads by removing thread- related enum types. Signed-off-by: David Binder Signed-off-by: David Kershner

Re: [PATCH 0/2] PCI: hv: fix a couple of issues in hv_pci_onchannelcallback()

2016-06-10 Thread Bjorn Helgaas
On Mon, May 30, 2016 at 04:17:57PM +0200, Vitaly Kuznetsov wrote: > kmemleak helped me to identify a memory leak in hv_pci_onchannelcallback() > and while fixing it I stumbled upon an unrelated issue(s) there. > > Vitaly Kuznetsov (2): > PCI: hv: don't leak buffer in hv_pci_onchannelcallback()

[PATCH RESEND 21/28] staging: unisys: visorbus: Move visorbus-unique functions to private header

2016-06-10 Thread David Kershner
From: David Binder Moves function prototypes that are unique to visorbus from include/visorbus.h to visorbus/visorbus_private.h. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH RESEND 05/28] staging: unisys: visorbus: modify format string to match argument

2016-06-10 Thread David Kershner
From: David Binder Modifies the format string of snprintf to expect an unsigned int instead of a signed one, per the supplied argument. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH RESEND 27/28] staging: unisys: visorinput: ensure proper locking wrt creation & ints

2016-06-10 Thread David Kershner
From: Tim Sell Ensure we properly lock between visorinput_channel_interrupt(), visorinput_open(), and devdata_create(). We now guarantee that: * interrupts will be disabled and remain disabled during device creation, by setting 'paused = true' across device creation

[PATCH RESEND 14/28] staging: unisys: visorbus: Remove unused functions

2016-06-10 Thread David Kershner
From: Bryan Thompson Remove visorbus_clear_channel, visorchannel_signalqueue_slots_avail, visorchannel_signalqueue_max_slots, visorchannel_clear, and visorchannel_debug which are no longer called by any driver. Signed-off-by: Bryan Thompson

[PATCH RESEND 12/28] staging: unisys: visorbus: Make visordriver_callback_lock a mutex

2016-06-10 Thread David Kershner
From: Bryan Thompson visordriver_callback_lock is just a binary semaphore that logically makes more sense as a mutex. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH RESEND 18/28] staging: unisys: visorbus: fix commenting in visorbus_main.c

2016-06-10 Thread David Kershner
From: David Binder This patch ONLY touches comment lines, i.e., NO executable code is affected. * All functions worthy of documenting now use standard kerneldoc formatting. * Improper uses of kerneldoc formatting were converted to standard multi-line comments. *

[PATCH RESEND 07/28] staging: unisys: include: Remove thread-related enum members

2016-06-10 Thread David Kershner
From: David Binder Code relating to ktheads was previously removed from s-Par driver code. This patch cleans up lingering remnants of kthreads by removing thread- related enum types. Signed-off-by: David Binder Signed-off-by: David Kershner

[PATCH RESEND 25/28] staging: unisys: visorbus: fix visorbus_private.h comments

2016-06-10 Thread David Kershner
From: Tim Sell This patch ONLY touches comment lines, i.e., NO executable code is affected. Comments were fixed in visorbus_private.h: * Minor typos were corrected. * Useless comments were removed. Signed-off-by: Tim Sell Signed-off-by: David

[PATCH RESEND 23/28] staging: unisys: visorbus: Remove notifier-related code from visorbus

2016-06-10 Thread David Kershner
From: David Binder When this functionality was first implemented, visorchipset and visorbus were separate drivers, which necessitated a registration mechanism for them to communicate. More-recently, visorchipset and visorbus were combined into a single driver, and now

[PATCH RESEND 11/28] staging: unisys: visorbus: remove periodic_work.h/.c

2016-06-10 Thread David Kershner
From: Tim Sell These files were made no-longer-necessary by recent commits. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/include/periodic_work.h | 40 -

[PATCH RESEND 15/28] staging: unisys: Remove reference to unused STANDALONE_CLIENT

2016-06-10 Thread David Kershner
From: Bryan Thompson The STANDALONE_CLIENT define is no longer used by Unisys driver code. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH RESEND 13/28] staging: unisys: visorbus: Remove unnecessary EXPORT_SYMBOL statements

2016-06-10 Thread David Kershner
From: Bryan Thompson The driver that is now visorbus started out as multiple separate drivers, and when they were merged the EXPORT_SYMBOL statements that were required for separate drivers were left in the code. This patch removes those now unnecessary exports.

[PATCH RESEND 16/28] staging: unisys: visorbus: remove unused parameter from function

2016-06-10 Thread David Kershner
From: Tim Sell The off parameter to visorchannel_create_guts() was never used, so it was removed. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchannel.c | 7 +++

[PATCH RESEND 19/28] staging: unisys: visorbus: fix visorchannel.c comments

2016-06-10 Thread David Kershner
From: David Binder This patch ONLY touches comment lines, i.e., NO executable code is affected. Comments were fixed in visorchannel.c: * All functions worthy of documenting now use standard kerneldoc formatting. * Multi-line comments were tweaked so as to use

[PATCH RESEND 10/28] staging: unisys: visorbus: use kernel timer instead of workqueue

2016-06-10 Thread David Kershner
From: Tim Sell A kernel timer is now used as the vehicle to periodically call the channel_interrupt function of registered visor drivers, instead of a workqueue. This simplifies a lot of things by making periodic_work.c and periodic_work.h no longer necessary. This

[PATCH RESEND 06/28] staging: unisys: visornic: Correct comment spelling mistake

2016-06-10 Thread David Kershner
From: David Binder Fixes a comment spelling mistake in visornic. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH RESEND 08/28] staging: unisys: visorbus: removed unused periodic_test_workqueue

2016-06-10 Thread David Kershner
From: Tim Sell periodic_test_workqueue was an unused relic from the past, and was removed. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorbus_main.c | 15

[PATCH RESEND 24/28] staging: unisys: visorbus: Rename function to follow existing convention

2016-06-10 Thread David Kershner
From: David Binder Renames visorchipset_device_pause_response to device_pause_response, thereby following the convention that other responder functions follow. Signed-off-by: David Binder Signed-off-by: David Kershner

[PATCH RESEND 17/28] staging: unisys: visorbus: fix commenting in vbusdevinfo.h

2016-06-10 Thread David Kershner
From: David Binder This patch ONLY touches comment lines, i.e., NO executable code is affected. * All functions worthy of documenting now use standard kerneldoc formatting. * Multi-line comments were tweaked so as to use appropriate conventions. * Minor typos were

[PATCH RESEND 00/28] staging: unisys: fix visorbus & visorinput issues raised by tglx

2016-06-10 Thread David Kershner
Resending due to imcomplete distribution list. This patchset comprises the first 26 patches of the previously-submitted patchset (but retracted): [PATCH v4 00/29] Fixed issues raised by tglx, then move visorbus to drivers/virt then adds 2 patches to visorinput

[PATCH RESEND 04/28] staging: unisys: visorbus: remove unused struct

2016-06-10 Thread David Kershner
From: David Binder Removes unused struct definition, channel_size_info, in response to findings by SonarQube. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH RESEND 03/28] staging: unisys: visorbus: remove unused module parameters

2016-06-10 Thread David Kershner
From: David Binder Removes unused module parameters from visorbus_main.c, in response to findings by SonarQube. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH RESEND 01/28] staging: unisys: visorbus: remove return values for write_vbus functions

2016-06-10 Thread David Kershner
From: Erik Arfvidson This patch removes the return values from the write_vbus_* channel functions. Nobody was checking the return values and the value stored into the vbus info is not critical to the functioning of the device. Signed-off-by: Erik Arfvidson

[PATCH RESEND 28/28] staging: unisys: visorinput: make lock_visor_dev a mutex

2016-06-10 Thread David Kershner
From: Tim Sell Since lock_visor_dev is a binary semaphore it makes more sense to use a mutex lock. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visorinput/visorinput.c | 34

[PATCH RESEND 09/28] staging: unisys: visorinput: remove unnecessary locking

2016-06-10 Thread David Kershner
From: Tim Sell Locking in the _interrupt() function is NOT necessary so long as we ensure that interrupts have been stopped whenever we need to pause or resume the device, which we now do. While a device is paused, we ensure that interrupts stay disabled, i.e. that the

[PATCH RESEND 20/28] staging: unisys: visorbus: Rectify commenting in visorchipset.c

2016-06-10 Thread David Kershner
From: David Binder Adds kerneldoc formatting to appropriate functions. Other multi-line comments now use proper formatting. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH RESEND 26/28] staging: unisys: Move vbushelper.h to visorbus directory

2016-06-10 Thread David Kershner
Only visorbus needs this header file so move it to visorbus directory. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/vbushelper.h | 46

[PATCH RESEND 22/28] staging: unisys: visorbus: rectify kerneldoc comment for struct

2016-06-10 Thread David Kershner
From: David Binder Fixes the kerneldoc comment for struct visor_device - the struct members were not listed with the appropriate @ prefix. Signed-off-by: David Binder --- drivers/staging/unisys/include/visorbus.h | 34

[PATCH 1/3] include: linux: visorbus: Add visorbus to include/linux directory

2016-06-10 Thread David Kershner
Update include/linux to include the s-Par associated common include header files needed for the s-Par visorbus. Since we have now moved the include directories over to include/linux/visorbus this patch makes all of the visor drivers visorbus, visorinput, visornic, and visorhba use the new include

[PATCH 2/3] Documentation: Move visorbus documentation from staging to Documentation/

2016-06-10 Thread David Kershner
This patch simple does a git mv of the drivers/staging/unisys/Documentation directory to Documentation. Renames overview.txt to visorbus.txt and renames sysfs-platform-visorchipset to the correct name sysfs-bus-visorbus. Signed-off-by: David Kershner Reviewed-by: Tim

[PATCH 3/3] drivers: Add visorbus to the drivers/virt directory

2016-06-10 Thread David Kershner
visorbus is currently located at drivers/staging/visorbus, this patch moves it to drivers/virt. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/Kconfig| 3 +--

[PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

2016-06-10 Thread David Kershner
This patchset is dependent on the previously-submitted patchset: staging: unisys: fix visorbus & visorinput issues raised by tglx This patchset moves drivers/staging/unisys/include to include/linux/visorbus, and moves drivers/staging/unisys/visorbus to drivers/virt/visorbus. This

RE: [PATCH v4 09/29] staging: unisys: visorinput: remove unnecessary locking

2016-06-10 Thread Sell, Timothy C
> > > > From: Thomas Gleixner [mailto:t...@linutronix.de] > > > > > > > > I think I asked this before, but I might have missed the answer. > > > > > > > > Why is this a rw_sempahore? It's never taken with down_read and > > looking > > > > at the usage sites it's simply a mutex, right? > > > > > >

Re: [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs in own kmem_caches

2016-06-10 Thread Faccini, Bruno
Hello, The intent of this patch is not to solve the corruptions for sure, but only to avoid the concerned MEs/small-MDs LNet structs to be quite frequently impacted due to their high allocation/free rate. This may also possibly help to save cycles due to high usage and contention when using a