Re: [PATCH v3 0/7] lib: string: add functions to case-convert strings

2016-07-20 Thread Markus Mayer
On Wed, Jul 13, 2016 at 03:52:38PM -0700, Markus Mayer wrote: > On Sat, Jul 09, 2016 at 09:11:05PM -0700, Markus Mayer wrote: >> On 9 July 2016 at 20:13, Chris Metcalf wrote: >>> On 7/8/2016 6:43 PM, Markus Mayer wrote: This series introduces a family of generic

Re: [PATCH 3/9] staging: ks7010: Return directly after a failed kmalloc()

2016-07-20 Thread SF Markus Elfring
>>> @@ -713,10 +713,8 @@ static int ks7010_sdio_update_index(struct >>> ks_wlan_private *priv, u32 index) >>> unsigned char *data_buf; >>> >>> data_buf = kmalloc(sizeof(u32), GFP_KERNEL); >>> - if (!data_buf) { >>> - rc = 1; >>> - goto error_out; >>> - } >>> + if

Re: [PATCH 5/9] staging: ks7010: Delete unnecessary uses of the variable "retval"

2016-07-20 Thread SF Markus Elfring
>>> @@ -90,7 +90,6 @@ static int ks7010_sdio_write(struct ks_wlan_private >>> *priv, unsigned int address, >>> void ks_wlan_hw_sleep_doze_request(struct ks_wlan_private *priv) >>> { >>> unsigned char rw_data; >>> - int retval; >>> >>> DPRINTK(4, "\n"); >>> >>> @@ -99,9 +98,10 @@ void

[PATCH] Staging: media: timblogiw: File cleanup.

2016-07-20 Thread Jeremiah Goerdt
Cleaned up checkpatch.pl warnings and checks. Signed-off-by: Jeremiah Goerdt --- drivers/staging/media/timb/timblogiw.c | 134 - 1 file changed, 67 insertions(+), 67 deletions(-) diff --git a/drivers/staging/media/timb/timblogiw.c

Re: staging: ks7010: Rename jump labels

2016-07-20 Thread Jean Delvare
Hello Markus, Wolfram, On Wed, 20 Jul 2016 20:21:25 +0200, SF Markus Elfring wrote: > >> Adjust jump targets according to the Linux coding style convention. > > > > Really? Is that documented somewhere? > > How do you think about information from the chapter "7: Centralized exiting > of

Re: staging: ks7010: Rename jump labels

2016-07-20 Thread SF Markus Elfring
>> Adjust jump targets according to the Linux coding style convention. > > Really? Is that documented somewhere? How do you think about information from the chapter "7: Centralized exiting of functions"?

Re: [PATCH v6] [media] pci: Add tw5864 driver

2016-07-20 Thread Hans Verkuil
On 07/20/2016 03:42 AM, Andrey Utkin wrote: > Changes since v5: > - Rework known issues notice as suggested by Hans Verkuil (and previously > Joe Perches) > > I am leaving for a vacation in a day and won't respond before 3rd of August. > I wish to all of you to enjoy your time, too. > > Thanks

[PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Arnd Bergmann
Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of incorrect code that results from 'char' being unsigned here, e.g. staging/rtl8192e/rtl8192e/r8192E_phy.c:1072:36: error: comparison is always false due to limited range of data type [-Werror=type-limits]

Re: [PATCH 3/3] staging/rtl8192e: avoid comparing unsigned type >= 0

2016-07-20 Thread Jes Sorensen
Arnd Bergmann writes: > There is one remaining warning about a type limit check in rtl8192e: > > staging/rtl8192e/rtl819x_TSProc.c:326:14: error: comparison is always true > due to limited range of data type [-Werror=type-limits] > > This changes a macro into a local function to

Re: [PATCH 2/9] staging: ks7010: Delete unnecessary assignments for buffer variables

2016-07-20 Thread Wolfram Sang
On Sun, Jul 17, 2016 at 08:15:11PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 17 Jul 2016 13:38:46 +0200 > > A few variables were assigned a null pointer despite of the detail > that they were immediately reassigned by the following

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Jes Sorensen
Arnd Bergmann writes: > On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote: >> Arnd Bergmann writes: >> Well it really all depends on how much time I have and how much others >> step up and help contribute to the code. For rtl8xxxu my plans are as >>

[PATCH 3/3] staging/rtl8192e: avoid comparing unsigned type >= 0

2016-07-20 Thread Arnd Bergmann
There is one remaining warning about a type limit check in rtl8192e: staging/rtl8192e/rtl819x_TSProc.c:326:14: error: comparison is always true due to limited range of data type [-Werror=type-limits] This changes a macro into a local function to clarify the types and simplify the check while

[PATCH 1/3] staging/rtl8192u: use s8 instead of char

2016-07-20 Thread Arnd Bergmann
Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of incorrect code that results from 'char' being unsigned here, e.g. staging/rtl8192u/r8192U_core.c:4150:16: error: comparison is always false due to limited range of data type [-Werror=type-limits]

Re: [PATCH 1/9] staging: ks7010: Delete unnecessary checks before the function call "kfree"

2016-07-20 Thread Wolfram Sang
On Sun, Jul 17, 2016 at 08:10:48PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 17 Jul 2016 13:14:57 +0200 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the calls is not

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Christian Lamparter
On Wednesday, July 20, 2016 5:06:27 PM CEST Xose Vazquez Perez wrote: > Arnd Bergmann wrote: > > > rtlwifi, but I found the older r8712u device to work fine with > > the staging/rtl8712 driver. > > A replacement for "staging/rtl8712", with MAC80211 support, is > available at:

Re: [PATCH 3/9] staging: ks7010: Return directly after a failed kmalloc()

2016-07-20 Thread Wolfram Sang
On Sun, Jul 17, 2016 at 08:58:14PM +0200, Julia Lawall wrote: > > > On Sun, 17 Jul 2016, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Sun, 17 Jul 2016 15:55:02 +0200 > > > > Return directly after a memory allocation failed at the beginning. > > >

Re: [PATCH 5/9] staging: ks7010: Delete unnecessary uses of the variable "retval"

2016-07-20 Thread Wolfram Sang
On Sun, Jul 17, 2016 at 08:56:59PM +0200, Julia Lawall wrote: > > > On Sun, 17 Jul 2016, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Sun, 17 Jul 2016 18:15:23 +0200 > > > > Some return values can also be directly used for various condition

Re: [PATCH 8/9] staging: ks7010: Delete a variable in write_to_device()

2016-07-20 Thread Wolfram Sang
On Sun, Jul 17, 2016 at 08:28:44PM +0200, SF Markus Elfring wrote: > From 01291121668ccb54f1a784765a8d2b5811afa75a Mon Sep 17 00:00:00 2001 > From: Markus Elfring > Date: Sun, 17 Jul 2016 19:26:15 +0200 > Subject: [PATCH 8/9] staging: ks7010: Delete a variable in

RE: [PATCH] staging: comedi: ni_mio_common: fix AO inttrig backwards compatibility

2016-07-20 Thread Hartley Sweeten
On Tuesday, July 19, 2016 4:18 AM, Ian Abbott wrote: > Commit ebb657babfa9 ("staging: comedi: ni_mio_common: clarify the > cmd->start_arg validation and use") introduced a backwards compatibility > issue in the use of asynchronous commands on the AO subdevice when > `start_src` is `TRIG_EXT`.

Re: [PATCH 4/9] staging: ks7010: Rename jump labels

2016-07-20 Thread Wolfram Sang
On Sun, Jul 17, 2016 at 08:20:12PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 17 Jul 2016 16:26:18 +0200 > > Adjust jump targets according to the Linux coding style convention. Really? Is that documented somewhere? Quoting Jean Delvare:

Re: [PATCH] Staging: ks7010: michael_mic: fixed macros coding style issue

2016-07-20 Thread Wolfram Sang
On Tue, Jul 19, 2016 at 09:51:06AM +0800, Bing Sun wrote: > Fixed coding style issue: > Enclose multiple statements macros definition in a do while loop. > Use one space around binary operators. > > Signed-off-by: Bing Sun Looks good for what it is. One comment below.

Re: [PATCH 7/9] staging: ks7010: Replace three printk() calls by pr_err()

2016-07-20 Thread Wolfram Sang
On Sun, Jul 17, 2016 at 01:26:03PM -0700, Joe Perches wrote: > On Sun, 2016-07-17 at 20:27 +0200, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Sun, 17 Jul 2016 19:12:27 +0200 > > > > Prefer usage of the macro "pr_err" over the interface "printk". > >

Re: [PATCH 6/9] staging: ks7010: Delete unnecessary braces

2016-07-20 Thread Wolfram Sang
On Sun, Jul 17, 2016 at 08:55:41PM +0200, Julia Lawall wrote: > > > On Sun, 17 Jul 2016, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Sun, 17 Jul 2016 18:39:03 +0200 > > > > Do not use curly brackets at some source code places > > where a single

[PATCH] staging: comedi: ni_mio_common: fix wrong insn_write handler

2016-07-20 Thread Ian Abbott
For counter subdevices, the `s->insn_write` handler is being set to the wrong function, `ni_tio_insn_read()`. It should be `ni_tio_insn_write()`. Signed-off-by: Ian Abbott Reported-by: Éric Piel Fixes: 10f74377eec3 ("staging: comedi: ni_tio: make

Re: [PATCH] staging: comedi: ni_mio_common: fix AO inttrig backwards compatibility

2016-07-20 Thread Ian Abbott
On 20/07/16 16:55, Hartley Sweeten wrote: On Tuesday, July 19, 2016 4:18 AM, Ian Abbott wrote: Commit ebb657babfa9 ("staging: comedi: ni_mio_common: clarify the cmd->start_arg validation and use") introduced a backwards compatibility issue in the use of asynchronous commands on the AO subdevice

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Arnd Bergmann
On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote: > Arnd Bergmann writes: > > On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote: > >> Arnd Bergmann writes: > >> Well it really all depends on how much time I have and how much others > >>

Re: [PATCH 9/9] staging: ks7010: Delete three unnecessary variable initialisations

2016-07-20 Thread Wolfram Sang
On Sun, Jul 17, 2016 at 08:51:39PM +0200, Julia Lawall wrote: > > > On Sun, 17 Jul 2016, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Sun, 17 Jul 2016 19:40:47 +0200 > > > > Three variables will be set to an appropriate value a bit later. > >