Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in prism2sta.c

El 2016年10月03日 a las 20:18, Joe Perches escribió: On Mon, 2016-10-03 at 20:12 +0200, Sergio Paracuellos wrote: El 2016年10月03日 a las 18:16, Joe Perches escribió: Perhaps better as hw->scanresults = kmemdup(inf, sizeof(*inf), GFP_ATOMIC); I agree. But because all the code is full of

[PATCH] staging: greybus: fix block comment

This patch fix the coding style problem of block comment detected by the checkpatch.pl. WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Hisao Tanabe --- drivers/staging/greybus/arche-apb-ctrl.c | 8 +--- 1 file changed, 5 insertions(+), 3

[PATCH 03/15] staging: wlang-ng: fix block comment warnings in p80211conv.c

This patch fix the following checkpatch.pl warnings in p80211conv.c: WARNING: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211conv.c | 318 +-- 1 file changed, 159

[PATCH 08/15] staging: wlang-ng: fix line style warnings in p80211req.c

This patch fix the following checkpatch.pl warnings in p80211req.c: WARNING: line over 80 characters Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211req.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 10/15] staging: wlang-ng: fix line style warnings in p80211wep.c

This patch fix the following checkpatch.pl warnings in p80211wep.c: WARNING: line over 80 characters Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211wep.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 11/15] staging: wlang-ng: fix block comment warnings in prism2mgmt.c

This patch fix the following checkpatch.pl warnings in prism2mgmt.c: WARNING: Block comments should align the * on each line WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2mgmt.c |

[PATCH 14/15] staging: wlang-ng: fix line style warnings in prism2sta.c

This patch fix the following checkpatch.pl warnings in prism2sta.c: WARNING: line over 80 characters Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2sta.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[PATCH] staging: wlang-ng: avoid new typedef CTLX_STATE

This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef CTLX_STATE Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 3 +-- drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-

[PATCH 02/15] staging: wlang-ng: fix block comment warnings in hfa384x_usb.c

This patch fix the following checkpatch.pl warnings in hfa384x_usb.c: WARNING: Block comments should align the * on each line WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x_usb.c

[PATCH 06/15] staging: wlang-ng: do not return -ENOSYS

Fixed coding style issue by replacing ENOSYS with EINVAL. This patch fix the following checkpatch.pl warnings in p80211netdev.c: WARNING: ENOSYS means 'invalid syscall nr' and nothing else Signed-off-by: Sergio Paracuellos ---

[PATCH 01/15] staging: wlang-ng: fix line style warnings in hfa384x_usb.c

This patch fix the following checkpatch.pl warnings in hfa384x_usb.c: WARNING: line over 80 characters Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x_usb.c | 71 +++ 1 file changed, 38 insertions(+), 33

[PATCH 04/15] staging: wlang-ng: fix line style warnings in p80211netdev.c

This patch fix the following checkpatch.pl warnings in p80211netdev.c: WARNING: line over 80 characters Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211netdev.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[PATCH 00/15] staging: wlang-ng: Fix several style issues in several source files.

This patch series fix some of the following checkpatch.pl reported warnings: WARNING: line over 80 characters WARNING: Block comments should align the * on each line WARNING: Block comments use a trailing */ on a separate line WARNING: ENOSYS means 'invalid syscall nr' and nothing else Sergio

Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in prism2sta.c

On Mon, 2016-10-03 at 18:04 +0200, Sergio Paracuellos wrote: > This patch fix the following checkpatch.pl warnings in prism2sta.c: > WARNING: line over 80 characters [] > diff --git a/drivers/staging/wlan-ng/prism2sta.c > b/drivers/staging/wlan-ng/prism2sta.c [] > @@ -1099,7 +1101,8 @@ static

[PATCH 05/15] staging: wlang-ng: fix block comment warnings in p80211netdev.c

This patch fix the following checkpatch.pl warnings in p80211netdev.c: WARNING: Block comments should align the * on each line WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211netdev.c

[PATCH 07/15] staging: wlang-ng: fix block comment warnings in p80211req.c

This patch fix the following checkpatch.pl warnings in p80211req.c: WARNING: Block comments should align the * on each line WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211req.c | 166

[PATCH 15/15] staging: wlang-ng: fix block comment warnings in prism2fw.c

This patch fix the following checkpatch.pl warnings in prism2fw.c WARNING: Block comments should align the * on each line WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2fw.c | 485

[PATCH 09/15] staging: wlang-ng: fix block comment warnings in p80211wep.c

This patch fix the following checkpatch.pl warnings in p80211wep.c: WARNING: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211wep.c | 90 ++--- 1 file changed, 45

[PATCH 13/15] staging: wlang-ng: fix block comment warnings in prism2sta.c

This patch fix the following checkpatch.pl warnings in prism2sta.c: WARNING: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2sta.c | 36 ++-- 1 file changed, 18

[PATCH 12/15] staging: wlang-ng: fix block comment warnings in prism2mib.c

This patch fix the following checkpatch.pl warnings in prism2mib.c: WARNING: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2mib.c | 100 ++-- 1 file changed, 50

[PATCH 2/9] staging: wlang-ng: fix block comments style in p80211hdr.h

This patch fixes the following checkpatch.pl warning in p80211hdr.h: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211hdr.h | 114 ++-- 1 file changed, 57

[PATCH 6/9] staging: wlang-ng: fix block comments style in p80211msg.h

This patch fixes the following checkpatch.pl warning in p80211msg.h Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211msg.h | 90 ++--- 1 file changed, 45

[PATCH 8/9] staging: wlang-ng: fix block comments style in p80211req.h

This patch fixes the following checkpatch.pl warning in p80211req.h Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211req.h | 90 ++--- 1 file changed, 45

[PATCH 1/9] staging: wlang-ng: fix block comments style in p80211conv.h

This patch fixes the following checkpatch.pl warning in p80211conv.h: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211conv.h | 100 +-- 1 file changed, 50

[PATCH 7/9] staging: wlang-ng: fix block comments style in p80211netdev.h

This patch fixes the following checkpatch.pl warning in p80211netdev.h Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211netdev.h | 100 - 1 file changed, 50

[PATCH 3/9] staging: wlang-ng: fix block comments style in p80211ioctl.h

This patch fixes the following checkpatch.pl warning in p80211ioctl.h Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211ioctl.h | 120 +- 1 file changed, 60

[PATCH 9/9] staging: wlang-ng: fix block comments style in prism2mgmt.h

This patch fixes the following checkpatch.pl warning in prism2mgmt.h Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2mgmt.h | 122 ++- 1 file changed, 62

[PATCH 5/9] staging: wlang-ng: fix block comments style in p80211mgmt.h

This patch fixes the following checkpatch.pl warning in p80211mgmt.h: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211mgmt.h | 194 +-- 1 file changed, 97

[PATCH 4/9] staging: wlang-ng: fix block comments style in p80211metadef.h

This patch fixes the following checkpatch.pl warning in p80211metadef.h Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211metadef.h | 88 - 1 file changed, 44

[PATCH 0/9] staging: wlang-ng: fix block comments style warning in header files

This patch series fix checkpatch.pl script reported warning Block comments should align the * on each line Sergio Paracuellos (9): staging: wlang-ng: fix block comments style in p80211conv.h staging: wlang-ng: fix block comments style in p80211hdr.h staging: wlang-ng: fix block comments

[PATCH] staging: wlang-ng: get memory from kernel allocators instead of big static buffer

This patch fix the following sparse warnings in prism2fw.c: warning: memset with byte count of 12 Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2fw.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in prism2sta.c

El 2016年10月03日 a las 18:16, Joe Perches escribió: On Mon, 2016-10-03 at 18:04 +0200, Sergio Paracuellos wrote: This patch fix the following checkpatch.pl warnings in prism2sta.c: WARNING: line over 80 characters [] diff --git a/drivers/staging/wlan-ng/prism2sta.c

Re: [PATCH] [media] : Removing warnings caught by checkpatch.pl

On Sun, Oct 02, 2016 at 02:30:45AM +0530, Harman Kalra wrote: > static int iss_video_queue_setup(struct vb2_queue *vq, > - unsigned int *count, unsigned int *num_planes, > - unsigned int sizes[], struct device > *alloc_devs[]) > +

[PATCH 0/8] staging: rts5208: Cleanup

This patchset is just clean-up in xd.c and xd.h in the rts5208 driver. All checkpatch.pl issues have been resolved except for lines over 80 characters. Most of those should be refactored. Wayne Porter (8): staging: rts5208: Fix CamelCase found by checkpatch staging: rts5208: xd.h: Alignment

[PATCH 3/8] staging: rts5208: Alignment fix

Coding style checks found by checkpatch Signed-off-by: Wayne Porter --- drivers/staging/rts5208/xd.c | 332 +++ 1 file changed, 179 insertions(+), 153 deletions(-) diff --git a/drivers/staging/rts5208/xd.c

[PATCH 2/8] staging: rts5208: xd.h: Alignment fix

Change alignment to match open parenthesis Signed-off-by: Wayne Porter --- drivers/staging/rts5208/xd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/xd.h b/drivers/staging/rts5208/xd.h index 675b0bf..33ad1f4 100644 ---

[PATCH 1/8] staging: rts5208: Fix CamelCase found by checkpatch

Convert CamelCase to recommended style. Signed-off-by: Wayne Porter --- drivers/staging/rts5208/xd.c | 8 drivers/staging/rts5208/xd.h | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rts5208/xd.c

[PATCH 7/8] staging: rts5208: xd.c: Fix CamelCase

Covert CamelCase as checkpatch suggests Signed-off-by: Wayne Porter --- drivers/staging/rts5208/xd.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c index

Re: [PATCH 4/8] staging: rts5208: Logical continuation fixes

On Mon, 2016-10-03 at 23:17 +, Wayne Porter wrote: > Checkpatch detected multiple instances of logical continuation warnings [] > diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c [] > @@ -819,11 +819,11 @@ static int reset_xd(struct rtsx_chip *chip) >

[PATCH 8/8] staging: rts5208: xd.c: Remove multiple assignments

Checkpatch found multiple assignments on one line so move them to their own lines. Signed-off-by: Wayne Porter --- drivers/staging/rts5208/xd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c

[PATCH 5/8] staging: rts5208: xd.c: Remove unnecessary parentheses

Issues found with checkpatch Signed-off-by: Wayne Porter --- drivers/staging/rts5208/xd.c | 64 ++-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c index

[PATCH 6/8] staging: rts5208: xd.c: Clean up comparison to NULL

Checkpatch recommended changes Signed-off-by: Wayne Porter --- drivers/staging/rts5208/xd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c index 4d8733f..ccc5dd9 100644 ---

[PATCH 4/8] staging: rts5208: Logical continuation fixes

Checkpatch detected multiple instances of logical continuation warnings Signed-off-by: Wayne Porter --- drivers/staging/rts5208/xd.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rts5208/xd.c

Re: [PATCH v2 1/3] staging: greybus: sdio: fix cmd_flags check for none response

On Fri, Sep 30, 2016 at 11:54 PM, Rui Miguel Silva wrote: > When checking for command flags field if response is not available we > really need to compare it with the right define and not bitwise AND it. > > smatch warn: > drivers/staging/greybus/sdio.c:481

Re: [PATCH v2 2/3] staging: greybus: light: fix attributes allocation

On Fri, Sep 30, 2016 at 11:54 PM, Rui Miguel Silva wrote: > Fix allocation of attributes with the correct size, this also fix smatch > warning: > > drivers/staging/greybus/light.c:293 channel_attr_groups_set() > warn: double check that we're allocating correct size: 8 vs 16 > >

Re: [PATCH] [media] : Removing warnings caught by checkpatch.pl

Hello Harman, Thank you for the patch. The subject of your commit message should at least contain the name of the driver. Furthermore, you can mention that the patch originates from warnings output by checkpatch.pl, but the subject should describe what you fix (in this case what type of

Re: [PATCH] [media] v4l: omap4iss: Fix using BIT macro

On Monday 03 Oct 2016 06:58:22 Mauro Carvalho Chehab wrote: > Em Sat, 1 Oct 2016 16:37:46 -0700 Wayne Porter escreveu: > > Checks found by checkpatch > > > > Signed-off-by: Wayne Porter > > --- > > > > drivers/staging/media/omap4iss/iss_regs.h | 76

Re: [PATCH v2 3/3] staging: greybus: light: check delay_{on|off} before use

On Fri, Sep 30, 2016 at 11:54 PM, Rui Miguel Silva wrote: > Even though we trust leds core that the pointers should be valid, we are > safer to check delay_{on|off} before use. As these routines are getting called from core, I am not sure if it will be right to have such

Re: [PATCH] [media] v4l: omap4iss: Fix using BIT macro

Hi Wayne, Thank you for the patch. On Saturday 01 Oct 2016 16:37:46 Wayne Porter wrote: > Checks found by checkpatch > > Signed-off-by: Wayne Porter > --- > drivers/staging/media/omap4iss/iss_regs.h | 76 +--- > 1 file changed, 38 insertions(+), 38

Re: [PATCH] [media] v4l: omap4iss: Fix using BIT macro

Em Sat, 1 Oct 2016 16:37:46 -0700 Wayne Porter escreveu: > Checks found by checkpatch > > Signed-off-by: Wayne Porter > --- > drivers/staging/media/omap4iss/iss_regs.h | 76 > +++ > 1 file changed, 38 insertions(+), 38

[PATCH v4] staging: greybus: Fix a commit coding style issue.

Fixes a comment coding style warning by adding 2 blank lines. Issue found by checkpatch. Signed-off-by: Sidhant Gupta --- Changes since v3: * Corrected checkpatch.pl error earlier caused by this patch. drivers/staging/greybus/arche-apb-ctrl.c | 6 -- 1 file

Re: [PATCH] staging: lustre: ko2iblbd: handle ib_dereg_mr removal

Hell no. If you had actually read the changelog you'd see that there is a reason the functions went away, and simply calling the underlying methods (which also will go away) will not fix it. Please go back reading the changelogs, and while we're at it read some basic introductions into the RDMA

Re: [PATCH v4] staging: greybus: Fix a commit coding style issue.

On Mon, Oct 03, 2016 at 04:21:09PM +0530, Sidhant Gupta wrote: > Fixes a comment coding style warning by adding 2 blank lines. Issue > found by checkpatch. > > Signed-off-by: Sidhant Gupta Acked-by: Johan Hovold Thanks, Johan

Re: [PATCH v4] staging: greybus: Fix a commit coding style issue.

On Mon, Oct 3, 2016 at 4:21 PM, Sidhant Gupta wrote: > Fixes a comment coding style warning by adding 2 blank lines. Issue > found by checkpatch. > > Signed-off-by: Sidhant Gupta > --- > > Changes since v3: > * Corrected checkpatch.pl error

[PATCH 2/2 v3] pci-hyperv: lock pci bus on device eject

From: Long Li A PCI_EJECT message can arrive at the same time we are calling pci_scan_child_bus in the workqueue for the previous PCI_BUS_RELATIONS message or in create_root_hv_pci_bus(), in this case we could potentailly modify the bus from multiple places. Properly

[PATCH 1/2 v3] pci-hyperv: properly handle pci bus remove

From: Long Li hv_pci_devices_present is called in hv_pci_remove when we remove a PCI device from host (e.g. by disabling SRIOV on a device). In hv_pci_remove, the bus is already removed before the call, so we don't need to rescan the bus in the workqueue scheduled from

Re: [PATCH v4] staging: greybus: Fix a commit coding style issue.

On Monday 03 October 2016 04:21 PM, Sidhant Gupta wrote: > Fixes a comment coding style warning by adding 2 blank lines. Issue > found by checkpatch. > > Signed-off-by: Sidhant Gupta Reviewed-by: Vaishali Thakkar > --- > > Changes

Re: [PATCH] staging: greybus: fix block comment

On Mon, Oct 3, 2016 at 8:15 PM, Hisao Tanabe wrote: > This patch fix the coding style problem of block comment detected by the > checkpatch.pl. > > WARNING: Block comments use a trailing */ on a separate line > > Signed-off-by: Hisao Tanabe > --- >