On Tue, Jan 24, 2017 at 12:34:04PM -0800, Michael Zoran wrote:
> The vchi_msg_queue function which is used by other drivers
> to queue a message is difficult to understand and overly
> generic. Remove it and replace it with two more specific functions.
The vc04_services is missing several drivers.
Fixed the following checkpatch.pl errors in fb_pcd8544.c:
ERROR: Use 4 digit octal (0777) not decimal permissions
+module_param(tc, uint, 0);
ERROR: Use 4 digit octal (0777) not decimal permissions
+module_param(bs, uint, 0);
Also made the two module parameters readable from sysfs.
Signed-off-by
On Wed, 2017-01-25 at 15:10 +0300, Dan Carpenter wrote:
> On Tue, Jan 24, 2017 at 12:34:04PM -0800, Michael Zoran wrote:
> > The vchi_msg_queue function which is used by other drivers
> > to queue a message is difficult to understand and overly
> > generic. Remove it and replace it with two more sp
On Wed, Jan 25, 2017 at 02:24:22PM +0200, Dragos Tarcatu wrote:
> Fixed the following checkpatch.pl errors in fb_pcd8544.c:
>
> ERROR: Use 4 digit octal (0777) not decimal permissions
> +module_param(tc, uint, 0);
> ERROR: Use 4 digit octal (0777) not decimal permissions
> +module_param(bs, uint,
On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote:
> Just for clarity, when you mean staging code? Are you talking about the
> entire vc04_services driver or are we talking about the vchi_msg_queue
> function?
>
> At this point, vc04_services isn't used by anything in the tree at all
'Restructure architecture specific code' series (now merged in char-misc)
introduced a regression wrt kexec/kdump. Hypercall and TSC pages setup was
moved out to the architecture specific code and the cleanup was dropped. We,
however, still need this cleanup: in kexec case the new kernel may try
us
We need to cleanup the TSC page before doing kexec/kdump or the new kernel
may crash if it tries to use it.
Fixes: 63ed4e0c67df ("Drivers: hv: vmbus: Consolidate all Hyper-V specific
clocksource code")
Signed-off-by: Vitaly Kuznetsov
---
arch/x86/hyperv/hv_init.c | 4
1 file changed, 4 ins
We need to cleanup the hypercall page before doing kexec/kdump or the new
kernel may crash if it tries to use it. Reuse the now-empty hv_cleanup
function renaming it to hyperv_cleanup and moving to the arch specific
code.
Fixes: 8730046c1498 ("Drivers: hv vmbus: Move Hypercall page setup out of
c
On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote:
> On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote:
> > Just for clarity, when you mean staging code? Are you talking about
> > the
> > entire vc04_services driver or are we talking about the
> > vchi_msg_queue
> > function?
> >
On Wed, Jan 25, 2017 at 05:27:14AM -0800, Michael Zoran wrote:
> On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote:
> > On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote:
> > > Just for clarity, when you mean staging code? Are you talking about
> > > the
> > > entire vc04_services
On Wed, 2017-01-25 at 14:33 +0100, Greg KH wrote:
> On Wed, Jan 25, 2017 at 05:27:14AM -0800, Michael Zoran wrote:
> > On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote:
> > > On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote:
> > > > Just for clarity, when you mean staging code? A
On Wed, Jan 25, 2017 at 05:41:50AM -0800, Michael Zoran wrote:
> > > I'm just saying that IF the decision was made to continue
> > > upstreaming
> > > these drivers, then I'm willing to continue helping by submitting
> > > improvements.
> >
> > Either they should be merged, or these apis and struc
On Wed, 2017-01-25 at 17:12 +0300, Dan Carpenter wrote:
> > Again, that's not my decision. I can go either way. But if the
> > decision was made to delete it, I think the 4.10 version should
> > also be
> > deleted because the same logic applies. Nothing uses it 4.10
> > either
> > and 4.10 is s
On 25.01.2017 14:39, Greg Kroah-Hartman wrote:
On Wed, Jan 25, 2017 at 02:24:22PM +0200, Dragos Tarcatu wrote:
Fixed the following checkpatch.pl errors in fb_pcd8544.c:
ERROR: Use 4 digit octal (0777) not decimal permissions
+module_param(tc, uint, 0);
ERROR: Use 4 digit octal (0777) not decim
Coverity scan gives a warning when there is fall through in a switch
without a comment.
Reported-by: Stephen Hemminger
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/hv_balloon.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
index 14
On Wed, 2017-01-25 at 06:23 -0800, Michael Zoran wrote:
> On Wed, 2017-01-25 at 17:12 +0300, Dan Carpenter wrote:
> > > Again, that's not my decision. I can go either way. But if the
> > > decision was made to delete it, I think the 4.10 version should
> > > also be
> > > deleted because the same
This driver does not have a low-latency mode and should not report
anything else.
Also drop the skip-test flag which isn't used either.
Signed-off-by: Johan Hovold
---
drivers/staging/greybus/uart.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/uart.c b/drivers/stag
On Wed, 2017-01-25 at 08:53 -0800, Michael Zoran wrote:
> On Wed, 2017-01-25 at 06:23 -0800, Michael Zoran wrote:
> > On Wed, 2017-01-25 at 17:12 +0300, Dan Carpenter wrote:
> > > > Again, that's not my decision. I can go either way. But if
> > > > the
> > > > decision was made to delete it, I th
Currently this module needs to be manually configured by COMEDI
userspace tool before the test waveform can be read by a COMEDI
compatible application.
This patch adds auto-configuration capability and makes it the default
loading option. This is achieved by creating a device during init
to stand
It fixes the following issue reported by checkpatch.pl:
Prefer kernel type 'u32' over 'uint32_t'
Signed-off-by: Franck Demathieu
---
drivers/staging/greybus/sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
> Michael Zoran hat am 25. Januar 2017 um 17:53
> geschrieben:
>
>
> On Wed, 2017-01-25 at 06:23 -0800, Michael Zoran wrote:
> > On Wed, 2017-01-25 at 17:12 +0300, Dan Carpenter wrote:
> > > > Again, that's not my decision. I can go either way. But if the
> > > > decision was made to delete i
On Wed, 2017-01-25 at 18:39 +0100, Stefan Wahren wrote:
> > Michael Zoran hat am 25. Januar 2017 um 17:53
> > geschrieben:
> >
> >
> > On Wed, 2017-01-25 at 06:23 -0800, Michael Zoran wrote:
> > > On Wed, 2017-01-25 at 17:12 +0300, Dan Carpenter wrote:
> > > > > Again, that's not my decision. I
Hi,
On Wed, Jan 25, 2017 at 06:38:01PM +0100, Franck Demathieu wrote:
It fixes the following issue reported by checkpatch.pl:
Prefer kernel type 'u32' over 'uint32_t'
Signed-off-by: Franck Demathieu
Acked-by: Rui Miguel Silva
Cheers,
Rui
---
drivers/staging/greybus/sdio.c | 2 +-
1
Simpe /* fallthrough */ is enough
-Original Message-
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
Sent: Wednesday, January 25, 2017 8:27 AM
To: de...@linuxdriverproject.org
Cc: linux-ker...@vger.kernel.org; KY Srinivasan ; Haiyang
Zhang ; Stephen Hemminger
Subject: [PATCH] Driver
On 01/20/2017 06:48 AM, Hans Verkuil wrote:
On 01/07/2017 03:11 AM, Steve Longerbeam wrote:
+
+ /* cached control settings */
+ int ctrl_cache[OV5640_MAX_CONTROLS];
This is just duplicating the cached value in the control framework. I think
this can be dropped.
done, see below.
Greg KH writes:
> On Wed, Jan 25, 2017 at 05:27:14AM -0800, Michael Zoran wrote:
>> On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote:
>> > On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote:
>> > > Just for clarity, when you mean staging code? Are you talking about
>> > > the
>>
On Wed, 2017-01-25 at 10:09 -0800, Michael Zoran wrote:
> On Wed, 2017-01-25 at 18:39 +0100, Stefan Wahren wrote:
> > > Michael Zoran hat am 25. Januar 2017 um
> > > 17:53
> > > geschrieben:
> > Looking at the TODO shows 3 candidates: vc_mem, bcm2835-camera,
> > VCSM
> >
> > I suggest to pick one
On Wed, 2017-01-25 at 12:27 -0800, Eric Anholt wrote:
> Greg KH writes:
>
> > On Wed, Jan 25, 2017 at 05:27:14AM -0800, Michael Zoran wrote:
> > > On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote:
> > > > On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote:
> > > > > Just for clar
The newly added function triggers a harmless warning:
drivers/staging/lustre/lustre/ptlrpc/pack_generic.c: In function
'lustre_shrink_msg':
drivers/staging/lustre/lustre/ptlrpc/pack_generic.c:472:1: error: control
reaches end of non-void function [-Werror=return-type]
This probably happens beca
Replace symbolic permissions with their octect representation to fix
checkpatch warnings.
Signed-off-by: Sebastian Haas
---
drivers/staging/most/hdm-usb/hdm_usb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c
b/drivers/staging/m
Initial cleanup of bcm2835-audio driver for the
bcm2535(Raspberry PI)
Driver provides HDMI audio through ALSA and is built
on top of the vc04_services driver.
Original version of the driver is available at:
http://www.github.com/raspberry/linux
Driver compiles without any build errors or warning
On 01/24/2017 04:44 AM, Javier Martinez Canillas wrote:
Hello Steve,
On Fri, Jan 6, 2017 at 11:11 PM, Steve Longerbeam wrote:
From: Philipp Zabel
[snip]
+config VIDEO_MULTIPLEXER
+ tristate "Video Multiplexer"
+ depends on VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER
The driver
On 25-01-17, 18:07, Johan Hovold wrote:
> This driver does not have a low-latency mode and should not report
> anything else.
>
> Also drop the skip-test flag which isn't used either.
>
> Signed-off-by: Johan Hovold
> ---
> drivers/staging/greybus/uart.c | 1 -
> 1 file changed, 1 deletion(-)
>
On 25-01-17, 18:38, Franck Demathieu wrote:
> It fixes the following issue reported by checkpatch.pl:
> Prefer kernel type 'u32' over 'uint32_t'
>
> Signed-off-by: Franck Demathieu
> ---
> drivers/staging/greybus/sdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Viresh Ku
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Wednesday, January 25, 2017 00:08
> To: Dexuan Cui
> Cc: gre...@linuxfoundation.org; driverdev-devel@linuxdriverproject.org; KY
> Srinivasan ; Haiyang Zhang ;
> Stephen Hemminger ; o...@aepfle.de; Rolf
> Neugebauer ; jasow...@re
Please don't ever mention any legal issues on the list. We are not
lawyers and cannot help you. If you have legal concerns talk with your
lawyer or talk to Greg on the phone and he might be able to redirect you
to someone who can help.
regards,
dan carpenter
Thanks!
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, Jan 26, 2017 at 06:10:19AM +, Dexuan Cui wrote:
> > From: Stephen Hemminger [mailto:step...@networkplumber.org]
> > Sent: Wednesday, January 25, 2017 00:08
> > To: Dexuan Cui
> > Cc: gre...@linuxfoundation.org; driverdev-devel@linuxdriverproject.org; KY
> > Srinivasan ; Haiyang Zhang ;
On Thu, Jan 26, 2017 at 09:16:06AM +0300, Dan Carpenter wrote:
> Please don't ever mention any legal issues on the list. We are not
> lawyers and cannot help you. If you have legal concerns talk with your
> lawyer or talk to Greg on the phone and he might be able to redirect you
> to someone who
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org]
> > Dexuan Cui wrote:
> > As I checked against the kernels listed on the homapage,
> > the below versions are impacted:
> > v3.16.39
> > v3.18.47
> > v4.1.38
> > v4.8.17
> > v4.9.5
> > v4.10-rc5
> >
> > It's interesting v4.4.44
On Thu, Jan 26, 2017 at 07:44:46AM +, Dexuan Cui wrote:
> > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org]
> > > Dexuan Cui wrote:
> > > As I checked against the kernels listed on the homapage,
> > > the below versions are impacted:
> > > v3.16.39
> > > v3.18.47
> > > v4.
41 matches
Mail list logo
