[PATCH] speakup: Fix spurious space pronunciation on spelling letters

This gathers emitting the caps start string, space, spelled letter string, space, and caps stop string, into one printf, to avoid sending to the synth a space character alone, which the synth would then pronounce. Similarly, emit space along control-letter and letter spelling. Signed-off-by:

Re: [PATCH 09/10] staging: ks7010: remove zero comparison

On Tue, Mar 21, 2017 at 03:49:22PM +0300, Dan Carpenter wrote: > On Tue, Mar 21, 2017 at 01:37:11PM +1100, Tobin C. Harding wrote: > > Comparison, equal to zero, is redundant > > > > 'if (foo == 0)' is equal to 'if (!foo)' > > > > Typical kernel coding style is to use the shorter form. > > >

Re: [PATCH] Staging: ks7010 - fixed style block comments

On Wed, Mar 22, 2017 at 07:29:50AM +1300, Derek Robson wrote: > On Tue, Mar 21, 2017 at 08:56:25AM +0100, Greg KH wrote: > > On Sun, Mar 19, 2017 at 01:07:17PM +1300, Derek Robson wrote: > > > Fixed style of all block comments across whole driver > > > Found by checkpatch > > > > > >

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

On 03/21/2017 04:27 AM, Russell King - ARM Linux wrote: On Mon, Mar 20, 2017 at 06:23:24PM +0100, Philipp Zabel wrote: @@ -1173,15 +1196,8 @@ static void csi_try_fmt(struct csi_priv *priv, incc = imx_media_find_mbus_format(infmt->code,

Re: [patch 0/7] staging: speakup: introduce tty-based comms

Hello, So Rob, how do you see this going? Shall we introduce a serdev_device *tty_port_register_serdev_device(tty, device)? Will you work on it or should I give it a try? Samuel Samuel Thibault, on mer. 15 mars 2017 16:03:23 +0100, wrote: > Rob Herring, on mer. 15 mars 2017 09:45:59 -0500,

[PATCH 1/3] staging: media: Replace a bit shift by a use of BIT.

This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- .../staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 12 ++--

[PATCH 3/3] staging: media: omap4iss: Replace a bit shift by a use of BIT.

This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- drivers/staging/media/omap4iss/iss_csi2.c| 2 +- drivers/staging/media/omap4iss/iss_ipipe.c | 2

[PATCH 2/3] staging: media: davinci_vpfe: Replace a bit shift by a use of BIT.

This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 2 +-

[PATCH 0/3] staging: media: Replace a bit shift.

Replace a bit shift by a use of BIT in media driver. Arushi Singhal (3): staging: media: Replace a bit shift by a use of BIT. staging: media: davinci_vpfe: Replace a bit shift by a use of BIT. staging: media: omap4iss: Replace a bit shift by a use of BIT.

[PATCH] staging: media: Replace a bit shift by a use of BIT.

This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- drivers/staging/octeon/ethernet-tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH 2/5] staging: bcm2835-camera: Fix integer underrun in port_parameter_get

On Tue, 2017-03-21 at 14:45 +0300, Dan Carpenter wrote: > On Tue, Mar 21, 2017 at 04:36:16AM -0700, Michael Zoran wrote: > > On Tue, 2017-03-21 at 13:41 +0300, Dan Carpenter wrote: > > > You're fixing a bug you introduced in [PATCH 1/5].  Don't do > > > that.  Just > > > fix Dave's patch and add a

Re: [PATCH 1/2] staging: sm750fb: Remove typedefs from struct

On Tue, Mar 21, 2017 at 04:56:38PM +0530, Arushi Singhal wrote: > This patch removes typedefs from structure and renames them as > per kernel coding standards. In the subject, and in the text, say _which_ typedef you changed, and what you changed it to. Same for your patch 2/2. thanks, greg

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

On Mon, Mar 20, 2017 at 06:23:24PM +0100, Philipp Zabel wrote: > @@ -1173,15 +1196,8 @@ static void csi_try_fmt(struct csi_priv *priv, > incc = imx_media_find_mbus_format(infmt->code, > CS_SEL_ANY, true); > > - if

Re: [PATCH 2/5] staging: bcm2835-camera: Fix integer underrun in port_parameter_get

On Tue, 2017-03-21 at 13:41 +0300, Dan Carpenter wrote: > You're fixing a bug you introduced in [PATCH 1/5].  Don't do > that.  Just > fix Dave's patch and add a note in the commit log. > > regards, > dan carpenter > OK, thanks I'm still learning about the whole process. It looks like Dave's

Re: [PATCH v5 00/39] i.MX Media Driver

On Tue, Mar 21, 2017 at 11:59:02AM +0100, Hans Verkuil wrote: > Ah, good to hear that -s works with MC. I was not sure about that. > Thanks for the feedback! Not soo good on iMX6: $ v4l2-compliance -d /dev/video10 -s --expbuf-device=/dev/video0 ... Input ioctls: test

[RESEND PATCH 00/11] staging:speakup: Multiple Checkpatch issues.

Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (11): staging: speakup: Moved logical to previous line. staging: speakup: Remove multiple assignments staging: speakup: Simplify "NULL" comparisons staging: speakup: fixes braces {} should be

[PATCH 01/11] staging: speakup: Moved logical to previous line.

Moved logical operator to previous line to fix the following checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCH 03/11] staging: speakup: Simplify "NULL" comparisons

Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/selection.c | 2 +-

[PATCH 09/11] staging: speakup: Simplify the NULL comparisons

Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/fakekey.c | 2 +-

[PATCH 07/11] staging: speakup: spaces preferred around operator

Fixed the checkpatch.pl issues like: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) etc. Signed-off-by: Arushi Singhal

[PATCH 10/11] staging: speakup: Match alignment with open parenthesis.

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 2 +- drivers/staging/speakup/selection.c | 2 +- drivers/staging/speakup/serialio.c | 2 +-

[PATCH 08/11] staging: speakup: Removed Unnecessary parentheses.

Unnecessary parentheses are removed to improve readability. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/kobjects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/kobjects.c

[PATCH 06/11] staging: speakup: Moved OR operator to previous line.

Moved logical OR operator to previous line to fix the following checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 8 1 file changed, 4 insertions(+), 4

[PATCH 11/11] staging: speakup: Fix alignment with parenthesis.

This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/speakup_apollo.c | 2 +- drivers/staging/speakup/speakup_decext.c | 4

[PATCH 02/11] staging: speakup: Remove multiple assignments

This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git

[PATCH 04/11] staging: speakup: fixes braces {} should be used on all arms of this statement

This patch fixes the checks reported by checkpatch.pl for braces {} should be used on all arms of this statement. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 35 +++-

[PATCH 05/11] staging: speakup: Remove multiple assignments

This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/speakup/main.c

Re: [PATCH 2/5] staging: bcm2835-camera: Fix integer underrun in port_parameter_get

On Tue, Mar 21, 2017 at 04:36:16AM -0700, Michael Zoran wrote: > On Tue, 2017-03-21 at 13:41 +0300, Dan Carpenter wrote: > > You're fixing a bug you introduced in [PATCH 1/5].  Don't do > > that.  Just > > fix Dave's patch and add a note in the commit log. > > > > regards, > > dan carpenter > >

Re: [PATCH 2/5] staging: bcm2835-camera: Fix integer underrun in port_parameter_get

On Tue, Mar 21, 2017 at 04:51:03AM -0700, Michael Zoran wrote: > The original version seems to have been applied at this point. The > whole function looks like it could use some cleanup in general. Should > I just submit those an independent patch when I get to it or should I > submit a V2 the

Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks

On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote: > > > On Tue, 21 Mar 2017, Arushi Singhal wrote: > > > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield > > wrote: > > On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote: > > >

Re: [PATCH v5] staging: Use buf_lock instead of mlock and Refactor code

On Tue, Mar 21, 2017 at 8:01 PM, kbuild test robot <l...@intel.com> wrote: > Hi simran, > > [auto build test WARNING on iio/togreg] > [also build test WARNING on v4.11-rc3 next-20170321] > [if your patch is applied to the wrong git tree, please drop us a note to > help imp

[PATCH] drivers: staging: vt6656: fixed coding style errors

Fixed coding style errors. No errors with checkpatch.pl Signed-off-by: Prasant Jalan --- drivers/staging/vt6656/rf.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c index

[PATCH] drivers: staging: vt6656: fixed coding style errors

This patch fixes the following: - Replace spaces with tabs for indentation - adds spaces around symbol '-' - uses __func__ macro to print function name - truncated the line such that it is within 80 char limit as per kernel coding standards. Signed-off-by: Prasant Jalan

Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks

On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote: > Patchseries of IIO coding tasks This wouldn't be a patchset. Although they touch the same driver, the changes are unrelated. See more below... > > Arushi Singhal (2): > staging: ad7759: Replace mlock with driver private lock

Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks

On Tue, 21 Mar 2017, Arushi Singhal wrote: > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield > wrote: > On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote: > > Patchseries of IIO coding tasks > > This wouldn't be a patchset.  Although they

[PATCH v2 1/2] staging: sm750fb: Remove typedef from "typedef struct _mode_parameter_t"

This patch removes typedefs from struct and renames it from "typedef struct _mode_parameter_t" to "struct mode_parameter" as per kernel coding standards." Signed-off-by: Arushi Singhal --- changes in v2 -change the subject and commit message of PATCH.

[PATCH] drivers: staging: vt6656: fxed coding style errors

This patch replaces spaces with tabs for indentation as per kernel coding standards. Signed-off-by: Prasant Jalan --- drivers/staging/vt6656/rf.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6656/rf.c

[PATCH v2 0/2] Remove Typedefs.

Typedefs are removed in sm750fb driver. Arushi Singhal (2): staging: sm750fb: Remove typedef from "typedef struct _mode_parameter_t" staging: sm750fb: Remove typedef from "typedef enum _spolarity_t" drivers/staging/sm750fb/ddk750_mode.c | 8 +--- drivers/staging/sm750fb/ddk750_mode.h |

[PATCH v2 2/2] staging: sm750fb: Remove typedef from "typedef enum _spolarity_t"

This patch removes typedefs from enum and renames it from "typedef enum _spolarity_t" to "enum spolarity" as per kernel coding standards." Signed-off-by: Arushi Singhal --- changes in v2 -change the subject and commit message of PATCH.

Re: [Outreachy kernel] [PATCH v6] staging: Use buf_lock instead of mlock and Refactor code

On Mon, Mar 20, 2017 at 01:36:21AM +0530, simran singhal wrote: Hi Simran, I going to ask for a v7 without looking at the code ;) Subject line needs subsystem and driver. Subject and log message can be improved. > The IIO subsystem is redefining iio_dev->mlock to be used by > the IIO core

<    1   2