Re: [PATCH 08/22] crypto: chcr: Make use of the new sg_map helper function

On Fri, Apr 14, 2017 at 3:35 AM, Logan Gunthorpe wrote: > The get_page in this area looks *highly* suspect due to there being no > corresponding put_page. However, I've left that as is to avoid breaking > things. chcr driver will post the request to LLD driver cxgb4 and

Re: [PATCH] remove return statement

On Sat, 2017-04-15 at 10:35 +0530, surenderpolsani wrote: > staging : rtl8188e : remove return in void function Your patch subject isn't correct. It should be something like: Subject: [PATCH] staging: rtl8188e: Remove void function return > kernel coding style doesn't allow the return

[PATCH] remove return statement

staging : rtl8188e : remove return in void function kernel coding style doesn't allow the return statement in void function. Signed-off-by: surenderpolsani --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH] staging: rtl8723bs: remove redundant comparisons of unsigned ints with >= 0

Hi, On 13-04-17 16:13, Colin King wrote: From: Colin Ian King The comparison of mode >= 0 is redundant as mode is a u32 and this is always true. Remove this redundant code. Detected with CoverityScan ("Unsigned compared against 0") Signed-off-by: Colin Ian King

Re: [PATCH] staging: rtl8723bs: clean up identical code on an if statement

Hi, On 13-04-17 17:46, Colin King wrote: From: Colin Ian King The two different paths for an if statement are identical and hence we can just replace it with the single statement. Detected by CoverityScan, CID#1428443 ("Identical code for different branches")

Re: [Bug] VCHIQ functional test broken

On Thu, Apr 13, 2017 at 11:29:15PM +0100, Russell King - ARM Linux wrote: > > 00a19f3e25c0c40e0ec77f52d4841d23ad269169 is the first bad commit > > commit 00a19f3e25c0c40e0ec77f52d4841d23ad269169 > > Author: Rabin Vincent > > Date: Tue Nov 8 09:21:19 2016 +0100 > > > > ARM:

Re: [PATCH] staging/media: make atomisp vlv2_plat_clock explicitly non-modular

On Wed, Apr 12, 2017 at 09:57:55PM -0400, Paul Gortmaker wrote: > The Makefile / Kconfig currently controlling compilation of this code is: > > clock/Makefile:obj-$(CONFIG_INTEL_ATOMISP) += vlv2_plat_clock.o > > atomisp/Kconfig:menuconfig INTEL_ATOMISP > atomisp/Kconfig:bool "Enable

Re: [PATCH 06/18] staging: ks7010: remove argument identifiers

On Wed, Apr 12, 2017 at 09:56:51AM +1000, Tobin C. Harding wrote: > When declaring a function with a function pointer as parameter, having > the parameters to the function pointer prototype with explicit > identifiers does not add that much extra meaning to the code. In this > case the identifiers

Re: [Bug] VCHIQ functional test broken

Hi Rabin, > Rabin Vincent hat am 14. April 2017 um 09:41 geschrieben: > > > On Thu, Apr 13, 2017 at 11:29:15PM +0100, Russell King - ARM Linux wrote: > > > 00a19f3e25c0c40e0ec77f52d4841d23ad269169 is the first bad commit > > > commit 00a19f3e25c0c40e0ec77f52d4841d23ad269169 > > >

Using ion memory for direct-io

Hi Currently, the ion mapped to userspace will be forced with VM_IO and VM_PFNMAP flags. When I use the ion memory to do the direct-io, it will fail when reaching the get_user_pages, Back to the VM_IO and VM_PFNMAP flag, there two flags are introduced by the remap_pfn_range called by the

Re: [PATCH 01/18] staging: ks7010: replace defines with enums

On Wed, Apr 12, 2017 at 09:56:46AM +1000, Tobin C. Harding wrote: > Header has multiple constants defined using preprocessor > directive. In the cases where these are an integer progression an > enumeration type can be used. Doing so adds documentation to the code > and makes the usage explicit. >

Re: [PATCH] drivers/staging/iio: braces {} are not necessary for single statement blocks

On Mon, Apr 10, 2017 at 10:08:07AM +0530, Pushkar Jambhlekar wrote: > Handling checkpatch.pl warning for if block. For single if statement block, > braces are not neccessary. Making code consistent with linux kernel coding > guidelines. Pleasse wrap your changelog comments at 72 columns like

Re: [PATCH 03/22] libiscsi: Make use of new the sg_map helper function

On Thu, Apr 13, 2017 at 04:05:16PM -0600, Logan Gunthorpe wrote: > Convert the kmap and kmap_atomic uses to the sg_map function. We now > store the flags for the kmap instead of a boolean to indicate > atomicitiy. We also propogate a possible kmap error down and create > a new

Re: [PATCH 09/22] dm-crypt: Make use of the new sg_map helper in 4 call sites

On Thu, Apr 13, 2017 at 04:05:22PM -0600, Logan Gunthorpe wrote: > Very straightforward conversion to the new function in all four spots. I think the right fix here is to switch dm-crypt to the ahash API that takes a scatterlist. ___ devel mailing list

Re: [PATCH] Make ANDROID a menuconfig to ease disabling it all

Hello, >> No need to get into the submenu to disable all ANDROID-related config entries > > I don't understand this, what exactly do you mean? This is intended for people using make menuconfig to tailor their kernel config to their need by disabling all options they don't need. In order to have

Re: [PATCH RESEND v2] Staging: lustre cleanup macros in libcfs_private.h

On Thu, Apr 13, 2017 at 10:24:41AM +0100, Craig Inches wrote: > This resolves a checkpatch warning that "Single statement macros should > not use a do {} while (0) loop" by removing the loop and adjusting line > length accordingly. > > Signed-off-by: Craig Inches > --- >

Re: [PATCH 01/22] scatterlist: Introduce sg_map helper functions

> diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > index 0007b79..b95934b 100644 > --- a/drivers/dma-buf/dma-buf.c > +++ b/drivers/dma-buf/dma-buf.c > @@ -37,6 +37,9 @@ > > #include > > +/* Prevent the highmem.h macro from aliasing ops->kunmap_atomic */ > +#undef

Re: [PATCH v2] staging: lustre: Fix sparse endianness warnings cast to restricted __le64 and __le32

On Thu, Apr 13, 2017 at 12:09:23AM -0700, skanda.kash...@gmail.com wrote: > From: Skanda Guruanand > > Modified struct lu_dirpage in lustre_idl.h file to remove the sparse > warnings where cast to restricted types are made. > > Following warnings are removed by this

Re: [PATCH v2] staging: lustre: replace simple_strtoul with kstrtoint

On Tue, Mar 21, 2017 at 01:46:09PM +0100, Marcin Ciupak wrote: > Replace simple_strtoul with kstrtoint. > simple_strtoul is marked for obsoletion as reported by checkpatch.pl > > Signed-off-by: Marcin Ciupak > --- > v2: > -improving kstrtoint error handling >

Re: [PATCH 07/18] staging: ks7010: clean up SDIO header comments

On Wed, Apr 12, 2017 at 09:56:52AM +1000, Tobin C. Harding wrote: > SDIO header file does not use kernel doc format struct > comments. Adding them aids readability and enables documentation to be > built from the source code. Other comments may be tidied up as we do this. > > Add kernel format

Re: [PATCH] Make ANDROID a menuconfig to ease disabling it all

On Fri, Apr 14, 2017 at 11:04:21AM +0200, Vincent Legoll wrote: > No need to get into the submenu to disable all ANDROID-related config entries I don't understand this, what exactly do you mean? > > Signed-off-by: Vincent Legoll > --- > drivers/android/Kconfig | 12

Re: [PATCH] Make ANDROID a menuconfig to ease disabling it all

On Fri, Apr 14, 2017 at 11:46:07AM +0200, Vincent Legoll wrote: > Hello, > > >> No need to get into the submenu to disable all ANDROID-related config > >> entries > > > > I don't understand this, what exactly do you mean? > > This is intended for people using make menuconfig to tailor > their

[PATCH] staging: media: atomisp: fix range checking on clk_num

From: Colin Ian King The range checking on clk_num is incorrect; fix these so that invalid clk_num values are detected correctly. Detected by static analysis with by PVS-Studio Signed-off-by: Colin Ian King ---

Re: [PATCH] Make ANDROID a menuconfig to ease disabling it all

On Fri, Apr 14, 2017 at 2:32 PM, Greg KH wrote: > That's fine, but you aren't actually changing the functionality of any > of the build options here. You are just adding a 'menu' and showing > things a bit differently. Yes exactly, I did not intend to change

Re: [PATCH 04/22] target: Make use of the new sg_map function at 16 call sites (fwd)

it tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Logan-Gunthorpe/Introduce-common-scatterlist-map-function/20170414-142518 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next :: branch date: 8 hours ago ::

Re: [PATCH 03/22] libiscsi: Make use of new the sg_map helper function

On 14/04/17 02:36 AM, Christoph Hellwig wrote: > On Thu, Apr 13, 2017 at 04:05:16PM -0600, Logan Gunthorpe wrote: >> Convert the kmap and kmap_atomic uses to the sg_map function. We now >> store the flags for the kmap instead of a boolean to indicate >> atomicitiy. We also propogate a possible

RE: [PATCH 10/22] staging: unisys: visorbus: Make use of the new sg_map helper function

> -Original Message- > From: Logan Gunthorpe [mailto:log...@deltatee.com] ... > Subject: [PATCH 10/22] staging: unisys: visorbus: Make use of the new > sg_map helper function > > Straightforward conversion to the new function. > > Signed-off-by: Logan Gunthorpe Can

Re: [PATCH 04/22] target: Make use of the new sg_map function at 16 call sites (fwd)

://github.com/0day-ci/linux/commits/Logan-Gunthorpe/Introduce-common-scatterlist-map-function/20170414-142518 > base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next > :: branch date: 8 hours ago > :: commit date: 8 hours ago > >>> drivers/tar

Re: [PATCH 10/22] staging: unisys: visorbus: Make use of the new sg_map helper function

Great, thanks! Logan On 14/04/17 10:07 AM, Kershner, David A wrote: > Can you add Acked-by for this patch? > > Acked-by: David Kershner > > Tested on s-Par and no problems. > > Thanks, > David Kershner > >> --- >> drivers/staging/unisys/visorhba/visorhba_main.c

Re: [PATCH 01/22] scatterlist: Introduce sg_map helper functions

On 14/04/17 02:35 AM, Christoph Hellwig wrote: >> + >> static inline int is_dma_buf_file(struct file *); >> >> struct dma_buf_list { > > I think the right fix here is to rename the operation to unmap_atomic > and send out a little patch for that ASAP. Ok, I can do that next week. > I'd

Re: [PATCH] staging/media: make atomisp vlv2_plat_clock explicitly non-modular

[Re: [PATCH] staging/media: make atomisp vlv2_plat_clock explicitly non-modular] On 14/04/2017 (Fri 10:12) Greg Kroah-Hartman wrote: > On Wed, Apr 12, 2017 at 09:57:55PM -0400, Paul Gortmaker wrote: > > The Makefile / Kconfig currently controlling compilation of this code is: > > > >

Re: [PATCH 09/22] dm-crypt: Make use of the new sg_map helper in 4 call sites

On 14/04/17 02:39 AM, Christoph Hellwig wrote: > On Thu, Apr 13, 2017 at 04:05:22PM -0600, Logan Gunthorpe wrote: >> Very straightforward conversion to the new function in all four spots. > > I think the right fix here is to switch dm-crypt to the ahash API > that takes a scatterlist. Hmm,

Re: [PATCH] staging/media: make atomisp vlv2_plat_clock explicitly non-modular

> I'm pretty sure we want this code to be built as a module, so maybe a > Kconfig change would resolve the issue instead? > > Alan, any thoughts? It's a tiny chunk of platform helper code. It probably ultimately belongs in arch/x86 somewhere or folded into the driver. At the moment it won't

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

Hi! > > The MUX framework is already in linux-next. Could you use that instead of > > adding new driver + bindings that are not compliant with the MUX framework? > > I don't think it'd be much of a change in terms of code, using the MUX > > framework appears quite simple. > > It is not quite