Re: [bug report] staging: ks7010: add driver from Nanonote extra-repository

2017-04-30 Thread Tobin C. Harding
On Fri, Apr 28, 2017 at 04:27:29PM +0200, Wolfram Sang wrote: > On Fri, Apr 28, 2017 at 04:41:33PM +0300, Dan Carpenter wrote: > > Adding Tobin to CC, he is way more into the driver than I am these > days... I've mocked up a patch set to address this issue (along with some further refactoring of

Re: [PATCH] staging: ks7010: remove line continuations in quoted strings

2017-04-30 Thread Tobin C. Harding
On Fri, Apr 28, 2017 at 05:26:17PM +0300, Dan Carpenter wrote: > On Fri, Apr 28, 2017 at 04:19:28PM +0200, Ilia Sergachev wrote: > > Checkpatch emits WARNING: Avoid line continuations in quoted strings. > > > > Remove line continuations - split strings using quotes. > > > > Signed-off-by: Ilia

Re: [PATCH] staging/ks7010: Fix type assignment for struct hostif_hdr

2017-04-30 Thread Tobin C. Harding
On Sat, Apr 29, 2017 at 07:54:30PM +0200, Cezary Gapinski wrote: > Sparse spits out a warnings about __le16 and unsigned short assignment. > Change the type of size and event members of struct hostif_hdr > to __le16 and correct conversion to the proper cpu type. I believe that this patch is

Re: [PATCH 4/8] staging: ks7010: avoid CamelCase: link_ap_info_t fields

2017-04-30 Thread Tobin C. Harding
On Sat, Apr 29, 2017 at 10:58:44PM +0200, Janusz Lisiecki wrote: > Replace CamelCase struct field names with underscores to comply > with the standard kernel coding style. > Changed: > - FhParms_t > - DsParms_t > - CfParms_t > - IbssParms_t > - ErpParams_t > > Signed-off-by: Janusz Lisiecki

Re: [PATCH 0/8] Avoid CamelCases in ks7010 driver

2017-04-30 Thread Tobin C. Harding
On Sat, Apr 29, 2017 at 10:58:40PM +0200, Janusz Lisiecki wrote: > This patchset fix CamelCases in ks7010 driver except michael_mic > which will be replaced by kernel implementation in the future. Series looks good to me. For what its worth; Reviewed-by: Tobin C. Harding >

Re: [PATCH v4] staging: ks7010: fix block comment style

2017-04-30 Thread Tobin C. Harding
On Fri, Apr 28, 2017 at 03:01:32PM +0200, Ilia Sergachev wrote: > On Fri, 28 Apr 2017 14:20:21 +0200 > Greg Kroah-Hartman wrote: > > > > > Nope, the whole thing still doesn't apply: > > > > checking file drivers/staging/ks7010/ks_wlan_net.c > > Hunk #1 FAILED at

Re: [PATCH] staging: iio: isl29028: add isl29030 support

2017-04-30 Thread Sebastian Reichel
Hi, On Sun, Apr 30, 2017 at 05:27:07PM +0100, Jonathan Cameron wrote: > On 28/04/17 17:17, Brian Masney wrote: > > On Fri, Apr 28, 2017 at 05:55:58PM +0200, Sebastian Reichel wrote: > >> isl29030 is basically the same chip. The only difference > >> is the chip's first pin. For isl29028 its named

Re: [PATCH 2/5] iio: ade7753 Convert: symbolic permissions to octal

2017-04-30 Thread Jonathan Cameron
On 01/05/17 00:16, Quentin Swain wrote: > Convert S_IRUGO and S_IWUSR macros to octal permissions to resolve > warnings reported by checkpatch.pl > > Signed-off-by: Quentin Swain Applied > --- > drivers/staging/iio/meter/ade7753.c | 46 >

[PATCH 2/5] iio: ade7753 Convert: symbolic permissions to octal

2017-04-30 Thread Quentin Swain
Convert S_IRUGO and S_IWUSR macros to octal permissions to resolve warnings reported by checkpatch.pl Signed-off-by: Quentin Swain --- drivers/staging/iio/meter/ade7753.c | 46 ++--- 1 file changed, 23 insertions(+), 23 deletions(-) diff

[PATCH 3/5] iio: ade7754: Convert symbolic permissions to octal

2017-04-30 Thread Quentin Swain
Convert symbolic S_IRUGO and S_IWUSR macros to octal permissions to resolve warnings reported by checkpatch.pl Signed-off-by: Quentin Swain --- drivers/staging/iio/meter/ade7754.c | 56 ++--- 1 file changed, 28 insertions(+), 28

[PATCH 4/5] iio: ade7758: Convert symbolic permissions to octal

2017-04-30 Thread Quentin Swain
Convert symbolic S_IRUGO and S_IWUSR macros to octal permissions to fix warnings reported by checkpatch.pl Signed-off-by: Quentin Swain --- drivers/staging/iio/meter/ade7758_core.c | 50 1 file changed, 25 insertions(+), 25 deletions(-)

[PATCH 1/5] iio: ad9834 convert symbolic permissions to octal

2017-04-30 Thread Quentin Swain
Remove checkpatch warnings by converting symbolic S_IRUGO and S_IWUSR permissions to octal Signed-off-by: Quentin Swain --- drivers/staging/iio/frequency/ad9834.c | 22 +++--- drivers/staging/iio/frequency/dds.h| 2 +- 2 files changed, 12

[PATCH 5/5] iio: ade7854: Convert symbolic permissions to octal

2017-04-30 Thread Quentin Swain
Convert symbolic S_IRUGO and S_IWUSR macros to octal to fix warnings reported by checkpatch.pl Signed-off-by: Quentin Swain --- drivers/staging/iio/meter/ade7854.c | 88 ++--- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git

Fix permissions warning from check-patch for tsl2x7x

2017-04-30 Thread Quentin Swain
Replace the use of symbolic permissions macros, S_IRUGO and S_IWUSR, with octal permissons to resolve errors reported by checkpatch.pl. checkpatch.pl still reports errors for use of decimal permissions in a handful of cases where the macros were replaced with the octal in ad9834 and ade7753. It

Re: [PATCH 5/5] iio: ade7854: Convert symbolic permissions to octal

2017-04-30 Thread Jonathan Cameron
On 01/05/17 00:17, Quentin Swain wrote: > Convert symbolic S_IRUGO and S_IWUSR macros to octal to fix > warnings reported by checkpatch.pl > > Signed-off-by: Quentin Swain Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with

Re: [PATCH 4/5] iio: ade7758: Convert symbolic permissions to octal

2017-04-30 Thread Jonathan Cameron
On 01/05/17 00:17, Quentin Swain wrote: > Convert symbolic S_IRUGO and S_IWUSR macros to octal permissions to > fix warnings reported by checkpatch.pl > > Signed-off-by: Quentin Swain Applied. > --- > drivers/staging/iio/meter/ade7758_core.c | 50 >

Re: [PATCH 3/5] iio: ade7754: Convert symbolic permissions to octal

2017-04-30 Thread Jonathan Cameron
On 01/05/17 00:17, Quentin Swain wrote: > Convert symbolic S_IRUGO and S_IWUSR macros to octal permissions > to resolve warnings reported by checkpatch.pl > > Signed-off-by: Quentin Swain Applied. > --- > drivers/staging/iio/meter/ade7754.c | 56 >

[PATCH 5/6] Drivers: hv: vmbus: Fix rescind handling

2017-04-30 Thread kys
From: K. Y. Srinivasan Fix the rescind handling. This patch addresses the following rescind scenario that is currently not handled correctly: If a rescind were to be received while the offer is still being peocessed, we will be blocked indefinitely since the rescind message

[PATCH 2/6] tools: hv: properly handle long paths

2017-04-30 Thread kys
From: Vitaly Kuznetsov Paths can be up to PATH_MAX long and PATH_MAX is usually greater than 256. While on it, simplify path reconstruction to a simple snprintf(), define and reuse KVP_NET_DIR. Suggested-by: Tomas Hozza Signed-off-by: Vitaly Kuznetsov

[PATCH 3/6] Drivers: hv: vmbus: Fix error code returned by vmbus_post_msg()

2017-04-30 Thread kys
From: K. Y. Srinivasan ENOBUFS is a more approrpiate error code to be returned when the hypervisor cannot post the message because of insufficient buffers. Make the adjustment. Signed-off-by: K. Y. Srinivasan --- drivers/hv/connection.c |2 +- 1

[PATCH 1/6] Tools: hv: vss: Thaw the filesystem and continue if freeze call has timed out

2017-04-30 Thread kys
From: Alex Ng If a FREEZE operation takes too long, the driver may time out and move on to another operation. The daemon is unaware of this and attempts to notify the driver that the FREEZE succeeded. This results in an error from the driver and the daemon leaves

[PATCH 4/6] Drivers: hv: util: Make hv_poll_channel() a little more efficient

2017-04-30 Thread kys
From: K. Y. Srinivasan The current code unconditionally sends an IPI. If we are running on the correct CPU and are in interrupt level, we don't need an IPI. Make this adjustment. Signed-off-by: K. Y. Srinivasan --- drivers/hv/hyperv_vmbus.h |4

[PATCH 6/6] HV: properly delay KVP packets when negotiation is in progress

2017-04-30 Thread kys
From: Long Li The host may send multiple negotiation packets (due to timeout) before the KVP user-mode daemon is connected. KVP user-mode daemon is connected. We need to defer processing those packets until the daemon is negotiated and connected. It's okay for guest to

Re: [PATCH 1/5] iio: ad9834 convert symbolic permissions to octal

2017-04-30 Thread Jonathan Cameron
On 01/05/17 00:16, Quentin Swain wrote: > Remove checkpatch warnings by converting symbolic S_IRUGO and S_IWUSR > permissions to octal > > Signed-off-by: Quentin Swain Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.

Re: Fix permissions warning from check-patch for tsl2x7x

2017-04-30 Thread Jonathan Cameron
On 01/05/17 00:16, Quentin Swain wrote: > Replace the use of symbolic permissions macros, S_IRUGO and S_IWUSR, > with octal permissons to resolve errors reported by checkpatch.pl. > checkpatch.pl still reports errors for use of decimal permissions in a > handful of cases where the macros were

Re: [PATCH] staging: iio: isl29028: add isl29030 support

2017-04-30 Thread Jonathan Cameron
On 28/04/17 17:17, Brian Masney wrote: > On Fri, Apr 28, 2017 at 05:55:58PM +0200, Sebastian Reichel wrote: >> isl29030 is basically the same chip. The only difference >> is the chip's first pin. For isl29028 its named ADDR0 and >> can be used to change the chip's i2c address. For isl29030 >> on

[staging:staging-next 961/1005] drivers/staging//ccree/ssi_driver.c:298:10: note: in expansion of macro 'KERN_INFO'

2017-04-30 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next head: 11270059e8d0b6f80801fac910c4ef751ca05c4c commit: abefd6741d540fc624e73a2a3bdef2397bcbd064 [961/1005] staging: ccree: introduce CryptoCell HW driver config: m32r-allyesconfig (attached as .config)

[PATCH 0/6] Drivers: hv: Miscellaneous fixes

2017-04-30 Thread kys
From: K. Y. Srinivasan Miscellaneous fixes to vmbus and util drivers. Alex Ng (1): Tools: hv: vss: Thaw the filesystem and continue if freeze call has timed out K. Y. Srinivasan (3): Drivers: hv: vmbus: Fix error code returned by vmbus_post_msg() Drivers: hv:

[PATCH] staging: media: atomisp: use logical AND, not bitwise

2017-04-30 Thread Guru Das Srinagesh
Fixes sparse warning "dubious: x & !y" in logical expression. Signed-off-by: Guru Das Srinagesh --- .../media/atomisp/pci/atomisp2/css2400/runtime/binary/src/binary.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git