Re: [PATCH] Stagingdriver octeon-usb:checkpatch fix at line149

On Tue, Jun 13, 2017 at 11:57:59AM +0530, bincy_k_phi...@yahoo.co.in wrote: > From: bincy > > Signed-off-by: bincy > --- > drivers/staging/octeon-usb/octeon-hcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Also can not take

Re: [PATCH] Stagingdriver:octeon-hcd.c modified for checkpatch fixes

On Tue, Jun 13, 2017 at 07:33:10AM +, Bincy K Philip wrote: > Hi Greg, > Thanks for the reply.I have send an updated patch. > I am not sure why getting a Failure message from > "linux-ker...@vger.kernel.org" Because you are sending html email to a public mailing list that rejects it. Please

[PATCH] staging: octeon-usb: fix coding style error

From: bincy trivial fix for space alignment error Signed-off-by: bincy --- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c

Re: [PATCH] Drivers: sm750fb - style fix

On Thu, Jun 08, 2017 at 08:17:07PM +1200, Derek Robson wrote: > Fix checkpatch.pl warnings of the form "function definition argument > 'foo' should also have an identifier name" in header files. > > Signed-off-by: Derek Robson > --- > drivers/staging/sm750fb/sm750.h | 24

Re: [PATCH v7 02/10] staging: fsl-mc: fix macros with possible side effects

On Thu, Jun 08, 2017 at 05:28:47PM +0300, laurentiu.tu...@nxp.com wrote: > From: Laurentiu Tudor > > Several macros were triggering this checkpatch.pl warning: > "Macro argument reuse '$arg' - possible side-effects?" > Fix the warning by avoiding multiple macro

Re: [PATCH v7 10/10] staging: fsl-mc: move bus driver out of staging

On Thu, Jun 08, 2017 at 05:28:55PM +0300, laurentiu.tu...@nxp.com wrote: > From: Stuart Yoder > > Move the source files out of staging into their final locations: > -include files in drivers/staging/fsl-mc/include go to include/linux/fsl > -irq-gic-v3-its-fsl-mc-msi.c

Re: [PATCH] rts5208: Fix a sleep-in-atomic bug in sd_send_cmd_get_rsp

On Mon, Jun 05, 2017 at 09:31:36AM +0800, Jia-Ju Bai wrote: > The driver may sleep under a spin lock, and the function call path is: > rtsx_exclusive_enter_ss (acquire the lock by spin_lock) > rtsx_enter_ss > rtsx_power_off_card > sd_cleanup_work > sd_stop_seq_mode >

[PATCH] staging: octeon-usb: fix coding style error

From: bincy trivial fix for space alignment error Signed-off-by: bincy --- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c

[PATCH v2] staging: android: ion: Improve memory alloc style

Use variable name instead of structure name to get size of memory to allocate as proposed by checkpatch.pl Signed-off-by: Aliaksei Karaliou --- drivers/staging/android/ion/ion_system_heap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

RE: [PATCH] staging: android: ion: heap: Improve code style

Sorry for that and thank you for reply. Regarding scripts/get_maintainer.pl, it seems that trying to avoid disturbing too much people it turned out vice versa. And it was wrong idea to ignoring vger mailing list since I need this patch to be in public. Best regards, Aliaksei. Aliaksei Karaliou

[PATCH v2] staging: octeon-usb: fix coding style error

From: bincy trivial fix for space alignment error Signed-off-by: bincy k philip --- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c

Re: [PATCH] staging: android: ion: heap: Improve code style

On Tue, Jun 13, 2017 at 10:33:25AM +0300, Aliaksei Karaliou wrote: > This patch implements changes proposed by checkpatch.pl: > * Remove redundant lines. > * Don't use structure name to get size of memory to allocate. Please never do different things in the same patch, no matter how

Re: [PATCH] staging: octeon-usb: fix coding style error

On Tue, Jun 13, 2017 at 03:25:12PM +0530, bincy_k_phi...@yahoo.co.in wrote: > From: bincy > > trivial fix for space alignment error > > Signed-off-by: bincy I need a "real" name here, somthing you sign legal documents with. And you sent

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

12.06.2017 18:03, Greg Kroah-Hartman wrote: > On Mon, Jun 12, 2017 at 05:40:21PM +0200, Hans de Goede wrote: >> Hi, >> >> On 12-06-17 13:44, Greg Kroah-Hartman wrote: >>> On Mon, Jun 12, 2017 at 12:07:41PM +0200, Hans de Goede wrote: > The most important thing is for the driver to be atomic if

[PATCH] staging: octeon-usb: fix coding style error

From: bincy trivial fix for space alignment error Signed-off-by: bincy --- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c

[PATCH] rts5208: Fix a sleep-in-atomic bug in sd_send_cmd_get_rsp

The driver may sleep under a spin lock, and the function call path is: rtsx_exclusive_enter_ss (acquire the lock by spin_lock) rtsx_enter_ss rtsx_power_off_card sd_cleanup_work sd_stop_seq_mode sd_switch_clock sd_ddr_tuning

Re: [PATCH] staging: lustre: fid: Fixes debug output style problem

On Fri, Jun 09, 2017 at 04:30:52PM +0300, Roman Storozhenko wrote: > Fixes a style problems. Replaces non-standard 'Lx' specifier with a > standard 'llx'. > > Signed-off-by: Roman Storozhenko > --- > drivers/staging/lustre/lustre/fid/fid_request.c | 2 +- > 1 file

Re: [PATCH] staging: wlan-ng: Amend type mismatch warnings

On Mon, Jun 12, 2017 at 10:45:38PM +0530, suni...@techveda.org wrote: > From: Suniel Mahesh > > The following type mismatch warnings reported by sparse > have been amended: > warning: cast to restricted __le16 > warning: incorrect type in assignment (different base types) >

Re: [PATCH v2 1/3] staging: rtl8188eu: Remove redundant parenthesis

On Tue, Jun 13, 2017 at 08:50:38AM +0300, Aviya Erenfeld wrote: > Remove redundant parenthesis > > Signed-off-by: Aviya Erenfeld > --- > drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff

Re: [PATCH 1/4] staging: typec: Replace pd_header_cnt with pd_header_cnt_le

On Sun, Jun 11, 2017 at 10:53:19AM +, ? ? wrote: > From: Pan Li > > Convertn __le to cpu type when access pd_header count. Please do not indent, and please spell check where ever possible. thanks, greg k-h ___

Re: [PATCH] Staging: wlan-ng: Fix sparse warnings by using appropriate endian types

On Wed, Jun 07, 2017 at 11:57:08AM +0200, Antoine BLIN wrote: > From: Antoine > > Fix the following sparse endianness warnings: > > drivers/staging/wlan-ng/prism2sta.c:1949:17: warning: cast to restricted > __le16 > drivers/staging/wlan-ng/prism2sta.c:1949:17: warning:

Re: [PATCH v2] staging: octeon-usb: fix coding style error

On Tue, Jun 13, 2017 at 03:45:32PM +0530, bincy_k_phi...@yahoo.co.in wrote: > From: bincy > > trivial fix for space alignment error > > Signed-off-by: bincy k philip > --- > drivers/staging/octeon-usb/octeon-hcd.c | 2 +- > 1 file

Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around binary operators

On Mon, Jun 12, 2017 at 12:46:10PM +0200, Fabian Wolff wrote: > This patch adds spaces around the binary operators '-' and '+', which > is the preferred style, and reformats a pointer argument declaration > to fix a false positive "spaces preferred around that '*'" message > reported by

Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around binary operators

On 12 June 2017 at 20:46, Fabian Wolff wrote: > This patch adds spaces around the binary operators '-' and '+', which > is the preferred style, and reformats a pointer argument declaration > to fix a false positive "spaces preferred around that '*'" message > reported by

[PATCH v2] staging: fsl-mc: fix typo in comment

Resolving checkpatch issue: CHECK: 'successfuly' may be misspelled - perhaps 'successfully'? Signed-off-by: Gabriel Somlo --- On Tue, Jun 13, 2017 at 02:57:40PM +0200, Greg KH wrote: > On Mon, Jun 12, 2017 at 03:43:35PM -0400, Gabriel L. Somlo wrote: > > Signed-off-by: Gabriel

Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

On Tue, Jun 13, 2017 at 6:30 PM, Greg KH wrote: > On Sat, Jun 10, 2017 at 02:37:22AM +0530, srishti sharma wrote: >> Fixed alignment so that it matched open parenthesis. >> >> Signed-off-by: srishti sharma >> --- >>

Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around binary operators

On Tue, Jun 13, 2017 at 02:58:43PM +0200, Greg KH wrote: > On Mon, Jun 12, 2017 at 12:46:10PM +0200, Fabian Wolff wrote: > > This patch adds spaces around the binary operators '-' and '+', which > > is the preferred style, and reformats a pointer argument declaration > > to fix a false positive

Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

On Tue, Jun 13, 2017 at 08:07:14PM +0530, srishti sharma wrote: > On Tue, Jun 13, 2017 at 6:30 PM, Greg KH wrote: > > On Sat, Jun 10, 2017 at 02:37:22AM +0530, srishti sharma wrote: > >> Fixed alignment so that it matched open parenthesis. > >> > >> Signed-off-by:

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

13.06.2017 14:48, Greg Kroah-Hartman wrote: [Discussion of vboxvideo coding style.] > Once your code is accepted into the main kernel tree, why would you > continue to work in an out-of-tree repo anyway? That's ripe for > disaster, what's keeping you from just working with the in-tree version?

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

On Tue, Jun 13, 2017 at 01:50:16PM +0200, Michael Thayer wrote: > 12.06.2017 18:03, Greg Kroah-Hartman wrote: > > On Mon, Jun 12, 2017 at 05:40:21PM +0200, Hans de Goede wrote: > >> Hi, > >> > >> On 12-06-17 13:44, Greg Kroah-Hartman wrote: > >>> On Mon, Jun 12, 2017 at 12:07:41PM +0200, Hans de

Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

On Sat, Jun 10, 2017 at 02:37:22AM +0530, srishti sharma wrote: > Fixed alignment so that it matched open parenthesis. > > Signed-off-by: srishti sharma > --- > drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

On Tue, Jun 13, 2017 at 03:45:14PM +0200, Michael Thayer wrote: > 13.06.2017 14:48, Greg Kroah-Hartman wrote: > [Discussion of vboxvideo coding style.] > > Once your code is accepted into the main kernel tree, why would you > > continue to work in an out-of-tree repo anyway? That's ripe for > >

Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around binary operators

Kernel style is to have spaces around the operators. This is staging code so we do all the style fixes. We don't always update older drivers but sometimes we do. No one is planning to change those drivers though so I guess the answer is no we're not going to update those unless you are?

Re: [PATCH 7/9] Staging: rtl8712: ieee80211: fixed camelcase coding style issue

On Sun, Jun 11, 2017 at 11:57:55PM +0530, Jaya Durga wrote: > Fixed coding style issue > > Renamed IEs to ie_s > > Signed-off-by: Jaya Durga Where are patches 1-6 for this series? Please fix and resend. thanks, greg k-h ___ devel

Re: [PATCH] staging: fsl-mc: fix misspelled comment identified by checkpatch

On Mon, Jun 12, 2017 at 03:43:35PM -0400, Gabriel L. Somlo wrote: > Signed-off-by: Gabriel Somlo > --- > drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I can't take patches without any changelog test at all, sorry. greg

Re: [PATCH 9/9] Staging: rtl8712: ieee80211: fixed camelcase coding style issue

On Sun, Jun 11, 2017 at 11:57:57PM +0530, Jaya Durga wrote: > Fixed coding style issue > > Renamed Ssid to ssid > Renamed Ssid_Length to ssid_length > > Signed-off-by: Jaya Durga Where are patches 1-8 of this series? ___ devel mailing

[PATCH] staging: wlan-ng: prism2mib.c: Fix type cast issues

Fix the following sparse warnings: prism2mib.c:717:45: warning: cast to restricted __le16 prism2mib.c:720:45: warning: incorrect type in assignment (different base types) prism2mib.c:720:45:expected unsigned short [unsigned] [addressable] [usertype] datalen prism2mib.c:720:45:got

[PATCH v2 3/5] staging: rtl8723bs: wifi_regd.c: remove superfluous spaces from pointer arguments

This patch implements the suggestions of checkpatch.pl to remove unnecessary spaces before function pointer arguments as well as in statements of the form "foo * bar" (which should be "foo *bar"). Signed-off-by: Fabian Wolff Signed-off-by: Mate Horvath

[PATCH v2 4/5] staging: rtl8723bs: wifi_regd.c: adjust alignment to match open parenthesis

This patch adjusts the alignment of several lines to match their respective opening parenthesis. Signed-off-by: Fabian Wolff Signed-off-by: Mate Horvath --- v1->v2: refresh patch drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 9 + 1

[PATCH v2 5/5] staging: rtl8723bs: wifi_regd.c: insert blank line after declarations

This patch inserts a missing blank line after variable declarations. Signed-off-by: Fabian Wolff Signed-off-by: Mate Horvath --- v1->v2: refresh patch drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v2 2/5] staging: rtl8723bs: wifi_regd.c: fix comment formatting

This patch improves the formatting of block comments and removes one commented-out line of code entirely (keeping it would be redundant thanks to version control). Signed-off-by: Fabian Wolff Signed-off-by: Mate Horvath --- v1->v2: refresh

[PATCH v2 1/5] staging: rtl8723bs: wifi_regd.c: put spaces around binary operators

This patch adds spaces around the binary operators '-' and '+'. Signed-off-by: Fabian Wolff Signed-off-by: Mate Horvath --- v1->v2: apply changes only to arithmetic operators drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 6 +++--- 1 file

[PATCH v2 0/5] staging: rtl8723bs: wifi_regd.c: fix checkpatch errors and warnings

v1->v2: Refresh patches and restrict the first patch to arithmetic operators This patch series fixes all errors and warnings generated by checkpatch.pl for wifi_regd.c. Fabian Wolff (5): staging: rtl8723bs: wifi_regd.c: put spaces around binary operators staging: rtl8723bs: wifi_regd.c: fix

[PATCH 1/2] staging: rtl8723bs: Convert LIST_CONTAINOR to use kernel container_of

These are similar macros so use the normal kernel one. As well, there are odd games being played with casting a plist to a union recv_frame by using LIST_CONTAINOR. Just use a direct cast to union recv_frame instead. Signed-off-by: Joe Perches ---

[PATCH 0/2] staging: rtl8723bs: Fix LIST_CONTAINOR spelling and uses

Joe Perches (2): staging: rtl8723bs: Convert LIST_CONTAINOR to use kernel container_of staging: rtl8723bs: Convert LIST_CONTAINOR to container_of This is basically a simple substitution of a spelling typo of a macro with an addition to simplify some odd uses of the macro. I have no objection

[PATCH 2/2] staging: rtl8723bs: Convert LIST_CONTAINOR to container_of

Use the normal kernel macro. Remove the now ununsed LIST_CONTAINOR macro. Signed-off-by: Joe Perches --- drivers/staging/rtl8723bs/core/rtw_ap.c| 16 drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-

Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

On Tue, Jun 13, 2017 at 8:17 PM, Dan Carpenter wrote: > On Tue, Jun 13, 2017 at 08:07:14PM +0530, srishti sharma wrote: >> On Tue, Jun 13, 2017 at 6:30 PM, Greg KH wrote: >> > On Sat, Jun 10, 2017 at 02:37:22AM +0530, srishti sharma wrote: >>

Re: [PATCH v8 07/10] hyper-v: globalize vp_index

Stephen Hemminger writes: > On Fri, 9 Jun 2017 15:27:33 +0200 > Vitaly Kuznetsov wrote: > >> To support implementing remote TLB flushing on Hyper-V with a hypercall >> we need to make vp_index available outside of vmbus module. Rename and >>

RE: [PATCH v8 07/10] hyper-v: globalize vp_index

> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Tuesday, June 13, 2017 19:29 > > Stephen Hemminger writes: > > > On Fri, 9 Jun 2017 15:27:33 +0200 > > Vitaly Kuznetsov wrote: > > > >> To support implementing remote TLB flushing on

Re: [PATCH] staging: android: uapi: drop definitions of removed ION_IOC_{FREE,SHARE} ioctls

On Tue, Jun 13, 2017 at 09:17:05PM +0300, Gleb Fotengauer-Malinovskiy wrote: > On Tue, May 30, 2017 at 04:33:57PM -0700, Laura Abbott wrote: > > On 05/30/2017 07:11 AM, Gleb Fotengauer-Malinovskiy wrote: > > > This problem was found by strace ioctl list generator. > > > > > > Fixes: 15c6098cfec5

Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

On Wed, Jun 14, 2017 at 03:15:11AM +0530, srishti sharma wrote: > On Tue, Jun 13, 2017 at 8:17 PM, Dan Carpenter > wrote: > > On Tue, Jun 13, 2017 at 08:07:14PM +0530, srishti sharma wrote: > >> On Tue, Jun 13, 2017 at 6:30 PM, Greg KH > >>

Re: [PATCH v8 07/10] hyper-v: globalize vp_index

On Fri, 9 Jun 2017 15:27:33 +0200 Vitaly Kuznetsov wrote: > To support implementing remote TLB flushing on Hyper-V with a hypercall > we need to make vp_index available outside of vmbus module. Rename and > globalize. > > Signed-off-by: Vitaly Kuznetsov

[patch 1/2] staging: speakup: add function to convert dev name to number

The function converts strings like ttyS0 and ttyUSB0 to dev_t like (4, 64) and (188, 0). Subsequent patch in this set will call it to convert user-supplied device into device number. The function does some basic sanity checks on the string passed in. It currently supports ttyS*, ttyUSB* and, for

[patch 0/2] staging: speakup: support more than ttyS*

Hi, These patches extend speakup support to ttyUSB* and lp*. They introduce a new module param dev whose function is similar to ser but instead of taking serial port number as argument, it takes strings like ttyS0 or ttyUSB0. First patch just adds functionality to convert such strings into dev_t.

[patch 2/2] staging: speakup: make ttyio synths use device name

This patch introduces new module parameter, dev, which takes a string representing the device that the external synth is connected to, e.g. ttyS0, ttyUSB0 etc. This is then used to communicate with the synth. That way, speakup can support more than ttyS*. As of this patch, it only supports ttyS*,

[PATCH 11/11] Staging: rtl8712: ieee80211: fixed coding style issue

Fixed WARNING: line over 80 characters Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/ieee80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c index 97ef063..b823656 100644

[PATCH] Stagingdriver octeon-usb:checkpatch fix at line149

From: bincy Signed-off-by: bincy --- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index

Re: [PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style issue

sorry for the inconvenience caused i have corrected it. Regards, Jaya Durga R On June 13, 2017 at 11:25 AM Greg KH wrote: > On Tue, Jun 13, 2017 at 10:47:58AM +0530, R Jayadurga wrote: > > This e-mail is for the sole use of the intended recipient(s) and may > >

[PATCH v3] net: phy: Make phy_ethtool_ksettings_get return void

Make return value void since function never return meaningfull value Signed-off-by: Yuval Shaia Acked-by: Sergei Shtylyov --- v0 ->v1: * These files were missing in v0 * drivers/net/ethernet/renesas/ravb_main.c

Re: [PATCH] Stagingdriver:octeon-hcd.c modified for checkpatch fixes

On Tue, Jun 13, 2017 at 11:31:42AM +0530, bincy wrote: > Signed-off-by: bincy k philip > --- > drivers/staging/octeon-usb/octeon-hcd.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) You didn't fix everything my patch-bot told you about, please

[PATCH] Stagingdriver:octeon-hcd.c modified for checkpatch fixes

Signed-off-by: bincy k philip --- drivers/staging/octeon-usb/octeon-hcd.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index 068aece..c1f715e

Re: [PATCH v2 3/3] staging: rtl8188eu: Shorten lines over 80 chars

On Tue, 2017-06-13 at 08:52 +0300, Aviya Erenfeld wrote: > Shorten lines over 80 chars Most of these changes are not useful. Style nits if 80 columns are _really_ desired. > diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c > b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c [] > @@

Re: [PATCH] staging: android: uapi: drop definitions of removed ION_IOC_{FREE,SHARE} ioctls

On Tue, May 30, 2017 at 04:33:57PM -0700, Laura Abbott wrote: > On 05/30/2017 07:11 AM, Gleb Fotengauer-Malinovskiy wrote: > > This problem was found by strace ioctl list generator. > > > > Fixes: 15c6098cfec5 ("staging: android: ion: Remove ion_handle and > > ion_client") As this commit fixes

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

On Tue, Jun 13, 2017 at 01:50:16PM +0200, Michael Thayer wrote: > 12.06.2017 18:03, Greg Kroah-Hartman wrote: > > On Mon, Jun 12, 2017 at 05:40:21PM +0200, Hans de Goede wrote: > >> Hi, > >> > >> On 12-06-17 13:44, Greg Kroah-Hartman wrote: > >>> On Mon, Jun 12, 2017 at 12:07:41PM +0200, Hans de

[PATCH] staging: android: ion: heap: Improve code style

This patch implements changes proposed by checkpatch.pl: * Remove redundant lines. * Don't use structure name to get size of memory to allocate. Signed-off-by: Aliaksei Karaliou --- drivers/staging/android/ion/ion_system_heap.c | 8 +++- 1 file

Re: [PATCH v3 2/7] staging: sm750fb: unifying macro usage and definitions

On Thu, May 18, 2017 at 03:56:26PM +0200, Greg KH wrote: > On Tue, May 16, 2017 at 11:20:18AM +0200, Matej Dujava wrote: > > This patch adds tabs into macro definitions so all rhs are on same column. > > Move MHz macro from ddk_chip.c to ddk_chip.h. > > > > Signed-off-by: Matej Dujava

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

13.06.2017 15:59, Greg Kroah-Hartman wrote: > On Tue, Jun 13, 2017 at 03:45:14PM +0200, Michael Thayer wrote: >> 13.06.2017 14:48, Greg Kroah-Hartman wrote: >> [Discussion of vboxvideo coding style.] >>> Once your code is accepted into the main kernel tree, why would you >>> continue to work in an

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

On Tue, Jun 13, 2017 at 05:00:15PM +0200, Michael Thayer wrote: > 13.06.2017 15:59, Greg Kroah-Hartman wrote: > > On Tue, Jun 13, 2017 at 03:45:14PM +0200, Michael Thayer wrote: > >> 13.06.2017 14:48, Greg Kroah-Hartman wrote: > >> [Discussion of vboxvideo coding style.] > >>> Once your code is

Re: [PATCH 11/11] Staging: rtl8712: ieee80211: fixed coding style issue

Greg is never going to merge your patches until you fix your numbering so you may as well do that before anything else. This patch fixes a bug in a patch which is never going to be merged so it's not needed. Google "how to send a v2 patch". regards, dan carpenter