[staging:staging-next 280/326] ERROR: "ieee80211_rx_irqsafe" [drivers/staging/rtlwifi/r8822be.ko] undefined!

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next head: aa5ebdeb5d9e5be183721d5105769ad6240d5981 commit: 5b5ab4cb5cda824ef59e0511ac5d585f35f1a1a6 [280/326] staging: r8822be: Add Makefiles and Kconfig for new driver config: i386-randconfig-i0-08210518

Re: [PATCH 2/2] staging:rtl8188eu:core Fix add spaces around

On Mon, Aug 21, 2017 at 12:50:07PM +0530, Janani S wrote: > This patch is created to solve the coding style issues reported > by checkpatch script. What issue? And where is patch 1/2? > > Signed-off-by: Janani S Please use your full name. thanks, greg k-h

Re: [PATCH 3/3] staging:rtl8188eu:core Fix coding style issues

On Mon, Aug 21, 2017 at 01:00:14PM +0530, Janani S wrote: > This patch solves the following warning shown by > checkpatch script > WARNING: Comparisons should place the constants > on the right side of the test Why the odd line-wrapping? And where is patch 1/3 and 2/3? thanks, greg k-h

Re: [PATCH] staging: vboxvideo: constify drm_fb_helper_funcs

On Mon, Aug 21, 2017 at 03:36:34PM +0530, Arvind Yadav wrote: > drm_fb_helper_funcs are not supposed to change at runtime. > All functions working with drm_fb_helper_funcs provided by > work with const drm_fb_helper_funcs. > So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav

Re: [PATCH] staging: fsl-mc: move bus driver out of staging

On Sat, Aug 19, 2017 at 08:18:12PM +0300, laurentiu.tu...@nxp.com wrote: > From: Stuart Yoder > > Move the source files out of staging into their final locations: > -include files in drivers/staging/fsl-mc/include go to include/linux/fsl > -irq-gic-v3-its-fsl-mc-msi.c

Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns

On Thu, Aug 17, 2017 at 02:55:04PM +0300, laurentiu.tu...@nxp.com wrote: > From: Laurentiu Tudor > > Throughout the driver we use == 0 / != 0 to check strcmp() returns except > this place, so fix it. You will just get someone else fixing it as it is not what checkpatch

Re: [PATCH] drivers: staging: android: Fix style/formatting issues

On Tue, Aug 22, 2017 at 09:04:50PM -0400, Nick Fox wrote: > Fix two issues reported by checkpatch. The first removes an extra > blank line, the second changes an argument to kmalloc(). Original > checkpatch output is below: That should be two different patches, please break this up. thanks,

Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on 32bit ARM

On Tue, 22 Aug 2017 18:51:08 -0700 Greg KH wrote: > On Tue, Aug 08, 2017 at 07:03:05PM +0800, Jisheng Zhang wrote: > > As noted in commit d0bdff0db809 ("staging: Fix build issues with new > > binder API"), we can add back the choice for 32bit ARM "once a 64bit > > __get_user_asm_* implementation

[PATCH 2/2] staging: android: ion: Change argument to kmalloc (checkpatch)

Change argument to kmalloc() to fix style issue, reported by checkpatch Signed-off-by: Nick Fox --- drivers/staging/android/ion/ion_cma_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_cma_heap.c

Re: [PATCH] staging/ccree: Declare compiled out fuctions static inline

Try saving this email and then do `cat email.txt | git am`. It is corrupted. This is not how to send a v2 patch. Please read: https://kernelnewbies.org/FirstKernelPatch#head-5c81b3c517a1d0bbc24f92594cb734e155fcbbcb Look through the email archives for examples of other v2 patches. regards,

[PATCH 1/2] staging: android: ion: Remove extra line (checkpatch)

Remove extra blank line (reported by checkpatch.pl) Signed-off-by: Nick Fox --- drivers/staging/android/ion/ion_cma_heap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c index

Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on 32bit ARM

On Tue, Aug 22, 2017 at 7:34 PM, Jisheng Zhang wrote: > On Tue, 22 Aug 2017 18:51:08 -0700 Greg KH wrote: > >> On Tue, Aug 08, 2017 at 07:03:05PM +0800, Jisheng Zhang wrote: >> > As noted in commit d0bdff0db809 ("staging: Fix build issues with new >> > binder API"), we can

Re: [PATCH 3/3] ANDROID: binder: fix proc->tsk check.

On Tue, Aug 22, 2017 at 08:49:59AM -0700, Greg KH wrote: > On Mon, Aug 21, 2017 at 11:48:39AM -0700, John Stultz wrote: > > On Tue, Aug 8, 2017 at 11:08 AM, Greg KH wrote: > > > On Tue, Aug 08, 2017 at 10:34:47AM -0700, John Stultz wrote: > > >> On Fri, Jul 28, 2017 at

Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on 32bit ARM

On Tue, Aug 22, 2017 at 7:56 PM, John Stultz wrote: > On Tue, Aug 22, 2017 at 7:34 PM, Jisheng Zhang wrote: >> On Tue, 22 Aug 2017 18:51:08 -0700 Greg KH wrote: >> >>> On Tue, Aug 08, 2017 at 07:03:05PM +0800, Jisheng Zhang wrote: >>> > As noted in

Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on 32bit ARM

On Tue, Aug 22, 2017 at 8:01 PM, Jisheng Zhang wrote: > On Tue, 22 Aug 2017 19:57:04 -0700 John Stultz wrote: > >> On Tue, Aug 22, 2017 at 7:56 PM, John Stultz wrote: >> > On Tue, Aug 22, 2017 at 7:34 PM, Jisheng Zhang wrote: >>

[PATCH] drivers: staging: android: Fix style/formatting issues

Fix two issues reported by checkpatch. The first removes an extra blank line, the second changes an argument to kmalloc(). Original checkpatch output is below: ion/ion_cma_heap.c:34: CHECK: Please don't use multiple blank lines ion/ion_cma_heap.c:49: CHECK: Prefer kmalloc(sizeof(*table)...) over

Re: [PATCH] staging: rtl8192e: Change fixed function names with "%s:", __func__

On Mon, Aug 21, 2017 at 09:32:35PM +0800, Shurong Zhang wrote: > Replace hard-coded function names in strings with "%s", __func__ in the > dot11d.c file. Issue found by checkpatch.pl. Please always wrap your changelog text at 72 columns. And why did you send this twice? thanks, greg k-h

Re: [PATCH 1/5] android: binder: Refactor prev and next buffer into a helper function

On Tue, Aug 15, 2017 at 05:25:55PM -0700, Sherry Yang wrote: > Change-Id: Ie2a446ad9907f0d306fd1b8e6d79d87e48826ce2 Why is this here? > Signed-off-by: Sherry Yang I can't take patches without any changelog text at all, sorry. Please fix up and resend this series. thanks,

Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on 32bit ARM

On Tue, Aug 08, 2017 at 07:03:05PM +0800, Jisheng Zhang wrote: > As noted in commit d0bdff0db809 ("staging: Fix build issues with new > binder API"), we can add back the choice for 32bit ARM "once a 64bit > __get_user_asm_* implementation is merged." Commit e38361d032f1 ("ARM: > 8091/2: add

Re: [PATCH] android: binder: check result of binder_get_thread() in binder_poll()

On Mon, May 08, 2017 at 01:43:23PM -0700, Dmitry Torokhov wrote: > If binder_get_thread() fails to give us a thread data, we should avoid > dereferencing a NULL pointer and return POLLERR instead. > > Signed-off-by: Dmitry Torokhov > Reviewed-by: Douglas Anderson

Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns

On Tue, 2017-08-22 at 18:40 -0700, Greg KH wrote: > On Thu, Aug 17, 2017 at 02:55:04PM +0300, laurentiu.tu...@nxp.com wrote: > > From: Laurentiu Tudor > > > > Throughout the driver we use == 0 / != 0 to check strcmp() returns except > > this place, so fix it. > > You

Re: [EXT] Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on 32bit ARM

On Tue, 22 Aug 2017 19:56:07 -0700 John Stultz wrote: > External Email > > -- > On Tue, Aug 22, 2017 at 7:34 PM, Jisheng Zhang wrote: > > On Tue, 22 Aug 2017 18:51:08 -0700 Greg KH wrote: > > > >> On

Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on 32bit ARM

On Tue, 22 Aug 2017 19:57:04 -0700 John Stultz wrote: > On Tue, Aug 22, 2017 at 7:56 PM, John Stultz wrote: > > On Tue, Aug 22, 2017 at 7:34 PM, Jisheng Zhang wrote: > > > >> On Tue, 22 Aug 2017 18:51:08 -0700 Greg KH wrote: > >> > >>> On Tue,

[PATCH][staging-next] staging: typec: tcpm: make function tcpm_get_pwr_opmode

From: Colin Ian King The function pointer tcpm_get_pwr_opmode is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: symbol 'tcpm_get_pwr_opmode' was not declared. Should it be static? Signed-off-by: Colin Ian King

Re: [PATCH 3/3] ANDROID: binder: fix proc->tsk check.

On Mon, Aug 21, 2017 at 11:48:39AM -0700, John Stultz wrote: > On Tue, Aug 8, 2017 at 11:08 AM, Greg KH wrote: > > On Tue, Aug 08, 2017 at 10:34:47AM -0700, John Stultz wrote: > >> On Fri, Jul 28, 2017 at 4:56 AM, Martijn Coenen wrote: > >> > Commit

[PATCH] staging: rtlwifi: fix multiple build errors

ion(+), 1 deletion(-) --- linux-next-20170822.orig/drivers/staging/rtlwifi/Kconfig +++ linux-next-20170822/drivers/staging/rtlwifi/Kconfig @@ -1,6 +1,6 @@ config R8822BE tristate "Realtek RTL8822BE Wireless Network Adapter" - depends on PCI && m + depends on NETDEVICES

[PATCH v2 00/46] staging: unisys: Additional code changes

Several simplifications and cleanup patches. This series now includes the patch to switch to use the new UUID API. -- Changes since v1 -- Incorporated UUID API patch -- Refactored other patches that were affected by the UUID API patch. Andy Shevchenko (1): staging: unisys: Switch to use new

RE: [PATCH] storvsc: do not assume SG list is continuous when doing bounce buffers (for 4.1 stable only)

> Wouldn't it make sense to backport the changes to set the virt_boundary > (which probably still is the SG_GAPS flag in such an old kernel)? We can make storvsc use SG_GAPS. But the following patch is missing in 4.1 stable block layer to make this work on some I/O situations. Backporting is

[PATCH v2 18/46] staging: unisys: include: Remove unused vdiskmgmt commands

The vdisk task management commands are no longer used by s-Par, this patch removes the definitions for them. Reviewed-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH v2 12/46] staging: unisys: include: fix improper use of dma_data_direction

From: Steven Matthews Replace use of standard Linux dma_data_direction with a Unisys- specific uis_dma_data_direction and provide a function to convert from the latter to the former. This is necessary because Unisys s-Par depends on the exact format of this field in

[PATCH v2 04/46] staging: unisys: Switch to use new generic UUID API

From: Andy Shevchenko There are new types and helpers that are supposed to be used in new code. As a preparation to get rid of legacy types and API functions do the conversion here. While here, re-indent couple of lines to increase readability. Cc: David

[PATCH v2 29/46] staging: unisys: Move VNIC GUID to visornic

Instead of including it in the global channel.h, move the VNIC GUID to the visornic module. Reviewed-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH v2 01/46] staging: unisys: visorbus: remove filename from beginning of file

From: Zohaib Javed The filename was in a comment at the beginning of the file. It is not needed. Signed-off-by: Zohaib Javed Signed-off-by: David Kershner Reviewed-by: David Binder

[PATCH v2 25/46] staging: unisys: visorbus: Remove unnecessary includes for visorchipset.c

Visorchipset.c was including unnecessary include files, either included by other headers or not needed at all. Reviewed-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH v2 37/46] staging: unisys: visorbus: visorchannel.c: Remove filename in top comment

From: David Binder Removes unnecessary filename in the top file comment. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH v2 30/46] staging: unisys: Move SIOVM guid to visorbus

The SIOVM guid is only used by visorchipset. So define it there instead of a global header file. Reviewed-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH v2 15/46] staging: unisys: include: Remove unused #define MAXNUM

The MAXNUM #define was not being used, and it shouldn't be used. Remove it. Reviewed-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/iochannel.h | 1 -

[PATCH v2 32/46] staging: unisys: don't copy to local variable

Do the check with the values in the structure instead of copying them to local variables. Reviewed-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH v2 31/46] staging: unisys: visorbus: Remove confusing comment in controlvmchannel.

Referencing a SegmentIndex doesn't make sense in the Linux drivers, get rid of the comment. Reviewed-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH v2 27/46] staging: unisys: visorinput: Get rid of unused includes

Cleanups caused us to not need to include a bunch of headers, got rid of them. Reviewed-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH v2 26/46] staging: unisys: include: iochannel needs to include skbuff

The iochannel.h header file references ETH_HLEN which is defined in skbuff. Removed it from visorhba since it was no longer needed. Reviewed-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH v2 10/46] staging: unisys: visorbus: Merge vmcallinterface.h into visorchipset.c

From: David Binder The contents of vmcallinterface.h are better placed within visorchipset.c from an organizational perspective. The values are only used in that file. Signed-off-by: David Binder Signed-off-by: David Kershner

[PATCH v2 19/46] staging: unisys: include: Remove unused throttling defines.

We no longer send messages directly to the s-Par event log, so we do not need the throttling defines anymore. Reviewed-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH v2 03/46] staging: unisys: visorbus: Adding a new line between function definition

From: Zohaib Javed Added a new line before issue_vmcall_io_controlvm_addr() function definition. Signed-off-by: Zohaib Javed Signed-off-by: David Kershner Reviewed-by: David Binder

[PATCH v2 24/46] staging: unisys: visorbus: fix include dependency

Due to include order, the visorbus_private.h file was missing a required include header visorbus.h. If visorchipset.c or visorbus_main.c ever were to change the order of the includes for visobus.h and visorbus_private.h, the code would fail to compile. Reviewed-by: Sameer Wadgaonkar

[PATCH v2 35/46] staging: unisys: visorbus: visorchipset.c: Fix SonarQube sprintf findings

From: David Binder Fixes two sprintf invocations where we attempt to format an unsigned integer as a signed integer. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH v2 34/46] staging: unisys: visorbus: Get rid of passthrough function visorchipset_bus_create

The function visorchipset_bus_create just called visorbus_create_instance, we should just combine it with visorbus_create_instance. Reviewed-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH v2 28/46] staging: unisys: include: remove unnecessary blank line from channel.h

Remove unnecessary blank line from channel.h #defines. Reviewed-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/channel.h | 1 - 1 file changed, 1

[PATCH v2 22/46] staging: unisys: include: Remove unnecessary forward declaration

The struct visor_device had a forward declaration that was not needed. Remove it. Reviewed-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/visorbus.h

[PATCH v2 36/46] staging: unisys: visorbus: visorbus_main.c: Remove filename in top comment

From: David Binder Removes unnecessary filename in the top file comment. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH v2 38/46] staging: unisys: visorinput: visorinput.c: Remove filename in top comment

From: David Binder Removes unnecessary filename in the top file comment. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH v2 16/46] staging: unisys: use the kernel min define

The kernel already provides a min function, we should be using that instead of creating our own MINNUM. Reviewed-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH v2 43/46] staging: unisys: visorbus: Get rid of passthrough function visorchipset_bus_destroy

From: Sameer Wadgaonkar The function visorchipset_bus_destroy just called viosrbus_remove_instance, we can just combine it with visorbus_remove_instance. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner

[PATCH v2 42/46] staging: unisys: include: iochannel.h: Add proper copyright statement

From: David Binder Adds the proper Unisys copyright statement to the top of iochannel.h. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH v2 46/46] staging: unisys: use ATTRIBUTE_GROUPS instead of creating our own

Greg noticed that we were creating our own attribute groups, instead of using the ATTRIBUTE_GROUPS macro, this patch fixes our mistake. Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH v2 41/46] staging: unisys: visorinput: ultrainputreport.h: Adjust comment formatting

From: David Binder The first line of the top file comment should begin on the line following the block comment opening, thereby following the convention used elsewhere in the driver set. Signed-off-by: David Binder Signed-off-by: David Kershner

[PATCH v2 45/46] staging: unisys: visorbus: Get rid of passthrough function visorchipset_device_destroy

From: Sameer Wadgaonkar The function visorchipset_device_destroy just called remove_visor_device, we can just combine it with remove_visor_device. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner

[PATCH v2 33/46] staging: unisys: reference bus_no and dev_no directly

Don't store it in a local variable but reference it from the visor_device. Reviewed-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c |

[PATCH v2 44/46] staging: unisys: visorbus: Get rid of passthrough function visorchipset_device_create

From: Sameer Wadgaonkar The function visorchipset_device_create just called create_visor_device, we can just combine it with create_visor_device. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner

[PATCH v2 39/46] staging: unisys: include: visorbus.h: Remove filename in top comment

From: David Binder Removes unnecessary filename in the top file comment. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH v2 40/46] staging: unisys: visorhba: Adjust top comment formatting

From: David Binder The first line of the top file comment should begin on the line following the block comment opening, thereby following the convention used elsewhere in the driver set. Signed-off-by: David Binder Signed-off-by: David Kershner

[PATCH v2 17/46] staging: unisys: include: iochannel.h: Update comments for #defines

Cleaned up some #defines to make the beginning of the file read easier. Reviewed-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/iochannel.h | 10

[PATCH v2 08/46] staging: unisys: visornic: update the struct visornic_devdata comments

From: Sameer Wadgaonkar Cleaned up the in-line comments in the structure and added a single block comment for the structure. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: David

[PATCH v2 23/46] staging: unisys: include: Remove unneeded includes from visorbus.h

A bunch of code churn has caused the following include files to not be needed by visorbus.h: linux/poll.h linux/kernel.h linux/uuid.h linux/seq_file.h Reviewed-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH v2 07/46] staging: unisys: visorbus: fix multi-line function definition

From: Charles Daniels Fixed incorrectly styled function definitions in visorbus/visorchipset.c by placing the function names on the same line as the return. Signed-off-by: Charles Daniels Signed-off-by: David Kershner

[PATCH v2 09/46] staging: unisys: visornic: visornic_main.c: fix multiline dereference.

From: Sameer Wadgaonkar This patch fixes two checkpatch warnings in the visornic_main.c file to avoid multiline dereference. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim

[PATCH v2 13/46] staging: unisys: visorbus: merging the visorbus_*_response functions into one.

From: Sameer Wadgaonkar The functions visorbus_create_response(), visorbus_destroy_response(), viosrbus_device_create_response(), viosrbus_device_destroy_response() are all functionally similar. Merging these four functions into a single function called

[PATCH v2 06/46] staging: unisys: visorbus: visorbus_private.h remove filename

From: Mark Foresta Remove the filename in the comment at the beginning of the file. Signed-off-by: Mark Foresta Signed-off-by: David Kershner Reviewed-by: David Binder Reviewed-by: Tim Sell

[PATCH v2 05/46] staging: unisys: visorbus: Update comment style vbuschannel.h

From: Mark Foresta Moved blocked comment on to own line at beginning of struct to follow standard. Since this is an internal structure, the block comment isn't actually a kernel-doc so we only start the block with one asterisk. Signed-off-by: Mark Foresta

[PATCH v2 21/46] staging: unisys: include: Fix up comment style in visorbus.h

Visorbus.h had comments that did not have /* on its own line, this patch makes it uniform. Reviewed-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH v2 14/46] staging: unisys: visorbus: merging the visorbus_device_pause_response and visorbus_device_resume_response functions into one.

From: Sameer Wadgaonkar The functions viosrbus_device_pause_response() and viosrbus_device_resume_response() are functionally similar. Merging these functions into a single function called visorbus_device_changestate_response(). Signed-off-by: Sameer Wadgaonkar

[PATCH v2 02/46] staging: unisys: include: iochannel.h: Removed unused DEFINE

From: Zohaib Javed Removed unused #define GPI_ENTRIES_PER_PAGE Signed-off-by: Zohaib Javed Signed-off-by: David Kershner Reviewed-by: David Binder Reviewed-by: Tim Sell

[PATCH v2 11/46] staging: unisys: visorbus: Remove unnecessary comments

From: David Binder Removes comments that do not provide any valuable information. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH v2 20/46] staging: unisys: include: cleanup channel comment

A comment in channel.h was referencing windows guests, in reality the OS of the guest is agnostic and the comment should reflect that. Reviewed-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell

Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns

On Tue, Aug 22, 2017 at 07:33:45PM -0700, Joe Perches wrote: > On Tue, 2017-08-22 at 18:40 -0700, Greg KH wrote: > > On Thu, Aug 17, 2017 at 02:55:04PM +0300, laurentiu.tu...@nxp.com wrote: > > > From: Laurentiu Tudor > > > > > > Throughout the driver we use == 0 / != 0

Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on 32bit ARM

On Tue, Aug 22, 2017 at 08:14:10PM -0700, John Stultz wrote: > On Tue, Aug 22, 2017 at 8:01 PM, Jisheng Zhang wrote: > > On Tue, 22 Aug 2017 19:57:04 -0700 John Stultz wrote: > > > >> On Tue, Aug 22, 2017 at 7:56 PM, John Stultz > >> wrote: > >> > On

Re: [PATCH 1/2] staging: android: ion: Remove extra line (checkpatch)

On Tue, Aug 22, 2017 at 10:55:36PM -0400, Nick Fox wrote: > Remove extra blank line (reported by checkpatch.pl) > > Signed-off-by: Nick Fox > --- > drivers/staging/android/ion/ion_cma_heap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [PATCH 2/2] staging: android: ion: Change argument to kmalloc (checkpatch)

On Tue, Aug 22, 2017 at 10:55:37PM -0400, Nick Fox wrote: > Change argument to kmalloc() to fix style issue, reported by checkpatch > > Signed-off-by: Nick Fox > --- > drivers/staging/android/ion/ion_cma_heap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

RE: [PATCH] vsock: only load vmci transport on VMware hypervisor by default

> From: Jorgen S. Hansen [mailto:jhan...@vmware.com] > > On Aug 22, 2017, at 11:54 AM, Stefan Hajnoczi > wrote: > > ... > > We *can* by looking at the destination CID. Please take a look at > > drivers/misc/vmw_vmci/vmci_route.c:vmci_route() to see how VMCI > handles > >

[PATCH] staging: olpc_dcon: Change fixed function names with "%s: ", __func__

Replace hard-coded function names in strings with "%s", __func__ in the olpc_dcon.c file. Issue found by checkpatch.pl. Signed-off-by: Shurong Zhang --- drivers/staging/olpc_dcon/olpc_dcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] staging: olpc_dcon: Change fixed function names with "%s: ", __func__

Replace hard-coded function names in strings with "%s", __func__ in the olpc_dcon.c file. Issue found by checkpatch.pl. Signed-off-by: Shurong Zhang --- drivers/staging/olpc_dcon/olpc_dcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on 32bit ARM

On Wed, Aug 23, 2017 at 10:34:20AM +0800, Jisheng Zhang wrote: > On Tue, 22 Aug 2017 18:51:08 -0700 Greg KH wrote: > > > On Tue, Aug 08, 2017 at 07:03:05PM +0800, Jisheng Zhang wrote: > > > As noted in commit d0bdff0db809 ("staging: Fix build issues with new > > > binder API"), we can add back

Re: [PATCH] staging: olpc_dcon: Change fixed function names with "%s: ", __func__

On Wed, Aug 23, 2017 at 01:06:52PM +0800, Shurong Zhang wrote: > Replace hard-coded function names in strings with "%s", __func__ > in the olpc_dcon.c file. Issue found by checkpatch.pl. What is up with the odd indentation? And why did you send this twice? Which patch should I use? I'll

[PATCH v2 net-next 1/1] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)

Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It uses VMBus ringbuffer as the transportation layer. With hv_sock, applications between the host (Windows 10, Windows Server 2016 or newer) and the guest can talk with each other using

Re: [PATCH v2 16/46] staging: unisys: use the kernel min define

On Tue, Aug 22, 2017 at 01:27:06PM -0400, David Kershner wrote: > The kernel already provides a min function, we should be using that > instead of creating our own MINNUM. > > Reviewed-by: Sameer Wadgaonkar > Signed-off-by: David Kershner

Re: [PATCH v2 00/46] staging: unisys: Additional code changes

On Tue, Aug 22, 2017 at 01:26:50PM -0400, David Kershner wrote: > Several simplifications and cleanup patches. This series now includes the > patch to switch to use the new UUID API. > > -- Changes since v1 > -- Incorporated UUID API patch > -- Refactored other patches that were affected by the

RE: [PATCH net-next 3/3] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)

> From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > On Fri, Aug 18, 2017 at 10:23:54PM +, Dexuan Cui wrote: > > > > +static bool hvs_stream_allow(u32 cid, u32 port) > > > > +{ > > > > + static const u32 valid_cids[] = { > > > > + VMADDR_CID_ANY, > > > > > > Is this for

Re: [PATCH v2 1/4] staging: pi433: Style fix - Correct long lines

On Sat, Aug 19, 2017 at 09:47:28PM -0700, Joe Perches wrote: > On Wed, 2017-08-16 at 10:31 +0300, Dan Carpenter wrote: > > On Wed, Aug 16, 2017 at 10:53:18AM +0530, Rishabh Hardas wrote: > > > @@ -143,10 +142,13 @@ struct pi433_rx_cfg { > > > > > > #define PI433_IOC_MAGIC 'r' >

Re: [PATCH] vsock: only load vmci transport on VMware hypervisor by default

On Fri, Aug 18, 2017 at 11:07:37PM +, Dexuan Cui wrote: > > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > > > CID is not really used by us, because we only support guest<->host > > communication, > > > and don't support guest<->guest communication. The Hyper-V host > > references > > >

Re: [PATCH v2 1/4] staging: pi433: Style fix - Correct long lines

Hi everybody, from my point of view, we should stay with the old implementation. Ok - line is too long according to style guide. But these long lines are IMHO easy to read: All four are pretty similar. By having all Tokens in exact the same length and having one below other, you can easily

Re: [PATCH v2 1/4] staging: pi433: Style fix - Correct long lines

I'm skeptical that these are the absolute platonic ideal of what the code should look like... You may be right that it's mathematically impossible to make these lines more readable, but we can't really debate alternate versions of this until someone sends us a patch. regards, dan carpenter

Re: [PATCH v2 1/4] staging: pi433: Style fix - Correct long lines

On Tue, Aug 22, 2017 at 02:57:49PM +0530, Rishabh Hardas wrote: > On Sat, Aug 19, 2017 at 09:47:28PM -0700, Joe Perches wrote: > > On Wed, 2017-08-16 at 10:31 +0300, Dan Carpenter wrote: > > > On Wed, Aug 16, 2017 at 10:53:18AM +0530, Rishabh Hardas wrote: > > > > @@ -143,10 +142,13 @@ struct

Re: [PATCH net-next 3/3] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)

On Fri, Aug 18, 2017 at 10:23:54PM +, Dexuan Cui wrote: > > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > > Sent: Thursday, August 17, 2017 07:56 > > To: Dexuan Cui > > On Tue, Aug 15, 2017 at 10:18:41PM +, Dexuan Cui wrote: > > > +static u32

Re: [PATCH] staging/ccree: Declare compiled out fuctions static inline

On Wed, Aug 16, 2017 at 03:09:09PM -0700, Greg KH wrote: > On Mon, Jul 31, 2017 at 02:47:23PM +0530, RishabhHardas wrote: > > From: RishabhHardas > > > > Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and > > 'fips_handler' > > that they were not

Re: [PATCH] storvsc: do not assume SG list is continuous when doing bounce buffers (for 4.1 stable only)

Wouldn't it make sense to backport the changes to set the virt_boundary (which probably still is the SG_GAPS flag in such an old kernel)? ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging/ccree: Declare compiled out fuctions static inline

Google for how to send a v2 patch. https://www.google.com/search?q=how+to+send+a+v2+patch https://kernelnewbies.org/FirstKernelPatch regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

[PATCH][next] staging: r8822be: fix a couple of spelling mistakes

From: Colin Ian King Trivial fixes to spelling mistake in pr_err error messages: errorr -> error mismactch -> mismatch Signed-off-by: Colin Ian King --- .../staging/rtlwifi/halmac/halmac_88xx/halmac_api_88xx.c | 2 +-

Re: [PATCH 15/15] usb: make device_type const

On Sat, Aug 19, 2017 at 01:52:26PM +0530, Bhumika Goyal wrote: > Make this const as it is only stored in the type field of a device > structure, which is const. > Done using Coccinelle. > > Signed-off-by: Bhumika Goyal Acked-by: Heikki Krogerus

Re: [PATCH] vsock: only load vmci transport on VMware hypervisor by default

> On Aug 22, 2017, at 11:54 AM, Stefan Hajnoczi wrote: > > On Fri, Aug 18, 2017 at 11:07:37PM +, Dexuan Cui wrote: >>> Not all features need to be supported. For example, VMCI supports >>> SOCK_DGRAM while Hyper-V and virtio do not. But features that are >>> available

Re: [PATCH] staging/ccree: Declare compiled out fuctions static inline

On Wed, Aug 16, 2017 at 03:09:09PM -0700, Greg KH wrote: > On Mon, Jul 31, 2017 at 02:47:23PM +0530, RishabhHardas wrote: > > From: RishabhHardas > > > > Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and > > 'fips_handler' > > that they were not

  1   2   >