[PATCH V2 1/1] vmbus: hvsock: add proper sync for vmbus_hvsock_device_unregister()

2017-10-18 Thread kys
From: Dexuan Cui Without the patch, vmbus_hvsock_device_unregister() can destroy the device prematurely when close() is called, and can cause NULl dereferencing or potential data loss (the last portion of the data stream may be dropped prematurely). Signed-off-by: Dexuan Cui Cc: Haiyang Zhang

Re: [PATCH v3 10/14] extcon: intel-int3496: Add support for controlling the USB-role mux

2017-10-18 Thread Hans de Goede
Hi, On 18-10-17 04:33, Chanwoo Choi wrote: Hi Hans, On 2017년 09월 23일 03:37, Hans de Goede wrote: Cherry Trail SoCs have a built-in USB-role mux for switching between the host and device controllers, rather then using an external mux controller by a GPIO. There is a driver using the mux-subsys

Re: [PATCH v3 10/14] extcon: intel-int3496: Add support for controlling the USB-role mux

2017-10-18 Thread Chanwoo Choi
On 2017년 10월 18일 18:14, Hans de Goede wrote: > Hi, > > On 18-10-17 04:33, Chanwoo Choi wrote: >> Hi Hans, >> >> On 2017년 09월 23일 03:37, Hans de Goede wrote: >>> Cherry Trail SoCs have a built-in USB-role mux for switching between >>> the host and device controllers, rather then using an external m

Re: [PATCH] staging: wlan-ng: Remove unnecessary parentheses

2017-10-18 Thread kbuild test robot
-wlan-ng-Remove-unnecessary-parentheses/20171018-180433 config: x86_64-randconfig-x005-201742 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by

[PATCH] drivers: hv: balloon: remove extraneous assignment to region_start

2017-10-18 Thread Colin King
From: Colin Ian King The variable region_start is assigned twice, the first value is never read and redundant, so can be removed. We can clean up the code further by assigning rg_start directly rather than using the temporary variable region_start which can then be removed. Cleans up the clang w

Re: [PATCH v3 01/26] staging: most: rearrange source files

2017-10-18 Thread Greg KH
On Mon, Oct 16, 2017 at 10:46:08AM +0200, Christian Gromm wrote: > This patch renames and moves the source files of the driver. Additionally, > it adapts the ABI, Makefiles and Kconfig files of the kernel's build > system. Ok, this says _what_ the patch does, but we know that already by looking at

Re: [PATCH v3 02/26] staging: most: integrate driver in kernel's device model

2017-10-18 Thread Greg KH
On Mon, Oct 16, 2017 at 10:46:09AM +0200, Christian Gromm wrote: > The following patch adapts the driver to use the device model by: > > - adopting the MOST bus_type > - registering the core as a busdriver > - removing private kobject/kset usage > - removing private lists a

Re: [PATCH v3 17/26] staging: most: change designator for modules interfacing userspace

2017-10-18 Thread Greg KH
On Mon, Oct 16, 2017 at 10:46:24AM +0200, Christian Gromm wrote: > A module that is meant to make up the userspace experience of the driver > is no longer referred to as AIM. Instead it is denoted as a component of > the core. Further, it is understood as an integral part of the core, the > purpose

Re: [PATCH 00/26] staging: most: make use of kernel's device model and fix defects

2017-10-18 Thread Greg KH
On Mon, Oct 16, 2017 at 10:46:07AM +0200, Christian Gromm wrote: > This patch set integrates the MOST driver to the Linux kernel's device > model and provides bug fixes. Part of this process is moving and renaming > files to get a clearer directory layout. This needs to be reworked a bit better, s

Re: [PATCH v2] Staging: rtl8188eu: core: rtw_ap: Use list_for_each_entry_safe

2017-10-18 Thread Greg KH
On Thu, Oct 05, 2017 at 03:16:42PM +0530, Srishti Sharma wrote: > This is a cleanup patch and doesn't change runtime behavior. It > changes an open coded list traversal to use list_for_each_entry_safe. > Done using the following semantic patch by coccinelle. You have sent me two different patches

Re: [PATCH 1/2] staging: check for skb->len in gdm_lte_emulate_arp

2017-10-18 Thread Greg KH
On Wed, Oct 18, 2017 at 12:45:57AM +0300, Andrii Vladyka wrote: > check for skb->len in gdm_lte_emulate_arp > > Signed-off-by: Andrii Vladyka > --- > drivers/staging/gdm724x/gdm_lte.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers/staging/gdm724x/gdm_lte.c > b/drivers/st

[PATCH 2/2] staging: gdm724x: fix return codes in gdm_lte

2017-10-18 Thread Andrii Vladyka
fix return codes in gdm_lte in gdm724x driver Signed-off-by: Andrii Vladyka --- drivers/staging/gdm724x/gdm_lte.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c index 066b14e..0527b0d 10064

[PATCH 1/2] staging: gdm724x: check for skb->len in gdm_lte_emulate_arp

2017-10-18 Thread Andrii Vladyka
check for skb->len in gdm_lte_emulate_arp in gdm724x driver Signed-off-by: Andrii Vladyka --- drivers/staging/gdm724x/gdm_lte.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c index 9ab6ce2..066b14e 100644 --- a/driv

Re: [PATCH] staging: rtlwifi: remove duplicated macros in comments

2017-10-18 Thread Greg KH
On Thu, Oct 05, 2017 at 04:44:31PM -0700, Matthew Giassa wrote: > Removing a comment that duplicates definitions for pci_power_t > enumeration, and pointing to the relevant header file (current comment > is also missing PCI_POWER_ERROR). > > Signed-off-by: Matthew Giassa > --- > drivers/staging/

Re: [PATCH] Staging: rtlwifi: phydm: Use setup_timer

2017-10-18 Thread Greg KH
On Sat, Oct 07, 2017 at 10:56:25PM +0530, Srishti Sharma wrote: > Use setup_timer to combine initialization of a timer with the > initialization of the timer's function and data fields. Done > using the following semantic patch by coccinelle. > > @r@ > struct timer_list *l; > expression f, d; > @@

Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

2017-10-18 Thread Greg KH
On Wed, Oct 04, 2017 at 07:21:10PM +0200, Srinivasan Shanmugam wrote: > Removed all the unnecessary extern from rtl8723bs That's not what this patch does :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailm

Re: [PATCH v3 02/26] staging: most: integrate driver in kernel's device model

2017-10-18 Thread Christian Gromm
On 18.10.2017 14:12, Greg KH wrote: On Mon, Oct 16, 2017 at 10:46:09AM +0200, Christian Gromm wrote: The following patch adapts the driver to use the device model by: - adopting the MOST bus_type - registering the core as a busdriver - removing private kobject/kset usage

Re: [PATCH] Staging: rtl8723bs: core: rtw_recv: fix parenthesis alignment warning in validate_recv_mgnt_frame()

2017-10-18 Thread Greg KH
On Thu, Oct 05, 2017 at 03:45:33PM +0200, Srinivasan Shanmugam wrote: > Fix parenthesis alignment warning in validate_recv_mgnt_frame() > > Signed-off-by: Srinivasan Shanmugam > --- > drivers/staging/rtl8723bs/core/rtw_recv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch does no

Re: [PATCH] staging: irda: resolve sparse errors due to implicit pci_power_t casts

2017-10-18 Thread Greg KH
On Thu, Oct 05, 2017 at 04:38:23PM -0700, Matthew Giassa wrote: > Explicitly casting pci_power_t types to resolve sparse warnings (shown > below). > > Also fixing a related logging bug where pci_power_t is cast to unsigned > (can be negative, i.e. PCI_POWER_ERROR). > > Original sparse report: >

Re: [PATCH v2] staging: wlan-ng: Remove unnecessary parentheses

2017-10-18 Thread Greg KH
On Mon, Oct 16, 2017 at 09:48:21PM -0400, Frank A. Cancio Bello wrote: > Remove unnecessary parentheses to comply with preferred coding style for > the linux kernel and avoid the following checkpatch's message: > 'CHECK: Unnecessary parentheses around' > > Credits to checkpatch. > > Signed-off-by

Re: [PATCH v3 02/26] staging: most: integrate driver in kernel's device model

2017-10-18 Thread Greg KH
On Wed, Oct 18, 2017 at 04:02:33PM +0200, Christian Gromm wrote: > On 18.10.2017 14:12, Greg KH wrote: > > On Mon, Oct 16, 2017 at 10:46:09AM +0200, Christian Gromm wrote: > > > The following patch adapts the driver to use the device model by: > > > > > > - adopting the MOST bus_type > > > - r

Re: [PATCH v3 02/26] staging: most: integrate driver in kernel's device model

2017-10-18 Thread Dan Carpenter
On Wed, Oct 18, 2017 at 04:02:33PM +0200, Christian Gromm wrote: > On 18.10.2017 14:12, Greg KH wrote: > > On Mon, Oct 16, 2017 at 10:46:09AM +0200, Christian Gromm wrote: > > > The following patch adapts the driver to use the device model by: > > > > > > - adopting the MOST bus_type > > > - r

[RFC 02/12] mtd: nand: force drivers to explicitly send READ/PROG commands

2017-10-18 Thread Miquel Raynal
From: Boris Brezillon The core currently send the READ0 and SEQIN+PAGEPROG commands in nand_do_read/write_ops(). This is inconsistent with ->read/write_oob[_raw]() hooks behavior which are expected to send these commands. There's already a flag (NAND_ECC_CUSTOM_PAGE_ACCESS) to inform the core th

[RFC 03/12] mtd: nand: use a static data_interface in the nand_chip structure

2017-10-18 Thread Miquel Raynal
Change the data_interface field from the nand_chip structure, convert the pointer to a static structure. Also remove the nand_get_default_data_interface() function that become useless and rename the onfi_init_data_interface() by nand_fill_data_interface(), which is a more appropriate name because

[RFC 00/12] Marvell NAND controller rework with ->exec_op()

2017-10-18 Thread Miquel Raynal
Hi, This series adds the implementation of the NAND framework ->exec_op() interface with all the related hooks and helpers. The reasons for adding it are explained in details in the commit log "mtd: nand: add ->exec_op() implementation", but mostly it will ease later expansion of the framework, a

[RFC 09/12] ARM: dts: armada-38x: use reworked NAND controller driver

2017-10-18 Thread Miquel Raynal
Change the bindings to use the reworked Marvell NAND controller driver. Also adapt the nand controller node organization to distinguish which property is relevant for the controller, and which one is NAND chip specific. Expose the partitions as a subnode of the NAND chip. Remove the 'marvell,nand-

[RFC 04/12] mtd: nand: add ->exec_op() implementation

2017-10-18 Thread Miquel Raynal
Introduce the new way to control the NAND controller drivers by implementing the ->exec_op() core helpers and allowing new drivers to use it instead of relying on ->cmd_ctrl(), ->cmdfunc() and ->read/write_byte/word/buf(). The logic is now to send to the controller driver a list of instructions. T

[RFC 06/12] mtd: nand: add reworked Marvell NAND controller driver

2017-10-18 Thread Miquel Raynal
Add marvell_nand driver which aims at replacing the existing pxa3xx_nand driver. The new driver intends to be easier to understand and follows the brand new NAND framework rules by implementing hooks for every pattern the controller might support and referencing them inside a parser object that wi

[RFC 10/12] ARM: dts: armada-39x: use reworked NAND controller driver

2017-10-18 Thread Miquel Raynal
Change the bindings to use the reworked Marvell NAND controller driver. Also adapt the nand controller node organization to distinguish which property is relevant for the controller, and which one is NAND chip specific. Expose the partitions as a subnode of the NAND chip. Remove the 'marvell,nand-

[RFC 08/12] ARM: dts: armada-375: use reworked NAND controller driver

2017-10-18 Thread Miquel Raynal
Change the bindings to use the reworked Marvell NAND controller driver. Also adapt the nand controller node organization to distinguish which property is relevant for the controller, and which one is NAND chip specific. Expose the partitions as a subnode of the NAND chip. Remove the 'marvell,nand-

[RFC 01/12] mtd: nand: provide several helpers to do common NAND operations

2017-10-18 Thread Miquel Raynal
From: Boris Brezillon This is part of the process of removing direct calls to ->cmdfunc() outside of the core in order to introduce a better interface to execute NAND operations. Here we provide several helpers and make use of them to remove all direct calls to ->cmdfunc(). This way, we can easi

[RFC 11/12] ARM: dts: pxa: use reworked NAND controller driver

2017-10-18 Thread Miquel Raynal
Change the bindings to use the reworked Marvell NAND controller driver. Also adapt the nand controller node organization to distinguish which property is relevant for the controller, and which one is NAND chip specific. Expose the partitions as a subnode of the NAND chip. Signed-off-by: Miquel Ray

[RFC 05/12] dt-bindings: mtd: add Marvell NAND controller documentation

2017-10-18 Thread Miquel Raynal
Document the bindings for the legacy and the new bindings relative to Marvell NAND controller driver rework. Signed-off-by: Miquel Raynal --- .../devicetree/bindings/mtd/marvell-nand.txt | 95 ++ 1 file changed, 95 insertions(+) create mode 100644 Documentation/devicet

[RFC 07/12] ARM: dts: armada-370-xp: use reworked NAND controller driver

2017-10-18 Thread Miquel Raynal
Change the bindings to use the reworked Marvell NAND controller driver. Also adapt the nand controller node organization to distinguish which property is relevant for the controller, and which one is NAND chip specific. Expose the partitions as a subnode of the NAND chip. Remove the 'marvell,nand-

[RFC 12/12] ARM64: dts: marvell: use reworked NAND controller driver on Armada 7K/8K

2017-10-18 Thread Miquel Raynal
Change the bindings to use the reworked Marvell NAND controller driver. Also adapt the nand controller node organization to distinguish which property is relevant for the controller, and which one is NAND chip specific. Expose the partitions as a subnode of the NAND chip. Remove the 'marvell,nand-

Re: [PATCH v2] staging: wlan-ng: Remove unnecessary parentheses

2017-10-18 Thread Frank A. Cancio Bello
On Wed, Oct 18, 2017 at 04:17:04PM +0200, Greg KH wrote: > On Mon, Oct 16, 2017 at 09:48:21PM -0400, Frank A. Cancio Bello wrote: > > Remove unnecessary parentheses to comply with preferred coding style for > > the linux kernel and avoid the following checkpatch's message: > > 'CHECK: Unnecessary p

Re: [PATCH v2] staging: wlan-ng: Remove unnecessary parentheses

2017-10-18 Thread Greg KH
On Wed, Oct 18, 2017 at 10:46:09AM -0400, Frank A. Cancio Bello wrote: > On Wed, Oct 18, 2017 at 04:17:04PM +0200, Greg KH wrote: > > On Mon, Oct 16, 2017 at 09:48:21PM -0400, Frank A. Cancio Bello wrote: > > > Remove unnecessary parentheses to comply with preferred coding style for > > > the linux

Re: [Outreachy kernel] Re: [PATCH v2] Staging: rtl8188eu: core: rtw_ap: Use list_for_each_entry_safe

2017-10-18 Thread Julia Lawall
On Wed, 18 Oct 2017, Srishti Sharma wrote: > > > On Wed, Oct 18, 2017 at 6:01 PM, Greg KH wrote: > On Thu, Oct 05, 2017 at 03:16:42PM +0530, Srishti Sharma wrote: > > This is a cleanup patch and doesn't change runtime behavior. > It > > changes an open coded list travers

Re: [PATCH v3 02/26] staging: most: integrate driver in kernel's device model

2017-10-18 Thread Christian Gromm
On 18.10.2017 16:35, Dan Carpenter wrote: On Wed, Oct 18, 2017 at 04:02:33PM +0200, Christian Gromm wrote: On 18.10.2017 14:12, Greg KH wrote: On Mon, Oct 16, 2017 at 10:46:09AM +0200, Christian Gromm wrote: The following patch adapts the driver to use the device model by: - adopting

Re: [Outreachy kernel] Re: [PATCH v2] Staging: rtl8188eu: core: rtw_ap: Use list_for_each_entry_safe

2017-10-18 Thread Julia Lawall
On Wed, 18 Oct 2017, Srishti Sharma wrote: > > > On Wed, Oct 18, 2017 at 8:29 PM, Julia Lawall wrote: > > > On Wed, 18 Oct 2017, Srishti Sharma wrote: > > > > > > > On Wed, Oct 18, 2017 at 6:01 PM, Greg KH >wrote: > >       On Thu, Oct 05, 2017 at 03:16:42P

[PATCH v3] staging: wlan-ng: Remove unnecessary parentheses

2017-10-18 Thread Frank A. Cancio Bello
Remove unnecessary parentheses to comply with preferred coding style for the linux kernel and avoid the following checkpatch's messages: 'CHECK: Unnecessary parentheses around' 'CHECK: Logical continuations should be on the previous line' Credits to checkpatch. Signed-off-by: Frank A. Cancio Bell

Re: [PATCH] imx-csi: fix burst size

2017-10-18 Thread Philipp Zabel
On Fri, 2017-09-29 at 22:41 +0100, Russell King wrote: > Setting a burst size of "8" doesn't work for IMX219 with 8-bit bayer, > but a burst size of "16" does. Fix this. > > Signed-off-by: Russell King Oh, well, this isn't for me to apply after all. Acked-by: Philipp Zabel regards Philipp >

Re: [RFC 03/12] mtd: nand: use a static data_interface in the nand_chip structure

2017-10-18 Thread Boris Brezillon
On Wed, 18 Oct 2017 16:36:20 +0200 Miquel Raynal wrote: > Change the data_interface field from the nand_chip structure, convert > the pointer to a static structure. You mean "embed a nand_data_interface object". Not sure the static specifier can be used to describe what you do. > > Also remove

[PATCH 0/4] Code cleanup

2017-10-18 Thread Srishti Sharma
This patch series performs code cleanup like using list_for_each_entry_safe to make code more compact and using list_entry instead of container_of for struct list_head* variable types. Srishti Sharma (4): Staging: rtl8188eu: core: rtw_xmit: Use list_for_each_entry_safe Staging: rtl8188eu: co

[PATCH 1/4] Staging: rtl8188eu: core: rtw_xmit: Use list_for_each_entry_safe

2017-10-18 Thread Srishti Sharma
This is a cleanup patch and doesn't change runtime behaviour. It changes an open coded list traversal to use list_for_each_entry_safe. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; expression e; identifier m,list_del_init,f; type T1; T1* pos; iterator name list_fo

[PATCH 2/4] Staging: rtl8188eu: core: rtw_ap: Use list_for_each_entry_safe

2017-10-18 Thread Srishti Sharma
This is a cleanup patch and doesn't change runtime behaviour. It changes an open coded list traversal to use list_for_each_entry_safe. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; expression e; identifier m,list_del_init,f; type T1; T1* pos; iterator name list_fo

[PATCH 3/4] Staging: rtl8188eu: core: rtw_mlme_ext: Use list_for_each_entry_safe

2017-10-18 Thread Srishti Sharma
This is a cleanup patch and doesn't change runtime behaviour. It changes an open coded list traversal to use list_for_each_entry_safe. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; expression e; identifier m,list_del_init,f; type T1; T1* pos; iterator name list_fo

[PATCH 4/4] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-10-18 Thread Srishti Sharma
For variables of the struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging/rtl8188e

staging: fsl-mc-bus: using MSI?

2017-10-18 Thread Randy Dunlap
Hi, I have seen a few randconfig builds where FSL_MC_BUS is enabled. This selects GENERIC_MSI_IRQ_DOMAIN -- even if CONFIG_PCI and CONFIG_PCI_MSI are not enabled. (This is with COMPILE_TEST enabled.) I see in the README.txt file that the DPAA2/MC does use some kind of message interrupts. Severa

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

2017-10-18 Thread Laura Abbott
On 09/27/2017 06:20 AM, Benjamin Gaignard wrote: > diff --git a/drivers/staging/android/ion/ion.c > b/drivers/staging/android/ion/ion.c > index 93e2c90..092b24c 100644 > --- a/drivers/staging/android/ion/ion.c > +++ b/drivers/staging/android/ion/ion.c > @@ -40,6 +40,8 @@ > > #include "ion.h" >

[PATCH] staging: wlan-ng: Convert timers to use timer_setup()

2017-10-18 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Greg Kroah-Hartman Cc: Sergio Paracuellos Cc: Adrien Descamps Cc: Thibaut SAUTEREAU Cc: de...@driver

Re: [PATCH v3] staging: ccree: fix boolreturn.cocci warning

2017-10-18 Thread Tobin C. Harding
Hi Suniel, Well done with you continued versions. I am being particularly nit picky here but since we are striving for perfection I'm sure will humour me. If English is not your first language please forgive me for picking you up on language subtleties. On Wed, Oct 18, 2017 at 12:11:55PM +0530,

Re: [PATCH v3] staging: wlan-ng: Remove unnecessary parentheses

2017-10-18 Thread Tobin C. Harding
On Wed, Oct 18, 2017 at 11:48:21AM -0400, Frank A. Cancio Bello wrote: > Remove unnecessary parentheses to comply with preferred coding style for > the linux kernel and avoid the following checkpatch's messages: > 'CHECK: Unnecessary parentheses around' > 'CHECK: Logical continuations should be on

Re: [RFC 04/12] mtd: nand: add ->exec_op() implementation

2017-10-18 Thread Boris Brezillon
On Wed, 18 Oct 2017 16:36:21 +0200 Miquel Raynal wrote: > Introduce the new way to control the NAND controller drivers by > implementing the ->exec_op() core helpers and allowing new drivers to > use it instead of relying on ->cmd_ctrl(), ->cmdfunc() and > ->read/write_byte/word/buf(). " Introdu

Re: [RFC 05/12] dt-bindings: mtd: add Marvell NAND controller documentation

2017-10-18 Thread Boris Brezillon
On Wed, 18 Oct 2017 16:36:22 +0200 Miquel Raynal wrote: > Document the bindings for the legacy and the new bindings relative to > Marvell NAND controller driver rework. > > Signed-off-by: Miquel Raynal > --- > .../devicetree/bindings/mtd/marvell-nand.txt | 95 > ++ >

Re: [RFC 00/12] Marvell NAND controller rework with ->exec_op()

2017-10-18 Thread Boris Brezillon
Hi Miquel, On Wed, 18 Oct 2017 16:36:17 +0200 Miquel Raynal wrote: > Hi, > > This series adds the implementation of the NAND framework ->exec_op() > interface with all the related hooks and helpers. The reasons for adding > it are explained in details in the commit log "mtd: nand: add > ->exec

Re: [PATCH v3] staging: wlan-ng: Remove unnecessary parentheses

2017-10-18 Thread Frank A. Cancio Bello
On Thu, Oct 19, 2017 at 08:40:08AM +1100, Tobin C. Harding wrote: > On Wed, Oct 18, 2017 at 11:48:21AM -0400, Frank A. Cancio Bello wrote: > > --- a/drivers/staging/wlan-ng/p80211req.c > > +++ b/drivers/staging/wlan-ng/p80211req.c > > @@ -124,7 +124,7 @@ int p80211req_dorequest(struct wlandevice *w

Re: [PATCH v3] staging: wlan-ng: Remove unnecessary parentheses

2017-10-18 Thread Tobin C. Harding
On Wed, Oct 18, 2017 at 06:50:52PM -0400, Frank A. Cancio Bello wrote: > On Thu, Oct 19, 2017 at 08:40:08AM +1100, Tobin C. Harding wrote: > > On Wed, Oct 18, 2017 at 11:48:21AM -0400, Frank A. Cancio Bello wrote: > > > --- a/drivers/staging/wlan-ng/p80211req.c > > > +++ b/drivers/staging/wlan-ng/p

[PATCH net] hv_sock: add locking in the open/close/release code paths

2017-10-18 Thread Dexuan Cui
Without the patch, when hvs_open_connection() hasn't completely established a connection (e.g. it has changed sk->sk_state to SS_CONNECTED, but hasn't inserted the sock into the connected queue), vsock_stream_connect() may see the sk_state change and return the connection to the userspace, and nex

Re: [PATCH] staging: wilc1000: replace redundant computations with 0

2017-10-18 Thread Joe Perches
On Tue, 2017-10-10 at 15:05 +0100, Colin King wrote: > From: Colin Ian King > > Shifting and masking strHostIfSetMulti->enabled is redundant since > enabled is a bool and so all the shifted and masked values will be > zero. Replace them with zero to simplify the code. > > Detected by CoveritySca

Re: [PATCH v3] staging: ccree: fix boolreturn.cocci warning

2017-10-18 Thread Suniel Mahesh
On Thursday 19 October 2017 02:24 AM, Tobin C. Harding wrote: > Hi Suniel, > > Well done with you continued versions. I am being particularly nit picky here > but since we are > striving for perfection I'm sure will humour me. If English is not your first > language please > forgive me for picki