Re: [PATCH v3 00/27] kill devm_ioremap_nocache

2018-01-12 Thread Yisheng Xie
Hi Christophe ， On 2018/1/4 16:05, Christophe LEROY wrote: > > > Le 25/12/2017 à 02:34, Yisheng Xie a écrit : >> >> >> On 2017/12/24 17:05, christophe leroy wrote: >>> >>> >>> Le 23/12/2017 à 14:48, Greg KH a écrit : On Sat, Dec 23, 2017 at 06:55:25PM +0800, Yisheng Xie wrote: > Hi all,

[PATCH v2 1/3] staging: xgifb: vb_table: fix whitespacing issues

2018-01-12 Thread Kenny Ballou
Correct minor checkpatch issues. Signed-off-by: Kenny Ballou --- drivers/staging/xgifb/vb_table.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/vb_table.h b/drivers/staging/xgifb/vb_table.h index 0da63e1da32f..42ecf7fe6766 100644 --- a/drivers/stag

[PATCH v2 0/3] staging: xgifb: checkpatch fixes

2018-01-12 Thread Kenny Ballou
Changes in v2: - Use realname for author and sign-off-by lines ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 3/3] staging: xgifb: vb_setmode: brace style fixes

2018-01-12 Thread Kenny Ballou
Add braces to certain "multiline" conditions where "multiline" means including comments. Signed-off-by: Kenny Ballou --- drivers/staging/xgifb/vb_setmode.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/driver

[PATCH v2 2/3] staging: xgifb: vb_setmode: fix 80 char lines

2018-01-12 Thread Kenny Ballou
Fix a number of checkpatch warnings in xgfib/vb_setmode.c about line length being over 80 characters. Signed-off-by: Kenny Ballou --- drivers/staging/xgifb/vb_setmode.c | 78 ++ 1 file changed, 54 insertions(+), 24 deletions(-) diff --git a/drivers/staging/xg

Re: [PATCH v2 2/3] staging: xgifb: vb_setmode: fix 80 char lines

2018-01-12 Thread Dan Carpenter
On Fri, Jan 12, 2018 at 05:36:40AM -0700, Kenny Ballou wrote: > Fix a number of checkpatch warnings in xgfib/vb_setmode.c about line > length being over 80 characters. > > Signed-off-by: Kenny Ballou > --- > drivers/staging/xgifb/vb_setmode.c | 78 > ++ > 1 f

Re: [PATCH v2 2/3] staging: xgifb: vb_setmode: fix 80 char lines

2018-01-12 Thread Kenny Ballou
On 2018年01月12日 12:42 GMT, Dan Carpenter wrote: > On Fri, Jan 12, 2018 at 05:36:40AM -0700, Kenny Ballou wrote: >> Fix a number of checkpatch warnings in xgfib/vb_setmode.c about line >> length being over 80 characters. >> >> Signed-off-by: Kenny Ballou >> --- >> drivers/staging/xgifb/vb_setmode.

Re: [PATCH v2 2/3] staging: xgifb: vb_setmode: fix 80 char lines

2018-01-12 Thread Dan Carpenter
On Fri, Jan 12, 2018 at 06:10:17AM -0700, Kenny Ballou wrote: > >> @@ -1468,7 +1472,8 @@ static void XGI_SetLVDSRegs(unsigned short > >> ModeIdIndex, > >>tempax |= tempcx; > >> > >>xgifb_reg_set(pVBInfo->Part1Port, 0x15, tempax); > >> - xgifb_reg_set(pVBInfo->Part1Port, 0x14, > >> + xgif

Re: [PATCH v2 2/3] staging: xgifb: vb_setmode: fix 80 char lines

2018-01-12 Thread Kenny Ballou
On 2018年01月12日 13:21 GMT, Dan Carpenter wrote: > On Fri, Jan 12, 2018 at 06:10:17AM -0700, Kenny Ballou wrote: >> >> @@ -1468,7 +1472,8 @@ static void XGI_SetLVDSRegs(unsigned short >> >> ModeIdIndex, >> >> tempax |= tempcx; >> >> >> >> xgifb_reg_set(pVBInfo->Part1Port, 0x15, tempax); >> >> -

Re: [PATCH v2 2/3] staging: xgifb: vb_setmode: fix 80 char lines

2018-01-12 Thread Dan Carpenter
On Fri, Jan 12, 2018 at 06:39:22AM -0700, Kenny Ballou wrote: > > On 2018年01月12日 13:21 GMT, Dan Carpenter wrote: > > On Fri, Jan 12, 2018 at 06:10:17AM -0700, Kenny Ballou wrote: > >> >> @@ -1468,7 +1472,8 @@ static void XGI_SetLVDSRegs(unsigned short > >> >> ModeIdIndex, > >> >> tempax |

Re: [PATCH v2 2/3] staging: xgifb: vb_setmode: fix 80 char lines

2018-01-12 Thread Kenny Ballou
On 2018年01月12日 13:45 GMT, Dan Carpenter wrote: > On Fri, Jan 12, 2018 at 06:39:22AM -0700, Kenny Ballou wrote: >> >> On 2018年01月12日 13:21 GMT, Dan Carpenter wrote: >> > On Fri, Jan 12, 2018 at 06:10:17AM -0700, Kenny Ballou wrote: >> >> >> @@ -1468,7 +1472,8 @@ static void XGI_SetLVDSRegs(unsigned

[PATCH] uio_hv_generic: fix new type mismatch warnings

2018-01-12 Thread Arnd Bergmann
In commit 72d146578950 ("uio_hv_generic: fix type mismatch warnings"), I addressed some warnings that show up with CONFIG_X86_PAE, now a new change has added more of the same: drivers/uio/uio_hv_generic.c: In function 'hv_uio_probe': drivers/uio/uio_hv_generic.c:205:5: error: cast from pointer to

[PATCH][next] staging: ccree: fix memory leaks in cc_ivgen_init

2018-01-12 Thread Colin King
From: Colin Ian King The current error exit path in function cc_ivgen_init via label 'out' free's resources from the drvdata->ivgen_handle context. However, drvdata->ivgen_handle has not been assigned to the context ivgen_ctx at this point, so the resources are not freed. Fix this by setting drvd

[PATCH v3 0/3] staging: xgifb: checkpatch fixes

2018-01-12 Thread Kenny Ballou
Changes for v3: - fix list address in sent preivously sent patches, sorry for duplicate mails to the CCs - remove spurious additional character that should never have been in the original patch series - remove some indented changes, specifically in 2/3, as discussed with Dan Carpenter __

[PATCH v3 2/3] staging: xgifb: vb_setmode: fix long line warnings

2018-01-12 Thread Kenny Ballou
Fix a number of checkpatch warnings in xgfib/vb_setmode.c about line length being over 80 characters. Signed-off-by: Kenny Ballou --- drivers/staging/xgifb/vb_setmode.c | 75 ++ 1 file changed, 52 insertions(+), 23 deletions(-) diff --git a/drivers/staging/xg

[PATCH v3 1/3] staging: xgifb: vb_table: fix whitespacing issues

2018-01-12 Thread Kenny Ballou
Correct minor checkpatch issues. Signed-off-by: Kenny Ballou --- drivers/staging/xgifb/vb_table.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/vb_table.h b/drivers/staging/xgifb/vb_table.h index 0da63e1da32f..42ecf7fe6766 100644 --- a/drivers/stag

[PATCH v3 3/3] staging: xgifb: vb_setmode: brace style fixes

2018-01-12 Thread Kenny Ballou
Add braces to certain "multiline" conditions where "multiline" means including comments. Signed-off-by: Kenny Ballou --- drivers/staging/xgifb/vb_setmode.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/driver

Re: [PATCH v3 2/3] staging: xgifb: vb_setmode: fix long line warnings

2018-01-12 Thread Dan Carpenter
On Fri, Jan 12, 2018 at 09:23:08AM -0700, Kenny Ballou wrote: > Fix a number of checkpatch warnings in xgfib/vb_setmode.c about line > length being over 80 characters. > > Signed-off-by: Kenny Ballou > --- > @@ -714,7 +715,9 @@ static void XGI_SetCRT1DE(unsigned short ModeIdIndex, > data &=

Re: [PATCH v3 2/3] staging: xgifb: vb_setmode: fix long line warnings

2018-01-12 Thread Kenny Ballou
On 2018年01月12日 19:22 GMT, Dan Carpenter wrote: On Fri, Jan 12, 2018 at 09:23:08AM -0700, Kenny Ballou wrote: Fix a number of checkpatch warnings in xgfib/vb_setmode.c about line length being over 80 characters. Signed-off-by: Kenny Ballou --- @@ -714,7 +715,9 @@ static void XGI_SetCRT1DE(uns

[PATCH v4 0/3] staging: xgifb: checkpatch fixes

2018-01-12 Thread Kenny Ballou
Changes in v4 from v3: - 2/3: - Correct mistakenly removed character - Remove style changes for non-line overrun fixes - Based on discussion of non-line overrun , correct style of other line fixes ___ devel mailing list de...@linuxdriverprojec

[patch v4 2/3] staging: xgifb: vb_setmode: fix long line warnings

2018-01-12 Thread Kenny Ballou
Fix a number of checkpatch warnings in xgfib/vb_setmode.c about line length being over 80 characters. Signed-off-by: Kenny Ballou --- drivers/staging/xgifb/vb_setmode.c | 64 +- 1 file changed, 42 insertions(+), 22 deletions(-) diff --git a/drivers/staging/xg

[patch v4 1/3] staging: xgifb: vb_table: fix whitespacing issues

2018-01-12 Thread Kenny Ballou
Correct minor checkpatch issues. Signed-off-by: Kenny Ballou --- drivers/staging/xgifb/vb_table.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/vb_table.h b/drivers/staging/xgifb/vb_table.h index 0da63e1da32f..42ecf7fe6766 100644 --- a/drivers/stag

[patch v4 3/3] staging: xgifb: vb_setmode: brace style fixes

2018-01-12 Thread Kenny Ballou
Add braces to certain "multiline" conditions where "multiline" means including comments. Signed-off-by: Kenny Ballou --- drivers/staging/xgifb/vb_setmode.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/driver

[PATCH] staging: lustre: lmv: prefer kstrto to single variable sscanf

2018-01-12 Thread Sumit Pundir
A kstrto should be preferred for a single variable instead of sscanf to convert string to the the required datatype. Issue reported by checkpatch.pl Signed-off-by: Sumit Pundir --- drivers/staging/lustre/lustre/lmv/lmv_obd.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) d