Re: [PATCH] scsi: storvsc: missing error code in storvsc_probe()

Dan, > We should set the error code if fc_remote_port_add() fails. Applied to 4.16/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: lustre: Fix avoid intensive reconnecting for ko2iblnd patch

> On Jan 16, 2018, at 09:56, Greg Kroah-Hartman > wrote: > > On Tue, Jan 16, 2018 at 03:01:49PM +, Eremin, Dmitry wrote: >> In the original commit 4d99b2581effe115376402e710fbcb1c3c073769 > > Please use the documented way to write this: > 4d99b2581eff

[PATCH v2 4/4] Staging: rtl8723bs: Use !x instead of NULL comparison

If "x" is compared to NULL, use "!x" instead of it, so as to follow the kernel coding style. Signed-off-by: Shreeya Patel --- Changes in v2 -Rebase and resend. drivers/staging/rtl8723bs/hal/sdio_ops.c | 18 +- 1 file changed, 9 insertions(+), 9

[PATCH v2 3/4] Staging: rtl8723bs: Change condition to assignment

Change the conditional operator to assignment as it is not a conditional statement. Signed-off-by: Shreeya Patel --- Changes in v2 -Rebase and resend. drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 2/4] Staging: rtl8723bs: Change names to conform to the kernel code

Change names of some variables and functions to conform to the kernel coding style. Signed-off-by: Shreeya Patel --- Changes in v2 -Rebase and resend. drivers/staging/rtl8723bs/hal/sdio_ops.c | 714 +++ 1 file changed, 357

[PATCH v2 0/4] Remove checkpatch warnings

This patchset removes some warnings generated by checkpatch for cleanup of the rtl8723bs driver. Also some additional cleanups are introduced in the *[1/4] and *[3/4] patches to make the code according to the kernel coding style. Changes in v2 -Rebase and resend the patches [2/4], [3/4] and

Re: [PATCH v3 3/7] x86/hyper-v: reenlightenment notifications support

On Tue, 16 Jan 2018, Vitaly Kuznetsov wrote: > Hyper-V supports Live Migration notification. This is supposed to be used > in conjunction with TSC emulation: when we are migrated to a host with > different TSC frequency for some short period host emulates our accesses > to TSC and sends us an

Re: [PATCH v3 5/7] x86/irq: Count Hyper-V reenlightenment interrupts

On Tue, 16 Jan 2018, Vitaly Kuznetsov wrote: > Hyper-V reenlightenment interrupts arrive when the VM is migrated, we're > not supposed to see many of them. However, it may be important to know > that the event has happened in case we have L2 nested guests. > > Signed-off-by: Vitaly Kuznetsov

Re: [PATCH v3 4/7] x86/hyper-v: redirect reenlightment notifications on CPU offlining

On Tue, 16 Jan 2018, Vitaly Kuznetsov wrote: > It is very unlikely for CPUs to get offlined when we run on Hyper-V as > we have a protection in vmbus module which prevents it when we have any > VMBus devices assigned. This, however, may change in future if an option > to reassign an already

[PATCH v3 6/7] x86/kvm: pass stable clocksource to guests when running nested on Hyper-V

Currently, KVM is able to work in 'masterclock' mode passing PVCLOCK_TSC_STABLE_BIT to guests when the clocksource we use on the host is TSC. When running nested on Hyper-V we normally use a different one: TSC page which is resistant to TSC frequency changes on event like L1 migration. Add support

[PATCH v3 7/7] x86/kvm: support Hyper-V reenlightenment

When we run nested KVM on Hyper-V guests we need to update masterclocks for all guests when L1 migrates to a host with different TSC frequency. Implement the procedure in the following way: - Pause all guests. - Tell our host (Hyper-V) to stop emulating TSC accesses. - Update our gtod copy,

[PATCH v3 2/7] x86/hyper-v: add a function to read both TSC and TSC page value simulateneously

This is going to be used from KVM code where we need to get both TSC and TSC page value. Nobody is supposed to use the function when Hyper-V code is compiled out, just BUG(). Signed-off-by: Vitaly Kuznetsov --- arch/x86/hyperv/hv_init.c | 1 +

[PATCH v3 4/7] x86/hyper-v: redirect reenlightment notifications on CPU offlining

It is very unlikely for CPUs to get offlined when we run on Hyper-V as we have a protection in vmbus module which prevents it when we have any VMBus devices assigned. This, however, may change in future if an option to reassign an already active channel will be added. It is also possible to run

[PATCH v3 5/7] x86/irq: Count Hyper-V reenlightenment interrupts

Hyper-V reenlightenment interrupts arrive when the VM is migrated, we're not supposed to see many of them. However, it may be important to know that the event has happened in case we have L2 nested guests. Signed-off-by: Vitaly Kuznetsov --- arch/x86/hyperv/hv_init.c |

[PATCH v3 3/7] x86/hyper-v: reenlightenment notifications support

Hyper-V supports Live Migration notification. This is supposed to be used in conjunction with TSC emulation: when we are migrated to a host with different TSC frequency for some short period host emulates our accesses to TSC and sends us an interrupt to notify about the event. When we're done

[PATCH v3 1/7] x86/hyper-v: check for required priviliges in hyperv_init()

In hyperv_init() we presume we always have access to VP index and hypercall MSRs while according to the specification we should check if we're allowed to access the corresponding MSRs before accessing them. Signed-off-by: Vitaly Kuznetsov Reviewed-by: Thomas Gleixner

[PATCH v3 0/7] x86/kvm/hyperv: stable clocksorce for L2 guests when running nested KVM on Hyper-V

Changes since v2: - Add Paolo's Acked-by to PATCH6-7 - Add Thomas' Reviewed-by to PATCH1 - Update the description of PATCH2 to match the reality [Thomas Gleixner] - Add __visible and __irq_entry annotations to hyperv_reenlightenment_intr() [Thomas Gleixner] - Drop spinlock protection and use

[PATCH] staging: lustre: Fix avoid intensive reconnecting for ko2iblnd patch

The logic of the original commit 4d99b2581eff ("staging: lustre: avoid intensive reconnecting for ko2iblnd") was assumed conditional free of struct kib_conn if the second argument free_conn in function kiblnd_destroy_conn(struct kib_conn *conn, bool free_conn) is true. But this hunk of code was

[PATCH v2] staging: fsl-mc: Convert documentation to rst format

Update the doc file to comply with the rst format. It's not integrated into the documentation build structure yet, since it's still located in drivers/staging. Signed-off-by: Ioana Radulescu --- v2: patch generated with -M option .../staging/fsl-mc/{README.txt =>

Re: [PATCH] staging: lustre: Fix avoid intensive reconnecting for ko2iblnd patch

On Tue, Jan 16, 2018 at 03:01:49PM +, Eremin, Dmitry wrote: > In the original commit 4d99b2581effe115376402e710fbcb1c3c073769 Please use the documented way to write this: 4d99b2581eff ("staging: lustre: avoid intensive reconnecting for ko2iblnd") > was missed one hunk. Added it now

Re: [PATCH 8/8] staging: fsl-mc: Convert documentation to rst format

On Tue, Jan 16, 2018 at 03:40:18PM +, Ruxandra Ioana Ciocoi Radulescu wrote: > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, January 16, 2018 5:14 PM > > To: Bogdan Purcareata > > Cc: Laurentiu Tudor

Re: staging: lustre: lnet: convert selftest to use workqueues

On Tue, Jan 16, 2018 at 03:59:58PM +, Colin Ian King wrote: > Hi, > > CoverityScan detected a couple of issues, one of which was introduced > with the following commit: > > commit 6106c0f82481e686b337ee0c403821fb5c3c17ef > Author: NeilBrown > Date: Thu Jan 11 15:06:40 2018

[PATCH] staging: most: replace function name to __func__

Fix checkpatch.pl warning message about logging code. Previous code contains hard coded function name. Fix this code by using __func__ macro. Signed-off-by: Sidong Yang --- drivers/staging/most/dim2/dim2.c | 2 +- drivers/staging/most/video/video.c | 24

Re: staging: lustre: lnet: convert selftest to use workqueues

Hi, CoverityScan detected a couple of issues, one of which was introduced with the following commit: commit 6106c0f82481e686b337ee0c403821fb5c3c17ef Author: NeilBrown Date: Thu Jan 11 15:06:40 2018 +1100 CoverityScan CID#1464078 ("Uninitialized scalar variable") I'm not sure

RE: [PATCH 8/8] staging: fsl-mc: Convert documentation to rst format

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, January 16, 2018 5:14 PM > To: Bogdan Purcareata > Cc: Laurentiu Tudor ; Ruxandra Ioana Ciocoi > Radulescu ;

Re: [PATCH v3 02/10] include: Move compat_timespec/ timeval to compat_time.h

On Mon, 15 Jan 2018 18:18:10 -0800 Deepa Dinamani wrote: > diff --git a/arch/x86/include/asm/ftrace.h b/arch/x86/include/asm/ftrace.h > index 09ad88572746..db25aa15b705 100644 > --- a/arch/x86/include/asm/ftrace.h > +++ b/arch/x86/include/asm/ftrace.h Acked-by: Steven

Re: [PATCH v3 00/10] posix_clocks: Prepare syscalls for 64 bit time_t conversion

On Tue, Jan 16, 2018 at 3:18 AM, Deepa Dinamani wrote: > The series is a preparation series for individual architectures > to use 64 bit time_t syscalls in compat and 32 bit emulation modes. > > This is a follow up to the series Arnd Bergmann posted: >

Re: [PATCH 8/8] staging: fsl-mc: Convert documentation to rst format

On Tue, Jan 16, 2018 at 03:19:10PM +0200, Bogdan Purcareata wrote: > From: Ioana Radulescu > > Update the doc file to comply with the rst format. > > It's not integrated into the documentation build structure yet, > since it's still located in drivers/staging. > >

Re: [PATCH 3/8] staging: fsl-mc: Add SPDX license identifiers

On Tue, Jan 16, 2018 at 03:19:05PM +0200, Bogdan Purcareata wrote: > diff --git a/drivers/staging/fsl-mc/bus/dpbp-cmd.h > b/drivers/staging/fsl-mc/bus/dpbp-cmd.h > index 5904836..1ac8ec6 100644 > --- a/drivers/staging/fsl-mc/bus/dpbp-cmd.h > +++ b/drivers/staging/fsl-mc/bus/dpbp-cmd.h > @@ -1,33

RE: [PATCH] scsi: storvsc: missing error code in storvsc_probe()

> -Original Message- > From: Cathy Avery [mailto:cav...@redhat.com] > Sent: Tuesday, January 16, 2018 6:36 AM > To: Dan Carpenter ; KY Srinivasan > > Cc: Haiyang Zhang ; Stephen Hemminger > ;

Re: [PATCH] Staging: netlogic: platform_net: Fixed '(' at the EOL

On Tue, Jan 16, 2018 at 07:33:03PM +0530, Naveen Panwar wrote: > Hi Guys, > > I submitted a new patch with the suggestions from Al Viro, did you guys > check it? I do not see any patch from my in my queue :( ___ devel mailing list

[PATCH] staging: lustre: Fix avoid intensive reconnecting for ko2iblnd patch

In the original commit 4d99b2581effe115376402e710fbcb1c3c073769 was missed one hunk. Added it now to avoid issue with use after free. Signed-off-by: Dmitry Eremin --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [PATCH] scsi: storvsc: missing error code in storvsc_probe()

On 01/16/2018 05:40 AM, Dan Carpenter wrote: We should set the error code if fc_remote_port_add() fails. Fixes: daf0cd445a21 ("scsi: storvsc: Add support for FC rport.") Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c

[PATCH 02/13] staging: wilc1000: rename wilc_wfi_p2pListenParams struct and its member variable

This is a cleanup patch to avoid the use of camelCase for variable names. In this patch, "Avoid camelCase" issue found by checkpatch.pl is fixed. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 28 +++

[PATCH 07/13] staging: wilc1000: rename camelCase used in functions start with WILC_WFI_Cfg

This is cleanup patch, to fix the camelCase issue reported by checkpatch.pl. In this patch remane the function starts with "WILC_WFI_Cfg" to avoid camelCase names. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 34

[PATCH 11/13] staging: wilc1000: rename strStaParams variable to avoid camelCase

This is a cleanup patch to rename strStaParams to sta_params to avoid camelCase. Changes fix "Avoid camelCase" issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 44 +++ 1 file

[PATCH 13/13] staging: wilc1000: rename strStatistics & tenuAuth_type to avoid camelCase

This is a cleanup patch to avoid using camelCase for variable names. Changes fix "Avoid camelCase" issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 30 +++ 1 file changed, 15

[PATCH 08/13] staging: wilc1000: rename pstrWFIDrv to wfi_drv to avoid camelCase naming

This is cleanup patch, it fixes "Avoid CamelCase: " issue found by checkpatch.pl Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 36 +++ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git

[PATCH 10/13] staging: wilc1000: rename variables using camelCase in add_key()

This is a cleanup patch to avoid using camelCase for variable names. Changes fix "Avoid camelCase" issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 56 +++ 1 file changed, 28

[PATCH 12/13] staging: wilc1000: rename pstrCfgParamVal varaible in set_wiphy_params()

This is a cleanup patch to fix camelCase issue found by checkpatch.pl script. In this patch, renamed pstrCfgParamVal to cfg_param_val to avoid camelCase for variable name. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 22

[PATCH 04/13] staging: wilc1000: remove unused element in wilc_wfi_p2p_listen_params struct

This is cleanup patch, to remove the unused "tenuChannelType" element from wilc_wfi_p2p_listen_params structure. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 05/13] staging: wilc1000: rename s32Error variable to avoid camelCase notation

This is cleanup patch, rename "s32Error" to fix "Avoid CamelCase: " found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 138 +++--- 1 file changed, 69 insertions(+), 69 deletions(-) diff

[PATCH 06/13] staging: wilc1000: rename CfgConnectResult() and its local variable names

This is cleanup patch,to avoid use of camelCase for variable name and function names in CfgConnectResult(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 74 +++ 1 file changed, 37 insertions(+), 37 deletions(-)

[PATCH 09/13] staging: wilc1000: rename NullBssid to null_bssid to avoid camelCase variable name

This is cleanup patch, it fixes "Avoid CamelCase: " found by checkpatch.pl. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 03/13] staging: wilc1000: rename au8Sta_AssociatedBss element sta_info structure

This is a cleanup patch, to rename au8Sta_AssociatedBss element of sta_info structure. The changes fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8

[PATCH 00/13] Changes to avoid CamelCase and removed unused variable

This patch series contains changes to avoid use of CamelCase for variable names. Also removed the unused variable in wilc_wfi_p2p_listen_params struct. Ajay Singh (13): staging: wilc1000: rename elements of wilc_priv struct to avoid using camelCase staging: wilc1000: rename

[PATCH 01/13] staging: wilc1000: rename elements of wilc_priv struct to avoid using camelCase

This is cleanup patch, to avoid the use of camelCase for "wilc_priv" structure member variables. The changes fix the camelCase issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 90

[PATCH 0/8] staging: fsl-mc: Cleanup

The patchset aims to address most of the feedback gathered at the latest attempt to move it out of staging. You can find the discussion here [1]. Patches 1-2 remove unused code and consolidate the fsl-mc core bus infrastructure header files into fsl-mc-private.h. Patch 3 removes full license

[PATCH 8/8] staging: fsl-mc: Convert documentation to rst format

From: Ioana Radulescu Update the doc file to comply with the rst format. It's not integrated into the documentation build structure yet, since it's still located in drivers/staging. Signed-off-by: Ioana Radulescu Reviewed-by: Laurentiu

[PATCH 7/8] staging: fsl-mc: README cleanup

From: Ioana Radulescu Minor cosmetic changes to the DPAA2 overview documentation file. Add a reference to the mc-bus driver sysfs documentation. Signed-off-by: Ioana Radulescu Reviewed-by: Laurentiu Tudor ---

[PATCH 6/8] staging: fsl-mc: Update include header

From: Ioana Radulescu With the declarations of its_fsl_mc_msi_init/cleanup() now removed from fsl-mc-private.h, irq-gic-v3-its-fsl-mc-msi.c only needs a couple of definitions from mc.h, so include that header directly. Signed-off-by: Ioana Radulescu

[PATCH 3/8] staging: fsl-mc: Add SPDX license identifiers

The fsl-mc bus and dpio driver files use a combination of GPL-2.0 and GPL-2.0+ OR BSD-3-Clause licenses. Update to latter for all files. Add SPDX tags and delete the full license text. Update copyright information. Signed-off-by: Bogdan Purcareata Reviewed-by:

[PATCH 5/8] staging: fsl-mc: Remove unnecessary dependency

From: Ioana Radulescu The function that enables fsl-mc msi interrupts doesn't need to be explicitly called from the fsl-mc bus driver initialization routine. Mark it to be independently called at system init; this is in line with how things are handled by other GICv3

[PATCH 4/8] staging: fsl-mc: Remove dead code

From: Ioana Radulescu Remove one unused function from irq-gic-v3-its-fsl-mc-msi.c Signed-off-by: Ioana Radulescu Reviewed-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/fsl-mc-private.h | 2 --

[PATCH 2/8] staging: fsl-mc: Consolidate bus core header files

The DPAA2 objects involved (DPMNG, DPMCP, DPRC) are used by the fsl-mc bus infrastructure only, so group the APIs and structs into fsl-mc-private.h. Signed-off-by: Bogdan Purcareata Reviewed-by: Laurentiu Tudor ---

[PATCH 1/8] staging: fsl-mc: Cleanup dprc and dpmcp header files

A lot of API and associated structures are not used by current code, so remove them. Signed-off-by: Bogdan Purcareata Reviewed-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dpmcp-cmd.h | 2 - drivers/staging/fsl-mc/bus/dpmcp.c |

[PATCH] scsi: storvsc: missing error code in storvsc_probe()

We should set the error code if fc_remote_port_add() fails. Fixes: daf0cd445a21 ("scsi: storvsc: Add support for FC rport.") Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 3b3d1d050cac..40fc7a590e81 100644 ---

[PATCH] staging: lustre: lnet: avoid uninitialized return value

gcc warns that the latest workqueue change leads to returning an uninitialized variable: drivers/staging/lustre/lnet/selftest/module.c: In function 'lnet_selftest_init': drivers/staging/lustre/lnet/selftest/module.c:98:10: error: 'rc' may be used uninitialized in this function

Re: [PATCH v3 02/10] include: Move compat_timespec/ timeval to compat_time.h

On Mon, Jan 15, 2018 at 06:18:10PM -0800, Deepa Dinamani wrote: > All the current architecture specific defines for these > are the same. Refactor these common defines to a common > header file. > > The new common linux/compat_time.h is also useful as it > will eventually be used to hold all the

Re: [lustre-devel] [bug report] staging: lustre: replace simple cases of LIBCFS_ALLOC with kzalloc.

On Mon, Jan 15, 2018 at 06:27:26PM +, Eremin, Dmitry wrote: > Hello Dan, > > The function kiblnd_destroy_conn() is conditionally free the conn pointer. > > void kiblnd_destroy_conn(kib_conn_t *conn, bool free_conn) > { > […] > if (free_conn) >