Re: [PATCH 1/4] staging: wilc1000: remove use of 'happened' variable in wilc_spi_read_int()

On Thu, Feb 22, 2018 at 02:09:01PM +0530, Ajay Singh wrote: > Hi Dan, > > On Thu, 22 Feb 2018 10:20:58 +0300 > Dan Carpenter wrote: > > > On Wed, Feb 21, 2018 at 09:42:09PM +0530, Ajay Singh wrote: > > > Modified wilc_spi_read_int() by removing unnecessary use of

Re: [PATCH 1/4] staging: wilc1000: remove use of 'happened' variable in wilc_spi_read_int()

Hi Dan, On Thu, 22 Feb 2018 10:20:58 +0300 Dan Carpenter wrote: > On Wed, Feb 21, 2018 at 09:42:09PM +0530, Ajay Singh wrote: > > Modified wilc_spi_read_int() by removing unnecessary use of "happened" > > variable. > > > > Signed-off-by: Ajay Singh

Re: [PATCH v2 4/9] staging: android: ion: Avoid NULL point in error path

Hi Greg, Sorry for late responds for I was on vacation. On 2018/2/17 0:27, Greg KH wrote: > On Mon, Feb 12, 2018 at 06:43:09PM +0800, Yisheng Xie wrote: >> If we failed to create debugfs for ion at ion_device_create, the >> debug_root of ion_device will be NULL, and then when try to create debug

Re: [PATCH v2 4/9] staging: android: ion: Avoid NULL point in error path

On Thu, Feb 22, 2018 at 04:59:27PM +0800, Yisheng Xie wrote: > Hi Greg, > > Sorry for late responds for I was on vacation. > > On 2018/2/17 0:27, Greg KH wrote: > > On Mon, Feb 12, 2018 at 06:43:09PM +0800, Yisheng Xie wrote: > >> If we failed to create debugfs for ion at ion_device_create, the

[PATCH] staging: media: atomisp: Remove inclusion of non-existing directories

This patch fix the following build warnings: CC [M] drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.o cc1: warning: drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/bayer_ls/bayer_ls_1.0/: No such file or directory [-Wmissing-include-dirs] cc1: warning:

[PATCH] staging: lustre: selftest: freeing an error pointer

We should just return directly if memdup_user() fails. The current code tries to free "param" which is an error pointer so it will Oops. Fixes: 2baddf262e98 ("staging: lustre: use memdup_user to allocate memory and copy from user") Signed-off-by: Dan Carpenter diff

[PATCH -next 2/2] staging: android: ion: Remove check of idev->debug_root

We will go on initial idev if failed to create debug_root, and it does not matter to check the return value of this debugfs call, just remove it. Signed-off-by: Yisheng Xie --- drivers/staging/android/ion/ion.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH -next 1/2] staging: android: ion: Remove check of debug_file

There's no need to check the return value of debug_file for it is just a debugfs and we will go on the following process if we failed to create debug_file. So just remove it. Signed-off-by: Yisheng Xie --- drivers/staging/android/ion/ion.c | 9 ++--- 1 file changed,

Re: [PATCH 2/4] staging: wilc1000: modified wilc_spi_read_int() by using GENMASK macro

Hi Dan, On 22.02.2018 09:37, Dan Carpenter wrote: > On Wed, Feb 21, 2018 at 09:42:10PM +0530, Ajay Singh wrote: >> Use existing macro GENMASK to get the bitmask value. Moved the code to >> get the bitmask value outside the loop, as its only required one time. >> >> Signed-off-by: Ajay Singh

Re: [PATCH 2/4] staging: wilc1000: modified wilc_spi_read_int() by using GENMASK macro

On 22.02.2018 11:23, Claudiu Beznea wrote: > Hi Dan, Sorry, I intended to be address this to Ajay, > > On 22.02.2018 09:37, Dan Carpenter wrote: >> On Wed, Feb 21, 2018 at 09:42:10PM +0530, Ajay Singh wrote: >>> Use existing macro GENMASK to get the bitmask value. Moved the code to >>> get the

Re: [PATCH] Staging: gdm724x: hci: Changed camel-case to snake-case.

On Wed, Feb 21, 2018 at 01:45:58PM +0300, Dan Carpenter wrote: > On Wed, Feb 21, 2018 at 02:39:28AM -0800, Quytelda Kahja wrote: > > Changed a variable name from camel to snake case to fix a coding style > > issue. > > > > Signed-off-by: Quytelda Kahja > > --- > >

Re: [PATCH v2 1/3] staging: xm2mvscale: Driver support for Xilinx M2M Video Scaler

On Wed, Feb 21, 2018 at 02:43:14PM -0800, Rohit Athavale wrote: > This commit adds driver support for the pre-release Xilinx M2M Video > Scaler IP. There are three parts to this driver : > > - The Hardware/IP layer that reads and writes register of the IP >contained in the scaler_hw_xm2m.c >

[GIT PULL] Staging/IIO fixes for 4.16-rc3

The following changes since commit 7928b2cbe55b2a410a0f5c1f154610059c57b1b2: Linux 4.16-rc1 (2018-02-11 15:04:29 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.16-rc2 for you to fetch changes up to

[PATCH] Staging: rtl8192e: rtllib_crypt_tkip.c: Use __func__ instead of function name and proper code ident for else statement

From: Debopriyo This is a patch to the rtllib_crypt_tkip.c file that fixes 2 issues found by the checkpatch.pl tool 1.Use of __func__ instead of function name 2.proper code identation for else statement Signed-off-by: Debopriyo Ghosh ---

[PATCH 1/3] staging: lustre: lov: use correct env in lov_io_data_version_end()

lov - the logical object volume manager - is responsible for striping data across multiple volumes. So when it is given a request, it creates one or more sub-requests, one for each target volume. Each sub_io request has a sub_env environment which it operates in. When lov_io_data_version_end()

[PATCH 0/3] Three lustre bugfixes

First two patches fix bugs that have been prevented the test suite from finished for me - now it completes with about 10% of tests failing. Third patch fixes a tiny bug I noticed while reviewing another recent patch to the same file. Thanks, NeilBrown --- NeilBrown (3): staging: lustre:

[PATCH 2/3] staging: lustre: lmv: correctly iput lmo_root

Commit 8f18c8a48b73 ("staging: lustre: lmv: separate master object with master stripe") changed how lmo_root inodes were managed, particularly when LMV_HASH_FLAG_MIGRATION is not set. Previously lsm_md_oinfo[0].lmo_root was always a borrowed inode reference and didn't need to by iput(). Since the

[PATCH 3/3] staging: lustre: lnet/selftest: don't ignore status from lstcon_test_add

If lstcon_test_add sets 'ret' (passed by reference) to 1, then lst_test_add_ioctl() ignores the return value. This isn't justified - the return value must be zero for 'ret' to be meaningful. Signed-off-by: NeilBrown --- drivers/staging/lustre/lnet/selftest/conctl.c |2 +- 1

Re: [PATCH v2 0/3] Initial driver support for Xilinx M2M Video Scaler

Le mercredi 21 février 2018 à 14:43 -0800, Rohit Athavale a écrit : > This patch series has three commits : > - Driver support for the Xilinx M2M Video Scaler IP > - TODO document > - DT binding doc > > Changes in HW register map is expected as the IP undergoes changes. > This is a first

[PATCH 3/4] Staging: gdm724x: Simplify the struct gdm_endian to a variable.

Since the testing for host endianness and in-driver conversion were removed in 77e8a50149a2, the gdm_endian struct contains only one member, and can therefore be simplified to a single u8 variable. Signed-off-by: Quytelda Kahja --- drivers/staging/gdm724x/gdm_endian.c | 24

[PATCH 2/4] Staging: gdm724x: hci: Changed camel-case to snake-case.

Changed a variable name from camel to snake case to fix a coding style issue. Signed-off-by: Quytelda Kahja --- drivers/staging/gdm724x/hci_packet.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/hci_packet.h

[PATCH 4/4] Staging: gdm724x: LTE: Refactor gdm_lte_pdn_table().

Mostly this change just reverses the primary conditional so most of the code can be pulled back a tab, which fixes some code style warnings. Signed-off-by: Quytelda Kahja --- drivers/staging/gdm724x/gdm_lte.c | 22 +++--- 1 file changed, 11 insertions(+),

[PATCH 1/4] Staging: gdm724x: LTE: Fix trailing open parentheses.

Fix lines with a trailing open parenthesis, which is a coding style issue. Signed-off-by: Quytelda Kahja --- drivers/staging/gdm724x/gdm_lte.c | 44 +++ 1 file changed, 21 insertions(+), 23 deletions(-) diff --git

Re: [PATCH 1/2] Staging: gdm724x: Simplify the struct gdm_endian to a variable.

Sorry, it depends on the several patches I submitted earlier in that email thread, since they were in response to several suggestions for earlier patches. I will resend all of the patches in that thread as a consecutive patch series in response to this email to minimize confusion. Thank you,

Re: [PATCH 0/4] staging: wilc1000: modify functions by making use of GENMASK macro

Please ignore this patch series, I will work on review comments and submit another version later. Regards, Ajay ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/2] Staging: gdm724x: Simplify the struct gdm_endian to a variable.

On Wed, Feb 21, 2018 at 05:12:36AM -0800, Quytelda Kahja wrote: > Since the testing for host endianness and in-driver conversion were > removed in 77e8a50149a2, the gdm_endian struct contains only one member, > and can therefore be simplified to a single u8 variable. > > Signed-off-by: Quytelda

Re: [PATCH v6 0/2] staging: fsl-mc: Move bus driver out of staging

On Mon, Feb 05, 2018 at 08:07:41AM -0600, Bogdan Purcareata wrote: > Previous submission: https://lkml.org/lkml/2018/1/26/215 > > Split the code into moving out the core bus infrastructure separate from > the irqchip glue code. Add a Kconfig dependency on ARM_GIC_V3_ITS. > Integrate the