Re: [PATCH] staging: wilc1000: replace kmalloc + memcpy with kmemdup

On Mon, 26 Mar 2018 18:16:29 +0100 Colin King wrote: > From: Colin Ian King > > Replace several allocation and memcpys with kmemdup and add in some > missing memory allocation failure checks. Also fix an incorrect > -EFAULT return with

Re: [PATCH v3 1/2] staging: media: davinci_vpfe: add error handling on kmalloc failure

On Wed, Mar 21, 2018 at 01:39:09PM +0900, Ji-Hun Kim wrote: > There is no failure checking on the param value which will be allocated > memory by kmalloc. Add a null pointer checking statement. Then goto error: > and return -ENOMEM error code when kmalloc is failed. > > Signed-off-by: Ji-Hun Kim

Re: [PATCH v3 1/2] staging: media: davinci_vpfe: add error handling on kmalloc failure

On Tue, Mar 27, 2018 at 02:00:45PM +0900, Ji-Hun Kim wrote: > > Are there any opinions? I'd like to know how this patch is going. > Looks good. Thanks! Greg just hasn't gotten to it yet. regards, dan carpenter ___ devel mailing list

Re: [PATCH 4/9] staging: wilc1000: free memory allocated in add wep key functions

On Fri, Mar 23, 2018 at 08:38:53PM +0530, Ajay Singh wrote: > Free memory allocated for wep key when command enqueue is failed. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/host_interface.c | 10 +++--- > 1 file changed, 7 insertions(+), 3

Re: [PATCH v2 6/6] staging: ks7010: factor out some functions from hostif_init

On Fri, Mar 23, 2018 at 06:00:38PM +0100, Sergio Paracuellos wrote: > +static inline void hostif_pmklist_init(struct ks_wlan_private *priv) > +{ > + int i; > memset(>pmklist, 0, sizeof(priv->pmklist)); Put a blank line after the declaration block. Otherwise it looks good. regards, dan

Re: [PATCH 1/6] staging: ks7010: use GENMASK instead of custom defines in SME_WEP_VAL_MASK

On Fri, Mar 23, 2018 at 05:26:01PM +0100, Sergio Paracuellos wrote: > This commits replaces custom defines that were been used > to define a mask using GENMASK macro from linux bitops > header file. > > With this change the "WARNING: line over 80 characters" > warning message reported by

Re: [PATCH 9/9] staging: wilc1000: free memory allocated for general info message from firmware

What happened to patch 8/9? Anyway, I can't apply this patch and it could be my fault or it could be the missing patch. I don't know... Anwyway, seems like a nice patchset. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 0/9] staging: wilc1000: fix memory leaks and checkpatch reported issues

Reviewed-by: Claudiu Beznea On 23.03.2018 17:08, Ajay Singh wrote: > This patch series contains changes to fix memory leaks, avoid NULL pointer > exceptions and checkpatch reported issue fixes. > > Ajay Singh (9): > staging: wilc1000: remove unused global

[PATCH] Staging: comedi: ni_stc: Fixed comment coding style issue

Fixed a coding style issue where the comment * was not aligned. Signed-off-by: Rene Hickersberger --- drivers/staging/comedi/drivers/ni_stc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_stc.h

Re: [PATCH 9/9] staging: wilc1000: free memory allocated for general info message from firmware

On Mon, Mar 26, 2018 at 05:01:50PM +0530, Ajay Singh wrote: > On Mon, 26 Mar 2018 11:32:41 +0300 > Dan Carpenter wrote: > > > What happened to patch 8/9? Anyway, I can't apply this patch and it > > could be my fault or it could be the missing patch. I don't know... >

Re: [PATCH 4/9] staging: wilc1000: free memory allocated in add wep key functions

Hi Dan, On Mon, 26 Mar 2018 11:17:48 +0300 Dan Carpenter wrote: > On Fri, Mar 23, 2018 at 08:38:53PM +0530, Ajay Singh wrote: > We should "return result;" here otherwise we'll hang when we > wait_for_completion(). This is the sort of bug why I always encourage >

[PATCH v2 6/9] staging: wilc1000: fix to free allocated memory in wilc_add_ptk()

Free allocated memory in wilc_add_ptk() when it fails to enqueue the command. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/host_interface.c | 13 +++-- 1 file changed, 7 insertions(+), 6

[PATCH v2 7/9] staging: wilc1000: free allocated memory in wilc_add_rx_gtk()

Free memory allocated in wilc_add_rx_gtk() before returing from the function. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/host_interface.c | 17 +++-- 1 file changed, 11 insertions(+), 6

[PATCH v2 4/9] staging: wilc1000: free memory allocated in add wep key functions

Free memory allocated for wep key when command enqueue is failed. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/host_interface.c | 24 ++-- 1 file changed, 14 insertions(+), 10

[PATCH v2 0/9] staging: wilc1000: fix memory leaks and checkpatch reported issues

This patch series contains changes to fix memory leaks, avoid NULL pointer exceptions and checkpatch reported issue fixes. V2: Modified patch #4, #6, #7 as per review comments. Added 'Reviewed-by' tags in commit description. Ajay Singh (9): staging: wilc1000: remove unused global variables

[PATCH v2 1/9] staging: wilc1000: remove unused global variables related to p2p

Cleanup patch to remove the unused global variables defined for p2p. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/host_interface.c | 59 --- 1 file changed, 59

[PATCH v2 8/9] staging: wilc1000: split handle_rcvd_gnrl_async_info() to avoid leading tabs

Fix 'Too many leading tabs' issue found by checkpatch.pl script in handle_rcvd_gnrl_async_info(). Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/host_interface.c | 286 -- 1

[PATCH v2 2/9] staging: wilc1000: avoid 'NULL' pointer access in wilc_network_info_received()

Added 'NULL' check before accessing the allocated memory. Free up the memory incase of failure to enqueue the command. Used kmemdup instead of kmalloc & memcpy. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea ---

Re: [PATCH 9/9] staging: wilc1000: free memory allocated for general info message from firmware

On Mon, 26 Mar 2018 11:32:41 +0300 Dan Carpenter wrote: > What happened to patch 8/9? Anyway, I can't apply this patch and it > could be my fault or it could be the missing patch. I don't know... I rechecked by applying the patches in order and didn't face any

[PATCH v2 9/9] staging: wilc1000: free memory allocated for general info message from firmware

Free allocated memory for failure scenario while processing the information message received from the firmware. Added NULL check and used kmemdup in the flow of handling information message. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea

[PATCH v2 3/9] staging: wilc1000: free allocated memory in edit and add station functions

Added fix to free the allocated memory in case of failure to enqueue the command. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/host_interface.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[PATCH v2 5/9] staging: wilc1000: free allocated memory after processing wilc_send_config_pkt()

Free allocated memory after completing wilc_send_config_pkt() function. Remove unncessary use of 'stamac' pointer in handle_get_inactive_time(). Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea ---

Re: [PATCH 4/4] drivers/net: Use octal not symbolic permissions

On Fri, Mar 23, 2018 at 03:54:39PM -0700, Joe Perches wrote: > Prefer the direct use of octal for permissions. > > Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace > and some typing. > > Miscellanea: > > o Whitespace neatening around these conversions. > > Signed-off-by: Joe

Re: [PATCH] staging: wilc1000: check for kmalloc allocation failures

On 26/03/18 16:35, Ajay Singh wrote: > Thanks for submitting the patch. > > On Wed, 21 Mar 2018 13:03:18 -0700 > Joe Perches wrote: > >> On Wed, 2018-03-21 at 19:19 +, Colin King wrote: >>> From: Colin Ian King >>> >>> There are three kmalloc

[PATCH v3 0/6] staging: ks7010: some clean ups in source and header files

The following patch series makes several changes to improve readability of some functions around several header and source files. One checkpatch script warning and some camel cases are removed also. v2: * Remove compilation warning because a declaration after initialization in

[PATCH v3 4/6] staging: ks7010: avoid camel case in function name get_WORD

This commit renames get_WORD function into get_word to avoid camel case. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hostif.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git

[PATCH v3 3/6] staging: ks7010: avoid camel case in function name get_BYTE

This commit renames get_BYTE function in favour of get_byte to avoid camel case. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hostif.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git

[PATCH v3 6/6] staging: ks7010: factor out some functions from hostif_init

This commit factors out some init functions from hostif_init to improve readability. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hostif.c | 77 ++ 1 file changed, 53 insertions(+), 24 deletions(-) diff --git

Re: [PATCH] staging: wilc1000: replace kmalloc + memcpy with kmemdup

Le 26/03/2018 à 19:16, Colin King a écrit : From: Colin Ian King Replace several allocation and memcpys with kmemdup and add in some missing memory allocation failure checks. Also fix an incorrect -EFAULT return with -ENOMEM. Signed-off-by: Colin Ian King

[PATCH] staging: wilc1000: remove unused return variable

From: HariPrasath Elango In this function,removed the unused integer variable as it is not actually used to return function success or failure. Return is a pointer to net_device structure. Signed-off-by: HariPrasath Elango ---

[PATCH v3 5/6] staging: ks7010: avoid camel case in function name get_DWORD

This commit renames function get_DWORD into get_dword to avoid camel case. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hostif.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git

[PATCH v3 1/6] staging: ks7010: use GENMASK instead of custom defines in SME_WEP_VAL_MASK

This commits replaces custom defines that were been used to define a mask using GENMASK macro from linux bitops header file. With this change the "WARNING: line over 80 characters" warning message reported by checkpatch script is also removed. Signed-off-by: Sergio Paracuellos

[PATCH v3 2/6] staging: ks7010: remove some dead code from ks_wlan_set_essid function

This commit removes death code which is not being used at all because it is inside a preprocessor if 0 directive. This change improves a bit readability of ks_wlan_set_essid function. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_wlan_net.c | 15

Re: [PATCH v3]PCI: hv: fix PCI-BUS domainID corruption

> This is not the correct way to submit patches for inclusion in the > stable kernel tree. Please read: > > for how to do this properly. My bad. I am sending the patch to the mainline kernel with a Cc: tag for stable and hoping the patch will be automatically merged to the

[PATCH] staging: wilc1000: replace kmalloc + memcpy with kmemdup

From: Colin Ian King Replace several allocation and memcpys with kmemdup and add in some missing memory allocation failure checks. Also fix an incorrect -EFAULT return with -ENOMEM. Signed-off-by: Colin Ian King ---

[PATCH v5] PCI: hv: Make sure the bus domain is really unique

When Linux runs as a guest VM in Hyper-V and Hyper-V adds the virtual PCI bus to the guest, Hyper-V always provides unique PCI domain. commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain") overrode unique domain with the serial number of the first device added to the virtual PCI

Re: [PATCH 4/4] drivers/net: Use octal not symbolic permissions

From: Joe Perches Date: Fri, 23 Mar 2018 15:54:39 -0700 > Prefer the direct use of octal for permissions. > > Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace > and some typing. > > Miscellanea: > > o Whitespace neatening around these conversions. > >

Re: [PATCH] staging: wilc1000: check for kmalloc allocation failures

Thanks for submitting the patch. On Wed, 21 Mar 2018 13:03:18 -0700 Joe Perches wrote: > On Wed, 2018-03-21 at 19:19 +, Colin King wrote: > > From: Colin Ian King > > > > There are three kmalloc allocations that are not null checked which > >

Re: [PATCH 1/6] staging: ks7010: use GENMASK instead of custom defines in SME_WEP_VAL_MASK

On Mon, Mar 26, 2018 at 10:33 AM, Dan Carpenter wrote: > On Fri, Mar 23, 2018 at 05:26:01PM +0100, Sergio Paracuellos wrote: >> This commits replaces custom defines that were been used >> to define a mask using GENMASK macro from linux bitops >> header file. >> >> With

[PATCH v3 2/4] drivers/staging/fsl-mc: Fix DPIO error path issues

The error path in the dpaa2_dpio_probe() function was not properly unmapping the QBMan device memory on the error path. This was also missing from the dpaa2_dpio_release() function. Also addresses a memory leak of the device private data structure. Signed-off-by: Roy Pledge

[PATCH v3 0/4] drives/soc/fsl: Move DPIO driver out of staging

This patchset moves the NXP DPIO (Datapath I/O Driver) out of the drivers/staging directory and into the drivers/soc/fsl directory. The DPIO driver enables access to Queue and Buffer Manager (QBMAN) hardware on NXP DPAA2 devices. This is a prerequiset to moving the DPAA2 Etherney driver out of

[PATCH v3 3/4] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

Move the NXP DPIO (Datapath I/O Driver) out of the drivers/staging directory and into the drivers/soc/fsl directory. The DPIO driver enables access to Queue and Buffer Manager (QBMAN) hardware on NXP DPAA2 devices. This is a prerequisite to moving the DPAA2 Ethernet driver out of staging.

[PATCH v3 4/4] drivers/staging: Remove fsl-mc driver from staging

Remove the staging/drivers/fsl-mc directory from the staging area now that all the components have been moved to the main kernel areas. Signed-off-by: Roy Pledge --- drivers/staging/Kconfig | 2 -- drivers/staging/Makefile| 1 -

[PATCH v3 1/4] drivers/staging/fsl-mc: Use memremap for DPIO cache enabled area

Change the mapping of the QBMan cache enabled area from using ioremap_wc() to memremap(). This allows the __iomem attribute to be removed from the pointer (which makes sense as accesses try this as cacheable memory not IO memory). These changes allow sparse checks to pass. Signed-off-by: Roy

[PATCH] staging: wilc1000: fix memdup.cocci warnings

From: Fengguang Wu drivers/staging/wilc1000/host_interface.c:946:32-39: WARNING opportunity for kmemdup drivers/staging/wilc1000/host_interface.c:970:30-37: WARNING opportunity for kmemdup Use kmemdup rather than duplicating its implementation Generated by:

Re: [bug report] staging: vchiq_core: Bail out in case of invalid tx_pos

Hi Dan, > Dan Carpenter hat am 22. März 2018 um 13:28 > geschrieben: > > > Hello Stefan Wahren, > > The patch d1eab9dec610: "staging: vchiq_core: Bail out in case of > invalid tx_pos" from May 26, 2017, leads to the following static > checker warning: > >

[PATCH 09/18] media: staging: atomisp: get rid of an unused function

The function __need_realloc_mipi_buffer() is not used anywhere. Signed-off-by: Mauro Carvalho Chehab --- .../atomisp/pci/atomisp2/atomisp_compat_css20.c | 21 - 1 file changed, 21 deletions(-) diff --git

[PATCH 02/18] media: staging: atomisp: do some coding style improvements

Use make coccicheck in patch mode to do some coding style improvements. Adjust the results manually. Signed-off-by: Mauro Carvalho Chehab --- .../media/atomisp/pci/atomisp2/atomisp_cmd.c | 14 +- .../media/atomisp/pci/atomisp2/atomisp_fops.c | 14

[PATCH 16/18] media: staging: atomisp: stop mixing enum types

This driver abuses on enum types: drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c:1027:37: warning: mixing different enum types drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c:1027:37: int enum ia_css_csi2_port versus

[PATCH 13/18] media: staging: atomisp: remove an useless check

There's a check at ia_css_vf_configure() to verify if binary is not null. However, this is called too late: drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/vf/vf_1.0/ia_css_vf.host.c:133 ia_css_vf_configure() warn: variable dereferenced before check 'binary' (see line

[PATCH 18/18] media: staging: atomisp: stop duplicating input format types

The same formats are defined twice with different names, as warned: drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c:5092:58: warning: mixing different enum types drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c:5092:58: int enum atomisp_input_format versus

[PATCH 10/18] media: staging: atomisp: Get rid of *default.host.[ch]

There are a number of files at atomisp that aren't used anywhere, called as "*default.host.[ch]": css2400/isp/kernels/dpc2/ia_css_dpc2_default.host.[ch] css2400/isp/kernels/bnlm/ia_css_bnlm_default.host.[ch] css2400/isp/kernels/tdf/tdf_1.0/ia_css_tdf_default.host.[ch]

[PATCH 07/18] media: staging: atomisp: fix endianess issues

There are lots of be-related warnings there, as it doesn't properly mark what data uses bigendian. Warnings fixed: drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c:134:15: warning: incorrect type in assignment (different base types)

[PATCH 05/18] media: staging: atomisp: get rid of stupid statements

It makes no sense to have a do nothing statement like: (void)stage; Fix those warnings: drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c:3808 sh_css_param_update_isp_params() error: uninitialized symbol 'stage'.

[PATCH 11/18] media: staging: atomisp: don't access a NULL var

Get rid of those warnings: drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c:446 gmin_v1p2_ctrl() error: we previously assumed 'gs' could be null (see line 444) drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c:480 gmin_v1p8_ctrl()

[PATCH 15/18] media: staging: atomisp: get rid of some static warnings

Get rid of those warnings: drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/tdf/tdf_1.0/ia_css_tdf.host.c:18:15: warning: symbol 'g_pyramid' was not declared. Should it be static? drivers/staging/media/atomisp/pci/atomisp2/mmu/sh_mmu_mrfld.c:66:23: warning: symbol

[PATCH 17/18] media: staging: atomisp: get rid of an unused var

As warned: drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c:8085 create_host_regular_capture_pipeline() error: uninitialized symbol 'frm'. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c | 1 - 1

[PATCH 06/18] media: staging: atomisp: add a missing include

atomisp_drvfs.c is not including its own header, causing those warnings: drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c:185:5: warning: symbol 'atomisp_drvfs_init' was not declared. Should it be static? drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c:201:6:

[PATCH 12/18] media: staging: atomisp: avoid a warning if 32 bits build

Checking if a size_t value is bigger than ULONG_INT only makes sense if building on 64 bits, as warned by: drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c:697 gmin_get_config_var() warn: impossible condition '(*out_len > (~0)) => (0-u32max > u32max)'

[PATCH 03/18] media: staging: atomisp: ia_css_output.host: don't use var before check

Fix this warning: drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/output/output_1.0/ia_css_output.host.c:64 ia_css_output_config() warn: variable dereferenced before check 'from->info' (see line 63) Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 04/18] media: staging atomisp: declare static vars as such

Fix a bunch of warnings: drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/bufq/src/bufq.c:93:23: warning: symbol 'css_queues' was not declared. Should it be static? drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/rmgr/src/rmgr_vbuf.c:27:32: warning: symbol

[PATCH 08/18] media: staging: atomisp: remove unused set_pd_base()

There's an implementation for set_pd_base at sh_mmu logic with is said to be mandatory. However, the implementation ends by calling a routine that does nothing. So get rid of this entire nonsense. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 14/18] media: staging: atomisp: use %p to print pointers

Instead of a converting pointers to unsigned long, just print them as-is, using %p. Fixes this warning: drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/debug/src/ia_css_debug.c:3012 ia_css_debug_pipe_graph_dump_sp_raw_copy() warn: argument 4 to %08lx specifier is cast from